)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"926848dede67567f16a3828fc82c77728c2ce4a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ee57d35_6cddb2bc","updated":"2023-02-08 04:36:30.000000000","message":"+1 overall i think this is good.\n\ni have no real issues with the content in general\n\nthe fact we have not mentioned ironic is perhaps the main feedback that and the comment on line 35.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"487028743fd4bf893a6bae66498d9c70415a3c40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"abc0589e_6afcc39c","updated":"2023-02-09 17:01:55.000000000","message":"Excellent and useful writing. I\u0027ll try to mention it in the prelude.","commit_id":"a2964417822bd1a4a83fa5c27282d2be1e18868a"}],"doc/source/admin/compute-node-identification.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"926848dede67567f16a3828fc82c77728c2ce4a9","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    Even after 2023.1, the compute node\u0027s hostname may not be changed after"},{"line_number":21,"context_line":"    the initial registration with the controller nodes, it is just not used"},{"line_number":22,"context_line":"    as the primary method for identification."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Self-provisioning of the node identity"},{"line_number":25,"context_line":"--------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"16944f73_974b312f","line":22,"updated":"2023-02-08 04:36:30.000000000","message":"do we want to havee a note saying this is not used for ironic?\nor perhaps add an ironic section to call that out seperately.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f3dc91d34a04d864dd21f24652c0eec172c54c3","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    Even after 2023.1, the compute node\u0027s hostname may not be changed after"},{"line_number":21,"context_line":"    the initial registration with the controller nodes, it is just not used"},{"line_number":22,"context_line":"    as the primary method for identification."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Self-provisioning of the node identity"},{"line_number":25,"context_line":"--------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6a10d3f7_efc6d7ba","line":22,"in_reply_to":"16944f73_974b312f","updated":"2023-02-08 14:50:27.000000000","message":"Yes, good call, I took the \"does not apply to ironic\" straight to omitting it entirely.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7e85faca05b78446b7127a71f1ce84cee8477fa","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    Even after 2023.1, the compute node\u0027s hostname may not be changed after"},{"line_number":21,"context_line":"    the initial registration with the controller nodes, it is just not used"},{"line_number":22,"context_line":"    as the primary method for identification."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Self-provisioning of the node identity"},{"line_number":25,"context_line":"--------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1b417eef_5091a815","line":22,"in_reply_to":"6a10d3f7_efc6d7ba","updated":"2023-02-09 16:52:47.000000000","message":"Done","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"926848dede67567f16a3828fc82c77728c2ce4a9","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Since this file (and it\u0027s parent directory) is writable by nova, it may be"},{"line_number":34,"context_line":"desirable to move this to one of the other locations that nova looks for the"},{"line_number":35,"context_line":"identification file."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Deployment provisioning of the node identity"},{"line_number":38,"context_line":"--------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"624ea05c_e48df4ba","line":35,"updated":"2023-02-08 04:36:30.000000000","message":"nit: we have not metioned where this is yet\n\ni would suggest swaping this section and then next or descirbing the locations that nova will look for the identity file sepereatly before both the \n\t\nSelf-provisioning and Deployment provisioning sections","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f3dc91d34a04d864dd21f24652c0eec172c54c3","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Since this file (and it\u0027s parent directory) is writable by nova, it may be"},{"line_number":34,"context_line":"desirable to move this to one of the other locations that nova looks for the"},{"line_number":35,"context_line":"identification file."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Deployment provisioning of the node identity"},{"line_number":38,"context_line":"--------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a188139_521a921a","line":35,"in_reply_to":"624ea05c_e48df4ba","updated":"2023-02-08 14:50:27.000000000","message":"I\u0027m talking about the generated file here, which I previously mentioned or eluded to on L31, L27, L14, L11, and L7.\n\nI think this section should come first because I think it should be the default behavior, i.e. people don\u0027t auto-provision this, but let nova do it for them.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7e85faca05b78446b7127a71f1ce84cee8477fa","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Since this file (and it\u0027s parent directory) is writable by nova, it may be"},{"line_number":34,"context_line":"desirable to move this to one of the other locations that nova looks for the"},{"line_number":35,"context_line":"identification file."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Deployment provisioning of the node identity"},{"line_number":38,"context_line":"--------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a52e5692_5ae6e088","line":35,"in_reply_to":"9a188139_521a921a","updated":"2023-02-09 16:52:47.000000000","message":"Ack ok yes i agree we want people to prefer this approch for upgrade so im fine with this","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"926848dede67567f16a3828fc82c77728c2ce4a9","unresolved":true,"context_lines":[{"line_number":60,"context_line":"Upgrading from pre-2023.1"},{"line_number":61,"context_line":"-------------------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Before release 2023.1, ``nova-compute`` only used the hostname to identify its"},{"line_number":64,"context_line":"compute node objects in the database. When upgrading from a prior release, the"},{"line_number":65,"context_line":"compute node will perform a one-time migration of the hostname-matched"},{"line_number":66,"context_line":"compute node UUID to the ``compute_id`` file in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"140f7a60_1ecaaba9","line":63,"range":{"start_line":63,"start_character":54,"end_line":63,"end_character":62},"updated":"2023-02-08 04:36:30.000000000","message":"nit: hostname and\t\n:oslo.config:option:`host` but ya i agree in general since the latter default to the former.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f3dc91d34a04d864dd21f24652c0eec172c54c3","unresolved":true,"context_lines":[{"line_number":60,"context_line":"Upgrading from pre-2023.1"},{"line_number":61,"context_line":"-------------------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Before release 2023.1, ``nova-compute`` only used the hostname to identify its"},{"line_number":64,"context_line":"compute node objects in the database. When upgrading from a prior release, the"},{"line_number":65,"context_line":"compute node will perform a one-time migration of the hostname-matched"},{"line_number":66,"context_line":"compute node UUID to the ``compute_id`` file in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6942f2ce_ff1b7b02","line":63,"range":{"start_line":63,"start_character":54,"end_line":63,"end_character":62},"in_reply_to":"140f7a60_1ecaaba9","updated":"2023-02-08 14:50:27.000000000","message":"Yeah I included both on L9 and didn\u0027t want to make it overly verbose, but I can re-mention both here I guess.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7e85faca05b78446b7127a71f1ce84cee8477fa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Upgrading from pre-2023.1"},{"line_number":61,"context_line":"-------------------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Before release 2023.1, ``nova-compute`` only used the hostname to identify its"},{"line_number":64,"context_line":"compute node objects in the database. When upgrading from a prior release, the"},{"line_number":65,"context_line":"compute node will perform a one-time migration of the hostname-matched"},{"line_number":66,"context_line":"compute node UUID to the ``compute_id`` file in the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"eac1dd1f_4f78999d","line":63,"range":{"start_line":63,"start_character":54,"end_line":63,"end_character":62},"in_reply_to":"6942f2ce_ff1b7b02","updated":"2023-02-09 16:52:47.000000000","message":"Done","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"926848dede67567f16a3828fc82c77728c2ce4a9","unresolved":true,"context_lines":[{"line_number":69,"context_line":".. note::"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    It is imperative that you allow the above migration to run and complete on"},{"line_number":72,"context_line":"    compute nodes that are being upgraded. Skipping this step by"},{"line_number":73,"context_line":"    pre-provisioning a ``compute_id`` file before the upgrade will **not** work"},{"line_number":74,"context_line":"    and will be equivalent to changing the compute node UUID after it has"},{"line_number":75,"context_line":"    already been created once."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7729b408_6c7bb2cf","line":75,"range":{"start_line":72,"start_character":42,"end_line":75,"end_character":30},"updated":"2023-02-08 04:36:30.000000000","message":"nit: technically if you looked up the compute node uuid in the hypervisor api or db directly you could pre provision it to the same value that nova will write.\n\nbut i agree just using uuidgen will not work and that is the method we are documentign for the pre-provisioned workflow so in context fo the dock this note is correct.\n\nhonestly for existing nodes i dont see any compleing usecase to preprovision this unless it was for upgrade reasons. i.e. you did not trust an upgrade to not change the host name for some reason so before upgrading you micht write the file manually so that if that happened we would detect that and not start the compute.\n\nin that case you are better off fixing your upgrade tooling to not change the hostname since as you noted even with this feature thats still not supproted.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7e85faca05b78446b7127a71f1ce84cee8477fa","unresolved":false,"context_lines":[{"line_number":69,"context_line":".. note::"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    It is imperative that you allow the above migration to run and complete on"},{"line_number":72,"context_line":"    compute nodes that are being upgraded. Skipping this step by"},{"line_number":73,"context_line":"    pre-provisioning a ``compute_id`` file before the upgrade will **not** work"},{"line_number":74,"context_line":"    and will be equivalent to changing the compute node UUID after it has"},{"line_number":75,"context_line":"    already been created once."}],"source_content_type":"text/x-rst","patch_set":1,"id":"de3840c4_4361eb4f","line":75,"range":{"start_line":72,"start_character":42,"end_line":75,"end_character":30},"in_reply_to":"3ed443f4_6a5e176f","updated":"2023-02-09 16:52:47.000000000","message":"Ack","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1f3dc91d34a04d864dd21f24652c0eec172c54c3","unresolved":true,"context_lines":[{"line_number":69,"context_line":".. note::"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    It is imperative that you allow the above migration to run and complete on"},{"line_number":72,"context_line":"    compute nodes that are being upgraded. Skipping this step by"},{"line_number":73,"context_line":"    pre-provisioning a ``compute_id`` file before the upgrade will **not** work"},{"line_number":74,"context_line":"    and will be equivalent to changing the compute node UUID after it has"},{"line_number":75,"context_line":"    already been created once."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ed443f4_6a5e176f","line":75,"range":{"start_line":72,"start_character":42,"end_line":75,"end_character":30},"in_reply_to":"7729b408_6c7bb2cf","updated":"2023-02-08 14:50:27.000000000","message":"Yeah, I definitely don\u0027t think we should be telling people to look up and pre-provision the node uuids before an upgrade. Just too much could go wrong there, and there\u0027s really no need.\n\nI think time will tell whether or not this (the upgrade or the auto-generation) ends up being problematic for people. Obviously I\u0027m not expecting it to, but if we need instructions on how to re-create a `compute_id` file that went missing, we can do that at the time. I\u0027d just hate to mix that in here now and people who are reading too fast and shallow think that they\u0027re *supposed* to do that, instead of it being recovery type instruction.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"}],"doc/source/cli/nova-compute.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"926848dede67567f16a3828fc82c77728c2ce4a9","unresolved":true,"context_lines":[{"line_number":42,"context_line":"* ``/etc/nova/rootwrap.conf``"},{"line_number":43,"context_line":"* ``/etc/nova/rootwrap.d/``"},{"line_number":44,"context_line":"* ``/etc/nova/compute_id``"},{"line_number":45,"context_line":"* ``/var/lib/nova/compute_id``"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"See Also"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f63ae32_10a82bbc","line":45,"updated":"2023-02-08 04:36:30.000000000","message":"i guess we dont generally list the state dir here so that is why you have not\nincluded /var/lib/nova/compute_id correct?","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1751034441b0d17095404d16555daaea37f89aaf","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* ``/etc/nova/rootwrap.conf``"},{"line_number":43,"context_line":"* ``/etc/nova/rootwrap.d/``"},{"line_number":44,"context_line":"* ``/etc/nova/compute_id``"},{"line_number":45,"context_line":"* ``/var/lib/nova/compute_id``"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"See Also"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"f00f9913_92e8fd49","line":45,"in_reply_to":"3f63ae32_10a82bbc","updated":"2023-02-09 16:54:59.000000000","message":"Done","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa8ee82e04dc7e526cbeebc04ba9663fa2822931","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* ``/etc/nova/rootwrap.conf``"},{"line_number":43,"context_line":"* ``/etc/nova/rootwrap.d/``"},{"line_number":44,"context_line":"* ``/etc/nova/compute_id``"},{"line_number":45,"context_line":"* ``/var/lib/nova/compute_id``"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"See Also"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fad93ef4_3774d072","line":45,"in_reply_to":"3f86528b_9ce6c934","updated":"2023-02-09 17:35:06.000000000","message":"no i really tought you only added one when i looked at it\nmaybe i clicked on the gerrit ui and missed it or something\n\nthis is what i was expecting\nnothing to do here its fine.","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ff06dc014d6cf6bcb2d2719f927566c11b4508ec","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* ``/etc/nova/rootwrap.conf``"},{"line_number":43,"context_line":"* ``/etc/nova/rootwrap.d/``"},{"line_number":44,"context_line":"* ``/etc/nova/compute_id``"},{"line_number":45,"context_line":"* ``/var/lib/nova/compute_id``"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"See Also"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f86528b_9ce6c934","line":45,"in_reply_to":"f00f9913_92e8fd49","updated":"2023-02-09 17:00:06.000000000","message":"Sorry, I missed this, but... it *is* listed? Or were you saying we should stub out the `/var/lib/nova` part since it\u0027s variable?","commit_id":"b7d0f8342e8006bfcbe64a8c897b05a4222030d7"}]}