)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d9c6415fb2b1b37bd979a33a6087f1236fa181c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb8b1e4b_09d26af5","updated":"2023-02-10 16:23:00.000000000","message":"Besides the os-traits bump needs the patch looks good to me. \nNote to other reviewers: this is the start of the feature just to expose the capability, we will need additional patches to be able to add the new XML elements to the guest based on the flavor extra_spec.","commit_id":"528cfaa212f198b071a60e2763ae5c07ff6b2d5b"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"c9c93cc905f425f26e1312450deff41022794831","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9202cbc4_16df6be9","updated":"2023-02-09 09:14:27.000000000","message":"The failure of Zuul job is due to os-traits changes not being released.\nShould I wait or take any action? ","commit_id":"528cfaa212f198b071a60e2763ae5c07ff6b2d5b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d024946adb49684df6835f8f10d123f02eeacd46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"401a6fca_da46e930","updated":"2023-02-10 13:58:18.000000000","message":"you need to bump the os-traits min requirements to be able to use the new traits.","commit_id":"528cfaa212f198b071a60e2763ae5c07ff6b2d5b"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"9ed3a3aee875e4eac1c7938a216a49cb25b92489","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81635a70_4fd9c261","in_reply_to":"1209256b_0b95c747","updated":"2023-02-13 02:40:56.000000000","message":"Thanks for your support.\nOK. I have confirmed that os-traits 2.10.0 [1] has been released and bumped the os-traits min requirements in this patch.\nOnce that blocking patch has been merged, I will bump the global requirements.\n\n[1] https://pypi.org/project/os-traits/2.10.0/","commit_id":"528cfaa212f198b071a60e2763ae5c07ff6b2d5b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d9c6415fb2b1b37bd979a33a6087f1236fa181c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1209256b_0b95c747","in_reply_to":"401a6fca_da46e930","updated":"2023-02-10 16:23:00.000000000","message":"But we need the global requirements bump first. I guess that is currently blocked by https://review.opendev.org/c/openstack/requirements/+/872065 which needs to land first, then another bump to move os-traits to 2.10.0","commit_id":"528cfaa212f198b071a60e2763ae5c07ff6b2d5b"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"affe1fea15df3e4eb46789f6e6921a3ce9a3c6e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c71c211_41cc123a","updated":"2023-02-17 06:12:11.000000000","message":"recheck\nGlobal requirements has been updated [1] to support os-traits 2.10.0 yesterday.\n[1] https://review.opendev.org/c/openstack/requirements/+/873416","commit_id":"854c91e8f5513d095d51d0ddfbbe9cb472339f54"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"dabf2b286c314c365b48cfb68e1e44ba064d341e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f5812b79_c14c1ac6","updated":"2023-02-28 02:07:37.000000000","message":"The issue related to os-traits has been solved.\nCould you please review it again?","commit_id":"7760a4bccb89761074a91f1584de4022c80c748f"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"d2d49ed3656253f32ab60344353a47449821eeae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9aa4f958_4cedb6e4","updated":"2023-03-31 04:43:00.000000000","message":"recheck pep8 failed on unrelated lines","commit_id":"afeb130f27a49ba1344f58798ae19d1ca06e116c"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"b4375ad7e19081c16593fdc8b028151cafe01825","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d822fa4f_7cbf3077","updated":"2023-07-11 02:58:31.000000000","message":"The nova-spec for 2023.2 bobcat [1] has been approved.\nCould you please review this patch again?\n\n[1] https://review.opendev.org/c/openstack/nova-specs/+/878753","commit_id":"30754632a1901dd02df375ff0564677e00e20917"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"207b0d3cac59ea374cbbbf243522028ca217e668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8ddff2db_e878b0b4","updated":"2023-07-21 15:18:38.000000000","message":"lgtm but I\u0027d prefer if we could have a specific version number in the libvirt.driver module.","commit_id":"30754632a1901dd02df375ff0564677e00e20917"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"916166022fd2e34d6b08cce25e31f4a39e23bb95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8718444_1eb0618c","in_reply_to":"8ddff2db_e878b0b4","updated":"2023-07-24 08:18:36.000000000","message":"Thanks for your review. As you suggested, I have made changes to check the minimum version in libvirt.driver module. I feel that the code is now simpler and cleaner. Thanks!","commit_id":"30754632a1901dd02df375ff0564677e00e20917"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b8fc9453eb6a80d571206ac5bd111ad19ddbdd3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b67bf39c_a3d67ac8","updated":"2023-08-31 00:29:14.000000000","message":"Looks OK to me too, thanks","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e64dcde6786439799c3a0f01b8d2fbb20ae4141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c337767a_952ba7ce","updated":"2023-08-30 22:09:36.000000000","message":"Seems okay to me, but I\u0027ll defer to Melwitt\u0027s concerns and/or let her +W","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e83fdfdb8df25fd4891d6844d29f033f658aa158","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2d675375_1c382b2e","updated":"2023-08-30 20:28:26.000000000","message":"Should we have a release note for this?","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"8c4218e9e37be7fd0a477c84dc7fc18f112d8ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8c0bb0dd_12d74d25","updated":"2023-07-27 01:40:23.000000000","message":"Thanks again for your review.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"52b783e999fad395f924964d125a8dc7c23dc8bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"999d86a2_a92d9402","updated":"2023-08-31 04:55:05.000000000","message":"Thanks for your reviews.\nAs you know, this patch is one step towards realizing the spec.\nI will prepare a subsequent patch.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c326c78b521e07cb1691ad8bb694fc6950c0f5b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"20d3d887_9099bf70","updated":"2023-07-26 13:21:46.000000000","message":"Thanks, lgtm. No issues found 😊","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"a924203b716af400a2b614f56384137611ca511f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"14a38b43_3b828993","updated":"2023-07-27 07:11:10.000000000","message":"recheck","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"ab55e2b8998d1eee86bd552d3c21ee834834f045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32e9ef85_c0f83414","updated":"2023-08-04 04:08:25.000000000","message":"recheck","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"01104f5a37b0ffc45da1a75a7169b981b5eca0ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a0f2fc4_6b175faf","updated":"2023-08-10 05:10:37.000000000","message":"recheck","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"862eb389a1cc23a3cb338f2bf41a037af6906d59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3b54d94a_1b25a692","updated":"2023-07-27 01:40:32.000000000","message":"recheck","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"124b48c8e90b74d4c3a388f5d5a5a6d57296ddc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f2b55ff2_f3979677","updated":"2023-07-31 02:05:24.000000000","message":"recheck","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"d053c8de99fa30316f431b99ac01dea12b81a9f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"33435ac0_80ec7e91","updated":"2023-07-26 06:07:20.000000000","message":"recheck\nunrelated failures because each attempt fails for a different reason","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"9da5fd86720916e37e1be146c84d6898ee065587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c620c738_c80a44b2","updated":"2023-07-27 04:44:09.000000000","message":"recheck again","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"a9e849145a8df3e94bdedd3b795ba15894a5169c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3ee97f3a_4d001863","updated":"2023-08-03 04:55:57.000000000","message":"recheck unrelated failure","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"e5af1717ff227078cef2dd1f9cec4340844883c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5e085024_3a642fc0","updated":"2023-07-24 23:58:14.000000000","message":"recheck unrelated failure","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"60374bf5e0de93940f36c643e60a61a77cd44065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8f25906c_a4fd21da","updated":"2023-07-28 01:17:52.000000000","message":"recheck unrelated failure","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"09ac3001de08145b9d2b419611bdddefe64285e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c174631e_fd80ff72","updated":"2023-08-07 07:23:31.000000000","message":"recheck unrelated failure","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"223fa6c1091b8438d64faf9c1f8da10c8634044a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2bee4d1_e7eac780","updated":"2023-07-25 02:27:48.000000000","message":"recheck unrelated failure again","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"ee57e5d503ecbbe0d111d4f7baf6f03e7c5c5396","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"413927a4_50b6aaa3","updated":"2023-08-03 01:26:19.000000000","message":"recheck unrelated failure: grenade-skip-level-always","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"338d5217044d12ae727f57c4e7f7d54a8d7102c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"367002d8_1a604939","updated":"2023-08-04 01:26:40.000000000","message":"recheck unrelated failure: nova-grenade-multinode","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"083a5b93da9a09bbb6f0942d3afba558d871d4e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e6e854af_ece9305d","updated":"2023-08-03 07:38:33.000000000","message":"recheck unrelated failure: nova-ovs-hybrid-plug","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"45023355a6fa2901ba8f169e25d4d650f63fb197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"09399a29_e5c2e75b","updated":"2023-08-02 09:50:35.000000000","message":"recheck unrelated failures","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"5ccb9b4d04f7adbc818fd08b7fe54bf7c22fcfd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bce61b21_3f7181aa","updated":"2023-08-10 02:56:27.000000000","message":"recheck unrelated failures","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"cfd1cc1159f3c652426631a8ab3afc89a86cf47f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a46a8b44_c5eec6d4","updated":"2023-08-08 01:24:40.000000000","message":"recheck unrelated failures: nova-ceph-multistore, nova-next","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"a97d9f02798e934deaa51bb7eea1c581d2e91c88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dff2c60a_e8388e75","updated":"2023-08-07 01:48:20.000000000","message":"recheck unrelated failures: nova-next, nova-grenade-multinode","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e64dcde6786439799c3a0f01b8d2fbb20ae4141","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"57d91dda_03d1870f","in_reply_to":"2d675375_1c382b2e","updated":"2023-08-30 22:09:36.000000000","message":"I think we don\u0027t need one for this patch itself, since it doesn\u0027t really add any new feature or really anything an operator would really notice, right? It\u0027s just exposing the trait, for some future use of it I imagine.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b8fc9453eb6a80d571206ac5bd111ad19ddbdd3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0e00892_a5dbedb1","in_reply_to":"57d91dda_03d1870f","updated":"2023-08-31 00:29:14.000000000","message":"Oh, yeah, I see now. This patch is only one piece of the feature in the spec. In the future there will be flavor extra specs and libvirt config additions:\n\nhttps://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/libvirt-maxphysaddr-support.html","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2845fe959451298cb4dbe7d94f0977c003cd14ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a9d3838c_a11df9ec","in_reply_to":"999d86a2_a92d9402","updated":"2023-08-31 09:06:57.000000000","message":"Nobuhiro, yeah, fwiw, I understood this series is not feature-completed by that patch, but I\u0027ll tho mark the blueprint as Implemented as we can\u0027t span a blueprint across multiple cycles.\n\nPlease repropose the spec (and create another blueprint like https://blueprints.launchpad.net/nova/+spec/libvirt-maxphysaddr-support-caracal) for Caracal once the directory is created (as a reminder, today is FeatureFreeze and we\u0027ll open Caracal dev cycle in 2 weeks-ish) and just mention in the Caracal spec reproposal what was merged and what\u0027s missing in the action items. \n\nThanks.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"d97416a4e856fc0510381ae34403f58f206c7430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"836fe069_620e43f1","in_reply_to":"a9d3838c_a11df9ec","updated":"2023-09-01 01:55:24.000000000","message":"Hi Sylvain,\nThanks for letting me know how to proceed with this series.\nI will resubmit the nova-specs and blueprint for caracal.\n\nInside the nova-specs, I will of course clarify merged items and missing items.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c326c78b521e07cb1691ad8bb694fc6950c0f5b7","unresolved":false,"context_lines":[{"line_number":21399,"context_line":"        self.assertFalse("},{"line_number":21400,"context_line":"            driver.capabilities.get(\u0027supports_address_space_passthrough\u0027))"},{"line_number":21401,"context_line":"        self.assertFalse("},{"line_number":21402,"context_line":"            driver.capabilities.get(\u0027supports_address_space_emulated\u0027))"},{"line_number":21403,"context_line":""},{"line_number":21404,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getLibVersion\u0027,"},{"line_number":21405,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("}],"source_content_type":"text/x-python","patch_set":6,"id":"fe607870_54189cbd","line":21402,"updated":"2023-07-26 13:21:46.000000000","message":"ack, lgtm","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"207b0d3cac59ea374cbbbf243522028ca217e668","unresolved":true,"context_lines":[{"line_number":249,"context_line":"# VDPA interface support"},{"line_number":250,"context_line":"MIN_LIBVIRT_VDPA \u003d (6, 9, 0)"},{"line_number":251,"context_line":"MIN_QEMU_VDPA \u003d (5, 1, 0)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"REGISTER_IMAGE_PROPERTY_DEFAULTS \u003d ["},{"line_number":254,"context_line":"    \u0027hw_machine_type\u0027,"},{"line_number":255,"context_line":"    \u0027hw_cdrom_bus\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3d72e4f_7eaae5b9","line":252,"updated":"2023-07-21 15:18:38.000000000","message":"nit: you can add a specific libvirt version here, please.","commit_id":"30754632a1901dd02df375ff0564677e00e20917"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"916166022fd2e34d6b08cce25e31f4a39e23bb95","unresolved":false,"context_lines":[{"line_number":249,"context_line":"# VDPA interface support"},{"line_number":250,"context_line":"MIN_LIBVIRT_VDPA \u003d (6, 9, 0)"},{"line_number":251,"context_line":"MIN_QEMU_VDPA \u003d (5, 1, 0)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"REGISTER_IMAGE_PROPERTY_DEFAULTS \u003d ["},{"line_number":254,"context_line":"    \u0027hw_machine_type\u0027,"},{"line_number":255,"context_line":"    \u0027hw_cdrom_bus\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"8606a801_43759aa3","line":252,"in_reply_to":"b3d72e4f_7eaae5b9","updated":"2023-07-24 08:18:36.000000000","message":"Done","commit_id":"30754632a1901dd02df375ff0564677e00e20917"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c326c78b521e07cb1691ad8bb694fc6950c0f5b7","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Maxphysaddr minimal support version."},{"line_number":256,"context_line":"MIN_LIBVIRT_MAXPHYSADDR \u003d (8, 7, 0)"},{"line_number":257,"context_line":"MIN_QEMU_MAXPHYSADDR \u003d (2, 7, 0)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"REGISTER_IMAGE_PROPERTY_DEFAULTS \u003d ["},{"line_number":260,"context_line":"    \u0027hw_machine_type\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"cde54317_f7f3a1b7","line":257,"updated":"2023-07-26 13:21:46.000000000","message":"thanks for this.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e83fdfdb8df25fd4891d6844d29f033f658aa158","unresolved":true,"context_lines":[{"line_number":451,"context_line":"            \"supports_ephemeral_encryption\":"},{"line_number":452,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":453,"context_line":"            \"supports_ephemeral_encryption_luks\":"},{"line_number":454,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":455,"context_line":"        }"},{"line_number":456,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d64bad3e_d9e5363d","line":454,"updated":"2023-08-30 20:28:26.000000000","message":"I _think_ given the NOTE [1] in nova/virt/driver.py, the capabilities should be added here as well.\n\nhttps://review.opendev.org/c/openstack/nova/+/873221/6/nova/virt/driver.py#121","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b8fc9453eb6a80d571206ac5bd111ad19ddbdd3a","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            \"supports_ephemeral_encryption\":"},{"line_number":452,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":453,"context_line":"            \"supports_ephemeral_encryption_luks\":"},{"line_number":454,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":455,"context_line":"        }"},{"line_number":456,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9917c108_02f08e0c","line":454,"in_reply_to":"aece6096_f479ec95","updated":"2023-08-31 00:29:14.000000000","message":"Ack","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e64dcde6786439799c3a0f01b8d2fbb20ae4141","unresolved":true,"context_lines":[{"line_number":451,"context_line":"            \"supports_ephemeral_encryption\":"},{"line_number":452,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":453,"context_line":"            \"supports_ephemeral_encryption_luks\":"},{"line_number":454,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":455,"context_line":"        }"},{"line_number":456,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"aece6096_f479ec95","line":454,"in_reply_to":"d64bad3e_d9e5363d","updated":"2023-08-30 22:09:36.000000000","message":"I dunno, I think that\u0027s just saying that all the capabilities should end up in the dict here at some point, not necessarily right here. Also, the author is mirroring existing behavior where we put things like the secure boot caps into this list later. See below.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e64dcde6786439799c3a0f01b8d2fbb20ae4141","unresolved":true,"context_lines":[{"line_number":859,"context_line":"            \u0027supports_secure_boot\u0027: self._host.supports_secure_boot,"},{"line_number":860,"context_line":"            \u0027supports_remote_managed_ports\u0027:"},{"line_number":861,"context_line":"            self._host.supports_remote_managed_ports"},{"line_number":862,"context_line":"        })"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        supports_maxphysaddr \u003d self._host.has_min_version("},{"line_number":865,"context_line":"            lv_ver\u003dMIN_LIBVIRT_MAXPHYSADDR,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e122cd16_9ecaf26d","line":862,"updated":"2023-08-30 22:09:36.000000000","message":"This is effectively the same thing the author is doing below, so at least there\u0027s prior art.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b8fc9453eb6a80d571206ac5bd111ad19ddbdd3a","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            \u0027supports_secure_boot\u0027: self._host.supports_secure_boot,"},{"line_number":860,"context_line":"            \u0027supports_remote_managed_ports\u0027:"},{"line_number":861,"context_line":"            self._host.supports_remote_managed_ports"},{"line_number":862,"context_line":"        })"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        supports_maxphysaddr \u003d self._host.has_min_version("},{"line_number":865,"context_line":"            lv_ver\u003dMIN_LIBVIRT_MAXPHYSADDR,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a055ac9e_76a5bb78","line":862,"in_reply_to":"e122cd16_9ecaf26d","updated":"2023-08-31 00:29:14.000000000","message":"Ah, OK .. I didn\u0027t think about it that way but that makes sense.","commit_id":"2fd034ec487f8352c12d09f5cd4fe4798ade8d96"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"207b0d3cac59ea374cbbbf243522028ca217e668","unresolved":true,"context_lines":[{"line_number":1818,"context_line":"        # So it simply returns the same value."},{"line_number":1819,"context_line":"        return self.has_min_version(lv_ver\u003d(8, 7, 0),"},{"line_number":1820,"context_line":"                                    hv_ver\u003d(2, 7, 0),"},{"line_number":1821,"context_line":"                                    hv_type\u003dHV_DRIVER_QEMU)"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    def _kernel_supports_amd_sev(self) -\u003e bool:"},{"line_number":1824,"context_line":"        if not os.path.exists(SEV_KERNEL_PARAM_FILE):"}],"source_content_type":"text/x-python","patch_set":5,"id":"010c9291_f79f1e00","line":1821,"updated":"2023-07-21 15:18:38.000000000","message":"just for making sure we can remove this check once we have a minimum libvirt version correct, could you please add the version where I said ?","commit_id":"30754632a1901dd02df375ff0564677e00e20917"},{"author":{"_account_id":31652,"name":"Nobuhiro MIKI","email":"nmiki@lycorp.co.jp","username":"nmiki"},"change_message_id":"916166022fd2e34d6b08cce25e31f4a39e23bb95","unresolved":false,"context_lines":[{"line_number":1818,"context_line":"        # So it simply returns the same value."},{"line_number":1819,"context_line":"        return self.has_min_version(lv_ver\u003d(8, 7, 0),"},{"line_number":1820,"context_line":"                                    hv_ver\u003d(2, 7, 0),"},{"line_number":1821,"context_line":"                                    hv_type\u003dHV_DRIVER_QEMU)"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    def _kernel_supports_amd_sev(self) -\u003e bool:"},{"line_number":1824,"context_line":"        if not os.path.exists(SEV_KERNEL_PARAM_FILE):"}],"source_content_type":"text/x-python","patch_set":5,"id":"8280e941_25662580","line":1821,"in_reply_to":"010c9291_f79f1e00","updated":"2023-07-24 08:18:36.000000000","message":"Done","commit_id":"30754632a1901dd02df375ff0564677e00e20917"}]}