)]}'
{"nova/api/ec2/cloud.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"7ed2ab26a255cc3bff269406eb6934b150370c59","unresolved":false,"context_lines":[{"line_number":696,"context_line":""},{"line_number":697,"context_line":"            instance_id \u003d db.get_ec2_instance_id_by_uuid(context,"},{"line_number":698,"context_line":"                    instance_uuid)"},{"line_number":699,"context_line":"            instance_ec2_id \u003d ec2utils.id_to_ec2_inst_id(instance_id)"},{"line_number":700,"context_line":"            instance_data \u003d \u0027%s[%s]\u0027 % (instance_ec2_id,"},{"line_number":701,"context_line":"                                        instance[\u0027host\u0027])"},{"line_number":702,"context_line":"        v \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAI3%2F%2F9LU%3D","line":699,"updated":"2012-06-25 19:31:15.000000000","message":"no need for both of these.\n\nJust use:\n\ninstance_ec2_id \u003d ec2utils.id_to_ec2_inst_id(instance_uuid)","commit_id":"339fa4b64d9da524979c3c600c5d2a070d841825"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"7ed2ab26a255cc3bff269406eb6934b150370c59","unresolved":false,"context_lines":[{"line_number":995,"context_line":"                internal_id \u003d ec2utils.ec2_id_to_id(ec2_id)"},{"line_number":996,"context_line":"                try:"},{"line_number":997,"context_line":"                    instance_uuid \u003d db.get_instance_uuid_by_id(context,"},{"line_number":998,"context_line":"                           internal_id)"},{"line_number":999,"context_line":"                    instance \u003d self.compute_api.get(context, instance_uuid)"},{"line_number":1000,"context_line":"                except exception.NotFound:"},{"line_number":1001,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAI3%2F%2F9K4%3D","line":998,"updated":"2012-06-25 19:31:15.000000000","message":"you can skip the internal_id and do this in a new method in ec2utils:\n\ninstance_id \u003d ec2utils.ec2_inst_id_to_uuid(ec2_id)\n\ninstead of through a database call directly.","commit_id":"339fa4b64d9da524979c3c600c5d2a070d841825"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c0d084255b2e63aa477445ec5074d4930fab8a41","unresolved":false,"context_lines":[{"line_number":986,"context_line":"        if instance_id:"},{"line_number":987,"context_line":"            instances \u003d []"},{"line_number":988,"context_line":"            for ec2_id in instance_id:"},{"line_number":989,"context_line":"                instance_id \u003d ec2utils.ec2_id_to_id(ec2_id)"},{"line_number":990,"context_line":"                try:"},{"line_number":991,"context_line":"                    instance_uuid \u003d ec2utils.ec2_inst_id_to_uuid(context,"},{"line_number":992,"context_line":"                        instance_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8wM%3D","line":989,"updated":"2012-06-26 05:28:49.000000000","message":"remove this line","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c0d084255b2e63aa477445ec5074d4930fab8a41","unresolved":false,"context_lines":[{"line_number":989,"context_line":"                instance_id \u003d ec2utils.ec2_id_to_id(ec2_id)"},{"line_number":990,"context_line":"                try:"},{"line_number":991,"context_line":"                    instance_uuid \u003d ec2utils.ec2_inst_id_to_uuid(context,"},{"line_number":992,"context_line":"                        instance_id)"},{"line_number":993,"context_line":"                    instance \u003d self.compute_api.get(context, instance_uuid)"},{"line_number":994,"context_line":"                except exception.NotFound:"},{"line_number":995,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8wI%3D","line":992,"updated":"2012-06-26 05:28:49.000000000","message":"use ec2_id here and line it up with  the c in context above.","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"}],"nova/api/metadata/base.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"06bb9c05440e5f03d95232736a13f5a0784ae09e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.ec2_ids \u003d {}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.ec2_ids[\u0027instance-id\u0027] \u003d ec2utils.id_to_ec2_inst_id("},{"line_number":92,"context_line":"                instance[\u0027id\u0027])"},{"line_number":93,"context_line":"        self.ec2_ids[\u0027ami-id\u0027] \u003d ec2utils.glance_id_to_ec2_id(ctxt,"},{"line_number":94,"context_line":"            instance[\u0027image_ref\u0027])"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAI3%2F%2F83g%3D","line":92,"updated":"2012-06-26 01:48:54.000000000","message":"I think dividing this line would help understand better\n\n ec2_inst_id \u003d  ec2utils.id_to_ec2_inst_id(instance_id)\n self.ec2_ids[\u0027instance-id\u0027] \u003d ec2_inst_id","commit_id":"339fa4b64d9da524979c3c600c5d2a070d841825"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c0d084255b2e63aa477445ec5074d4930fab8a41","unresolved":false,"context_lines":[{"line_number":5116,"context_line":"def get_ec2_instance_id_by_uuid(context, instance_id, session\u003dNone):"},{"line_number":5117,"context_line":"    result \u003d _ec2_instance_get_query(context,"},{"line_number":5118,"context_line":"                                     session\u003dsession,"},{"line_number":5119,"context_line":"                                     project_only\u003dTrue).\\"},{"line_number":5120,"context_line":"                    filter_by(uuid\u003dinstance_id).\\"},{"line_number":5121,"context_line":"                    first()"},{"line_number":5122,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8vY%3D","line":5119,"updated":"2012-06-26 05:28:49.000000000","message":"remove project_only","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c0d084255b2e63aa477445ec5074d4930fab8a41","unresolved":false,"context_lines":[{"line_number":5130,"context_line":"def get_instance_uuid_by_id(context, instance_id, session\u003dNone):"},{"line_number":5131,"context_line":"    result \u003d _ec2_instance_get_query(context,"},{"line_number":5132,"context_line":"                                     session\u003dsession,"},{"line_number":5133,"context_line":"                                     project_only\u003dTrue).\\"},{"line_number":5134,"context_line":"                    filter_by(id\u003dinstance_id).\\"},{"line_number":5135,"context_line":"                    first()"},{"line_number":5136,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8vU%3D","line":5133,"updated":"2012-06-26 05:28:49.000000000","message":"remove project_only","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c0d084255b2e63aa477445ec5074d4930fab8a41","unresolved":false,"context_lines":[{"line_number":5141,"context_line":""},{"line_number":5142,"context_line":""},{"line_number":5143,"context_line":"@require_context"},{"line_number":5144,"context_line":"def _ec2_instance_get_query(context, session\u003dNone, project_only\u003dFalse):"},{"line_number":5145,"context_line":"    return model_query(context, models.InstanceIdMapping, session\u003dsession,"},{"line_number":5146,"context_line":"                       project_only\u003dproject_only)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8vQ%3D","line":5144,"updated":"2012-06-26 05:28:49.000000000","message":"remove project_only parameter","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"c0d084255b2e63aa477445ec5074d4930fab8a41","unresolved":false,"context_lines":[{"line_number":5143,"context_line":"@require_context"},{"line_number":5144,"context_line":"def _ec2_instance_get_query(context, session\u003dNone, project_only\u003dFalse):"},{"line_number":5145,"context_line":"    return model_query(context, models.InstanceIdMapping, session\u003dsession,"},{"line_number":5146,"context_line":"                       project_only\u003dproject_only)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8vM%3D","line":5146,"updated":"2012-06-26 05:28:49.000000000","message":"use project_only\u003dFalse\n\n(the table doesn\u0027t have a project_id field so the project_only will not work)","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"81301c8314fea5bd68aaa7a050d96a1b57764e25","unresolved":false,"context_lines":[{"line_number":5143,"context_line":"@require_context"},{"line_number":5144,"context_line":"def _ec2_instance_get_query(context, session\u003dNone, project_only\u003dFalse):"},{"line_number":5145,"context_line":"    return model_query(context, models.InstanceIdMapping, session\u003dsession,"},{"line_number":5146,"context_line":"                       project_only\u003dproject_only)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8u4%3D","line":5146,"in_reply_to":"AAAAI3%2F%2F8vM%3D","updated":"2012-06-26 05:40:57.000000000","message":"actually just remove the project_only completely as it defaults to false","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"8408aad90ddf4f15b1f410b05fe627592c11c340","unresolved":false,"context_lines":[{"line_number":5139,"context_line":""},{"line_number":5140,"context_line":""},{"line_number":5141,"context_line":"@require_context"},{"line_number":5142,"context_line":"def _ec2_instance_get_query(context, session\u003dNone, project_only\u003dFalse):"},{"line_number":5143,"context_line":"    return model_query(context, models.InstanceIdMapping, session\u003dsession,"},{"line_number":5144,"context_line":"                       project_only\u003dproject_only)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAI3%2F%2F8lU%3D","line":5142,"updated":"2012-06-26 15:13:35.000000000","message":"please remove the project_only here as it should never be set.","commit_id":"169d7036324b5e7d7db03b60bf2fe8a0f1a2b06e"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"8408aad90ddf4f15b1f410b05fe627592c11c340","unresolved":false,"context_lines":[{"line_number":5141,"context_line":"@require_context"},{"line_number":5142,"context_line":"def _ec2_instance_get_query(context, session\u003dNone, project_only\u003dFalse):"},{"line_number":5143,"context_line":"    return model_query(context, models.InstanceIdMapping, session\u003dsession,"},{"line_number":5144,"context_line":"                       project_only\u003dproject_only)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAI3%2F%2F8lQ%3D","line":5144,"updated":"2012-06-26 15:13:35.000000000","message":"remove project_only here as well","commit_id":"169d7036324b5e7d7db03b60bf2fe8a0f1a2b06e"}],"nova/db/sqlalchemy/migrate_repo/versions/105_add_instance_id_mappings.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"158aa580c80913735874a4b82aa14d488b56968f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                      nullable\u003dFalse,"},{"line_number":41,"context_line":"                                      autoincrement\u003dTrue),"},{"line_number":42,"context_line":"                    Column(\u0027uuid\u0027, String(36),"},{"line_number":43,"context_line":"                                      nullable\u003dFalse))"},{"line_number":44,"context_line":"    try:"},{"line_number":45,"context_line":"        instance_id_mappings.create()"},{"line_number":46,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAI3%2F%2F%2F9Q%3D","line":43,"updated":"2012-06-20 05:52:40.000000000","message":"The indenting here is a bit messy. Can you clean it up please?","commit_id":"7208ca60c08d5c3e4d6bc51d20064313df1abc13"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"158aa580c80913735874a4b82aa14d488b56968f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        LOG.exception(\"Exception while creating table \u0027ec2_uuid_association\u0027\")"},{"line_number":48,"context_line":"        meta.drop_all(tables\u003d[instance_id_mappings])"},{"line_number":49,"context_line":"        raise"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":52,"context_line":"        migrate_engine.execute(\"ALTER TABLE instance_id_mappings"},{"line_number":53,"context_line":"                Engine\u003dInnoDB\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAI3%2F%2F%2F9E%3D","line":50,"updated":"2012-06-20 05:52:40.000000000","message":"You\u0027re going to need an index on the uuid column as well, as I imagine most lookups will be from uuid?","commit_id":"7208ca60c08d5c3e4d6bc51d20064313df1abc13"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"158aa580c80913735874a4b82aa14d488b56968f","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":52,"context_line":"        migrate_engine.execute(\"ALTER TABLE instance_id_mappings"},{"line_number":53,"context_line":"                Engine\u003dInnoDB\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":56,"context_line":"    instance_id_mappings \u003d Table(\u0027instance_id_mappings\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAI3%2F%2F%2F9M%3D","line":53,"updated":"2012-06-20 05:52:40.000000000","message":"Ditto on the indent.","commit_id":"7208ca60c08d5c3e4d6bc51d20064313df1abc13"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"f99b9f979a4948d5e7610940aed6f084e6b2b25d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":52,"context_line":"        migrate_engine.execute(\"ALTER TABLE instance_id_mappings"},{"line_number":53,"context_line":"                Engine\u003dInnoDB\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":56,"context_line":"    instance_id_mappings \u003d Table(\u0027instance_id_mappings\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAI3%2F%2F%2F80%3D","line":53,"in_reply_to":"AAAAI3%2F%2F%2F9M%3D","updated":"2012-06-20 05:57:11.000000000","message":"Also, the string split here is causing you problems with the gating tests.","commit_id":"7208ca60c08d5c3e4d6bc51d20064313df1abc13"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"158aa580c80913735874a4b82aa14d488b56968f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":62,"context_line":"        row \u003d instance_id_mappings.insert()"},{"line_number":63,"context_line":"        row.execute({\u0027id\u0027: instance_id,"},{"line_number":64,"context_line":"                \u0027uuid\u0027: uuid})"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAI3%2F%2F%2F9I%3D","line":64,"updated":"2012-06-20 05:52:40.000000000","message":"Ditto on the indent.","commit_id":"7208ca60c08d5c3e4d6bc51d20064313df1abc13"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"c63f028a4073f031f830bfdbf639e10c14b59cb9","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":51,"context_line":"        migrate_engine.execute(\"ALTER TABLE instance_id_mappings\\"},{"line_number":52,"context_line":"                Engine\u003dInnoDB\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":55,"context_line":"    instance_id_mappings \u003d Table(\u0027instance_id_mappings\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAI3%2F%2F%2FTI%3D","line":52,"updated":"2012-06-20 21:24:11.000000000","message":"I think you\u0027d be better of splitting this line like this:\n\n  (\"ALTER TABLE instance_id_mappings\"\n   \"Engine\u003dInnoDB\")","commit_id":"cec4c263b4aa03d6d1a12ee8bdefe6fe945bb418"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"06bb9c05440e5f03d95232736a13f5a0784ae09e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    Column(\u0027id\u0027, Integer(),"},{"line_number":39,"context_line":"                                      primary_key\u003dTrue,"},{"line_number":40,"context_line":"                                      nullable\u003dFalse,"},{"line_number":41,"context_line":"                                      autoincrement\u003dTrue),"},{"line_number":42,"context_line":"                    Column(\u0027uuid\u0027, String(36), index\u003dTrue, nullable\u003dFalse))"},{"line_number":43,"context_line":"    try:"},{"line_number":44,"context_line":"        instance_id_mappings.create()"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAI3%2F%2F83c%3D","line":41,"updated":"2012-06-26 01:48:54.000000000","message":"Please align all the Column parameters with the first parameter","commit_id":"339fa4b64d9da524979c3c600c5d2a070d841825"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"06bb9c05440e5f03d95232736a13f5a0784ae09e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":51,"context_line":"        migrate_engine.execute(\"ALTER TABLE instance_id_mappings \""},{"line_number":52,"context_line":"                \"Engine\u003dInnoDB\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":55,"context_line":"    instance_id_mappings \u003d Table(\u0027instance_id_mappings\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAI3%2F%2F83Y%3D","line":52,"updated":"2012-06-26 01:48:54.000000000","message":"This should align with \"ALTER","commit_id":"339fa4b64d9da524979c3c600c5d2a070d841825"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"bdfdbc1e37740570c921ed1031e405af3212519a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            Column(\u0027updated_at\u0027, DateTime(timezone\u003dFalse)),"},{"line_number":32,"context_line":"            Column(\u0027deleted_at\u0027, DateTime(timezone\u003dFalse)),"},{"line_number":33,"context_line":"            Column(\u0027deleted\u0027,"},{"line_number":34,"context_line":"            Boolean(create_constraint\u003dTrue, name\u003dNone)),"},{"line_number":35,"context_line":"            Column(\u0027id\u0027, Integer(),"},{"line_number":36,"context_line":"        primary_key\u003dTrue,"},{"line_number":37,"context_line":"        nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAI3%2F%2F80I%3D","line":34,"updated":"2012-06-26 02:46:32.000000000","message":"The B of Boolean should be right beneath \u0027 of \u0027deleted\u0027,","commit_id":"f02b68c8f38009989d6a0369b0136b1660d398f4"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"bdfdbc1e37740570c921ed1031e405af3212519a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        primary_key\u003dTrue,"},{"line_number":37,"context_line":"        nullable\u003dFalse,"},{"line_number":38,"context_line":"        autoincrement\u003dTrue),"},{"line_number":39,"context_line":"        Column(\u0027uuid\u0027, String(36), index\u003dTrue, nullable\u003dFalse))"},{"line_number":40,"context_line":"    try:"},{"line_number":41,"context_line":"        instance_id_mappings.create()"},{"line_number":42,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAI3%2F%2F80E%3D","line":39,"updated":"2012-06-26 02:46:32.000000000","message":"p of primary_key\nn of nullable\na of autoincrement\nC of Column\n should all start right beneath the \u0027 of \u0027id\u0027","commit_id":"f02b68c8f38009989d6a0369b0136b1660d398f4"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"bdfdbc1e37740570c921ed1031e405af3212519a","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":48,"context_line":"        migrate_engine.execute(\"ALTER TABLE instance_id_mappings \""},{"line_number":49,"context_line":"                \"Engine\u003dInnoDB\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":52,"context_line":"    instance_id_mappings \u003d Table(\u0027instance_id_mappings\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAI3%2F%2F80M%3D","line":49,"updated":"2012-06-26 02:46:32.000000000","message":"the \" of \"Engine\u003dInnoDB should be right beneath the \" of \"ALTER","commit_id":"f02b68c8f38009989d6a0369b0136b1660d398f4"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"f677a2a7b42fbc4d1e38e3d6dc79116895bf7e4d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            Column(\u0027id\u0027, Integer(),"},{"line_number":36,"context_line":"                        primary_key\u003dTrue,"},{"line_number":37,"context_line":"                        nullable\u003dFalse,"},{"line_number":38,"context_line":"                        autoincrement\u003dTrue),"},{"line_number":39,"context_line":"            Column(\u0027uuid\u0027, String(36), index\u003dTrue, nullable\u003dFalse))"},{"line_number":40,"context_line":"    try:"},{"line_number":41,"context_line":"        instance_id_mappings.create()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8v4%3D","line":38,"updated":"2012-06-26 05:22:17.000000000","message":"Column(\u0027deleted\u0027,\n       Boolean(create_constraint\u003dTrue, name\u003dNone)),\nColumn(\u0027id\u0027,\n       Integer(),\n       primary_key\u003dTrue,\n       nullable\u003dFalse,\n       autoincrement\u003dTrue),","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"f677a2a7b42fbc4d1e38e3d6dc79116895bf7e4d","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":48,"context_line":"        migrate_engine.execute(\"ALTER TABLE instance_id_mappings \""},{"line_number":49,"context_line":"                \"Engine\u003dInnoDB\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":52,"context_line":"    instance_id_mappings \u003d Table(\u0027instance_id_mappings\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAI3%2F%2F8vs%3D","line":49,"updated":"2012-06-26 05:22:17.000000000","message":"migrate_engine.execute(\"ALTER TABLE instance_id_mappings \"\n                       \"Engine\u003dInnoDB\")","commit_id":"5ddbecfb2fd15f1ccf9cefdf023d45201cf224a2"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"b345265f202b90b3e8b771777b21cb8491f7d581","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            Column(\u0027updated_at\u0027, DateTime(timezone\u003dFalse)),"},{"line_number":32,"context_line":"            Column(\u0027deleted_at\u0027, DateTime(timezone\u003dFalse)),"},{"line_number":33,"context_line":"            Column(\u0027deleted\u0027,"},{"line_number":34,"context_line":"            Boolean(create_constraint\u003dTrue, name\u003dNone)),"},{"line_number":35,"context_line":"            Column(\u0027id\u0027, Integer(),"},{"line_number":36,"context_line":"                    primary_key\u003dTrue,"},{"line_number":37,"context_line":"                    nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAI3%2F%2F8sM%3D","line":34,"updated":"2012-06-26 07:11:58.000000000","message":"Boolean should be below \u0027deleted\u0027. \"B\" and \"\u0027\" on the same column","commit_id":"467920acfd01729c7cb403fbd86f8646f9fabb67"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"cd08b48b4d3655d3d26876d1b1528576dd3d70ec","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    instances \u003d Table(\u0027instances\u0027, meta, autoload\u003dTrue)"},{"line_number":52,"context_line":"    instance_id_mappings \u003d Table(\u0027instance_id_mappings\u0027, meta, autoload\u003dTrue)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    instance_list \u003d list(instances.select().execute())"},{"line_number":55,"context_line":"    for instance in instance_list:"},{"line_number":56,"context_line":"        instance_id \u003d instance[\u0027id\u0027]"},{"line_number":57,"context_line":"        uuid \u003d instance[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAI3%2F%2F7eM%3D","line":54,"updated":"2012-06-27 16:22:41.000000000","message":"existing ids migrated here.","commit_id":"7adea95c7c407ce3f28270eb9d767c23c6dcf1a2"}]}
