)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b4f73232e66ba02792baab97dc4455361f2be3d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-01-27 04:28:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support rescue with ephemeral encryption"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This also makes rescue use the image metadata from the"},{"line_number":10,"context_line":"CONF.libvirt.rescue_image_id if it ends up being chosen as the rescue"},{"line_number":11,"context_line":"image. Previously, its image metadata was never used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"fae46031_60eccfdf","line":8,"updated":"2024-01-31 11:10:03.000000000","message":"we have some ealier attempets to support rescue, can we move that to here and do it properly in this one patch","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8710690b3598f79dc9972e791416f037eb37636f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-01-27 04:28:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support rescue with ephemeral encryption"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This also makes rescue use the image metadata from the"},{"line_number":10,"context_line":"CONF.libvirt.rescue_image_id if it ends up being chosen as the rescue"},{"line_number":11,"context_line":"image. Previously, its image metadata was never used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"fbf308e2_68c7a866","line":8,"in_reply_to":"fae46031_60eccfdf","updated":"2024-02-01 02:24:33.000000000","message":"Agreed, I\u0027m moving it.","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dd4d8a67adfacd653a978e239bcfabe77c8ec90","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-01-27 04:28:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support rescue with ephemeral encryption"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This also makes rescue use the image metadata from the"},{"line_number":10,"context_line":"CONF.libvirt.rescue_image_id if it ends up being chosen as the rescue"},{"line_number":11,"context_line":"image. Previously, its image metadata was never used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3ab36782_0f1ad63a","line":8,"in_reply_to":"fbf308e2_68c7a866","updated":"2024-02-13 07:50:24.000000000","message":"Done","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b4f73232e66ba02792baab97dc4455361f2be3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"0b00c140_003f0af3","updated":"2024-01-31 11:10:03.000000000","message":"-i is mainly around functional tests and i realise now that i have not really been looking for that expliclty until now so i might downgrade some of my other reviews","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dd4d8a67adfacd653a978e239bcfabe77c8ec90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"73f6ca5e_bbc32d5e","updated":"2024-02-13 07:50:24.000000000","message":"functional tests are still pending but i have manually tested this and it works\nso i could be conviced that we can merge this and add them in a follow up patch","commit_id":"08a9f8c99cad6397ebb0f33931eb00e0a23bf2c4"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d801279739d953db1b41aea3b5e8386ecd1c5141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"87df2960_ee5d8ae5","updated":"2024-02-14 15:06:43.000000000","message":"Looks ok for me.","commit_id":"a119af27d0a0237f98a1891b4b1ae52e6602cfc3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"93a3bab522d641a791859e7ce5c0d9b9c2b31899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"8bbb0d44_27373998","updated":"2024-02-23 20:11:50.000000000","message":"recheck Feb 23 13:57:24.802308 np0036852498 nova-compute[84657]: greenlet.error: cannot switch to a different thread\n\ninstance stuck in BUILD","commit_id":"7d3a14a3b89523fc14fb017254926086616d33d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cbe49f26053515e32e1de0786ffffca0af696ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"232cf3e2_01c697dd","updated":"2024-02-23 12:26:18.000000000","message":"recheck nova-next","commit_id":"7d3a14a3b89523fc14fb017254926086616d33d3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d18f734282085da0e194a2870c9df51817b4da8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"809b51b5_a11850d5","updated":"2024-02-24 00:22:22.000000000","message":"recheck urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host\u003d\u002710.209.0.200\u0027, port\u003d443): Read timed out. (read timeout\u003d60)","commit_id":"7d3a14a3b89523fc14fb017254926086616d33d3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cbd2429b805af2785932f44352c7c8aa51b08a16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"a404baf0_3ed6bac7","updated":"2024-06-06 06:19:59.000000000","message":"recheck tempest-integrated-compute-rbac-old-defaults TIMED_OUT","commit_id":"b455ffa50b19657ffc38c1d18243e79cc4f0a0b2"}],"nova/compute/api.py":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d801279739d953db1b41aea3b5e8386ecd1c5141","unresolved":false,"context_lines":[{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"        return objects.InstanceGroup.get_by_uuid(context, group_hint)"},{"line_number":1619,"context_line":""},{"line_number":1620,"context_line":"    def _update_ephemeral_encryption_bdms("},{"line_number":1621,"context_line":"        self,"},{"line_number":1622,"context_line":"        flavor: \u0027objects.Flavor\u0027,"},{"line_number":1623,"context_line":"        image_meta_dict: ty.Dict[str, ty.Any],"}],"source_content_type":"text/x-python","patch_set":26,"id":"7cce7379_f71f1a90","side":"PARENT","line":1620,"updated":"2024-02-14 15:06:43.000000000","message":"Ok moved to utils.","commit_id":"99bf0c4f4ebb99a6ac637b396c2d647ad76e8128"}],"nova/conf/libvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b4f73232e66ba02792baab97dc4455361f2be3d","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    Be careful when using an encrypted image as the default rescue image. It"},{"line_number":53,"context_line":"    would require that all end users have permissions to access the secret"},{"line_number":54,"context_line":"    indicated in the hw_ephemeral_encryption_secret_uuid image property of the"},{"line_number":55,"context_line":"    rescue image."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Possible values:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"d579a8e3_f4ed2e40","line":55,"updated":"2024-01-31 11:10:03.000000000","message":"+1 a public secrete is well not a secrete\n\ni dont want to block the use of encypted rescue images by default but i wonder if we should block it if set in this config option.\n\ni.e. only support rescue_image_id to refernce an image without hw_ephemeral_encyption_secret_uuid or perhaps log a warning on start up with a similar message.","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f32473f263479b7d3fec8e6b5d962281e82a8259","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    Be careful when using an encrypted image as the default rescue image. It"},{"line_number":53,"context_line":"    would require that all end users have permissions to access the secret"},{"line_number":54,"context_line":"    indicated in the hw_ephemeral_encryption_secret_uuid image property of the"},{"line_number":55,"context_line":"    rescue image."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Possible values:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"adee35ee_a731d944","line":55,"in_reply_to":"007b5904_389bd05f","updated":"2024-02-02 06:56:42.000000000","message":"I decided not to block configuration of rescue_image_id in part because it would require us to call glance API at startup and I don\u0027t see any precedent for doing something like that. Instead I have added a generic warning log message if CONF.libvirt.rescue_image_id has been set.","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8f301ad75c74f847288ec065615d1527bb017812","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Be careful when using an encrypted image as the default rescue image. It"},{"line_number":53,"context_line":"    would require that all end users have permissions to access the secret"},{"line_number":54,"context_line":"    indicated in the hw_ephemeral_encryption_secret_uuid image property of the"},{"line_number":55,"context_line":"    rescue image."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Possible values:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"007b5904_389bd05f","line":55,"in_reply_to":"9c8dd01d_0711b909","updated":"2024-02-01 09:13:56.000000000","message":"Acknowledged","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dd4d8a67adfacd653a978e239bcfabe77c8ec90","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    Be careful when using an encrypted image as the default rescue image. It"},{"line_number":53,"context_line":"    would require that all end users have permissions to access the secret"},{"line_number":54,"context_line":"    indicated in the hw_ephemeral_encryption_secret_uuid image property of the"},{"line_number":55,"context_line":"    rescue image."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Possible values:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"2e9f38a5_9d0ed2a4","line":55,"in_reply_to":"adee35ee_a731d944","updated":"2024-02-13 07:50:24.000000000","message":"Acknowledged","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8710690b3598f79dc9972e791416f037eb37636f","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    Be careful when using an encrypted image as the default rescue image. It"},{"line_number":53,"context_line":"    would require that all end users have permissions to access the secret"},{"line_number":54,"context_line":"    indicated in the hw_ephemeral_encryption_secret_uuid image property of the"},{"line_number":55,"context_line":"    rescue image."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Possible values:"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9c8dd01d_0711b909","line":55,"in_reply_to":"d579a8e3_f4ed2e40","updated":"2024-02-01 02:24:33.000000000","message":"I\u0027m +1 to blocking it. It doesn\u0027t really make sense IMHO to have an encrypted rescue image but I was trying to cover all the bases. Since it seems you agree, I will change it to block it.","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d801279739d953db1b41aea3b5e8386ecd1c5141","unresolved":false,"context_lines":[{"line_number":6225,"context_line":"                                 \u0027volume_id\u0027: \u0027volume_id\u0027}]"},{"line_number":6226,"context_line":"        self._test_check_and_transform_bdm(block_device_mapping)"},{"line_number":6227,"context_line":""},{"line_number":6228,"context_line":"    def test_update_ephemeral_encryption_bdms(self):"},{"line_number":6229,"context_line":"        flavor \u003d self._create_flavor("},{"line_number":6230,"context_line":"            extra_specs\u003d{"},{"line_number":6231,"context_line":"                \u0027hw:ephemeral_encryption\u0027: True,"}],"source_content_type":"text/x-python","patch_set":26,"id":"c9f6107c_4693d5e3","side":"PARENT","line":6228,"updated":"2024-02-14 15:06:43.000000000","message":"Ok moved as well to \"test_utils\".","commit_id":"99bf0c4f4ebb99a6ac637b396c2d647ad76e8128"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b4f73232e66ba02792baab97dc4455361f2be3d","unresolved":true,"context_lines":[{"line_number":25752,"context_line":"        # We should have saved sysmeta changes to the instance once, for the"},{"line_number":25753,"context_line":"        # rescue disk encryption secret UUID."},{"line_number":25754,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":25755,"context_line":""},{"line_number":25756,"context_line":"    def test_rescue_with_different_hw_disk_bus(self):"},{"line_number":25757,"context_line":"        params \u003d {\u0027config_drive\u0027: None, \u0027root_device_name\u0027: \u0027/dev/vda\u0027}"},{"line_number":25758,"context_line":"        image_meta_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":21,"id":"8f70f582_97fa1e14","line":25755,"updated":"2024-01-31 11:10:03.000000000","message":"two general commensts\n\nfor something like rescuse and most fo thise feature i think we need functional tests.\n\nunit tests are not really enough.\n\nsecond comment is that i think there is an edge case that may not be covered\n\nrescue does not require the instance to be in error.\ncalling rescue on an active instance should not put the instance to error if the resuce image referneces as secrete the user/adming does not have access too.\n\n\ncan you add a functional test to confirm that if an instance is in active state and you call rescue on it refrencing an image that requries a secrete you dont ahve access too (or that does not exist) that we detect that before trying to modify the instance and restore the instace to the previos status/task sate and just report the rescue instance action as failed with a correct error message in the instance action log.","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8f301ad75c74f847288ec065615d1527bb017812","unresolved":true,"context_lines":[{"line_number":25752,"context_line":"        # We should have saved sysmeta changes to the instance once, for the"},{"line_number":25753,"context_line":"        # rescue disk encryption secret UUID."},{"line_number":25754,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":25755,"context_line":""},{"line_number":25756,"context_line":"    def test_rescue_with_different_hw_disk_bus(self):"},{"line_number":25757,"context_line":"        params \u003d {\u0027config_drive\u0027: None, \u0027root_device_name\u0027: \u0027/dev/vda\u0027}"},{"line_number":25758,"context_line":"        image_meta_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":21,"id":"f8264397_f2744a83","line":25755,"in_reply_to":"2d3f3aee_9d199006","updated":"2024-02-01 09:13:56.000000000","message":"we can allow encypted rescue image if its the same image the instance was booted with out passed on the api action. where i dont think it makes sense is the config options.\n\nso i would not block it out right i would just put a check in init host to block it in the config option","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8710690b3598f79dc9972e791416f037eb37636f","unresolved":true,"context_lines":[{"line_number":25752,"context_line":"        # We should have saved sysmeta changes to the instance once, for the"},{"line_number":25753,"context_line":"        # rescue disk encryption secret UUID."},{"line_number":25754,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":25755,"context_line":""},{"line_number":25756,"context_line":"    def test_rescue_with_different_hw_disk_bus(self):"},{"line_number":25757,"context_line":"        params \u003d {\u0027config_drive\u0027: None, \u0027root_device_name\u0027: \u0027/dev/vda\u0027}"},{"line_number":25758,"context_line":"        image_meta_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":21,"id":"2d3f3aee_9d199006","line":25755,"in_reply_to":"8f70f582_97fa1e14","updated":"2024-02-01 02:24:33.000000000","message":"This is a good point. Though it might be moot if I block any attempt to use encrypted rescue images.","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dd4d8a67adfacd653a978e239bcfabe77c8ec90","unresolved":false,"context_lines":[{"line_number":25752,"context_line":"        # We should have saved sysmeta changes to the instance once, for the"},{"line_number":25753,"context_line":"        # rescue disk encryption secret UUID."},{"line_number":25754,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":25755,"context_line":""},{"line_number":25756,"context_line":"    def test_rescue_with_different_hw_disk_bus(self):"},{"line_number":25757,"context_line":"        params \u003d {\u0027config_drive\u0027: None, \u0027root_device_name\u0027: \u0027/dev/vda\u0027}"},{"line_number":25758,"context_line":"        image_meta_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":21,"id":"fc65178d_e38d282a","line":25755,"in_reply_to":"f8264397_f2744a83","updated":"2024-02-13 07:50:24.000000000","message":"Acknowledged","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9ae9c27d935a6ec4722e6c536cb89407ae9fd712","unresolved":true,"context_lines":[{"line_number":359,"context_line":"    return config_drive_type"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def get_encryption_info_from_bdm(bdm):"},{"line_number":363,"context_line":"    bdm_info \u003d {}"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    if bdm.get(\u0027encrypted\u0027):"}],"source_content_type":"text/x-python","patch_set":21,"id":"38fb577f_31634404","line":362,"updated":"2024-02-02 18:29:46.000000000","message":"you lost this in the rebase","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dd4d8a67adfacd653a978e239bcfabe77c8ec90","unresolved":false,"context_lines":[{"line_number":359,"context_line":"    return config_drive_type"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"def get_encryption_info_from_bdm(bdm):"},{"line_number":363,"context_line":"    bdm_info \u003d {}"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    if bdm.get(\u0027encrypted\u0027):"}],"source_content_type":"text/x-python","patch_set":21,"id":"54f0007c_448f0c83","line":362,"in_reply_to":"38fb577f_31634404","updated":"2024-02-13 07:50:24.000000000","message":"Done","commit_id":"bebe3d9358c8a6bb76d84c5b63e27777cd2826a8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9ae9c27d935a6ec4722e6c536cb89407ae9fd712","unresolved":true,"context_lines":[{"line_number":402,"context_line":"        bdm_info[\u0027boot_index\u0027] \u003d str(boot_index + 1)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    # If the device is encrypted pass through the secret, format and options"},{"line_number":405,"context_line":"    bdm_info.update(get_encryption_info_from_bdm(bdm))"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    return bdm_info"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9d189a7a_8c6e5ea9","line":405,"updated":"2024-02-02 18:29:46.000000000","message":"you seam to normally call this as \n\nblockinfo.get_encryption_info_from_bdm\n\nwhich impliese it shoudl be in this module\nand you also are calling it here with out self so it imples its intened to be a module level fucntion but tis not in thei commit so i guess you lost that in a rebase.","commit_id":"22782fd92844c82a7721d94eefa3b7d3af3c5e38"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87b266c5e941a846ee8189ac6d5a9744aa6e0ce6","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        bdm_info[\u0027boot_index\u0027] \u003d str(boot_index + 1)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    # If the device is encrypted pass through the secret, format and options"},{"line_number":405,"context_line":"    bdm_info.update(get_encryption_info_from_bdm(bdm))"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    return bdm_info"},{"line_number":408,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3e74b168_76b11aca","line":405,"in_reply_to":"9d189a7a_8c6e5ea9","updated":"2024-02-14 10:37:50.000000000","message":"Done","commit_id":"22782fd92844c82a7721d94eefa3b7d3af3c5e38"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87b266c5e941a846ee8189ac6d5a9744aa6e0ce6","unresolved":true,"context_lines":[{"line_number":841,"context_line":"        self._register_all_undefined_instance_details()"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        if CONF.libvirt.rescue_image_id:"},{"line_number":844,"context_line":"            LOG.warning("},{"line_number":845,"context_line":"                \u0027Configuration of [libvirt]rescue_image_id was detected. \u0027"},{"line_number":846,"context_line":"                \u0027It is recommended not to use an encrypted image as the \u0027"},{"line_number":847,"context_line":"                \u0027default rescue image as doing so would require that all end \u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"6ca42800_19948ade","line":844,"updated":"2024-02-14 10:37:50.000000000","message":"we may want to use info since we dont know if its encypted so there may be nothing for them to do","commit_id":"a119af27d0a0237f98a1891b4b1ae52e6602cfc3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8dba2cb993123498fcc0dcc828d0bc104e7e187a","unresolved":true,"context_lines":[{"line_number":841,"context_line":"        self._register_all_undefined_instance_details()"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        if CONF.libvirt.rescue_image_id:"},{"line_number":844,"context_line":"            LOG.warning("},{"line_number":845,"context_line":"                \u0027Configuration of [libvirt]rescue_image_id was detected. \u0027"},{"line_number":846,"context_line":"                \u0027It is recommended not to use an encrypted image as the \u0027"},{"line_number":847,"context_line":"                \u0027default rescue image as doing so would require that all end \u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"6e5bc020_fc07eb8f","line":844,"in_reply_to":"6ca42800_19948ade","updated":"2024-02-17 19:08:16.000000000","message":"Fair point, will update.","commit_id":"a119af27d0a0237f98a1891b4b1ae52e6602cfc3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80b2c1058c87ded12e74cc9bc20b5aa931ee13d6","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        self._register_all_undefined_instance_details()"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        if CONF.libvirt.rescue_image_id:"},{"line_number":844,"context_line":"            LOG.warning("},{"line_number":845,"context_line":"                \u0027Configuration of [libvirt]rescue_image_id was detected. \u0027"},{"line_number":846,"context_line":"                \u0027It is recommended not to use an encrypted image as the \u0027"},{"line_number":847,"context_line":"                \u0027default rescue image as doing so would require that all end \u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"4cd7c76f_c1f26e24","line":844,"in_reply_to":"6e5bc020_fc07eb8f","updated":"2024-02-22 09:49:37.000000000","message":"Done","commit_id":"a119af27d0a0237f98a1891b4b1ae52e6602cfc3"}]}