)]}'
{"id":"openstack%2Fnova~873722","triplet_id":"openstack%2Fnova~stable%2Ftrain~I8ef9db851b37c5249d2efbe09a15a1ddbae8205d","project":"openstack/nova","branch":"stable/train","attention_set":{},"removed_from_attention_set":{"6962":{"account":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"last_update":"2023-09-01 16:51:25.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I8ef9db851b37c5249d2efbe09a15a1ddbae8205d","subject":"libvirt: At start-up rework compareCPU() usage with a workaround","status":"ABANDONED","created":"2023-02-14 15:25:27.000000000","updated":"2023-09-01 16:51:25.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9637e60a2cead7d72c98a58d8838ecbc9e8cbc77","_number":873722,"virtual_id_number":873722,"owner":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-02-15 19:09:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-14 21:03:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-02-18 02:26:08.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"2fce4a99b17584035ee61673f5e3e694b066bf6c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-02-14 15:25:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b16c9a61d0879365be7bae6de9d84ef5412f8e3c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-02-14 16:10:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8fef483ed5dafb0be8c21b199da7a25c75e39730","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-14 21:03:16.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/b8919ff67edf4e638d00cf95117f29ac\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/971728dc3d5640a5a280e2e361eb0eb1 : SUCCESS in 1h 24m 37s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/b97c677f867b45d78c386512dd28db6f : SUCCESS in 56m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1bbd54109be14e5ea1ea63b3179b5071 : FAILURE in 17m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1882e7190a264c1f82f6bb820104fff7 : SUCCESS in 10m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/85ff578fab2d4e29bb7a237e137263fc : FAILURE in 14m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e10fc20be56e40f3a642d380414c05f3 : FAILURE in 16m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8244dbd1a207431598bea1b84bb0ac66 : FAILURE in 14m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0b9742dd06294be58140ed9d16f5dfcd : SUCCESS in 9m 25s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/24202ffe6e07484aba7c650f4d65ebe5 : SUCCESS in 1h 31m 49s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/8f5c523c51974be8b9ecf60a6a861c0b : SUCCESS in 1h 30m 00s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/67ca6795e6df4c89a57a1b02ad5ca959 : SUCCESS in 1h 26m 39s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/89eabf18f84e4664b5e508561cd20255 : SUCCESS in 1h 01m 29s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/656a5c9fcd4649b09eb91d0adc65565a : SUCCESS in 58m 44s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/f4f270554c354b1caef7cce1973473f1 : SUCCESS in 1h 29m 36s\n- nova-next https://zuul.opendev.org/t/openstack/build/aeaa13c2eba047c19710c7d0f62f3dfe : TIMED_OUT in 2h 07m 10s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b117847b08d442618709f77630d620cb : SUCCESS in 22m 45s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/bbf02d22f85a49c5a8e9868b1c35d111 : SUCCESS in 21m 25s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/bb4dff5ba7724b919c204958dd35bf7f : FAILURE in 4m 58s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/dc740b2d53304ebdaff9a4fe24c7c701 : FAILURE in 2h 26m 06s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/133c1769e1764e4d955bba5bc8983c48 : SUCCESS in 1h 19m 38s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f8890396700b450981a9a6511bde0cb7 : SUCCESS in 2h 04m 26s","accounts_in_message":[],"_revision_number":2},{"id":"c5a4690c8f0a85d7b778b8d585104321767fa7a7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-02-15 15:39:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5b8f0fa0406ac04589a8b860d4d7b1698dca5581","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-15 19:09:05.000000000","message":"Patch Set 3: Verified-1\n\n(4 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/de6780006c574c9389745b52a0f5e670\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/9bee462f5d7c4a4e9ffe94548e88ca07 : SUCCESS in 1h 46m 50s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/a8a507c724534c979d0ed2c763bfa4a8 : SUCCESS in 52m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/91253d10641240ac951dc57ad923cb33 : FAILURE in 14m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5f2d32db205a4b43b313ec93c551e98d : FAILURE in 10m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0dc9c082970f4929aea4ca14cef9f90b : POST_FAILURE in 19m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bd89f1f0de7c4f969a8917958a5b445d : FAILURE in 12m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/20e8ceb4bdb544b298fbff0e07ce3d8a : FAILURE in 13m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a7b0e7d3fa184c4dafeabf69e61e74af : SUCCESS in 12m 58s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/9aa4b3344b294374995042d14258c7d7 : TIMED_OUT in 1h 33m 10s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/aaf265d90b074ff4bd297504e9f6a5e2 : SUCCESS in 1h 26m 46s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/2527829716e748f2b999e1200b204074 : SUCCESS in 1h 14m 00s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6e9531b8753649bb9e9e7c5a390eed78 : FAILURE in 1h 05m 07s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/5d5cf3a07b6f45389b8f9c9d8497a419 : SUCCESS in 55m 50s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/71f613c200d04833af206ff2b6e74cc8 : FAILURE in 1h 37m 24s\n- nova-next https://zuul.opendev.org/t/openstack/build/fb43a030d4e44babada4751defb12c2f : SUCCESS in 1h 34m 14s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bfb291d177a842638808e36542b0b8cc : SUCCESS in 20m 29s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/f11e2e5ecdd4483ea84c7449b502ae3d : SUCCESS in 17m 52s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/bcf844af6c3e469cae1ea2418ecb9901 : FAILURE in 7m 50s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/8902e1958e384fb5b16cffc14e16b1fd : SUCCESS in 2h 17m 49s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a8e961dc3980489bbea2641466202d5e : SUCCESS in 1h 18m 02s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b81706af577f4c97a6da7404d6918d4b : SUCCESS in 1h 08m 26s","accounts_in_message":[],"_revision_number":3},{"id":"8f2b865d877752a6feb415d0da6c79275f75a0f6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2023-02-18 02:26:08.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 finger://zuul-v3-executor.novalocal/ea3b96913de44aaca5b8cecbb82fc44c : RETRY_LIMIT in 1m 13s","accounts_in_message":[],"_revision_number":3},{"id":"9637e60a2cead7d72c98a58d8838ecbc9e8cbc77","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 16:51:25.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"541d64d3a3b22e5ec2b47d93fe5da8360e467d55","revisions":{"696f9623bd5a922f1e4e63855eca76b114269a3e":{"kind":"REWORK","_number":1,"created":"2023-02-14 15:25:27.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/22/873722/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/22/873722/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/22/873722/1"}}},"commit":{"parents":[{"commit":"a121db00089e13a9b0b41583ad406f4e21dc60db","subject":"Add a workaround to skip hypervisor version check on LM","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a121db00089e13a9b0b41583ad406f4e21dc60db"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-17 10:15:37.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-02-14 15:24:14.000000000","tz":60},"subject":"libvirt: At start-up rework compareCPU() usage with a workaround","message":"libvirt: At start-up rework compareCPU() usage with a workaround\n\nIn this patch:\n\n  - Remove the first compareCPU() call (called via the wrapper\n    _compare_cpu()) in _check_cpu_compatibility(), and let libvirt\n    handle it.  (QEMU \u003e\u003d2.9 and libvirt \u003e\u003d 4.4.0 are the mininum\n    required versions, and upstream Nova satisfies them by a good\n    margin.)\n\n  - Validate the user-configured CPU models from\n    _get_cpu_model_mapping().  And take into account all the CPU flags\n    before calling _compare_cpu().\n\n    (Suggested-by: Sean Mooney -- thanks!)\n\n  - Add a workaround to allow skipping the remaining compareCPU() call\n    in _check_cpu_compatibility() as a potential future-proof (because\n    we cannot test all possible CPU models and hardware).  Unlike the\n    removed first call, this call takes into account the extra CPU flags\n    provided by the user into account when evaluating guest CPU model\n    compatibility.\n\nAs a follow up comes the patch[1] that replaces the older libvirt CPU\nAPI with the newer one.\n\nConflicts (Train):\n  - workarounds.py: Small rearrangement; this stable/train backport\n    hasn\u0027t merged yet:\n    https://review.opendev.org/c/openstack/nova/+/851226 -- Add a\n    workaround to skip hypervisor version check on LM\n  - libvirt/driver.py: Readjust the \u0027if\u0027 block in that validates CPU\n    model in _check_cpu_compatibility()\n  - libvirt/test_driver.py: Small adjustments; some tests from Wallaby\n    aren\u0027t in Train.\n\n[1] https://review.opendev.org/c/openstack/nova/+/869950 -- libvirt:\n    Replace usage of compareCPU() with compareHypervisorCPU()\n\nChange-Id: I8ef9db851b37c5249d2efbe09a15a1ddbae8205d\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n(cherry picked from commit 9caaaf1f221063a4329c72c8b67a6015648644a2)\n(cherry picked from commit 7c7c8442d3b02f7bb296b79574610e6b6036aefa)\n(cherry picked from commit 023244c83043b3cb1b1c2725e80b2955498e7971)\n(cherry picked from commit b6526563d4718a589f9f5645842cdbd69c759cad)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/696f9623bd5a922f1e4e63855eca76b114269a3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/696f9623bd5a922f1e4e63855eca76b114269a3e"}]},"parents_data":[{"branch_name":"refs/heads/stable/train","commit_id":"a121db00089e13a9b0b41583ad406f4e21dc60db","is_merged_in_target_branch":false,"change_id":"Iec387dcbc49ddb91ebf5cfd188224eaf6021c0e1","change_number":851226,"patch_set_number":2,"change_status":"ABANDONED"}],"branch":"refs/heads/stable/train"},"f31c69d5a05958f459eeacc40c0f056eed2670f1":{"kind":"REWORK","_number":2,"created":"2023-02-14 16:10:20.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/22/873722/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/22/873722/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/22/873722/2"}}},"commit":{"parents":[{"commit":"a121db00089e13a9b0b41583ad406f4e21dc60db","subject":"Add a workaround to skip hypervisor version check on LM","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a121db00089e13a9b0b41583ad406f4e21dc60db"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-17 10:15:37.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-02-14 16:10:06.000000000","tz":60},"subject":"libvirt: At start-up rework compareCPU() usage with a workaround","message":"libvirt: At start-up rework compareCPU() usage with a workaround\n\nIn this patch:\n\n  - Remove the first compareCPU() call (called via the wrapper\n    _compare_cpu()) in _check_cpu_compatibility(), and let libvirt\n    handle it.  (QEMU \u003e\u003d2.9 and libvirt \u003e\u003d 4.4.0 are the mininum\n    required versions, and upstream Nova satisfies them by a good\n    margin.)\n\n  - Validate the user-configured CPU models from\n    _get_cpu_model_mapping().  And take into account all the CPU flags\n    before calling _compare_cpu().\n\n    (Suggested-by: Sean Mooney -- thanks!)\n\n  - Add a workaround to allow skipping the remaining compareCPU() call\n    in _check_cpu_compatibility() as a potential future-proof (because\n    we cannot test all possible CPU models and hardware).  Unlike the\n    removed first call, this call takes into account the extra CPU flags\n    provided by the user into account when evaluating guest CPU model\n    compatibility.\n\nAs a follow up comes the patch[1] that replaces the older libvirt CPU\nAPI with the newer one.\n\nConflicts (Train):\n  - workarounds.py: Small rearrangement; this stable/train backport\n    hasn\u0027t merged yet:\n    https://review.opendev.org/c/openstack/nova/+/851226 -- Add a\n    workaround to skip hypervisor version check on LM\n  - libvirt/driver.py: Readjust the \u0027if\u0027 block in that validates CPU\n    model in _check_cpu_compatibility()\n  - libvirt/test_driver.py: Small adjustments; some tests from Wallaby\n    aren\u0027t in Train.\n\n[1] https://review.opendev.org/c/openstack/nova/+/869950 -- libvirt:\n    Replace usage of compareCPU() with compareHypervisorCPU()\n\nChange-Id: I8ef9db851b37c5249d2efbe09a15a1ddbae8205d\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n(cherry picked from commit 9caaaf1f221063a4329c72c8b67a6015648644a2)\n(cherry picked from commit 7c7c8442d3b02f7bb296b79574610e6b6036aefa)\n(cherry picked from commit 023244c83043b3cb1b1c2725e80b2955498e7971)\n(cherry picked from commit b6526563d4718a589f9f5645842cdbd69c759cad)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f31c69d5a05958f459eeacc40c0f056eed2670f1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f31c69d5a05958f459eeacc40c0f056eed2670f1"}]},"parents_data":[{"branch_name":"refs/heads/stable/train","commit_id":"a121db00089e13a9b0b41583ad406f4e21dc60db","is_merged_in_target_branch":false,"change_id":"Iec387dcbc49ddb91ebf5cfd188224eaf6021c0e1","change_number":851226,"patch_set_number":2,"change_status":"ABANDONED"}],"branch":"refs/heads/stable/train"},"541d64d3a3b22e5ec2b47d93fe5da8360e467d55":{"kind":"REWORK","_number":3,"created":"2023-02-15 15:39:29.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/22/873722/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/22/873722/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/22/873722/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/22/873722/3"}}},"commit":{"parents":[{"commit":"a121db00089e13a9b0b41583ad406f4e21dc60db","subject":"Add a workaround to skip hypervisor version check on LM","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a121db00089e13a9b0b41583ad406f4e21dc60db"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-17 10:15:37.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-02-15 15:39:14.000000000","tz":60},"subject":"libvirt: At start-up rework compareCPU() usage with a workaround","message":"libvirt: At start-up rework compareCPU() usage with a workaround\n\nIn this patch:\n\n  - Remove the first compareCPU() call (called via the wrapper\n    _compare_cpu()) in _check_cpu_compatibility(), and let libvirt\n    handle it.  (QEMU \u003e\u003d2.9 and libvirt \u003e\u003d 4.4.0 are the mininum\n    required versions, and upstream Nova satisfies them by a good\n    margin.)\n\n  - Validate the user-configured CPU models from\n    _get_cpu_model_mapping().  And take into account all the CPU flags\n    before calling _compare_cpu().\n\n    (Suggested-by: Sean Mooney -- thanks!)\n\n  - Add a workaround to allow skipping the remaining compareCPU() call\n    in _check_cpu_compatibility() as a potential future-proof (because\n    we cannot test all possible CPU models and hardware).  Unlike the\n    removed first call, this call takes into account the extra CPU flags\n    provided by the user into account when evaluating guest CPU model\n    compatibility.\n\nAs a follow up comes the patch[1] that replaces the older libvirt CPU\nAPI with the newer one.\n\nConflicts (Train):\n  - workarounds.py: Small rearrangement; this stable/train backport\n    hasn\u0027t merged yet:\n    https://review.opendev.org/c/openstack/nova/+/851226 -- Add a\n    workaround to skip hypervisor version check on LM\n  - libvirt/driver.py: Readjust the \u0027if\u0027 block in that validates CPU\n    model in _check_cpu_compatibility()\n  - libvirt/test_driver.py: Small adjustments; some tests from Wallaby\n    aren\u0027t in Train.\n\n[1] https://review.opendev.org/c/openstack/nova/+/869950 -- libvirt:\n    Replace usage of compareCPU() with compareHypervisorCPU()\n\nChange-Id: I8ef9db851b37c5249d2efbe09a15a1ddbae8205d\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n(cherry picked from commit 9caaaf1f221063a4329c72c8b67a6015648644a2)\n(cherry picked from commit 7c7c8442d3b02f7bb296b79574610e6b6036aefa)\n(cherry picked from commit 023244c83043b3cb1b1c2725e80b2955498e7971)\n(cherry picked from commit b6526563d4718a589f9f5645842cdbd69c759cad)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/541d64d3a3b22e5ec2b47d93fe5da8360e467d55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/541d64d3a3b22e5ec2b47d93fe5da8360e467d55"}]},"parents_data":[{"branch_name":"refs/heads/stable/train","commit_id":"a121db00089e13a9b0b41583ad406f4e21dc60db","is_merged_in_target_branch":false,"change_id":"Iec387dcbc49ddb91ebf5cfd188224eaf6021c0e1","change_number":851226,"patch_set_number":2,"change_status":"ABANDONED"}],"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}