)]}'
{"id":"openstack%2Fnova~874066","triplet_id":"openstack%2Fnova~stable%2Fxena~I63208c7bd5f9f4c3d5e4a40bd0f6253d0f042a37","project":"openstack/nova","branch":"stable/xena","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2023-04-06 10:43:24.000000000","reason":"Change was submitted"},"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-02-16 10:31:56.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"I63208c7bd5f9f4c3d5e4a40bd0f6253d0f042a37","subject":"db: Resolve additional SAWarning warnings","status":"MERGED","created":"2023-02-16 08:57:48.000000000","updated":"2023-04-06 10:44:36.000000000","submitted":"2023-04-06 10:43:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"874066","meta_rev_id":"e42056f93562202da022749ade0231cb76cda608","_number":874066,"virtual_id_number":874066,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-04-06 10:43:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2023-02-16 10:31:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-02-19 05:09:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":2,"date":"2023-04-06 09:03:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":1,"date":"2023-04-06 09:03:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-16 08:57:48.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2023-02-16 09:33:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-02-16 10:32:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-02-18 11:36:04.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-02-19 05:09:48.000000000","updated_by":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"reviewer":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"state":"REVIEWER"},{"updated":"2023-04-06 09:03:20.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"}],"messages":[{"id":"14a487c7988dc2e46fa50caf2b129a94c92569ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-02-16 08:57:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f28e2dff620ba8a99daa417572d3e7d761406358","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-16 09:33:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c87f58032c4644ba94f78bb8f7bffd9f\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/30fd02cc907b4b07859d7739f5c1d144 : SUCCESS in 32m 06s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/8797ff618c91449884632c7b3024574d : SUCCESS in 33m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c8319bfdf19a8cf045c699fb9b422270d00e0450","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-02-16 10:31:56.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e2f6897b8699ffe9f1e3ca2ab18e08c74a700d87","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-16 10:32:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/131d59ea80a14d9289c169601cf66025\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/6b750431e5ea49208f7cbd3e444b9ac2 : SUCCESS in 1h 32m 32s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/0a2a92f7e47f4e53907ba6e472f13d85 : FAILURE in 25m 47s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3e6495c8c0364d168ae3457ba30d08fe : SUCCESS in 50m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/96d6a65367e843cbb064539cf8fc9d7d : SUCCESS in 14m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2be25c22b06e44b89fff78bb91e02c95 : SUCCESS in 8m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e0f98b9e45b94e42965672867868fd2d : SUCCESS in 11m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/50383eb85aca42498c2be0e47950aa73 : SUCCESS in 11m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/17b9c77447784a86ac94ef63de95d15a : SUCCESS in 10m 28s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cc621af146dc43d7bad1cd0fe773e0ea : SUCCESS in 9m 13s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/78de697d79c74a1dbfe090263233a40d : SUCCESS in 46m 36s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/ddaaad02f3d64572b2f50cdacd67138c : SUCCESS in 1h 11m 43s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/dc73ff0f8c124a1e9248ce1f917fdbdd : SUCCESS in 37m 25s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/19a9dc0c54b24d98a2b71c9b255f8b17 : SUCCESS in 37m 55s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/32013771b25646fe95edbc5a766538fb : SUCCESS in 1h 10m 03s\n- nova-next https://zuul.opendev.org/t/openstack/build/d77849d0e1bd47a5990b99a11eb8ed01 : SUCCESS in 1h 21m 54s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/89fc9ae1bf6a41929fd35945966fcaa9 : SUCCESS in 42m 08s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/e1daeb6dabd74cf89f474172fea3c2c7 : FAILURE in 5m 20s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/37c79cb4f20c4fb1b155cd940734b1d5 : SUCCESS in 22m 26s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/395fc369f79946d6b2e5675c157586b0 : SUCCESS in 20m 24s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/6fb8134ce2db44b1acfcf50dc38b33ab : SUCCESS in 18m 21s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/51fb2853b7e34557adc8b2274f7f26ea : SUCCESS in 1h 08m 01s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8b0df54acbd94dedaba0d61b8cac913e : SUCCESS in 49m 00s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/284b7146963746edafed497ab8c63024 : SUCCESS in 21m 38s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/40b4528be3024a62b9a9938e9b9d32bb : FAILURE in 38m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5fb1ab9a542d66ae1d23e53cb9f6ff56147f450b","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2023-02-18 11:36:04.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/0a7740664f4c4a94b56ca5295a918a23 : RETRY_LIMIT in 1m 05s","accounts_in_message":[],"_revision_number":1},{"id":"54cbe4ad34fabd7c32fb618465e56f13b062fc35","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2023-02-19 05:09:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"005557bf5516369099ce08f6e5431162d317d81c","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2023-04-06 09:03:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bc47a3d133c22d22980fb3060867df08e63342ef","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 09:03:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"60c1a9c64b428c583cece6c69b66e41fc7656034","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 10:43:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/163d23412fe1488c9e8ee7d644183ed4\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/802bd1dacb834f7aad8c456b4af3ac23 : SUCCESS in 1h 18m 23s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/5ecadf19b0324e18a4578eea247e7e02 : SUCCESS in 1h 02m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e386833febe64fb5a1cf654ffb659185 : SUCCESS in 7m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c2fd39abf2b0485d8c55d97a7202fdb1 : SUCCESS in 11m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7747fd3c3fd54517bc654f7bbe22e08f : SUCCESS in 11m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4bfbd1b6186f4a5795841cee57290347 : SUCCESS in 8m 57s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f0a8874ae62e4f6ab4dc902558609bfa : SUCCESS in 56m 45s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/1538deea61c041f8af58d506eb9d313d : SUCCESS in 55m 36s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/a22a9a5edf0f437ea11db4b6aee92f9a : SUCCESS in 23m 06s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/69950266028e499e865acad41606feda : SUCCESS in 18m 57s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/9f4d39bfde594397aa847b0ca41fcca8 : SUCCESS in 1h 34m 07s\n- nova-next https://zuul.opendev.org/t/openstack/build/2350a1cfb28046c5a098587559c5cbd4 : SUCCESS in 1h 14m 16s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/9f818db4bbb94f799004b92e047714a7 : SUCCESS in 4m 52s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/0e0f436e517d4a92ab4050ff1b3dba38 : SUCCESS in 1h 17m 04s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/18c1564cd4e24555ac3a39833679cfe8 : SUCCESS in 1h 18m 38s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/66cdfc0050e041aa8bce3c56802d6b71 : SUCCESS in 40m 27s","accounts_in_message":[],"_revision_number":1},{"id":"d69716abca0ad84ab34530cbd88d3f09654ac869","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 10:43:24.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"e42056f93562202da022749ade0231cb76cda608","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-06 10:44:36.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/549d1f1c0de9487cab481071c96f6327\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c474fc2c69040e8963bc17f556446e6 : SUCCESS in 51s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5b1d487d7fc49580a606b68e1271cae5f2f2df87","revisions":{"5b1d487d7fc49580a606b68e1271cae5f2f2df87":{"kind":"REWORK","_number":1,"created":"2023-02-16 08:57:48.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/66/874066/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/66/874066/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/66/874066/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/66/874066/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/66/874066/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/66/874066/1"}}},"commit":{"parents":[{"commit":"f25cebf8f11c02a162e1ad21291c090dd1a745e3","subject":"Merge \"nova-live-migration tests not needed for Ironic\" into stable/xena","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f25cebf8f11c02a162e1ad21291c090dd1a745e3"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2022-04-08 10:38:54.000000000","tz":60},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-02-16 08:55:45.000000000","tz":0},"subject":"db: Resolve additional SAWarning warnings","message":"db: Resolve additional SAWarning warnings\n\nResolving the following SAWarning warnings:\n\n  Coercing Subquery object into a select() for use in IN(); please pass\n  a select() construct explicitly\n\n  SELECT statement has a cartesian product between FROM element(s)\n  \"foo\" and FROM element \"bar\". Apply join condition(s) between each\n  element to resolve.\n\nWhile the first of these was a trivial fix, the second one is a little\nmore involved. It was caused by attempting to build a query across\ntables that had no relationship as part of our archive logic. For\nexample, consider the following queries, generated early in\n\u0027_get_fk_stmts\u0027:\n\n  SELECT instances.uuid\n  FROM instances, security_group_instance_association\n  WHERE security_group_instance_association.instance_uuid \u003d instances.uuid\n    AND instances.id IN (__[POSTCOMPILE_id_1])\n\n  SELECT security_groups.id\n  FROM security_groups, security_group_instance_association, instances\n  WHERE security_group_instance_association.security_group_id \u003d security_groups.id\n    AND instances.id IN (__[POSTCOMPILE_id_1])\n\nWhile the first of these is fine, the second is clearly wrong: why are\nwe filtering on a field that is of no relevance to our join? These were\ngenerated because we were attempting to archive one or more instances\n(in this case, the instance with id\u003d1) and needed to find related tables\nto archive at the same time. A related table is any table that\nreferences our \"source\" table - \u0027instances\u0027 here - by way of a foreign\nkey. For each of *these* tables, we then lookup each foreign key and\njoin back to the source table, filtering by matching entries in the\nsource table. The issue here is that we\u0027re looking up every foreign key.\nWhat we actually want to do is lookup only the foreign keys that point\nback to our source table. This flaw is why we were generating the second\nSELECT above: the \u0027security_group_instance_association\u0027 has two foreign\nkeys, one pointing to our \u0027instances\u0027 table but also another pointing to\nthe \u0027security_groups\u0027 table. We want the first but not the second.\n\nResolve this by checking if the table that each foreign key points to is\nactually the source table and simply skip if not. With this issue\nresolved, we can enable errors on SAWarning warnings in general without\nany filters.\n\nConflicts:\n    nova/tests/fixtures/nova.py\n\nNOTE(melwitt): The conflict is because change\nI63f57980e01f472a25821790610f0836f1882a7f (tests: Restore - don\u0027t reset\n- warning filters) is not in Xena.\n\nChange-Id: I63208c7bd5f9f4c3d5e4a40bd0f6253d0f042a37\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n(cherry picked from commit 8142b9dc47b7096ab9d8180f0b5b1e52d513e2dc)\n(cherry picked from commit ce2cc54bfe236554badb9f6bf53a958417e5525d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5b1d487d7fc49580a606b68e1271cae5f2f2df87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5b1d487d7fc49580a606b68e1271cae5f2f2df87"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}