)]}'
{"id":"openstack%2Fnova~874071","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I63208c7bd5f9f4c3d5e4a40bd0f6253d0f042a37","project":"openstack/nova","branch":"stable/victoria","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 18:56:49.000000000","reason":"Change was abandoned"},"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-02-16 10:33:00.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}},"hashtags":[],"change_id":"I63208c7bd5f9f4c3d5e4a40bd0f6253d0f042a37","subject":"db: Resolve additional SAWarning warnings","status":"ABANDONED","created":"2023-02-16 09:31:44.000000000","updated":"2024-03-05 18:56:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3d82ada5a8e15e3c9e2d1bc2f6177afa57612f84","_number":874071,"virtual_id_number":874071,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-02-16 11:11:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2023-02-16 10:33:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-02-19 05:29:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-16 09:31:44.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2023-02-16 11:11:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-02-18 09:20:36.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-02-19 05:29:25.000000000","updated_by":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"reviewer":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"state":"REVIEWER"},{"updated":"2024-03-05 18:56:49.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"2e2f0e445f52ce8b5ed8ecdd2ddc0b4b6c2e22ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-02-16 09:31:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d633c800fa058fd328f5dc8abdff07290335948f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-02-16 10:33:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4c678c269466a707ab6f7721d2e93c318f4b2516","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-16 11:11:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/fa5c33f853274cd8ba7401984cf6a500\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/bd0393a603994b35b6404a6bfb1d412c : SUCCESS in 1h 16m 14s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7dd19b161ec84682a39d222f8ff56162 : POST_FAILURE in 23m 41s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6cef9f683beb404c9767ba49c19ace95 : SUCCESS in 17m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6f03f9eb9eec4ba3b442b70a5e1cf185 : SUCCESS in 7m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8973450cf8184af28782a776bd8e13de : SUCCESS in 11m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ea65bce267f44db28555abdfd96489d4 : SUCCESS in 14m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f564595b5e8b46e1a74d17ac8544bd13 : SUCCESS in 9m 42s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/55dc8f10a4d3431f8fe455255b4fb08c : SUCCESS in 52m 36s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/e1de2b1646714e60bc7997327290753b : SUCCESS in 1h 06m 38s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/58444af1bb4949f4a4e74de37cee8ba5 : FAILURE in 53m 24s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/c10e54af41184645b053f4f5f8bed8ce : SUCCESS in 1h 13m 09s\n- nova-next https://zuul.opendev.org/t/openstack/build/37b97592999e4746953a1b047bca0f70 : SUCCESS in 1h 28m 15s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/83e1ab24774c4305a2e9c17d96b8e1eb : FAILURE in 5m 06s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b18bbb377dce4d7980e89074fad6c3bd : SUCCESS in 21m 01s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/64711a2378bc43dd8c5014454b9d6378 : SUCCESS in 1h 30m 42s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8083e9fa4089427696640a7ca16f795c : SUCCESS in 55m 01s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/656cca353b8b443ca261794f8563c94a : FAILURE in 37m 38s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/aeab73326e0c4a398dbf6ce7c98286c7 : FAILURE in 43m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7673f70258b746e27e342be3b58c05aca52a13ed","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2023-02-18 09:20:36.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 finger://zuul-v3-executor.novalocal/91d06b83303d422bb469b78ab4f8bce6 : FAILURE in 1h 10m 49s","accounts_in_message":[],"_revision_number":1},{"id":"4a6753f914f87f18fb084fc4c83c39dd7825dccc","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2023-02-19 05:29:25.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3d82ada5a8e15e3c9e2d1bc2f6177afa57612f84","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 18:56:49.000000000","message":"Abandoned\n\nstable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3fd73d5935ac048eaa5f90c9f996e66aab0431b8","revisions":{"3fd73d5935ac048eaa5f90c9f996e66aab0431b8":{"kind":"REWORK","_number":1,"created":"2023-02-16 09:31:44.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/71/874071/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/874071/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/874071/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/874071/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/874071/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/874071/1"}}},"commit":{"parents":[{"commit":"70fd0cfc8ee2b541ffc1f9feb129314965d1670c","subject":"Merge \"Adapt websocketproxy tests for SimpleHTTPServer fix\" into stable/victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/70fd0cfc8ee2b541ffc1f9feb129314965d1670c"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2022-04-08 10:38:54.000000000","tz":60},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-02-16 09:31:13.000000000","tz":0},"subject":"db: Resolve additional SAWarning warnings","message":"db: Resolve additional SAWarning warnings\n\nResolving the following SAWarning warnings:\n\n  Coercing Subquery object into a select() for use in IN(); please pass\n  a select() construct explicitly\n\n  SELECT statement has a cartesian product between FROM element(s)\n  \"foo\" and FROM element \"bar\". Apply join condition(s) between each\n  element to resolve.\n\nWhile the first of these was a trivial fix, the second one is a little\nmore involved. It was caused by attempting to build a query across\ntables that had no relationship as part of our archive logic. For\nexample, consider the following queries, generated early in\n\u0027_get_fk_stmts\u0027:\n\n  SELECT instances.uuid\n  FROM instances, security_group_instance_association\n  WHERE security_group_instance_association.instance_uuid \u003d instances.uuid\n    AND instances.id IN (__[POSTCOMPILE_id_1])\n\n  SELECT security_groups.id\n  FROM security_groups, security_group_instance_association, instances\n  WHERE security_group_instance_association.security_group_id \u003d security_groups.id\n    AND instances.id IN (__[POSTCOMPILE_id_1])\n\nWhile the first of these is fine, the second is clearly wrong: why are\nwe filtering on a field that is of no relevance to our join? These were\ngenerated because we were attempting to archive one or more instances\n(in this case, the instance with id\u003d1) and needed to find related tables\nto archive at the same time. A related table is any table that\nreferences our \"source\" table - \u0027instances\u0027 here - by way of a foreign\nkey. For each of *these* tables, we then lookup each foreign key and\njoin back to the source table, filtering by matching entries in the\nsource table. The issue here is that we\u0027re looking up every foreign key.\nWhat we actually want to do is lookup only the foreign keys that point\nback to our source table. This flaw is why we were generating the second\nSELECT above: the \u0027security_group_instance_association\u0027 has two foreign\nkeys, one pointing to our \u0027instances\u0027 table but also another pointing to\nthe \u0027security_groups\u0027 table. We want the first but not the second.\n\nResolve this by checking if the table that each foreign key points to is\nactually the source table and simply skip if not. With this issue\nresolved, we can enable errors on SAWarning warnings in general without\nany filters.\n\nChange-Id: I63208c7bd5f9f4c3d5e4a40bd0f6253d0f042a37\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n(cherry picked from commit 8142b9dc47b7096ab9d8180f0b5b1e52d513e2dc)\n(cherry picked from commit ce2cc54bfe236554badb9f6bf53a958417e5525d)\n(cherry picked from commit 5b1d487d7fc49580a606b68e1271cae5f2f2df87)\n(cherry picked from commit 5d0325a78b2a5f7a9109290fb23d46a841042da6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3fd73d5935ac048eaa5f90c9f996e66aab0431b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3fd73d5935ac048eaa5f90c9f996e66aab0431b8"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}