)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0a662a26b48a4989e417ff80e217c37db09b625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a239d95f_74f7b048","updated":"2023-03-01 14:56:29.000000000","message":"Sounds better to me now. Some wordsmithing suggestions inline if you want the docs to sound a little more natural.","commit_id":"e5e8a9496b570ed611292a946fb45fa853da0a1f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd1d0d3326409a296190b9a11d9be870b3546245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d69f5cc6_dc4466af","updated":"2023-03-02 09:11:17.000000000","message":"Thanks for the grammar nits.","commit_id":"e5e8a9496b570ed611292a946fb45fa853da0a1f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"625485ea11387988579cb58ac05f6a7fec7fe24c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c7b7aded_eabc5527","updated":"2023-03-02 09:12:54.000000000","message":"I don\u0027t usually +2 my change but given the proximity of RC1, the gate status and the timezone difference, I then proxy Dan\u0027s vote here.","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c181f05ad0368fb3c1c3b518a972b99bd2585113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8208d55a_eecd44ce","updated":"2023-03-02 14:23:22.000000000","message":"Again proxying Dan\u0027s vote, see my previous comment explaining why.","commit_id":"349100eecc67c51f9d770ccb4fdec0e28e0dc909"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9e835f470bdd471648f6bbbda4a45699962c55e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a7de70a5_850f1830","updated":"2023-03-02 23:12:54.000000000","message":"recheck ssh timeout during grenade resource phase","commit_id":"349100eecc67c51f9d770ccb4fdec0e28e0dc909"}],"doc/source/admin/upgrades.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01e41b03a4977bfe7e9ad52ff7ec92c9132865d8","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. important::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    By OpenStack 2023.1 (Antelope), Nova does now currently support the"},{"line_number":52,"context_line":"    coexistence of N and N+2 or greater"},{"line_number":53,"context_line":"    :program:`nova-compute` or :program:`nova-conductor` services in the same"},{"line_number":54,"context_line":"    deployment. The `nova-conductor`` service will fail to start when a"},{"line_number":55,"context_line":"    ``nova-compute`` service that is older than the previous release (N-3 or"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8d36c137_3873b4e1","line":52,"range":{"start_line":51,"start_character":4,"end_line":52,"end_character":39},"updated":"2023-02-28 18:57:17.000000000","message":"As of OpenStack 2023.1 (Antelope), Nova enables the\n    coexistence of N and N-2 (Yoga)","commit_id":"2be7826d39914717cac5b2fdaacf58b86a66161d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ef86ce977d27862eaef00ccb2457020ea8d15f3d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. important::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    By OpenStack 2023.1 (Antelope), Nova does now currently support the"},{"line_number":52,"context_line":"    coexistence of N and N+2 or greater"},{"line_number":53,"context_line":"    :program:`nova-compute` or :program:`nova-conductor` services in the same"},{"line_number":54,"context_line":"    deployment. The `nova-conductor`` service will fail to start when a"},{"line_number":55,"context_line":"    ``nova-compute`` service that is older than the previous release (N-3 or"}],"source_content_type":"text/x-rst","patch_set":4,"id":"231d91d2_a4361bfb","line":52,"range":{"start_line":51,"start_character":4,"end_line":52,"end_character":39},"in_reply_to":"8d36c137_3873b4e1","updated":"2023-03-01 10:10:08.000000000","message":"Ack","commit_id":"2be7826d39914717cac5b2fdaacf58b86a66161d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01e41b03a4977bfe7e9ad52ff7ec92c9132865d8","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    By OpenStack 2023.1 (Antelope), Nova does now currently support the"},{"line_number":52,"context_line":"    coexistence of N and N+2 or greater"},{"line_number":53,"context_line":"    :program:`nova-compute` or :program:`nova-conductor` services in the same"},{"line_number":54,"context_line":"    deployment. The `nova-conductor`` service will fail to start when a"},{"line_number":55,"context_line":"    ``nova-compute`` service that is older than the previous release (N-3 or"},{"line_number":56,"context_line":"    greater) is detected. Similarly, in a :doc:`deployment with multiple cells"},{"line_number":57,"context_line":"    \u003c/admin/cells\u003e`, neither the super conductor service nor any per-cell"},{"line_number":58,"context_line":"    conductor service will start if any other conductor service in the"},{"line_number":59,"context_line":"    deployment is older than the previous release."}],"source_content_type":"text/x-rst","patch_set":4,"id":"c36d95e3_4d510c28","line":56,"range":{"start_line":54,"start_character":16,"end_line":56,"end_character":25},"updated":"2023-02-28 18:57:17.000000000","message":"The `nova-conductor`` service will fail to start when a\n``nova-compute`` service that is older than N-2(Yoga) is detected.","commit_id":"2be7826d39914717cac5b2fdaacf58b86a66161d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ef86ce977d27862eaef00ccb2457020ea8d15f3d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    By OpenStack 2023.1 (Antelope), Nova does now currently support the"},{"line_number":52,"context_line":"    coexistence of N and N+2 or greater"},{"line_number":53,"context_line":"    :program:`nova-compute` or :program:`nova-conductor` services in the same"},{"line_number":54,"context_line":"    deployment. The `nova-conductor`` service will fail to start when a"},{"line_number":55,"context_line":"    ``nova-compute`` service that is older than the previous release (N-3 or"},{"line_number":56,"context_line":"    greater) is detected. Similarly, in a :doc:`deployment with multiple cells"},{"line_number":57,"context_line":"    \u003c/admin/cells\u003e`, neither the super conductor service nor any per-cell"},{"line_number":58,"context_line":"    conductor service will start if any other conductor service in the"},{"line_number":59,"context_line":"    deployment is older than the previous release."}],"source_content_type":"text/x-rst","patch_set":4,"id":"0eeec06e_60d82639","line":56,"range":{"start_line":54,"start_character":16,"end_line":56,"end_character":25},"in_reply_to":"952fc8c4_ed5a1e47","updated":"2023-03-01 10:10:08.000000000","message":"Ack","commit_id":"2be7826d39914717cac5b2fdaacf58b86a66161d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a024a1f7e6654a4b1acbc093b7519597c878d924","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    By OpenStack 2023.1 (Antelope), Nova does now currently support the"},{"line_number":52,"context_line":"    coexistence of N and N+2 or greater"},{"line_number":53,"context_line":"    :program:`nova-compute` or :program:`nova-conductor` services in the same"},{"line_number":54,"context_line":"    deployment. The `nova-conductor`` service will fail to start when a"},{"line_number":55,"context_line":"    ``nova-compute`` service that is older than the previous release (N-3 or"},{"line_number":56,"context_line":"    greater) is detected. Similarly, in a :doc:`deployment with multiple cells"},{"line_number":57,"context_line":"    \u003c/admin/cells\u003e`, neither the super conductor service nor any per-cell"},{"line_number":58,"context_line":"    conductor service will start if any other conductor service in the"},{"line_number":59,"context_line":"    deployment is older than the previous release."}],"source_content_type":"text/x-rst","patch_set":4,"id":"952fc8c4_ed5a1e47","line":56,"range":{"start_line":54,"start_character":16,"end_line":56,"end_character":25},"in_reply_to":"c36d95e3_4d510c28","updated":"2023-02-28 20:33:39.000000000","message":"Personally I\u0027d just make this less specific to a release and say something like \"The nova-conductor service will fail to start when a nova-compute service older than the support envelope is detected\" and leave it at that. Perhaps you could say \"This varies by release\" or something as well and maybe \"As of 2023.1, this may be older than just the previous version, as has been the policy in the past, depending on the support guarantees of a given release.\"","commit_id":"2be7826d39914717cac5b2fdaacf58b86a66161d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0a662a26b48a4989e417ff80e217c37db09b625","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. important::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    By OpenStack 2023.1 (Antelope), Nova does now currently support the"},{"line_number":52,"context_line":"    coexistence of N and N-2 (Yoga)"},{"line_number":53,"context_line":"    :program:`nova-compute` or :program:`nova-conductor` services in the same"},{"line_number":54,"context_line":"    deployment. The `nova-conductor`` service will fail to start when a"}],"source_content_type":"text/x-rst","patch_set":5,"id":"822b483c_fb81525c","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":49},"updated":"2023-03-01 14:56:29.000000000","message":"Two things here:\n\n\"By 2023.1\" doesn\u0027t really sound right, but \"As of\" does.\n\nAlso \"does now\" sounds awkward, but if you take the above, this sounds better:\n\n\"As of OpenStack 2023.1 (Antelope), Nova supports the coexistence of...\"","commit_id":"e5e8a9496b570ed611292a946fb45fa853da0a1f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd1d0d3326409a296190b9a11d9be870b3546245","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. important::"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    By OpenStack 2023.1 (Antelope), Nova does now currently support the"},{"line_number":52,"context_line":"    coexistence of N and N-2 (Yoga)"},{"line_number":53,"context_line":"    :program:`nova-compute` or :program:`nova-conductor` services in the same"},{"line_number":54,"context_line":"    deployment. The `nova-conductor`` service will fail to start when a"}],"source_content_type":"text/x-rst","patch_set":5,"id":"19bff552_37da4b27","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":49},"in_reply_to":"822b483c_fb81525c","updated":"2023-03-02 09:11:17.000000000","message":"Ack","commit_id":"e5e8a9496b570ed611292a946fb45fa853da0a1f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0a662a26b48a4989e417ff80e217c37db09b625","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    conductor service will start if any other conductor service in the"},{"line_number":60,"context_line":"    deployment is older than the previous release."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    Older releases than 2023.1 will only support rolling upgrades for a single"},{"line_number":63,"context_line":"    release difference between :program:`nova-compute` and"},{"line_number":64,"context_line":"    :program:`nova-conductor` services."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"62e1dd04_dc7c8350","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":30},"updated":"2023-03-01 14:56:29.000000000","message":"\"Releases older than 2023.1 will\" sounds better to a native speaker.","commit_id":"e5e8a9496b570ed611292a946fb45fa853da0a1f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd1d0d3326409a296190b9a11d9be870b3546245","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    conductor service will start if any other conductor service in the"},{"line_number":60,"context_line":"    deployment is older than the previous release."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    Older releases than 2023.1 will only support rolling upgrades for a single"},{"line_number":63,"context_line":"    release difference between :program:`nova-compute` and"},{"line_number":64,"context_line":"    :program:`nova-conductor` services."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"8bfece5d_cab260e8","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":30},"in_reply_to":"62e1dd04_dc7c8350","updated":"2023-03-02 09:11:17.000000000","message":"Ack","commit_id":"e5e8a9496b570ed611292a946fb45fa853da0a1f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ef473ea8ab260f6658ca6c26eada0afa7a9bf45","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fd821efb_e94af796","updated":"2023-03-02 09:50:56.000000000","message":"It feels we are trying to patch this doc instead for reformulating it adapt to the new SLURP process. I think SLURP is a big enough feature to make it the default description and move the N-\u003eN+1 case as the exception instead.","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c181f05ad0368fb3c1c3b518a972b99bd2585113","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5ac0c8c4_0f7754ba","in_reply_to":"fd821efb_e94af796","updated":"2023-03-02 14:23:22.000000000","message":"For the moment, this is a bit unsupported officially (even if 2023.1 is a SLURP release) and we don\u0027t have a lot of time. But surely we can do a better documentation later (and even backporting the document)","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ef473ea8ab260f6658ca6c26eada0afa7a9bf45","unresolved":true,"context_lines":[{"line_number":38,"context_line":"Rolling upgrade process"},{"line_number":39,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"To reduce downtime, the compute services can be upgraded in a rolling fashion."},{"line_number":42,"context_line":"It means upgrading a few services at a time. This results in a condition where"},{"line_number":43,"context_line":"both old (N) and new (N+1) nova-compute services co-exist for a certain time"},{"line_number":44,"context_line":"period. Note that, there is no upgrade of the hypervisor here, this is just"},{"line_number":45,"context_line":"upgrading the nova services. If reduced downtime is not a concern (or lower"},{"line_number":46,"context_line":"complexity is desired), all services may be taken down and restarted at the"},{"line_number":47,"context_line":"same time."}],"source_content_type":"text/x-rst","patch_set":6,"id":"bc477957_a9b15571","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":7},"updated":"2023-03-02 09:50:56.000000000","message":"I might improve on this as well as it also hints that only N -\u003e N+1 rolling is supported. But for antelope we have N -\u003e N+2 experimental rolling support as well.","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c181f05ad0368fb3c1c3b518a972b99bd2585113","unresolved":false,"context_lines":[{"line_number":38,"context_line":"Rolling upgrade process"},{"line_number":39,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"To reduce downtime, the compute services can be upgraded in a rolling fashion."},{"line_number":42,"context_line":"It means upgrading a few services at a time. This results in a condition where"},{"line_number":43,"context_line":"both old (N) and new (N+1) nova-compute services co-exist for a certain time"},{"line_number":44,"context_line":"period. Note that, there is no upgrade of the hypervisor here, this is just"},{"line_number":45,"context_line":"upgrading the nova services. If reduced downtime is not a concern (or lower"},{"line_number":46,"context_line":"complexity is desired), all services may be taken down and restarted at the"},{"line_number":47,"context_line":"same time."}],"source_content_type":"text/x-rst","patch_set":6,"id":"4708514f_9acf67dc","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":7},"in_reply_to":"bc477957_a9b15571","updated":"2023-03-02 14:23:22.000000000","message":"Ack","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ef473ea8ab260f6658ca6c26eada0afa7a9bf45","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    in the release notes. Similarly, in a :doc:`deployment with multiple cells"},{"line_number":57,"context_line":"    \u003c/admin/cells\u003e`, neither the super conductor service nor any per-cell"},{"line_number":58,"context_line":"    conductor service will start if any other conductor service in the"},{"line_number":59,"context_line":"    deployment is older than the previous release."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    Releases older than 2023.1 will only support rolling upgrades for a single"},{"line_number":62,"context_line":"    release difference between :program:`nova-compute` and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"f966a5aa_7db11df4","line":59,"range":{"start_line":59,"start_character":15,"end_line":59,"end_character":50},"updated":"2023-03-02 09:50:56.000000000","message":"this also talks about previous release which is confusing as for Antelope it is more than just the previous release","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c181f05ad0368fb3c1c3b518a972b99bd2585113","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    in the release notes. Similarly, in a :doc:`deployment with multiple cells"},{"line_number":57,"context_line":"    \u003c/admin/cells\u003e`, neither the super conductor service nor any per-cell"},{"line_number":58,"context_line":"    conductor service will start if any other conductor service in the"},{"line_number":59,"context_line":"    deployment is older than the previous release."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    Releases older than 2023.1 will only support rolling upgrades for a single"},{"line_number":62,"context_line":"    release difference between :program:`nova-compute` and"}],"source_content_type":"text/x-rst","patch_set":6,"id":"096f45fc_b9e89e31","line":59,"range":{"start_line":59,"start_character":15,"end_line":59,"end_character":50},"in_reply_to":"f966a5aa_7db11df4","updated":"2023-03-02 14:23:22.000000000","message":"Ack","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"}],"nova/objects/service.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"56282b88b7cfed959a1fc6d8e80e15fbbd426983","unresolved":true,"context_lines":[{"line_number":240,"context_line":"# This is used to raise an error at service startup if older than N-1 computes"},{"line_number":241,"context_line":"# are detected. Update this at the end of every release cycle before RC1"},{"line_number":242,"context_line":"# to point to the smallest service version that was added, except if the"},{"line_number":243,"context_line":"# current release is a SLURP one where we need to support N-1."},{"line_number":244,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Zed\u0027"},{"line_number":245,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":246,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"38fbf1ba_dac9b50b","line":243,"updated":"2023-02-23 16:00:59.000000000","message":"I guess we don\u0027t really need to change this as SLURP does not require rolling upgrade support:\n\n```\nRolling Upgrades: This scheme does not necessarily dictate that live or rolling upgrades need to be supported between “SLURP” releases. Meaning RPC compatibility between N to N-1 guarantees can remain, resulting in deployments that are on a “SLURP to SLURP” release schedule requiring some downtime during an upgrade because components will be spanning more than two actual releases.\n```\n\nOr do we want state that in nova we do support rolling upgrade between SLURP A and SLURP C release?","commit_id":"6b62d8cdc9adba0fd05c0c9ac7c99733755e1ddd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fac5f1a9798ffed05339420eaa12cb134c95472e","unresolved":true,"context_lines":[{"line_number":240,"context_line":"# This is used to raise an error at service startup if older than N-1 computes"},{"line_number":241,"context_line":"# are detected. Update this at the end of every release cycle before RC1"},{"line_number":242,"context_line":"# to point to the smallest service version that was added, except if the"},{"line_number":243,"context_line":"# current release is a SLURP one where we need to support N-1."},{"line_number":244,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Zed\u0027"},{"line_number":245,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":246,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a710e608_a73c3ed3","line":243,"in_reply_to":"38fbf1ba_dac9b50b","updated":"2023-02-28 08:31:52.000000000","message":"\u003e I guess we don\u0027t really need to change this as SLURP does not require rolling upgrade support:\n\u003e \n\nIndeed, as you said :\nhttps://governance.openstack.org/tc/resolutions/20220210-release-cadence-adjustment.html\n\nThe TC resolution for SLURP doesn\u0027t ask to the service projects to make sure they can rolling upgrade in between SLURP releases, I agree.\n\n\n\u003e Or do we want state that in nova we do support rolling upgrade between SLURP A and SLURP C release?\n\nThat being said, I think we could at least *try* to not say that the latest supported servion version would be N-1 but rather N-2 for a SLURP release and should be tested using grenade-skip-level jobs.\n\nThat being said, let\u0027s wait to discuss this in the Bobcat PTG. If we disagree at the PTG, I\u0027ll remove this point before Bobcat RC1.","commit_id":"6b62d8cdc9adba0fd05c0c9ac7c99733755e1ddd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"453b72887e50972354d94907121e7f4cc3d039a5","unresolved":false,"context_lines":[{"line_number":240,"context_line":"# This is used to raise an error at service startup if older than N-1 computes"},{"line_number":241,"context_line":"# are detected. Update this at the end of every release cycle before RC1"},{"line_number":242,"context_line":"# to point to the smallest service version that was added, except if the"},{"line_number":243,"context_line":"# current release is a SLURP one where we need to support N-1."},{"line_number":244,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Zed\u0027"},{"line_number":245,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":246,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b778cf7_557494c3","line":243,"in_reply_to":"a710e608_a73c3ed3","updated":"2023-02-28 09:00:35.000000000","message":"As we had the grenade-skip-level job in place during the Antelope cycle, I\u0027m quite inclined to say we have an experimental level of support for Yoga to Antelope. See my further revision.\n\nhttps://zuul.openstack.org/builds?job_name\u003dgrenade-skip-level\u0026project\u003dopenstack%2Fnova\u0026skip\u003d0\n\n(Resolving the comment now)","commit_id":"6b62d8cdc9adba0fd05c0c9ac7c99733755e1ddd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9b984ae832fadb99f67115e109ec92515f3e3155","unresolved":true,"context_lines":[{"line_number":238,"context_line":"NODE_IDENTITY_VERSION \u003d 65"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# This is used to raise an error at service startup if older than N-1 computes"},{"line_number":241,"context_line":"# are detected. Update this at the end of every release cycle before RC1"},{"line_number":242,"context_line":"# to point to the smallest service version that was added."},{"line_number":243,"context_line":"# NOTE(sbauza): It was agreed to have Yoga to 2023.1 upgrade be a"},{"line_number":244,"context_line":"# \u0027dress rehearsal\u0027. We\u0027re accordingly accepting to support N-2 despite our"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0fbc252_88ba7e76","line":241,"range":{"start_line":241,"start_character":35,"end_line":241,"end_character":38},"updated":"2023-02-28 09:00:19.000000000","message":"Why we need to change from the beginning to the end when we refresh our constraints below? Anyhow if you change this you need to also adapt the PTL guide  https://github.com/openstack/nova/blob/master/doc/source/contributor/ptl-guide.rst#immediately-after-rc","commit_id":"393a5b7ca2a798c4219bcf017c82ed89cf63cdd7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ef473ea8ab260f6658ca6c26eada0afa7a9bf45","unresolved":false,"context_lines":[{"line_number":238,"context_line":"NODE_IDENTITY_VERSION \u003d 65"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# This is used to raise an error at service startup if older than N-1 computes"},{"line_number":241,"context_line":"# are detected. Update this at the end of every release cycle before RC1"},{"line_number":242,"context_line":"# to point to the smallest service version that was added."},{"line_number":243,"context_line":"# NOTE(sbauza): It was agreed to have Yoga to 2023.1 upgrade be a"},{"line_number":244,"context_line":"# \u0027dress rehearsal\u0027. We\u0027re accordingly accepting to support N-2 despite our"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2e2f82e_f9b3daa8","line":241,"range":{"start_line":241,"start_character":35,"end_line":241,"end_character":38},"in_reply_to":"126dd429_5ebf7083","updated":"2023-03-02 09:50:56.000000000","message":"Ack","commit_id":"393a5b7ca2a798c4219bcf017c82ed89cf63cdd7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9c30b05cd282228895002707e177624c66453cee","unresolved":true,"context_lines":[{"line_number":238,"context_line":"NODE_IDENTITY_VERSION \u003d 65"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# This is used to raise an error at service startup if older than N-1 computes"},{"line_number":241,"context_line":"# are detected. Update this at the end of every release cycle before RC1"},{"line_number":242,"context_line":"# to point to the smallest service version that was added."},{"line_number":243,"context_line":"# NOTE(sbauza): It was agreed to have Yoga to 2023.1 upgrade be a"},{"line_number":244,"context_line":"# \u0027dress rehearsal\u0027. We\u0027re accordingly accepting to support N-2 despite our"}],"source_content_type":"text/x-python","patch_set":2,"id":"126dd429_5ebf7083","line":241,"range":{"start_line":241,"start_character":35,"end_line":241,"end_character":38},"in_reply_to":"b0fbc252_88ba7e76","updated":"2023-02-28 09:02:53.000000000","message":"Yup, I just created a patch https://review.opendev.org/c/openstack/nova/+/875621/1 and we should indeed amend the PTL doc.","commit_id":"393a5b7ca2a798c4219bcf017c82ed89cf63cdd7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9b984ae832fadb99f67115e109ec92515f3e3155","unresolved":true,"context_lines":[{"line_number":244,"context_line":"# \u0027dress rehearsal\u0027. We\u0027re accordingly accepting to support N-2 despite our"},{"line_number":245,"context_line":"# experimental testing. We\u0027ll mention the level of support operators should"},{"line_number":246,"context_line":"# expect from Yoga to 2023.1 rolling upgrades in the release notes."},{"line_number":247,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":248,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":249,"context_line":"    \u0027Victoria\u0027: 52,"},{"line_number":250,"context_line":"    \u0027Wallaby\u0027: 54,"}],"source_content_type":"text/x-python","patch_set":2,"id":"57d67dc3_248ff602","line":247,"updated":"2023-02-28 09:00:19.000000000","message":"If we keep this here that means Antelope will support not just Zed computes but also Yoga computes. If we want this then this needs more than just a comment change above. This needs at least some signalling to the deployers about the changed in the support pattern. \n\nLooking at the original patch introduced the hard failure[1]. We need at least a release notes stating the new rolling support window.\n\nAlso the current upgrade doc explicitly states no support for N-2 computes[2] so that doc also needs to be aligned.\n\n[1] https://review.opendev.org/c/openstack/nova/+/738482\n[2] https://github.com/openstack/nova/blob/master/doc/source/admin/upgrades.rst#rolling-upgrade-process","commit_id":"393a5b7ca2a798c4219bcf017c82ed89cf63cdd7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9c30b05cd282228895002707e177624c66453cee","unresolved":true,"context_lines":[{"line_number":244,"context_line":"# \u0027dress rehearsal\u0027. We\u0027re accordingly accepting to support N-2 despite our"},{"line_number":245,"context_line":"# experimental testing. We\u0027ll mention the level of support operators should"},{"line_number":246,"context_line":"# expect from Yoga to 2023.1 rolling upgrades in the release notes."},{"line_number":247,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":248,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":249,"context_line":"    \u0027Victoria\u0027: 52,"},{"line_number":250,"context_line":"    \u0027Wallaby\u0027: 54,"}],"source_content_type":"text/x-python","patch_set":2,"id":"84b910e9_af6c3f8a","line":247,"in_reply_to":"57d67dc3_248ff602","updated":"2023-02-28 09:02:53.000000000","message":"I don\u0027t disagree with your documentation and relnotes concerns, I just discovered we properly need to do it in both our prelude and in the doc you pointed out.","commit_id":"393a5b7ca2a798c4219bcf017c82ed89cf63cdd7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ef473ea8ab260f6658ca6c26eada0afa7a9bf45","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# \u0027dress rehearsal\u0027. We\u0027re accordingly accepting to support N-2 despite our"},{"line_number":245,"context_line":"# experimental testing. We\u0027ll mention the level of support operators should"},{"line_number":246,"context_line":"# expect from Yoga to 2023.1 rolling upgrades in the release notes."},{"line_number":247,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":248,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":249,"context_line":"    \u0027Victoria\u0027: 52,"},{"line_number":250,"context_line":"    \u0027Wallaby\u0027: 54,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a35ef560_70b788dc","line":247,"in_reply_to":"84b910e9_af6c3f8a","updated":"2023-03-02 09:50:56.000000000","message":"OK I see the doc change and the prelude change so this comment is handled.","commit_id":"393a5b7ca2a798c4219bcf017c82ed89cf63cdd7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ef473ea8ab260f6658ca6c26eada0afa7a9bf45","unresolved":true,"context_lines":[{"line_number":246,"context_line":"# support operators should expect from Yoga to 2023.1 rolling upgrades in the"},{"line_number":247,"context_line":"# release notes."},{"line_number":248,"context_line":"# At the very beginning of a non-SLURP cycle, we should update the minimum"},{"line_number":249,"context_line":"# version to be N-1 (eg. for Bobcat, only support Antelope computes)."},{"line_number":250,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":251,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":252,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":6,"id":"be5cb919_46a076b3","line":249,"updated":"2023-03-02 09:50:56.000000000","message":"I hope we can generalize this whole comment to be applicable to SLURP and non SLURP releases.\n\n* At the beginning of a non-SLURP release cycle (e.g. Bobcat) we need to bump the OLDEST_SUPPORTED_SERVICE_VERSION to point to the last SLURP release (e.g. Antelope).\n\n* At the beginning of a SLURP release cycle  (e.g. C) we need to keep the OLDEST_SUPPORTED_SERVICE_VERSION as is (e.g. Antelope) to signal that this SLURP release support upgrading from the previous SLURP release. \n\n* At the end of each release (SLURP or non-SLURP) we need to add the release specific service version to SERVICE_VERSION_ALIASES. (In the past I used the smallest release specific version in that list, but I can accept if we switch to the largest release specific version)\n\nDid I missed any rules we need to follow?","commit_id":"835b88585e4792ec66f65f57bdc0cc98bc2c43b1"}]}