)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9d646a683e8938858f98719a29e99273c5f78ac9","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"},{"line_number":19,"context_line":"Change-Id: I789eeae86947e9a3cbd7d5fcc58d2aabe3b8b84c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"45084264_444ceef2","line":18,"updated":"2023-05-29 11:18:23.000000000","message":"this has now merged but im ok with leaving it.","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"},{"line_number":19,"context_line":"Change-Id: I789eeae86947e9a3cbd7d5fcc58d2aabe3b8b84c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ea2fbc45_710e9fe1","line":18,"in_reply_to":"45084264_444ceef2","updated":"2023-06-27 10:27:57.000000000","message":"Ack","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6b8c4334ed83509581dd0a1944232abba5a12d96","unresolved":true,"context_lines":[{"line_number":12,"context_line":"4) Unit and Functional tests were updated"},{"line_number":13,"context_line":"5) Requirments was updated ( os-traits \u003d 3.0.0 )"},{"line_number":14,"context_line":"6) Releasnote was added"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"204ff3a4_10ccf200","line":15,"updated":"2023-11-15 09:15:27.000000000","message":"Do we need any patch to glance about the new image property?","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7eafcf4bffa13abcdd297549224d010c157aa47b","unresolved":true,"context_lines":[{"line_number":12,"context_line":"4) Unit and Functional tests were updated"},{"line_number":13,"context_line":"5) Requirments was updated ( os-traits \u003d 3.0.0 )"},{"line_number":14,"context_line":"6) Releasnote was added"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"2a075a00_b5c50314","line":15,"in_reply_to":"204ff3a4_10ccf200","updated":"2023-11-15 12:06:23.000000000","message":"its stongly encuraged but not required.\n\nin glance we shoudl extend the default metadefs to inculde documentaiton of the image property/extra specs here \n\nhttps://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt.json#L35\n\nand the useful image properties doc shoudl also be extended here \nhttps://github.com/openstack/glance/blob/master/doc/source/admin/useful-image-properties.rst\n\nnetiher of these are required for this to function but are more about documentation\n\nthe metadef will enabel horizon/heat to expose the image property automatically and admisn as well as useser honest shoudl read the Useful image properties doc in glance in general.\n\n\non our side we can refernce the image property when documenting the flaovr extra spec. that documention is currently missign form this patch https://github.com/openstack/nova/blob/master/doc/source/user/flavors.rst","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd03e280476a504318a090f3c16630cc29c5601c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"4) Unit and Functional tests were updated"},{"line_number":13,"context_line":"5) Requirments was updated ( os-traits \u003d 3.0.0 )"},{"line_number":14,"context_line":"6) Releasnote was added"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"f75e5dff_09bf0ce9","line":15,"in_reply_to":"2a075a00_b5c50314","updated":"2023-11-16 12:39:13.000000000","message":"sorry the user flavor guide does nto need to be udated the flavor extraspec is already \n\nhttps://5e2e8f3aeccddec75327-8da05f86af8a44d2353be3e602197c08.ssl.cf1.rackcdn.com/876075/27/check/openstack-tox-docs/8e3d058/docs/configuration/extra-specs.html#hw:virtio_packed_ring\n\ni forgot we generate that doc form the validaorts now and nolonger have to update it manually\n\n\nhttps://review.opendev.org/c/openstack/glance/+/882133 also already covers the glance doc updates","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"4) Unit and Functional tests were updated"},{"line_number":13,"context_line":"5) Requirments was updated ( os-traits \u003d 3.0.0 )"},{"line_number":14,"context_line":"6) Releasnote was added"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"988e2915_9a0475f8","line":15,"in_reply_to":"f75e5dff_09bf0ce9","updated":"2023-11-28 18:40:05.000000000","message":"Done","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffecce0dd1d70e9e420038363441578147324bb1","unresolved":true,"context_lines":[{"line_number":13,"context_line":"5) Requirments was updated ( os-traits \u003d 3.0.0 )"},{"line_number":14,"context_line":"6) Releasnote was added"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"},{"line_number":19,"context_line":"Change-Id: I789eeae86947e9a3cbd7d5fcc58d2aabe3b8b84c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"fa191fd5_8f282b8d","line":16,"updated":"2023-11-29 18:33:24.000000000","message":"ah the spec is not merged so cool we can proceed with this.","commit_id":"eb8519d811f1c08bc964146f484367c858b8f0c2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffecce0dd1d70e9e420038363441578147324bb1","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Nova spec: https://review.opendev.org/c/openstack/nova-specs/+/868377"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/os-traits/+/876069"},{"line_number":19,"context_line":"Change-Id: I789eeae86947e9a3cbd7d5fcc58d2aabe3b8b84c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"02f726d7_a046f31a","line":19,"updated":"2023-11-29 18:33:24.000000000","message":"also already merged so there are no unmet deps\nthis merged last cycle so its already released.","commit_id":"eb8519d811f1c08bc964146f484367c858b8f0c2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"fe45db760d9a1a7db6d0ead5863f66240045d6f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b210a1f1_871265d6","updated":"2023-03-07 13:35:52.000000000","message":"recheck","commit_id":"54aecda89440771999cabac4f6257f92a7bf203b"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"879da7c081b572d195dbe82de92c6d7724ac0f8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7ef26de_a3416a54","updated":"2023-03-09 10:52:35.000000000","message":"recheck","commit_id":"60935003f266035d8b3a1fd22039c1c513c6f6a5"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"ae4f0c298d59a60d07429339a14cacf8b14b03dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45881c60_feea8840","updated":"2023-05-12 08:25:21.000000000","message":"recheck","commit_id":"0cca2ab685a9f081d8ff98b61fd25a66fb810042"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c531066b090d071fc339b5e55a24c9c7e8808f09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6eceeccf_d1f25f81","updated":"2023-05-15 11:30:28.000000000","message":"over all this look ok but im not actully seing any unit/functional test coverage for usign the packed queueu format.\n\nthis change should have at lesat one test for both image and flavor that show that if you enable the packed queue format the relevent xml section is generated.\ni woudl also like to see a test of setting the image and flavor to conflicting values and asserting the exception is raised.","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"d7521ca6edada1b050e2b46cd111339258bc2e94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dd50738d_aef05b1d","updated":"2023-05-12 18:46:41.000000000","message":"recheck","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"086921b49e68610bab3dc61d145faf3df0ec637d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cd7caeb3_0b82debf","updated":"2023-05-15 11:31:25.000000000","message":"you should also add a release note and perhaps some docs for this too.","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"fc283f237e65afe2caadc7c3251b04c21df4aed5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3dfc0322_df99bcc8","updated":"2023-06-22 13:20:21.000000000","message":"Looks good to me, maybe a small typo in a test.","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"c0d5189f1f16acff38865ea527c82a9577400c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0e5c9342_2de5bb61","updated":"2023-05-31 12:19:18.000000000","message":"recheck","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"ff10a158745952b14ddd8667d2f4c69129f4ae85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5ffbe9e8_4fe94f0f","updated":"2023-06-01 10:01:41.000000000","message":"recheck","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"0b54454abf4c6321c6ae468349871e69a11beac3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"959e7d34_96c56cc7","updated":"2023-05-31 17:25:47.000000000","message":"recheck","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"14bb71724398f126e1e773bd79c59e24049e7af8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"aeb08642_b370b68d","updated":"2023-06-04 19:30:17.000000000","message":"recheck","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"f4695c0856b57471d0bea4ef762bc810f385dcd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bf94496a_f5929589","updated":"2023-05-31 08:05:15.000000000","message":"recheck","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"9e6b60437f5846ead3c384d1540e24acefba6966","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e4613fd4_ecfecb21","updated":"2023-06-01 18:41:30.000000000","message":"recheck","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"068e9ffe_ce7cc0fe","updated":"2023-06-27 10:27:57.000000000","message":"+1 since most of my previous comments have been adress but holding +2 since im concerned about resize/rebuild see comment inline\n\ncan we add some fucntional tests to test that.\nonce that is done i think this could be merged","commit_id":"cc91f6636cb632c7524c58f4c19704ef94c0a7a0"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"f23932199ed84644582bfbdab079d822a19d1a8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a4b8e56b_154b5c3f","updated":"2023-06-27 07:01:03.000000000","message":"recheck","commit_id":"cc91f6636cb632c7524c58f4c19704ef94c0a7a0"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"c79819503bfd0eafd7e5865a165d2a2010adff1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fa8c23cb_346ea28b","updated":"2023-06-27 10:28:44.000000000","message":"recheck","commit_id":"cc91f6636cb632c7524c58f4c19704ef94c0a7a0"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"5e6cef17b284aa19446d3f460e47fe56ca9e7e0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2efbcca4_2665c2d7","updated":"2023-07-05 14:24:28.000000000","message":"recheck","commit_id":"345258a4aa784bb05eb04fa09c5c0ad8fb6ef153"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87bd0d935ec0ca27c7f3d430c8460bc79ec02e8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"449c6997_feef7db2","updated":"2023-07-05 17:25:48.000000000","message":"setting review priority since i think this is more or less ready but i do not have time to review today.","commit_id":"345258a4aa784bb05eb04fa09c5c0ad8fb6ef153"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"9e0a4d9fc7a8878e58b574c5998db28bd4378134","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"17020568_8f77a164","updated":"2023-07-11 12:37:14.000000000","message":"recheck","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"5c040c249861465bf2e68e2f803fee8cf3cd03f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"53d0f3b7_6a68d319","updated":"2023-07-13 07:49:28.000000000","message":"recheck","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"eed08319844dd25c32a08c5aac728c449f5cca48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"6e9ec1a3_774e70d7","updated":"2023-07-07 12:43:04.000000000","message":"recheck","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"1d7f9e66c7e6c25e17af382d825f806fd68280e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"bc4062c2_bf29c279","updated":"2023-07-12 12:23:53.000000000","message":"recheck","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"89ba257e44e727b8f33064b4703d6ad7c60e9498","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f8968fd2_5cafe7a6","updated":"2023-07-10 07:57:24.000000000","message":"recheck","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"bbcf3230915d5d150dd38e77dbea40f48fe1dc9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"57478b80_29f15a26","updated":"2023-08-01 06:51:08.000000000","message":"recheck","commit_id":"14bbd16555757b774869a1fb58a14a974bb04fc5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"07aab11e_7842a846","updated":"2023-08-02 13:59:16.000000000","message":"I didn\u0027t get into a deep dive of the actual functionality here, but found enough things to warrant a respin before I do.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"cb45ef65827c0279d2c62e60c06b0c523f093d38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c7466f31_3005c681","updated":"2023-08-01 12:53:06.000000000","message":"Lgtm. Thanks for your efforts.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"f0db81cf24ede8b02c28ae79b21eb623bcfc0b35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"594c3296_de705e39","updated":"2023-08-03 08:41:34.000000000","message":"recheck","commit_id":"5bf3de375172782333433ce6ff03592310b27e30"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"b66571ce_42b3e64c","updated":"2023-09-20 11:59:51.000000000","message":"-1 since the spec needs to be reappeoved.\n\ni did a quick pass over this and have resovled the resovled comemnts\n\ni will try to do a full review this week when i have more time","commit_id":"af44e654e294940a85fff54b4223ddca4e40c4b7"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"817c90212f1681a384a1ba3d37fa1b0ae846651c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ae3d472f_26e0da7b","updated":"2023-11-13 16:30:29.000000000","message":"recheck","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"c58e45b4_e6a4dfe7","updated":"2023-11-28 18:40:05.000000000","message":"much closer\nsome of gibis comments have been adressed and most of this looks correct but there are still some issues inline","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1ba358f6facdaad4507aeca79c9b1d2c9304474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"176f697a_d8d07f7b","updated":"2023-11-29 18:37:17.000000000","message":"just cleaned up some of the unresolve comments","commit_id":"eb8519d811f1c08bc964146f484367c858b8f0c2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bebda984a1fc89bc1024a95bf6dc9d0504453934","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"3a66b23e_03786106","updated":"2023-11-30 09:43:17.000000000","message":"my comments were fixed. Looks good to me","commit_id":"eb8519d811f1c08bc964146f484367c858b8f0c2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"554468e468523fe090d815c4c6264b9dc70362f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"f4709906_59c8c5a8","updated":"2023-11-30 09:59:26.000000000","message":"the remaining test refactor comment from Dan can be handled in a follow up","commit_id":"eb8519d811f1c08bc964146f484367c858b8f0c2"}],"nova/api/validation/extra_specs/hw.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":true,"context_lines":[{"line_number":530,"context_line":"    base.ExtraSpecValidator("},{"line_number":531,"context_line":"        name\u003d\u0027hw:virtio_packed_ring\u0027,"},{"line_number":532,"context_line":"        description\u003d("},{"line_number":533,"context_line":"            \u0027Whether to enable the packed virtqueue feature. \u0027"},{"line_number":534,"context_line":"            \u0027This requires guest support and is only supported by \u0027"},{"line_number":535,"context_line":"            \u0027the libvirt driver.\u0027"},{"line_number":536,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":14,"id":"492ab435_c4a246d0","line":533,"range":{"start_line":533,"start_character":13,"end_line":533,"end_character":59},"updated":"2023-06-27 10:27:57.000000000","message":"nit:  i think it would read better as \"Permit guests to negotiate the virtio packed ring format.\"\n\nsince that does not imply it will actually be used.","commit_id":"cc91f6636cb632c7524c58f4c19704ef94c0a7a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb687af393c9d6b82538fe72424ee73de1739b3f","unresolved":false,"context_lines":[{"line_number":530,"context_line":"    base.ExtraSpecValidator("},{"line_number":531,"context_line":"        name\u003d\u0027hw:virtio_packed_ring\u0027,"},{"line_number":532,"context_line":"        description\u003d("},{"line_number":533,"context_line":"            \u0027Whether to enable the packed virtqueue feature. \u0027"},{"line_number":534,"context_line":"            \u0027This requires guest support and is only supported by \u0027"},{"line_number":535,"context_line":"            \u0027the libvirt driver.\u0027"},{"line_number":536,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":14,"id":"b9c62995_32b71b7c","line":533,"range":{"start_line":533,"start_character":13,"end_line":533,"end_character":59},"in_reply_to":"492ab435_c4a246d0","updated":"2023-07-25 09:47:09.000000000","message":"Done","commit_id":"cc91f6636cb632c7524c58f4c19704ef94c0a7a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f076af57f81c3c40bc38dae69dc26e8aa5cfbf2","unresolved":true,"context_lines":[{"line_number":527,"context_line":"            \u0027description\u0027: \u0027model for vIOMMU\u0027,"},{"line_number":528,"context_line":"        },"},{"line_number":529,"context_line":"    ),"},{"line_number":530,"context_line":"    base.ExtraSpecValidator("},{"line_number":531,"context_line":"        name\u003d\u0027hw:virtio_packed_ring\u0027,"},{"line_number":532,"context_line":"        description\u003d("},{"line_number":533,"context_line":"            \u0027Permit guests to negotiate the virtio packed ring format. \u0027"},{"line_number":534,"context_line":"            \u0027This requires guest support and is only supported by \u0027"},{"line_number":535,"context_line":"            \u0027the libvirt driver.\u0027"},{"line_number":536,"context_line":"        ),"},{"line_number":537,"context_line":"        value\u003d{"},{"line_number":538,"context_line":"            \u0027type\u0027: bool,"},{"line_number":539,"context_line":"            \u0027description\u0027: \u0027Whether to enable packed virtqueue\u0027,"},{"line_number":540,"context_line":"        },"},{"line_number":541,"context_line":"    ),"},{"line_number":542,"context_line":"]"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bddd82e9_7b5b6d9b","line":540,"range":{"start_line":530,"start_character":1,"end_line":540,"end_character":10},"updated":"2023-11-15 12:07:45.000000000","message":"the same info you have here is bascially what you need to add to the flavor extra spec docs and also to the glace metadefs and useful image properties doc.","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":false,"context_lines":[{"line_number":527,"context_line":"            \u0027description\u0027: \u0027model for vIOMMU\u0027,"},{"line_number":528,"context_line":"        },"},{"line_number":529,"context_line":"    ),"},{"line_number":530,"context_line":"    base.ExtraSpecValidator("},{"line_number":531,"context_line":"        name\u003d\u0027hw:virtio_packed_ring\u0027,"},{"line_number":532,"context_line":"        description\u003d("},{"line_number":533,"context_line":"            \u0027Permit guests to negotiate the virtio packed ring format. \u0027"},{"line_number":534,"context_line":"            \u0027This requires guest support and is only supported by \u0027"},{"line_number":535,"context_line":"            \u0027the libvirt driver.\u0027"},{"line_number":536,"context_line":"        ),"},{"line_number":537,"context_line":"        value\u003d{"},{"line_number":538,"context_line":"            \u0027type\u0027: bool,"},{"line_number":539,"context_line":"            \u0027description\u0027: \u0027Whether to enable packed virtqueue\u0027,"},{"line_number":540,"context_line":"        },"},{"line_number":541,"context_line":"    ),"},{"line_number":542,"context_line":"]"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"0fa2cefb_32e3d2c5","line":540,"range":{"start_line":530,"start_character":1,"end_line":540,"end_character":10},"in_reply_to":"bddd82e9_7b5b6d9b","updated":"2023-11-28 18:40:05.000000000","message":"the doc i was refering too is actully auto generated form this file so this info is already there :)","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"}],"nova/compute/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":752,"context_line":"            raise exception.FlavorMemoryTooSmall()"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        # Only validate values of flavor/image so the return results of"},{"line_number":755,"context_line":"        # following \u0027get\u0027 functions are not used."},{"line_number":756,"context_line":"        hardware.get_packed_virtqueue_constraint(flavor, image)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Image min_disk is in gb, size is in bytes. For sanity, have them both"}],"source_content_type":"text/x-python","patch_set":20,"id":"300cca09_736099ed","line":755,"updated":"2023-08-02 13:59:16.000000000","message":"This comment doesn\u0027t make sense to me. Can you add some more explanation of what is going on? It sounds from the text that you\u0027re *not* validating something, but you\u0027re clearly adding something here.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            raise exception.FlavorMemoryTooSmall()"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        # Only validate values of flavor/image so the return results of"},{"line_number":755,"context_line":"        # following \u0027get\u0027 functions are not used."},{"line_number":756,"context_line":"        hardware.get_packed_virtqueue_constraint(flavor, image)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # Image min_disk is in gb, size is in bytes. For sanity, have them both"}],"source_content_type":"text/x-python","patch_set":20,"id":"cb00e5bb_2707ec43","line":755,"in_reply_to":"300cca09_736099ed","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"}],"nova/scheduler/request_filter.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c531066b090d071fc339b5e55a24c9c7e8808f09","unresolved":true,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"@trace_request_filter"},{"line_number":277,"context_line":"def packed_virtqueue_filter(ctxt, request_spec):"},{"line_number":278,"context_line":"    \"\"\"Allow only compute nodes with Packed virtqueue."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    This filter retains only nodes whose compute manager published the"}],"source_content_type":"text/x-python","patch_set":6,"id":"caee84ed_83f72d5a","line":277,"updated":"2023-05-15 11:30:28.000000000","message":"+1 i think this is fine to run unconditionally.","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"@trace_request_filter"},{"line_number":277,"context_line":"def packed_virtqueue_filter(ctxt, request_spec):"},{"line_number":278,"context_line":"    \"\"\"Allow only compute nodes with Packed virtqueue."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    This filter retains only nodes whose compute manager published the"}],"source_content_type":"text/x-python","patch_set":6,"id":"e1faac8c_dc52befe","line":277,"in_reply_to":"caee84ed_83f72d5a","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c531066b090d071fc339b5e55a24c9c7e8808f09","unresolved":true,"context_lines":[{"line_number":454,"context_line":"    isolate_aggregates,"},{"line_number":455,"context_line":"    transform_image_metadata,"},{"line_number":456,"context_line":"    accelerators_filter,"},{"line_number":457,"context_line":"    packed_virtqueue_filter,"},{"line_number":458,"context_line":"    routed_networks_filter,"},{"line_number":459,"context_line":"    remote_managed_ports_filter,"},{"line_number":460,"context_line":"    ephemeral_encryption_filter,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff3d6b33_ce7e8e47","line":457,"updated":"2023-05-15 11:30:28.000000000","message":"nit: we normally just add new filters to the end but in this case its fine either way.","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    isolate_aggregates,"},{"line_number":455,"context_line":"    transform_image_metadata,"},{"line_number":456,"context_line":"    accelerators_filter,"},{"line_number":457,"context_line":"    packed_virtqueue_filter,"},{"line_number":458,"context_line":"    routed_networks_filter,"},{"line_number":459,"context_line":"    remote_managed_ports_filter,"},{"line_number":460,"context_line":"    ephemeral_encryption_filter,"}],"source_content_type":"text/x-python","patch_set":6,"id":"47aa5128_b5dbef86","line":457,"in_reply_to":"ff3d6b33_ce7e8e47","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"237d77adbee2ba55ca4e1768c590efdabb614c2f","unresolved":true,"context_lines":[{"line_number":281,"context_line":"    COMPUTE_NET_VIRTIO_PACKED trait, thus indicates virtqueue packed feature."},{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    trait_name \u003d os_traits.COMPUTE_NET_VIRTIO_PACKED"},{"line_number":284,"context_line":"    if (request_spec.flavor.extra_specs.get(\u0027hw:virtio_packed_ring\u0027) or"},{"line_number":285,"context_line":"        request_spec.image.properties.get(\u0027hw_virtio_packed_ring\u0027)):"},{"line_number":286,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":287,"context_line":"        LOG.debug(\u0027virtqueue_filter request filter added required \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"da348876_4f45ab72","line":284,"range":{"start_line":284,"start_character":8,"end_line":284,"end_character":68},"updated":"2023-06-22 17:38:41.000000000","message":"this is wrong\n\nyou need to convert the flavor extra spec form a srtring too a bool\nusing oslo.utils something like this.\n\n\n\nfrom oslo.utils import strutils\n\nflavor_requsted \u003d strutils.bool_from_string(request_spec.flavor.extra_specs.get(\u0027hw:virtio_packed_ring\u0027, \u0027False\u0027))\nimage_requested \u003d request_spec.image.properties.get(\u0027hw_virtio_packed_ring\u0027)\n\nif (flavor_requsted or image_requested):\n   ...\n   \n   \nwith that said it would be better to reuse the get_packed_virtqueue_constraint function you added in hardware.py.","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    COMPUTE_NET_VIRTIO_PACKED trait, thus indicates virtqueue packed feature."},{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    trait_name \u003d os_traits.COMPUTE_NET_VIRTIO_PACKED"},{"line_number":284,"context_line":"    if (request_spec.flavor.extra_specs.get(\u0027hw:virtio_packed_ring\u0027) or"},{"line_number":285,"context_line":"        request_spec.image.properties.get(\u0027hw_virtio_packed_ring\u0027)):"},{"line_number":286,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":287,"context_line":"        LOG.debug(\u0027virtqueue_filter request filter added required \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"2d99785e_97c8f88c","line":284,"range":{"start_line":284,"start_character":8,"end_line":284,"end_character":68},"in_reply_to":"da348876_4f45ab72","updated":"2023-06-27 10:27:57.000000000","message":"Done","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":true,"context_lines":[{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    trait_name \u003d os_traits.COMPUTE_NET_VIRTIO_PACKED"},{"line_number":284,"context_line":"    if(hardware.get_packed_virtqueue_constraint(request_spec.flavor,"},{"line_number":285,"context_line":"                                                request_spec.image)):"},{"line_number":286,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":287,"context_line":"        LOG.debug(\u0027virtqueue_filter request filter added required \u0027"},{"line_number":288,"context_line":"                  \u0027trait %s\u0027, trait_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"aa4a9d60_27c13d25","line":285,"updated":"2023-06-27 10:27:57.000000000","message":"it would be good to add a note here if you respine.\n\nhardware.get_packed_virtqueue_constraint can raise an excpetion however\nif we get this far it should not as the compatibalty shoudl have alredy been check in the api.\n\nwith that said we could also catfch the excption and return false isntead for extra safty.\n\nthe edge case im conserned about is resize and rebuild.\n\ncan you add a functional test that boots a vm with the packed format requested in the image and try resizing it to a flavor with it set to false.\n\nand simialrly request it in the flavor and rebuild the vm to an image with it set to false.","commit_id":"cc91f6636cb632c7524c58f4c19704ef94c0a7a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1ba358f6facdaad4507aeca79c9b1d2c9304474","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    trait_name \u003d os_traits.COMPUTE_NET_VIRTIO_PACKED"},{"line_number":284,"context_line":"    if(hardware.get_packed_virtqueue_constraint(request_spec.flavor,"},{"line_number":285,"context_line":"                                                request_spec.image)):"},{"line_number":286,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":287,"context_line":"        LOG.debug(\u0027virtqueue_filter request filter added required \u0027"},{"line_number":288,"context_line":"                  \u0027trait %s\u0027, trait_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"eda2d8b3_ccacbda3","line":285,"in_reply_to":"aa4a9d60_27c13d25","updated":"2023-11-29 18:37:17.000000000","message":"Acknowledged","commit_id":"cc91f6636cb632c7524c58f4c19704ef94c0a7a0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":281,"context_line":"    COMPUTE_NET_VIRTIO_PACKED trait, thus indicates virtqueue packed feature."},{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    trait_name \u003d os_traits.COMPUTE_NET_VIRTIO_PACKED"},{"line_number":284,"context_line":"    if(hardware.get_packed_virtqueue_constraint(request_spec.flavor,"},{"line_number":285,"context_line":"                                                request_spec.image)):"},{"line_number":286,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":287,"context_line":"        LOG.debug(\u0027virtqueue_filter request filter added required \u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"23218f21_be0435d7","line":284,"updated":"2023-08-02 13:59:16.000000000","message":"There should be a space after your `if` keyword.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    COMPUTE_NET_VIRTIO_PACKED trait, thus indicates virtqueue packed feature."},{"line_number":282,"context_line":"    \"\"\""},{"line_number":283,"context_line":"    trait_name \u003d os_traits.COMPUTE_NET_VIRTIO_PACKED"},{"line_number":284,"context_line":"    if(hardware.get_packed_virtqueue_constraint(request_spec.flavor,"},{"line_number":285,"context_line":"                                                request_spec.image)):"},{"line_number":286,"context_line":"        request_spec.root_required.add(trait_name)"},{"line_number":287,"context_line":"        LOG.debug(\u0027virtqueue_filter request filter added required \u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"2981a163_94f28082","line":284,"in_reply_to":"23218f21_be0435d7","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb687af393c9d6b82538fe72424ee73de1739b3f","unresolved":true,"context_lines":[{"line_number":2215,"context_line":"        # By returning 400, We want to confirm that the RESIZE server"},{"line_number":2216,"context_line":"        # does not cause unexpected behavior."},{"line_number":2217,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":2218,"context_line":""},{"line_number":2219,"context_line":"        # Cleanup"},{"line_number":2220,"context_line":"        self._delete_server(found_server)"},{"line_number":2221,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5cc2ce76_65fd70a1","line":2218,"updated":"2023-07-25 09:47:09.000000000","message":"if you respin i would add one more assert to asset tht the instance is still in teh Active state.","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6db5ac463ed75f57b60010c73f1fb89a04a6563c","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"        # By returning 400, We want to confirm that the RESIZE server"},{"line_number":2216,"context_line":"        # does not cause unexpected behavior."},{"line_number":2217,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":2218,"context_line":""},{"line_number":2219,"context_line":"        # Cleanup"},{"line_number":2220,"context_line":"        self._delete_server(found_server)"},{"line_number":2221,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"a8ae4864_b1a3ebd0","line":2218,"in_reply_to":"5cc2ce76_65fd70a1","updated":"2023-09-20 12:02:08.000000000","message":"Done","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb687af393c9d6b82538fe72424ee73de1739b3f","unresolved":true,"context_lines":[{"line_number":2250,"context_line":"        # By returning 400, We want to confirm that the RESIZE server"},{"line_number":2251,"context_line":"        # does not cause unexpected behavior."},{"line_number":2252,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":2253,"context_line":""},{"line_number":2254,"context_line":"        # Cleanup"},{"line_number":2255,"context_line":"        self._delete_server(found_server)"},{"line_number":2256,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"cc94ded8_4b577e1a","line":2253,"updated":"2023-07-25 09:47:09.000000000","message":"same as above\nthe instance shoudl still be in the active state since it was rejected by the api check.","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6db5ac463ed75f57b60010c73f1fb89a04a6563c","unresolved":false,"context_lines":[{"line_number":2250,"context_line":"        # By returning 400, We want to confirm that the RESIZE server"},{"line_number":2251,"context_line":"        # does not cause unexpected behavior."},{"line_number":2252,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":2253,"context_line":""},{"line_number":2254,"context_line":"        # Cleanup"},{"line_number":2255,"context_line":"        self._delete_server(found_server)"},{"line_number":2256,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"6972badd_c264bf69","line":2253,"in_reply_to":"cc94ded8_4b577e1a","updated":"2023-09-20 12:02:08.000000000","message":"Done","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":2194,"context_line":"        rp_uuid1 \u003d self._get_provider_uuid_by_host(self.compute1.host)"},{"line_number":2195,"context_line":"        self._set_provider_traits(rp_uuid1, [\u0027COMPUTE_NET_VIRTIO_PACKED\u0027])"},{"line_number":2196,"context_line":""},{"line_number":2197,"context_line":"        # Avoid migration"},{"line_number":2198,"context_line":"        self.flags(allow_resize_to_same_host\u003dTrue)"},{"line_number":2199,"context_line":""},{"line_number":2200,"context_line":"        # Create image"}],"source_content_type":"text/x-python","patch_set":28,"id":"7167cac9_df73f1bb","line":2197,"updated":"2023-11-28 18:40:05.000000000","message":"it does not actually avoid migration it just allows the same host to be used.\nthere is no preference given for the same host.\nif the logic will depend on using the same hsot we need to disable the other host to ensure that.\n\n\nlooking at the logic below there is no hard dependency on selecting the same host in this case so this should be ok as is.","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80a34b67e4620e611e02f5d59ef7f5eb07937b7c","unresolved":false,"context_lines":[{"line_number":2194,"context_line":"        rp_uuid1 \u003d self._get_provider_uuid_by_host(self.compute1.host)"},{"line_number":2195,"context_line":"        self._set_provider_traits(rp_uuid1, [\u0027COMPUTE_NET_VIRTIO_PACKED\u0027])"},{"line_number":2196,"context_line":""},{"line_number":2197,"context_line":"        # Avoid migration"},{"line_number":2198,"context_line":"        self.flags(allow_resize_to_same_host\u003dTrue)"},{"line_number":2199,"context_line":""},{"line_number":2200,"context_line":"        # Create image"}],"source_content_type":"text/x-python","patch_set":28,"id":"f2b85e26_e4378a53","line":2197,"in_reply_to":"7167cac9_df73f1bb","updated":"2023-11-29 18:29:40.000000000","message":"Done","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":2233,"context_line":"        rp_uuid1 \u003d self._get_provider_uuid_by_host(self.compute1.host)"},{"line_number":2234,"context_line":"        self._set_provider_traits(rp_uuid1, [\u0027COMPUTE_NET_VIRTIO_PACKED\u0027])"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"        # Avoid migration"},{"line_number":2237,"context_line":"        self.flags(allow_resize_to_same_host\u003dTrue)"},{"line_number":2238,"context_line":""},{"line_number":2239,"context_line":"        # Create flavor"}],"source_content_type":"text/x-python","patch_set":28,"id":"5c1a9214_d0105991","line":2236,"updated":"2023-11-28 18:40:05.000000000","message":"same comment as above\nalthough in this case you are doing rebuild and rebuild never chagne host so this is not relevent to this test case.","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80a34b67e4620e611e02f5d59ef7f5eb07937b7c","unresolved":false,"context_lines":[{"line_number":2233,"context_line":"        rp_uuid1 \u003d self._get_provider_uuid_by_host(self.compute1.host)"},{"line_number":2234,"context_line":"        self._set_provider_traits(rp_uuid1, [\u0027COMPUTE_NET_VIRTIO_PACKED\u0027])"},{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"        # Avoid migration"},{"line_number":2237,"context_line":"        self.flags(allow_resize_to_same_host\u003dTrue)"},{"line_number":2238,"context_line":""},{"line_number":2239,"context_line":"        # Create flavor"}],"source_content_type":"text/x-python","patch_set":28,"id":"eea8bb90_10e1526f","line":2236,"in_reply_to":"5c1a9214_d0105991","updated":"2023-11-29 18:29:40.000000000","message":"Done","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":386,"context_line":"    # ImageMetaProps, so when you see a fail here for that reason, you must"},{"line_number":387,"context_line":"    # *also* bump the version of ImageMetaPropsPayload. See its docstring for"},{"line_number":388,"context_line":"    # more information."},{"line_number":389,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.12-24345c28a6463e85e12902d43af0ecf2\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":391,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":392,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ca2069e7_c83dd78c","line":389,"updated":"2023-08-02 13:59:16.000000000","message":"This is telling you that you need a version bump. That\u0027s why the hash changed - not just to make you update the hash. See the comment above.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6f70ad1ed32db50df30d405119199a4557c6817","unresolved":true,"context_lines":[{"line_number":386,"context_line":"    # ImageMetaProps, so when you see a fail here for that reason, you must"},{"line_number":387,"context_line":"    # *also* bump the version of ImageMetaPropsPayload. See its docstring for"},{"line_number":388,"context_line":"    # more information."},{"line_number":389,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.12-24345c28a6463e85e12902d43af0ecf2\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":391,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":392,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"9b1ecbb1_f6755f77","line":389,"in_reply_to":"6596567a_5df34798","updated":"2023-08-02 15:42:05.000000000","message":"for context the notifcation object fields are generated form the nova object field\n\nSCHEMA \u003d {\n        k: (\u0027image_meta_props\u0027, k) for k in image_meta.ImageMetaProps.fields}\n\nhttps://github.com/openstack/nova/blob/master/nova/notifications/objects/image.py#L133-L136\n\nso when ever you bump the main object it also requries the notficaiton object to be updated unless that filed is intentionally omitted form the notifcationobject.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"d122cdd14655449376c860367105622fb758415b","unresolved":true,"context_lines":[{"line_number":386,"context_line":"    # ImageMetaProps, so when you see a fail here for that reason, you must"},{"line_number":387,"context_line":"    # *also* bump the version of ImageMetaPropsPayload. See its docstring for"},{"line_number":388,"context_line":"    # more information."},{"line_number":389,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.12-24345c28a6463e85e12902d43af0ecf2\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":391,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":392,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"fd46eb0e_fe84bfff","line":389,"in_reply_to":"9b1ecbb1_f6755f77","updated":"2023-08-02 19:26:26.000000000","message":"yeah, I already start to fix all comments from Dan.\nAlso, I found that I should update this file\nnova/doc/notification_samples/common_payloads/ImageMetaPropsPayload.json","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ec1623ebaa9cc62e0a50257f582f7c490ec3f962","unresolved":true,"context_lines":[{"line_number":386,"context_line":"    # ImageMetaProps, so when you see a fail here for that reason, you must"},{"line_number":387,"context_line":"    # *also* bump the version of ImageMetaPropsPayload. See its docstring for"},{"line_number":388,"context_line":"    # more information."},{"line_number":389,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.12-24345c28a6463e85e12902d43af0ecf2\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":391,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":392,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"6596567a_5df34798","line":389,"in_reply_to":"ca2069e7_c83dd78c","updated":"2023-08-02 15:36:32.000000000","message":"oh good catch i tough they had already incremented it but no they just update the hash.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    # ImageMetaProps, so when you see a fail here for that reason, you must"},{"line_number":387,"context_line":"    # *also* bump the version of ImageMetaPropsPayload. See its docstring for"},{"line_number":388,"context_line":"    # more information."},{"line_number":389,"context_line":"    \u0027ImageMetaPropsPayload\u0027: \u00271.12-24345c28a6463e85e12902d43af0ecf2\u0027,"},{"line_number":390,"context_line":"    \u0027InstanceActionNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":391,"context_line":"    \u0027InstanceActionPayload\u0027: \u00271.8-4fa3da9cbf0761f1f700ae578f36dc2f\u0027,"},{"line_number":392,"context_line":"    \u0027InstanceActionRebuildNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"582b82b9_4c31954d","line":389,"in_reply_to":"fd46eb0e_fe84bfff","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":1073,"context_line":"    \u0027IDEDeviceBus\u0027: \u00271.0-29d4c9f27ac44197f01b6ac1b7e16502\u0027,"},{"line_number":1074,"context_line":"    \u0027ImageMeta\u0027: \u00271.8-642d1b2eb3e880a367f37d72dd76162d\u0027,"},{"line_number":1075,"context_line":"    \u0027Instance\u0027: \u00272.8-2727dba5e4a078e6cc848c1f94f7eb24\u0027,"},{"line_number":1076,"context_line":"    \u0027ImageMetaProps\u0027: \u00271.35-66ec4135a4c08d6e67e39cb0400b059e\u0027,"},{"line_number":1077,"context_line":"    \u0027InstanceAction\u0027: \u00271.2-9a5abc87fdd3af46f45731960651efb5\u0027,"},{"line_number":1078,"context_line":"    \u0027InstanceActionEvent\u0027: \u00271.4-5b1f361bd81989f8bb2c20bb7e8a4cb4\u0027,"},{"line_number":1079,"context_line":"    \u0027InstanceActionEventList\u0027: \u00271.1-13d92fb953030cdbfee56481756e02be\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"88951b65_55e11a31","line":1076,"updated":"2023-08-02 13:59:16.000000000","message":"Please don\u0027t break the sort order and move this back where it belongs.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"    \u0027IDEDeviceBus\u0027: \u00271.0-29d4c9f27ac44197f01b6ac1b7e16502\u0027,"},{"line_number":1074,"context_line":"    \u0027ImageMeta\u0027: \u00271.8-642d1b2eb3e880a367f37d72dd76162d\u0027,"},{"line_number":1075,"context_line":"    \u0027Instance\u0027: \u00272.8-2727dba5e4a078e6cc848c1f94f7eb24\u0027,"},{"line_number":1076,"context_line":"    \u0027ImageMetaProps\u0027: \u00271.35-66ec4135a4c08d6e67e39cb0400b059e\u0027,"},{"line_number":1077,"context_line":"    \u0027InstanceAction\u0027: \u00271.2-9a5abc87fdd3af46f45731960651efb5\u0027,"},{"line_number":1078,"context_line":"    \u0027InstanceActionEvent\u0027: \u00271.4-5b1f361bd81989f8bb2c20bb7e8a4cb4\u0027,"},{"line_number":1079,"context_line":"    \u0027InstanceActionEventList\u0027: \u00271.1-13d92fb953030cdbfee56481756e02be\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"60638e19_4aa38b4d","line":1076,"in_reply_to":"88951b65_55e11a31","updated":"2023-11-28 18:40:05.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":true,"context_lines":[{"line_number":1104,"context_line":"    \u0027IDEDeviceBus\u0027: \u00271.0-29d4c9f27ac44197f01b6ac1b7e16502\u0027,"},{"line_number":1105,"context_line":"    \u0027ImageMeta\u0027: \u00271.8-642d1b2eb3e880a367f37d72dd76162d\u0027,"},{"line_number":1106,"context_line":"    \u0027ImageMetaProps\u0027: \u00271.35-66ec4135a4c08d6e67e39cb0400b059e\u0027,"},{"line_number":1107,"context_line":"    \u0027Instance\u0027: \u00272.8-2727dba5e4a078e6cc848c1f94f7eb24\u0027,"},{"line_number":1108,"context_line":"    \u0027InstanceAction\u0027: \u00271.2-9a5abc87fdd3af46f45731960651efb5\u0027,"},{"line_number":1109,"context_line":"    \u0027InstanceActionEvent\u0027: \u00271.4-5b1f361bd81989f8bb2c20bb7e8a4cb4\u0027,"},{"line_number":1110,"context_line":"    \u0027InstanceActionEventList\u0027: \u00271.1-13d92fb953030cdbfee56481756e02be\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f17f9d3_4f0663ce","line":1107,"updated":"2023-09-20 11:59:51.000000000","message":"nit: it would be preferabel to not reorder this\nit avoid merge conflcits","commit_id":"af44e654e294940a85fff54b4223ddca4e40c4b7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"    \u0027IDEDeviceBus\u0027: \u00271.0-29d4c9f27ac44197f01b6ac1b7e16502\u0027,"},{"line_number":1105,"context_line":"    \u0027ImageMeta\u0027: \u00271.8-642d1b2eb3e880a367f37d72dd76162d\u0027,"},{"line_number":1106,"context_line":"    \u0027ImageMetaProps\u0027: \u00271.35-66ec4135a4c08d6e67e39cb0400b059e\u0027,"},{"line_number":1107,"context_line":"    \u0027Instance\u0027: \u00272.8-2727dba5e4a078e6cc848c1f94f7eb24\u0027,"},{"line_number":1108,"context_line":"    \u0027InstanceAction\u0027: \u00271.2-9a5abc87fdd3af46f45731960651efb5\u0027,"},{"line_number":1109,"context_line":"    \u0027InstanceActionEvent\u0027: \u00271.4-5b1f361bd81989f8bb2c20bb7e8a4cb4\u0027,"},{"line_number":1110,"context_line":"    \u0027InstanceActionEventList\u0027: \u00271.1-13d92fb953030cdbfee56481756e02be\u0027,"}],"source_content_type":"text/x-python","patch_set":25,"id":"1e5c1afd_b7721a5e","line":1107,"in_reply_to":"3f17f9d3_4f0663ce","updated":"2023-11-28 18:40:05.000000000","message":"Done","commit_id":"af44e654e294940a85fff54b4223ddca4e40c4b7"}],"nova/tests/unit/scheduler/test_request_filter.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":512,"context_line":"    @mock.patch.object(request_filter, \u0027LOG\u0027)"},{"line_number":513,"context_line":"    def test_virtio_filter_with_packed_ring(self, mock_log):"},{"line_number":514,"context_line":"        # First ensure that packed_virtqueue_filter is included"},{"line_number":515,"context_line":"        self.assertIn(request_filter.accelerators_filter,"},{"line_number":516,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027myes\u0027}"}],"source_content_type":"text/x-python","patch_set":10,"id":"02678d30_fab5eb7f","line":515,"range":{"start_line":515,"start_character":37,"end_line":515,"end_character":56},"updated":"2023-05-18 19:41:15.000000000","message":"this is the wrong filter","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"a59bdbb36a7ae5e7296ab1d67549cff9f28259ca","unresolved":false,"context_lines":[{"line_number":512,"context_line":"    @mock.patch.object(request_filter, \u0027LOG\u0027)"},{"line_number":513,"context_line":"    def test_virtio_filter_with_packed_ring(self, mock_log):"},{"line_number":514,"context_line":"        # First ensure that packed_virtqueue_filter is included"},{"line_number":515,"context_line":"        self.assertIn(request_filter.accelerators_filter,"},{"line_number":516,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027myes\u0027}"}],"source_content_type":"text/x-python","patch_set":10,"id":"50149754_4e9cb863","line":515,"range":{"start_line":515,"start_character":37,"end_line":515,"end_character":56},"in_reply_to":"02678d30_fab5eb7f","updated":"2023-05-19 12:46:14.000000000","message":"Done","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":526,"context_line":"        request_filter.packed_virtqueue_filter(self.context, reqspec)"},{"line_number":527,"context_line":"        self.assertEqual({ot.COMPUTE_NET_VIRTIO_PACKED}, reqspec.root_required)"},{"line_number":528,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":531,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":532,"context_line":"                                        properties\u003dobjects.ImageMetaProps("}],"source_content_type":"text/x-python","patch_set":10,"id":"3318c925_a55d6353","line":529,"updated":"2023-05-18 19:41:15.000000000","message":"ack so you asserted that the request spec does not have the trait\nran the filter and then asserted it added the expected trait when it was requested in the flaovr","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        request_filter.packed_virtqueue_filter(self.context, reqspec)"},{"line_number":527,"context_line":"        self.assertEqual({ot.COMPUTE_NET_VIRTIO_PACKED}, reqspec.root_required)"},{"line_number":528,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":531,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":532,"context_line":"                                        properties\u003dobjects.ImageMetaProps("}],"source_content_type":"text/x-python","patch_set":10,"id":"6193a281_49c315f9","line":529,"in_reply_to":"3318c925_a55d6353","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":537,"context_line":"        # Request filter puts the trait into the request spec"},{"line_number":538,"context_line":"        request_filter.packed_virtqueue_filter(self.context, reqspec)"},{"line_number":539,"context_line":"        self.assertEqual({ot.COMPUTE_NET_VIRTIO_PACKED}, reqspec.root_required)"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        # Assert both the in-method logging and trace decorator."},{"line_number":543,"context_line":"        log_lines \u003d [c[0][0] for c in mock_log.debug.call_args_list]"}],"source_content_type":"text/x-python","patch_set":10,"id":"c0898aa0_17f7524b","line":540,"updated":"2023-05-18 19:41:15.000000000","message":"here you have don tit again but with the image.\n\nThecnically shti shoudl be a serepate test.\n\none for the image and one for the flavor","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"a59bdbb36a7ae5e7296ab1d67549cff9f28259ca","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        # Request filter puts the trait into the request spec"},{"line_number":538,"context_line":"        request_filter.packed_virtqueue_filter(self.context, reqspec)"},{"line_number":539,"context_line":"        self.assertEqual({ot.COMPUTE_NET_VIRTIO_PACKED}, reqspec.root_required)"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        # Assert both the in-method logging and trace decorator."},{"line_number":543,"context_line":"        log_lines \u003d [c[0][0] for c in mock_log.debug.call_args_list]"}],"source_content_type":"text/x-python","patch_set":10,"id":"f6046ee9_e6491938","line":540,"in_reply_to":"c0898aa0_17f7524b","updated":"2023-05-19 12:46:14.000000000","message":"Done","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        self.assertEqual({ot.COMPUTE_NET_VIRTIO_PACKED}, reqspec.root_required)"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        # Assert both the in-method logging and trace decorator."},{"line_number":543,"context_line":"        log_lines \u003d [c[0][0] for c in mock_log.debug.call_args_list]"},{"line_number":544,"context_line":"        self.assertIn(\u0027added required trait\u0027, log_lines[0])"},{"line_number":545,"context_line":"        self.assertIn(\u0027took %.1f seconds\u0027, log_lines[1])"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    @mock.patch.object(request_filter, \u0027LOG\u0027)"},{"line_number":548,"context_line":"    def test_virtio_filter_no_packed_ring(self, mock_log):"}],"source_content_type":"text/x-python","patch_set":10,"id":"62907181_147d1558","line":545,"range":{"start_line":542,"start_character":5,"end_line":545,"end_character":56},"updated":"2023-05-18 19:41:15.000000000","message":"this is fine but its not really needed.\n\u0027took %.1f seconds\u0027 this is done by a decorator which is tested separately so we dont really neeed to test it here but its  fine","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        self.assertEqual({ot.COMPUTE_NET_VIRTIO_PACKED}, reqspec.root_required)"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        # Assert both the in-method logging and trace decorator."},{"line_number":543,"context_line":"        log_lines \u003d [c[0][0] for c in mock_log.debug.call_args_list]"},{"line_number":544,"context_line":"        self.assertIn(\u0027added required trait\u0027, log_lines[0])"},{"line_number":545,"context_line":"        self.assertIn(\u0027took %.1f seconds\u0027, log_lines[1])"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    @mock.patch.object(request_filter, \u0027LOG\u0027)"},{"line_number":548,"context_line":"    def test_virtio_filter_no_packed_ring(self, mock_log):"}],"source_content_type":"text/x-python","patch_set":10,"id":"a020b296_e7f420f3","line":545,"range":{"start_line":542,"start_character":5,"end_line":545,"end_character":56},"in_reply_to":"62907181_147d1558","updated":"2023-05-29 11:17:31.000000000","message":"Done","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":548,"context_line":"    def test_virtio_filter_no_packed_ring(self, mock_log):"},{"line_number":549,"context_line":"        # First ensure that packed_virtqueue_filter is included"},{"line_number":550,"context_line":"        self.assertIn(request_filter.packed_virtqueue_filter,"},{"line_number":551,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":554,"context_line":"                                      image\u003dobjects.ImageMeta("}],"source_content_type":"text/x-python","patch_set":10,"id":"c04ae0ee_c325242c","line":551,"updated":"2023-05-18 19:41:15.000000000","message":"this is the correct filter.","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":548,"context_line":"    def test_virtio_filter_no_packed_ring(self, mock_log):"},{"line_number":549,"context_line":"        # First ensure that packed_virtqueue_filter is included"},{"line_number":550,"context_line":"        self.assertIn(request_filter.packed_virtqueue_filter,"},{"line_number":551,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":554,"context_line":"                                      image\u003dobjects.ImageMeta("}],"source_content_type":"text/x-python","patch_set":10,"id":"47be172f_46fd8c4e","line":551,"in_reply_to":"c04ae0ee_c325242c","updated":"2023-05-29 11:17:31.000000000","message":"Done","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":562,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        # Assert about logging"},{"line_number":565,"context_line":"        mock_log.assert_not_called()"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def test_routed_networks_filter_not_enabled(self):"},{"line_number":568,"context_line":"        self.assertIn(request_filter.routed_networks_filter,"}],"source_content_type":"text/x-python","patch_set":10,"id":"87aa961e_7a488991","line":565,"updated":"2023-05-18 19:41:15.000000000","message":"ack can you fix the filter in the previous test and split it into two?\n\nbetween the previous test and this one you have tested both the flavor and iamge request and tested the noop case wehre its not requested in either so im happy with that.\n\nwe detecht an block requestign differnt value in the flavor and image in the api so so that does not need to be tested as it will never get to the schduler if they are in conflict.","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"a59bdbb36a7ae5e7296ab1d67549cff9f28259ca","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        # Assert about logging"},{"line_number":565,"context_line":"        mock_log.assert_not_called()"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def test_routed_networks_filter_not_enabled(self):"},{"line_number":568,"context_line":"        self.assertIn(request_filter.routed_networks_filter,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4a1e51d_7c26788b","line":565,"in_reply_to":"87aa961e_7a488991","updated":"2023-05-19 12:46:14.000000000","message":"Done","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        # Request filter puts the trait into the request spec"},{"line_number":544,"context_line":"        request_filter.packed_virtqueue_filter(self.context, reqspec)"},{"line_number":545,"context_line":"        self.assertEqual({ot.COMPUTE_NET_VIRTIO_PACKED}, reqspec.root_required)"},{"line_number":546,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"    def test_routed_networks_filter_not_enabled(self):"},{"line_number":549,"context_line":"        self.assertIn(request_filter.routed_networks_filter,"}],"source_content_type":"text/x-python","patch_set":11,"id":"311961db_ee9a859d","line":546,"updated":"2023-05-29 11:17:31.000000000","message":"thanks for spliting this","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"fc283f237e65afe2caadc7c3251b04c21df4aed5","unresolved":true,"context_lines":[{"line_number":515,"context_line":"        self.assertIn(request_filter.packed_virtqueue_filter,"},{"line_number":516,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027myes\u0027}"},{"line_number":519,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003des),"},{"line_number":520,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":521,"context_line":"                                        properties\u003dobjects.ImageMetaProps()))"}],"source_content_type":"text/x-python","patch_set":13,"id":"0d8ba8f2_17eb201f","line":518,"range":{"start_line":518,"start_character":40,"end_line":518,"end_character":44},"updated":"2023-06-22 13:20:21.000000000","message":"typo ? --\u003e yes","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        self.assertIn(request_filter.packed_virtqueue_filter,"},{"line_number":516,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027myes\u0027}"},{"line_number":519,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003des),"},{"line_number":520,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":521,"context_line":"                                        properties\u003dobjects.ImageMetaProps()))"}],"source_content_type":"text/x-python","patch_set":13,"id":"200aec55_6cd32f30","line":518,"range":{"start_line":518,"start_character":40,"end_line":518,"end_character":44},"in_reply_to":"01711ac6_2559b362","updated":"2023-06-27 10:27:57.000000000","message":"Done","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"237d77adbee2ba55ca4e1768c590efdabb614c2f","unresolved":true,"context_lines":[{"line_number":515,"context_line":"        self.assertIn(request_filter.packed_virtqueue_filter,"},{"line_number":516,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027myes\u0027}"},{"line_number":519,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003des),"},{"line_number":520,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":521,"context_line":"                                        properties\u003dobjects.ImageMetaProps()))"}],"source_content_type":"text/x-python","patch_set":13,"id":"01711ac6_2559b362","line":518,"range":{"start_line":518,"start_character":40,"end_line":518,"end_character":44},"in_reply_to":"0d8ba8f2_17eb201f","updated":"2023-06-22 17:38:41.000000000","message":"nice catch correct. this shoudl be yes/on/true","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":518,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027true\u0027}"},{"line_number":519,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003des),"},{"line_number":520,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":521,"context_line":"                                        properties\u003dobjects.ImageMetaProps()))"},{"line_number":522,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":523,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3818fd3d_850b0a74","line":521,"updated":"2023-08-02 13:59:16.000000000","message":"This should be indented four spaces, not two.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027true\u0027}"},{"line_number":519,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003des),"},{"line_number":520,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":521,"context_line":"                                        properties\u003dobjects.ImageMetaProps()))"},{"line_number":522,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":523,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"40c4ccae_ae8c190e","line":521,"in_reply_to":"3818fd3d_850b0a74","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":537,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":538,"context_line":"                                        properties\u003dobjects.ImageMetaProps("},{"line_number":539,"context_line":"                                          hw_virtio_packed_ring\u003dTrue)))"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":541,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"}],"source_content_type":"text/x-python","patch_set":20,"id":"6e853b3a_246f7778","line":538,"updated":"2023-08-02 13:59:16.000000000","message":"This should be indented four spaces, not two.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":537,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":538,"context_line":"                                        properties\u003dobjects.ImageMetaProps("},{"line_number":539,"context_line":"                                          hw_virtio_packed_ring\u003dTrue)))"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":541,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"}],"source_content_type":"text/x-python","patch_set":20,"id":"d7e4d31e_bb217458","line":538,"in_reply_to":"6e853b3a_246f7778","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":536,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":537,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":538,"context_line":"                                        properties\u003dobjects.ImageMetaProps("},{"line_number":539,"context_line":"                                          hw_virtio_packed_ring\u003dTrue)))"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":541,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":542,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"cdb86cc6_d0849f3f","line":539,"updated":"2023-08-02 13:59:16.000000000","message":"Same here.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":537,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":538,"context_line":"                                        properties\u003dobjects.ImageMetaProps("},{"line_number":539,"context_line":"                                          hw_virtio_packed_ring\u003dTrue)))"},{"line_number":540,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":541,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":542,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"0ad85cfd_1ca71b56","line":539,"in_reply_to":"cdb86cc6_d0849f3f","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":506,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027true\u0027}"},{"line_number":509,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003des),"},{"line_number":510,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":511,"context_line":"                                          properties\u003dobjects.ImageMetaProps()))"},{"line_number":512,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":513,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dceb9011_ae343703","line":511,"range":{"start_line":509,"start_character":8,"end_line":511,"end_character":79},"updated":"2023-11-28 18:40:05.000000000","message":"nit: this formatting kind of hurts my soul :P\n\ni would prefer \n```\nreqspec \u003d objects.RequestSpec(\n    flavor\u003dobjects.Flavor(extra_specs\u003des),\n    image\u003dobjects.ImageMeta(properties\u003dobjects.ImageMetaProps()))\n```\nor this v if  that ^ is over the line lenght limit\n\n```\nreqspec \u003d objects.RequestSpec(\n    flavor\u003dobjects.Flavor(extra_specs\u003des),\n    image\u003dobjects.ImageMeta(\n        properties\u003dobjects.ImageMetaProps()))\n```","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80a34b67e4620e611e02f5d59ef7f5eb07937b7c","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"        es \u003d {\u0027hw:virtio_packed_ring\u0027: \u0027true\u0027}"},{"line_number":509,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003des),"},{"line_number":510,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":511,"context_line":"                                          properties\u003dobjects.ImageMetaProps()))"},{"line_number":512,"context_line":"        self.assertEqual(set(), reqspec.root_required)"},{"line_number":513,"context_line":"        self.assertEqual(set(), reqspec.root_forbidden)"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"982da908_4725dc88","line":511,"range":{"start_line":509,"start_character":8,"end_line":511,"end_character":79},"in_reply_to":"dceb9011_ae343703","updated":"2023-11-29 18:29:40.000000000","message":"Done","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        self.assertIn(request_filter.packed_virtqueue_filter,"},{"line_number":524,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":527,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":528,"context_line":"                                          properties\u003dobjects.ImageMetaProps("},{"line_number":529,"context_line":"                                              hw_virtio_packed_ring\u003dTrue)))"}],"source_content_type":"text/x-python","patch_set":28,"id":"577e6c45_bdba70a7","line":526,"updated":"2023-11-28 18:40:05.000000000","message":"same for this its technically fine but its wastign a lot of veritcal space","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80a34b67e4620e611e02f5d59ef7f5eb07937b7c","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self.assertIn(request_filter.packed_virtqueue_filter,"},{"line_number":524,"context_line":"                      request_filter.ALL_REQUEST_FILTERS)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        reqspec \u003d objects.RequestSpec(flavor\u003dobjects.Flavor(extra_specs\u003d{}),"},{"line_number":527,"context_line":"                                      image\u003dobjects.ImageMeta("},{"line_number":528,"context_line":"                                          properties\u003dobjects.ImageMetaProps("},{"line_number":529,"context_line":"                                              hw_virtio_packed_ring\u003dTrue)))"}],"source_content_type":"text/x-python","patch_set":28,"id":"0e92bb70_58d25ce7","line":526,"in_reply_to":"577e6c45_bdba70a7","updated":"2023-11-29 18:29:40.000000000","message":"Done","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb687af393c9d6b82538fe72424ee73de1739b3f","unresolved":true,"context_lines":[{"line_number":1935,"context_line":"              \u003cmodel type\u003d\"virtio\"/\u003e"},{"line_number":1936,"context_line":"              \u003cdriver name\u003d\"vhost\" packed\u003d\"on\"/\u003e"},{"line_number":1937,"context_line":"              \u003ctarget dev\u003d\"vnet0\"/\u003e"},{"line_number":1938,"context_line":"            \u003c/interface\u003e\"\"\")"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"        # parse the xml from the first object into a new object and make sure"},{"line_number":1941,"context_line":"        # they are the same"}],"source_content_type":"text/x-python","patch_set":17,"id":"37557fd3_1952a13c","line":1938,"updated":"2023-07-25 09:47:09.000000000","message":"i would nomrally prefer the serialisation and parsign to be two seperate test but this is what we did for other test in this file so its consistent.","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6db5ac463ed75f57b60010c73f1fb89a04a6563c","unresolved":false,"context_lines":[{"line_number":1935,"context_line":"              \u003cmodel type\u003d\"virtio\"/\u003e"},{"line_number":1936,"context_line":"              \u003cdriver name\u003d\"vhost\" packed\u003d\"on\"/\u003e"},{"line_number":1937,"context_line":"              \u003ctarget dev\u003d\"vnet0\"/\u003e"},{"line_number":1938,"context_line":"            \u003c/interface\u003e\"\"\")"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"        # parse the xml from the first object into a new object and make sure"},{"line_number":1941,"context_line":"        # they are the same"}],"source_content_type":"text/x-python","patch_set":17,"id":"6a0b78c0_b353224b","line":1938,"in_reply_to":"37557fd3_1952a13c","updated":"2023-09-20 12:02:08.000000000","message":"Ack","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":755,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":756,"context_line":"            {\u0027name\u0027: \u0027bar\u0027, \u0027properties\u0027: image_meta_props})"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        self._test_virtio_packed_config(image_meta, flavor)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def _test_virtio_config_queue_sizes("},{"line_number":761,"context_line":"            self, vnic_type\u003dnetwork_model.VNIC_TYPE_NORMAL):"}],"source_content_type":"text/x-python","patch_set":10,"id":"61f659de_8c620109","line":758,"updated":"2023-05-18 19:41:15.000000000","message":"+1","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":756,"context_line":"            {\u0027name\u0027: \u0027bar\u0027, \u0027properties\u0027: image_meta_props})"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        self._test_virtio_packed_config(image_meta, flavor)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def _test_virtio_config_queue_sizes("},{"line_number":761,"context_line":"            self, vnic_type\u003dnetwork_model.VNIC_TYPE_NORMAL):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bad1a255_99cfbb53","line":758,"in_reply_to":"61f659de_8c620109","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"}],"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":5685,"context_line":"        # pass: flavor-only configuration"},{"line_number":5686,"context_line":"        (\u0027yes\u0027, None, True),"},{"line_number":5687,"context_line":"        # pass: image-only configuration"},{"line_number":5688,"context_line":"        (None, False, False),"},{"line_number":5689,"context_line":"        # pass: identical image and flavor configuration"},{"line_number":5690,"context_line":"        (\u0027yes\u0027, True, True),"},{"line_number":5691,"context_line":"        # fail: mismatched image and flavor configuration"}],"source_content_type":"text/x-python","patch_set":10,"id":"fd089c8f_9e29378a","line":5688,"range":{"start_line":5688,"start_character":15,"end_line":5688,"end_character":27},"updated":"2023-05-18 19:41:15.000000000","message":"i would change this to True, True","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"a59bdbb36a7ae5e7296ab1d67549cff9f28259ca","unresolved":false,"context_lines":[{"line_number":5685,"context_line":"        # pass: flavor-only configuration"},{"line_number":5686,"context_line":"        (\u0027yes\u0027, None, True),"},{"line_number":5687,"context_line":"        # pass: image-only configuration"},{"line_number":5688,"context_line":"        (None, False, False),"},{"line_number":5689,"context_line":"        # pass: identical image and flavor configuration"},{"line_number":5690,"context_line":"        (\u0027yes\u0027, True, True),"},{"line_number":5691,"context_line":"        # fail: mismatched image and flavor configuration"}],"source_content_type":"text/x-python","patch_set":10,"id":"ea068188_a4bb7006","line":5688,"range":{"start_line":5688,"start_character":15,"end_line":5688,"end_character":27},"in_reply_to":"fd089c8f_9e29378a","updated":"2023-05-19 12:46:14.000000000","message":"Done","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":5738,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":5739,"context_line":"            {\u0027name\u0027: \u0027bar\u0027, \u0027properties\u0027: image_meta_props})"},{"line_number":5740,"context_line":""},{"line_number":5741,"context_line":"        if isinstance(expected, type) and issubclass(expected, Exception):"},{"line_number":5742,"context_line":"            self.assertRaises("},{"line_number":5743,"context_line":"                expected, hw.get_packed_virtqueue_constraint,"},{"line_number":5744,"context_line":"                flavor, image_meta,"}],"source_content_type":"text/x-python","patch_set":20,"id":"02b8ac15_ff2a247a","line":5741,"updated":"2023-08-02 13:59:16.000000000","message":"Not that this doesn\u0027t work, but it seems overly elaborate. Why not invert the two cases and just do `isinstance(expected, bool)` ?","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":5738,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":5739,"context_line":"            {\u0027name\u0027: \u0027bar\u0027, \u0027properties\u0027: image_meta_props})"},{"line_number":5740,"context_line":""},{"line_number":5741,"context_line":"        if isinstance(expected, type) and issubclass(expected, Exception):"},{"line_number":5742,"context_line":"            self.assertRaises("},{"line_number":5743,"context_line":"                expected, hw.get_packed_virtqueue_constraint,"},{"line_number":5744,"context_line":"                flavor, image_meta,"}],"source_content_type":"text/x-python","patch_set":20,"id":"79b8621d_4a1e4107","line":5741,"in_reply_to":"02b8ac15_ff2a247a","updated":"2023-11-28 18:40:05.000000000","message":"but ya i woudl be fine with inverting it.\n\nim also confused why this is diffent then line 5702\n\nthe function signiture and data being passed in is the same so this if should be the same.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":5699,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":5700,"context_line":"            {\u0027name\u0027: \u0027bar\u0027, \u0027properties\u0027: image_meta_props})"},{"line_number":5701,"context_line":""},{"line_number":5702,"context_line":"        if isinstance(expected, type):"},{"line_number":5703,"context_line":"            self.assertRaises("},{"line_number":5704,"context_line":"                expected, hw.get_vif_multiqueue_constraint, flavor, image_meta,"},{"line_number":5705,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"4faaff7d_1345f07a","line":5702,"updated":"2023-11-28 18:40:05.000000000","message":"i feel like this should be the same as line 5746","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80a34b67e4620e611e02f5d59ef7f5eb07937b7c","unresolved":false,"context_lines":[{"line_number":5699,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict("},{"line_number":5700,"context_line":"            {\u0027name\u0027: \u0027bar\u0027, \u0027properties\u0027: image_meta_props})"},{"line_number":5701,"context_line":""},{"line_number":5702,"context_line":"        if isinstance(expected, type):"},{"line_number":5703,"context_line":"            self.assertRaises("},{"line_number":5704,"context_line":"                expected, hw.get_vif_multiqueue_constraint, flavor, image_meta,"},{"line_number":5705,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"3fb4d0d9_9129713c","line":5702,"in_reply_to":"4faaff7d_1345f07a","updated":"2023-11-29 18:29:40.000000000","message":"Done","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"}],"nova/virt/hardware.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c531066b090d071fc339b5e55a24c9c7e8808f09","unresolved":true,"context_lines":[{"line_number":1936,"context_line":"    return flavor_value or image_value or False"},{"line_number":1937,"context_line":""},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"def get_packed_virtqueue_constraint("},{"line_number":1940,"context_line":"    flavor: \u0027objects.Flavor\u0027,"},{"line_number":1941,"context_line":"    image_meta: \u0027objects.ImageMeta\u0027,"},{"line_number":1942,"context_line":") -\u003e bool:"}],"source_content_type":"text/x-python","patch_set":6,"id":"2ce89d07_231082bc","line":1939,"updated":"2023-05-15 11:30:28.000000000","message":"ok. this modules is normally only used for numa/hugepages/cpu pinning\nbut i think this is fine to add here.","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":1936,"context_line":"    return flavor_value or image_value or False"},{"line_number":1937,"context_line":""},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"def get_packed_virtqueue_constraint("},{"line_number":1940,"context_line":"    flavor: \u0027objects.Flavor\u0027,"},{"line_number":1941,"context_line":"    image_meta: \u0027objects.ImageMeta\u0027,"},{"line_number":1942,"context_line":") -\u003e bool:"}],"source_content_type":"text/x-python","patch_set":6,"id":"66db78d8_16544433","line":1939,"in_reply_to":"2ce89d07_231082bc","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c531066b090d071fc339b5e55a24c9c7e8808f09","unresolved":true,"context_lines":[{"line_number":1968,"context_line":"            \"%(image_name)s which has %(prefix)s_%(key)s explicitly set to \""},{"line_number":1969,"context_line":"            \"%(image_val)s.\""},{"line_number":1970,"context_line":"        )"},{"line_number":1971,"context_line":"        raise exception.FlavorImageConflict("},{"line_number":1972,"context_line":"            msg % {"},{"line_number":1973,"context_line":"                \u0027prefix\u0027: \u0027hw\u0027,"},{"line_number":1974,"context_line":"                \u0027key\u0027: \u0027virtio_packed_ring\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"36692a4c_8005ef56","line":1971,"updated":"2023-05-15 11:30:28.000000000","message":"ack\nthis is the correct behavior yes.\nwe you can set iether value but if you set both they must be the same","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":1968,"context_line":"            \"%(image_name)s which has %(prefix)s_%(key)s explicitly set to \""},{"line_number":1969,"context_line":"            \"%(image_val)s.\""},{"line_number":1970,"context_line":"        )"},{"line_number":1971,"context_line":"        raise exception.FlavorImageConflict("},{"line_number":1972,"context_line":"            msg % {"},{"line_number":1973,"context_line":"                \u0027prefix\u0027: \u0027hw\u0027,"},{"line_number":1974,"context_line":"                \u0027key\u0027: \u0027virtio_packed_ring\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"573a52be_b6551e5c","line":1971,"in_reply_to":"36692a4c_8005ef56","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c531066b090d071fc339b5e55a24c9c7e8808f09","unresolved":true,"context_lines":[{"line_number":1982,"context_line":"    return flavor_value or image_value or False"},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"def get_vtpm_constraint("},{"line_number":1986,"context_line":"    flavor: \u0027objects.Flavor\u0027,"},{"line_number":1987,"context_line":"    image_meta: \u0027objects.ImageMeta\u0027,"},{"line_number":1988,"context_line":") -\u003e ty.Optional[VTPMConfig]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"cbeb05a0_e4247aea","line":1985,"updated":"2023-05-15 11:30:28.000000000","message":"we have some exampels of other none EPA features so its proably best to keep them all in the same place.","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":1982,"context_line":"    return flavor_value or image_value or False"},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"def get_vtpm_constraint("},{"line_number":1986,"context_line":"    flavor: \u0027objects.Flavor\u0027,"},{"line_number":1987,"context_line":"    image_meta: \u0027objects.ImageMeta\u0027,"},{"line_number":1988,"context_line":") -\u003e ty.Optional[VTPMConfig]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dbb82033_a7c8bd76","line":1985,"in_reply_to":"cbeb05a0_e4247aea","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"38c8b00a458c2ac3217b4673fac632e1155ff217"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"255cdf06df9bae37814cfaf0298d2c12d7f13890","unresolved":true,"context_lines":[{"line_number":1968,"context_line":"            \"%(image_name)s which has %(prefix)s_%(key)s explicitly set to \""},{"line_number":1969,"context_line":"            \"%(image_val)s.\""},{"line_number":1970,"context_line":"        )"},{"line_number":1971,"context_line":"        raise exception.FlavorImageConflict("},{"line_number":1972,"context_line":"            msg % {"},{"line_number":1973,"context_line":"                \u0027prefix\u0027: \u0027hw\u0027,"},{"line_number":1974,"context_line":"                \u0027key\u0027: \u0027virtio_packed_ring\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"a6e9aa3b_17822173","line":1971,"updated":"2023-05-30 14:49:36.000000000","message":"I was under the impression that usually flavor takes precedence over image. But conflict looks good as well :-)","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb687af393c9d6b82538fe72424ee73de1739b3f","unresolved":false,"context_lines":[{"line_number":1968,"context_line":"            \"%(image_name)s which has %(prefix)s_%(key)s explicitly set to \""},{"line_number":1969,"context_line":"            \"%(image_val)s.\""},{"line_number":1970,"context_line":"        )"},{"line_number":1971,"context_line":"        raise exception.FlavorImageConflict("},{"line_number":1972,"context_line":"            msg % {"},{"line_number":1973,"context_line":"                \u0027prefix\u0027: \u0027hw\u0027,"},{"line_number":1974,"context_line":"                \u0027key\u0027: \u0027virtio_packed_ring\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"d625e5b8_5b083835","line":1971,"in_reply_to":"4386155e_9569292d","updated":"2023-07-25 09:47:09.000000000","message":"Ack","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"237d77adbee2ba55ca4e1768c590efdabb614c2f","unresolved":true,"context_lines":[{"line_number":1968,"context_line":"            \"%(image_name)s which has %(prefix)s_%(key)s explicitly set to \""},{"line_number":1969,"context_line":"            \"%(image_val)s.\""},{"line_number":1970,"context_line":"        )"},{"line_number":1971,"context_line":"        raise exception.FlavorImageConflict("},{"line_number":1972,"context_line":"            msg % {"},{"line_number":1973,"context_line":"                \u0027prefix\u0027: \u0027hw\u0027,"},{"line_number":1974,"context_line":"                \u0027key\u0027: \u0027virtio_packed_ring\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"4386155e_9569292d","line":1971,"in_reply_to":"a6e9aa3b_17822173","updated":"2023-06-22 17:38:41.000000000","message":"as noted in a differnt review we have not used that patteren for abvout 6 years and wehn we did the image used to have prefernce in most cases.\n\nsince aournd rocky we have used conflict not precidence where the two disagree.","commit_id":"fd669e0303f4f64ea4fa270175716cedbcb8074c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"        image_value \u003d image_meta.get(\u0027properties\u0027, {}).get(image_key, None)"},{"line_number":1960,"context_line":"    else:"},{"line_number":1961,"context_line":"        flavor_value_str, image_value \u003d _get_flavor_image_meta("},{"line_number":1962,"context_line":"        key_value, flavor, image_meta)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"    flavor_value \u003d None"},{"line_number":1965,"context_line":"    if flavor_value_str is not None:"}],"source_content_type":"text/x-python","patch_set":20,"id":"ea948e31_93f38fcf","line":1962,"updated":"2023-08-02 13:59:16.000000000","message":"This is clearly not indented correctly...","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":1959,"context_line":"        image_value \u003d image_meta.get(\u0027properties\u0027, {}).get(image_key, None)"},{"line_number":1960,"context_line":"    else:"},{"line_number":1961,"context_line":"        flavor_value_str, image_value \u003d _get_flavor_image_meta("},{"line_number":1962,"context_line":"        key_value, flavor, image_meta)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"    flavor_value \u003d None"},{"line_number":1965,"context_line":"    if flavor_value_str is not None:"}],"source_content_type":"text/x-python","patch_set":20,"id":"d5f9d078_171cad32","line":1962,"in_reply_to":"ea948e31_93f38fcf","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6b8c4334ed83509581dd0a1944232abba5a12d96","unresolved":true,"context_lines":[{"line_number":1951,"context_line":"    :param image_meta: ``nova.objects.ImageMeta`` or dict instance"},{"line_number":1952,"context_line":"    :raises: nova.exception.FlavorImageConflict if a value is specified in both"},{"line_number":1953,"context_line":"        the flavor and the image, but the values do not match"},{"line_number":1954,"context_line":"    :raises: nova.exception.Invalid if a value or combination of values is"},{"line_number":1955,"context_line":"        invalid"},{"line_number":1956,"context_line":"    :returns: True if the Packed virtqueue must be enabled, else False."},{"line_number":1957,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"83d1b24a_ed558495","line":1954,"updated":"2023-11-15 09:15:27.000000000","message":"This is incorrect. The code raises FlavorImageConflict (which is not even inheriting from Invalid)","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":false,"context_lines":[{"line_number":1951,"context_line":"    :param image_meta: ``nova.objects.ImageMeta`` or dict instance"},{"line_number":1952,"context_line":"    :raises: nova.exception.FlavorImageConflict if a value is specified in both"},{"line_number":1953,"context_line":"        the flavor and the image, but the values do not match"},{"line_number":1954,"context_line":"    :raises: nova.exception.Invalid if a value or combination of values is"},{"line_number":1955,"context_line":"        invalid"},{"line_number":1956,"context_line":"    :returns: True if the Packed virtqueue must be enabled, else False."},{"line_number":1957,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"afc1fc40_2264fc71","line":1954,"in_reply_to":"83d1b24a_ed558495","updated":"2023-11-28 18:40:05.000000000","message":"Done","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":1812,"context_line":"        drv_elem \u003d None"},{"line_number":1813,"context_line":"        if (self.driver_name or"},{"line_number":1814,"context_line":"                self.driver_iommu or"},{"line_number":1815,"context_line":"                self.driver_packed is True or"},{"line_number":1816,"context_line":"                self.net_type \u003d\u003d \"vhostuser\"):"},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"            drv_elem \u003d etree.Element(\"driver\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"de3995a9_37a33ee7","line":1815,"range":{"start_line":1815,"start_character":38,"end_line":1815,"end_character":42},"updated":"2023-11-28 18:40:05.000000000","message":"you should not do an is check to compare to True\nis is an identity check not an equality check.","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80a34b67e4620e611e02f5d59ef7f5eb07937b7c","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"        drv_elem \u003d None"},{"line_number":1813,"context_line":"        if (self.driver_name or"},{"line_number":1814,"context_line":"                self.driver_iommu or"},{"line_number":1815,"context_line":"                self.driver_packed is True or"},{"line_number":1816,"context_line":"                self.net_type \u003d\u003d \"vhostuser\"):"},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"            drv_elem \u003d etree.Element(\"driver\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"5e8489b1_0d242bfd","line":1815,"range":{"start_line":1815,"start_character":38,"end_line":1815,"end_character":42},"in_reply_to":"a2054b9f_a0e8a2df","updated":"2023-11-29 18:29:40.000000000","message":"Done","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"50e719a077238532a44b0089591a70a55812e36d","unresolved":true,"context_lines":[{"line_number":1812,"context_line":"        drv_elem \u003d None"},{"line_number":1813,"context_line":"        if (self.driver_name or"},{"line_number":1814,"context_line":"                self.driver_iommu or"},{"line_number":1815,"context_line":"                self.driver_packed is True or"},{"line_number":1816,"context_line":"                self.net_type \u003d\u003d \"vhostuser\"):"},{"line_number":1817,"context_line":""},{"line_number":1818,"context_line":"            drv_elem \u003d etree.Element(\"driver\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"a2054b9f_a0e8a2df","line":1815,"range":{"start_line":1815,"start_character":38,"end_line":1815,"end_character":42},"in_reply_to":"de3995a9_37a33ee7","updated":"2023-11-29 10:54:46.000000000","message":"I had updated this logic according to this comment:\nhttps://review.opendev.org/c/openstack/nova/+/876075/27..28/nova/virt/libvirt/designer.py#b42","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24e916575cb7ae4760119bd9b4212468debae2d0","unresolved":true,"context_lines":[{"line_number":1821,"context_line":"                drv_elem.set(\"name\", self.driver_name)"},{"line_number":1822,"context_line":"            if self.driver_iommu:"},{"line_number":1823,"context_line":"                drv_elem.set(\"iommu\", \"on\")"},{"line_number":1824,"context_line":"            if self.driver_packed is True:"},{"line_number":1825,"context_line":"                drv_elem.set(\"packed\", \"on\")"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"        if drv_elem is not None:"}],"source_content_type":"text/x-python","patch_set":28,"id":"eb57c3d3_82d8358e","line":1824,"updated":"2023-11-28 18:40:05.000000000","message":"this is also wrong","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80a34b67e4620e611e02f5d59ef7f5eb07937b7c","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"                drv_elem.set(\"name\", self.driver_name)"},{"line_number":1822,"context_line":"            if self.driver_iommu:"},{"line_number":1823,"context_line":"                drv_elem.set(\"iommu\", \"on\")"},{"line_number":1824,"context_line":"            if self.driver_packed is True:"},{"line_number":1825,"context_line":"                drv_elem.set(\"packed\", \"on\")"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"        if drv_elem is not None:"}],"source_content_type":"text/x-python","patch_set":28,"id":"c7f950a1_8e0de24a","line":1824,"in_reply_to":"7d8e4b04_011bdd76","updated":"2023-11-29 18:29:40.000000000","message":"Done","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"50e719a077238532a44b0089591a70a55812e36d","unresolved":true,"context_lines":[{"line_number":1821,"context_line":"                drv_elem.set(\"name\", self.driver_name)"},{"line_number":1822,"context_line":"            if self.driver_iommu:"},{"line_number":1823,"context_line":"                drv_elem.set(\"iommu\", \"on\")"},{"line_number":1824,"context_line":"            if self.driver_packed is True:"},{"line_number":1825,"context_line":"                drv_elem.set(\"packed\", \"on\")"},{"line_number":1826,"context_line":""},{"line_number":1827,"context_line":"        if drv_elem is not None:"}],"source_content_type":"text/x-python","patch_set":28,"id":"7d8e4b04_011bdd76","line":1824,"in_reply_to":"eb57c3d3_82d8358e","updated":"2023-11-29 10:54:46.000000000","message":"I had updated this logic according to this comment:\nhttps://review.opendev.org/c/openstack/nova/+/876075/27..28/nova/virt/libvirt/designer.py#b42","commit_id":"14d90ccd8c0ec301e2f604762f24bf37e517635d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1ba358f6facdaad4507aeca79c9b1d2c9304474","unresolved":false,"context_lines":[{"line_number":1759,"context_line":"        self.filterparams \u003d []"},{"line_number":1760,"context_line":"        self.driver_name \u003d None"},{"line_number":1761,"context_line":"        self.driver_iommu \u003d False"},{"line_number":1762,"context_line":"        self.driver_packed \u003d False"},{"line_number":1763,"context_line":"        self.vhostuser_mode \u003d None"},{"line_number":1764,"context_line":"        self.vhostuser_path \u003d None"},{"line_number":1765,"context_line":"        self.vhostuser_type \u003d None"}],"source_content_type":"text/x-python","patch_set":30,"id":"77ca3b73_32c377ea","line":1762,"updated":"2023-11-29 18:37:17.000000000","message":"nit:  i would personally default to None here but\nthis wont impact anything.","commit_id":"eb8519d811f1c08bc964146f484367c858b8f0c2"}],"nova/virt/libvirt/designer.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6b8c4334ed83509581dd0a1944232abba5a12d96","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        conf.vhost_queues \u003d queues"},{"line_number":40,"context_line":"    if rx_queue_size:"},{"line_number":41,"context_line":"        conf.vhost_rx_queue_size \u003d rx_queue_size"},{"line_number":42,"context_line":"    if packed is not None:"},{"line_number":43,"context_line":"        conf.driver_packed \u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"8ac24ff6_f57aae9b","line":42,"updated":"2023-11-15 09:15:27.000000000","message":"This seems to be wrong. If packed \u003d False is passed to set_vif_guest_frontend_config then `conf.driver_packed` will be set to True.","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1ba358f6facdaad4507aeca79c9b1d2c9304474","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        conf.vhost_queues \u003d queues"},{"line_number":40,"context_line":"    if rx_queue_size:"},{"line_number":41,"context_line":"        conf.vhost_rx_queue_size \u003d rx_queue_size"},{"line_number":42,"context_line":"    if packed is not None:"},{"line_number":43,"context_line":"        conf.driver_packed \u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"928f72cb_78bcff0d","line":42,"in_reply_to":"82531926_ef1511d8","updated":"2023-11-29 18:37:17.000000000","message":"Done","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd03e280476a504318a090f3c16630cc29c5601c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        conf.vhost_queues \u003d queues"},{"line_number":40,"context_line":"    if rx_queue_size:"},{"line_number":41,"context_line":"        conf.vhost_rx_queue_size \u003d rx_queue_size"},{"line_number":42,"context_line":"    if packed is not None:"},{"line_number":43,"context_line":"        conf.driver_packed \u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"82531926_ef1511d8","line":42,"in_reply_to":"8ac24ff6_f57aae9b","updated":"2023-11-16 12:39:13.000000000","message":"good catch ya that is incorrect.","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb687af393c9d6b82538fe72424ee73de1739b3f","unresolved":true,"context_lines":[{"line_number":233,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# Packed virtqueue minimal support version"},{"line_number":236,"context_line":"MIN_LIBVIRT_PACKED \u003d (6, 3, 0)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"# Names of the types that do not get compressed during migration"},{"line_number":239,"context_line":"NO_COMPRESSION_TYPES \u003d (\u0027qcow2\u0027,)"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf5ca59b_7ce0902d","line":236,"updated":"2023-07-25 09:47:09.000000000","message":"if https://review.opendev.org/c/openstack/nova/+/887255 merges first then you can remove this and if this merges first then ^ will need to be updated.","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":233,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# Packed virtqueue minimal support version"},{"line_number":236,"context_line":"MIN_LIBVIRT_PACKED \u003d (6, 3, 0)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"# Names of the types that do not get compressed during migration"},{"line_number":239,"context_line":"NO_COMPRESSION_TYPES \u003d (\u0027qcow2\u0027,)"}],"source_content_type":"text/x-python","patch_set":17,"id":"cc9eb147_68c2dc72","line":236,"in_reply_to":"bf5ca59b_7ce0902d","updated":"2023-09-20 11:59:51.000000000","message":"Ack","commit_id":"0aa336e12a952249be0a8abcdfabb28d190f2d8c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":12431,"context_line":""},{"line_number":12432,"context_line":"    def _get_packed_virtqueue_traits(self) -\u003e ty.Dict[str, bool]:"},{"line_number":12433,"context_line":"        \"\"\"Get CPU-related traits to be set and unset on the host\u0027s resource"},{"line_number":12434,"context_line":"        provider."},{"line_number":12435,"context_line":""},{"line_number":12436,"context_line":"        :return: A dict of trait names mapped to boolean values."},{"line_number":12437,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"8400e491_b445111a","line":12434,"updated":"2023-08-02 13:59:16.000000000","message":"Same thing about the multi-line docstring.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":12431,"context_line":""},{"line_number":12432,"context_line":"    def _get_packed_virtqueue_traits(self) -\u003e ty.Dict[str, bool]:"},{"line_number":12433,"context_line":"        \"\"\"Get CPU-related traits to be set and unset on the host\u0027s resource"},{"line_number":12434,"context_line":"        provider."},{"line_number":12435,"context_line":""},{"line_number":12436,"context_line":"        :return: A dict of trait names mapped to boolean values."},{"line_number":12437,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"4e6b92b3_dc309afe","line":12434,"in_reply_to":"8400e491_b445111a","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6b8c4334ed83509581dd0a1944232abba5a12d96","unresolved":true,"context_lines":[{"line_number":230,"context_line":"# Virtuozzo driver support"},{"line_number":231,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"# Names of the types that do not get compressed during migration"},{"line_number":235,"context_line":"NO_COMPRESSION_TYPES \u003d (\u0027qcow2\u0027,)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"e14e7b55_c76b421f","side":"PARENT","line":233,"updated":"2023-11-15 09:15:27.000000000","message":"Unrelated whitespace damage","commit_id":"96d7c42e2759cd90930a0c5b31ea1b2b412baa2d"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        driver \u003d None"},{"line_number":192,"context_line":"        vhost_queues \u003d None"},{"line_number":193,"context_line":"        rx_queue_size \u003d None"},{"line_number":194,"context_line":"        packed \u003d None"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        packed \u003d self._get_packed_virtqueue_settings("},{"line_number":197,"context_line":"                image_meta, flavor)"}],"source_content_type":"text/x-python","patch_set":11,"id":"de8d5765_f41394a6","line":194,"updated":"2023-05-29 11:17:31.000000000","message":"nit: (1/2) you can remove this","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        driver \u003d None"},{"line_number":192,"context_line":"        vhost_queues \u003d None"},{"line_number":193,"context_line":"        rx_queue_size \u003d None"},{"line_number":194,"context_line":"        packed \u003d None"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        packed \u003d self._get_packed_virtqueue_settings("},{"line_number":197,"context_line":"                image_meta, flavor)"}],"source_content_type":"text/x-python","patch_set":11,"id":"58e54e14_63f366be","line":194,"in_reply_to":"de8d5765_f41394a6","updated":"2023-06-27 10:27:57.000000000","message":"Done","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":true,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if hardware.get_packed_virtqueue_constraint(flavor, image_meta):"},{"line_number":310,"context_line":"            return True"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            return None"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def get_bridge_name(self, vif):"}],"source_content_type":"text/x-python","patch_set":11,"id":"09fd9955_5f528f01","line":311,"updated":"2023-05-29 11:17:31.000000000","message":"nit: (2/2) if you remove this and just alwasy return None instead.","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if hardware.get_packed_virtqueue_constraint(flavor, image_meta):"},{"line_number":310,"context_line":"            return True"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            return None"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def get_bridge_name(self, vif):"}],"source_content_type":"text/x-python","patch_set":11,"id":"4944cf39_1fa61cdc","line":311,"in_reply_to":"09fd9955_5f528f01","updated":"2023-06-27 10:27:57.000000000","message":"Done","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        rx_queue_size \u003d None"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        packed \u003d self._get_packed_virtqueue_settings("},{"line_number":196,"context_line":"                image_meta, flavor)"},{"line_number":197,"context_line":"        # NOTE(stephenfin): Skip most things here as only apply to virtio"},{"line_number":198,"context_line":"        # devices"},{"line_number":199,"context_line":"        if vnic_type in network_model.VNIC_TYPES_DIRECT_PASSTHROUGH:"}],"source_content_type":"text/x-python","patch_set":20,"id":"326e3384_df0a7d48","line":196,"updated":"2023-08-02 13:59:16.000000000","message":"Isn\u0027t this over-indented? I\u0027m surprised you\u0027re not getting a pep8 error here. Either way, it looks like it should fit on the line above.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        rx_queue_size \u003d None"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        packed \u003d self._get_packed_virtqueue_settings("},{"line_number":196,"context_line":"                image_meta, flavor)"},{"line_number":197,"context_line":"        # NOTE(stephenfin): Skip most things here as only apply to virtio"},{"line_number":198,"context_line":"        # devices"},{"line_number":199,"context_line":"        if vnic_type in network_model.VNIC_TYPES_DIRECT_PASSTHROUGH:"}],"source_content_type":"text/x-python","patch_set":20,"id":"5e03194a_0bd6afe3","line":196,"in_reply_to":"326e3384_df0a7d48","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            return None"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _get_packed_virtqueue_settings(self, image_meta, flavor):"},{"line_number":302,"context_line":"        \"\"\"A methods to set the packed virtqueue,"},{"line_number":303,"context_line":"           if it has been requested in extra specs."},{"line_number":304,"context_line":"        \"\"\""},{"line_number":305,"context_line":"        if not isinstance(image_meta, objects.ImageMeta):"}],"source_content_type":"text/x-python","patch_set":20,"id":"d80ea23f_c90bbdf8","line":302,"range":{"start_line":302,"start_character":13,"end_line":302,"end_character":20},"updated":"2023-08-02 13:59:16.000000000","message":"\"method\"\n\nAlso, the first line of the docstring is supposed to be a single sentence, followed by a blank line and then any other text below that. Again, I thought hacking would be complaining about this. Perhaps only because it\u0027s not \"public\"?\n\nhttps://peps.python.org/pep-0257/#multi-line-docstrings","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            return None"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _get_packed_virtqueue_settings(self, image_meta, flavor):"},{"line_number":302,"context_line":"        \"\"\"A methods to set the packed virtqueue,"},{"line_number":303,"context_line":"           if it has been requested in extra specs."},{"line_number":304,"context_line":"        \"\"\""},{"line_number":305,"context_line":"        if not isinstance(image_meta, objects.ImageMeta):"}],"source_content_type":"text/x-python","patch_set":20,"id":"79807377_9e2a1d06","line":302,"range":{"start_line":302,"start_character":13,"end_line":302,"end_character":20},"in_reply_to":"d80ea23f_c90bbdf8","updated":"2023-09-20 11:59:51.000000000","message":"Done, that check is an optional thing that is not part of pep8 there is a spereate pep that descitrbe how doc strings shoudl be formated which i dont think we enforce in ci. anyway this is now fixed.","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6b8c4334ed83509581dd0a1944232abba5a12d96","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        if not isinstance(image_meta, objects.ImageMeta):"},{"line_number":304,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(image_meta)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        if hardware.get_packed_virtqueue_constraint(flavor, image_meta):"},{"line_number":307,"context_line":"            return True"},{"line_number":308,"context_line":"        return None"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def get_bridge_name(self, vif):"},{"line_number":311,"context_line":"        return vif[\u0027network\u0027][\u0027bridge\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"bbc16931_615a579d","line":308,"range":{"start_line":306,"start_character":0,"end_line":308,"end_character":19},"updated":"2023-11-15 09:15:27.000000000","message":"This is strange logic. Even if the flavor explicitly set the packed option to False this code will return None which might mean \"no preference was provided\".","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f1ba358f6facdaad4507aeca79c9b1d2c9304474","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        if not isinstance(image_meta, objects.ImageMeta):"},{"line_number":304,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(image_meta)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        if hardware.get_packed_virtqueue_constraint(flavor, image_meta):"},{"line_number":307,"context_line":"            return True"},{"line_number":308,"context_line":"        return None"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def get_bridge_name(self, vif):"},{"line_number":311,"context_line":"        return vif[\u0027network\u0027][\u0027bridge\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"fd916b28_e8c1fbee","line":308,"range":{"start_line":306,"start_character":0,"end_line":308,"end_character":19},"in_reply_to":"bbc16931_615a579d","updated":"2023-11-29 18:37:17.000000000","message":"Done","commit_id":"8aca53bfcdd6e98e2891b5c50288b3774a44fdd6"}],"releasenotes/notes/packed-virtqueue-filter-43a376674cb5b345.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd864e3909e236d2c7a81dcc35818971811e4fed","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    https://libvirt.org/formatdomain.html#virtio-related-options"},{"line_number":17,"context_line":"    https://docs.oasis-open.org/virtio/virtio/v1.1/csprd01/virtio-v1.1-csprd01.html"},{"line_number":18,"context_line":"    https://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/virtio_packedring_configuration_support.html"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"47371065_c0a6db0d","line":19,"updated":"2023-05-18 19:41:15.000000000","message":"+1","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    https://libvirt.org/formatdomain.html#virtio-related-options"},{"line_number":17,"context_line":"    https://docs.oasis-open.org/virtio/virtio/v1.1/csprd01/virtio-v1.1-csprd01.html"},{"line_number":18,"context_line":"    https://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/virtio_packedring_configuration_support.html"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dd7ceba4_677442dd","line":19,"in_reply_to":"47371065_c0a6db0d","updated":"2023-05-29 11:17:31.000000000","message":"Ack","commit_id":"e37db11e07085462d22ecacd6431bcde44c5dd5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58bb5570b0edcadd7f33693fdbfc01686ae50392","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    VMs using virtio-net will see an increase in performance. The increase"},{"line_number":8,"context_line":"    can be anywhere between 10/20% (see DPDK Intel Vhost/virtio perf. reports)"},{"line_number":9,"context_line":"    and 75% (using Napatech SmartNICs)."},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    Packed Ring can be requested via image property or flavor extra spec."},{"line_number":12,"context_line":"    hw_virtio_packed_ring\u003dtrue|false  (default false)"},{"line_number":13,"context_line":"    hw:virtio_packed_ring\u003dtrue|false  (default false)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"39927295_18446911","line":10,"updated":"2023-05-29 11:17:31.000000000","message":"nit: whitespaces","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"28222b8fda328a7574651e743286ce977c30faef","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    VMs using virtio-net will see an increase in performance. The increase"},{"line_number":8,"context_line":"    can be anywhere between 10/20% (see DPDK Intel Vhost/virtio perf. reports)"},{"line_number":9,"context_line":"    and 75% (using Napatech SmartNICs)."},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    Packed Ring can be requested via image property or flavor extra spec."},{"line_number":12,"context_line":"    hw_virtio_packed_ring\u003dtrue|false  (default false)"},{"line_number":13,"context_line":"    hw:virtio_packed_ring\u003dtrue|false  (default false)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"193c3cb4_61d89f06","line":10,"in_reply_to":"39927295_18446911","updated":"2023-06-27 10:27:57.000000000","message":"Done","commit_id":"8964b2adf8e0c04b233bde5c64a7bf7f21804e43"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23f39819cbd6c4b58ac7642200d8b9a0636ea462","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    hw_virtio_packed_ring\u003dtrue|false  (default false)"},{"line_number":13,"context_line":"    hw:virtio_packed_ring\u003dtrue|false  (default false)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Usefull references:"},{"line_number":16,"context_line":"    https://libvirt.org/formatdomain.html#virtio-related-options"},{"line_number":17,"context_line":"    https://docs.oasis-open.org/virtio/virtio/v1.1/csprd01/virtio-v1.1-csprd01.html"},{"line_number":18,"context_line":"    https://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/virtio_packedring_configuration_support.html"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c345d503_05d2aa62","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":11},"updated":"2023-08-02 13:59:16.000000000","message":"\"Useful\"","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c1110900a90f8378cf97475a0d138b12e21523a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    hw_virtio_packed_ring\u003dtrue|false  (default false)"},{"line_number":13,"context_line":"    hw:virtio_packed_ring\u003dtrue|false  (default false)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    Usefull references:"},{"line_number":16,"context_line":"    https://libvirt.org/formatdomain.html#virtio-related-options"},{"line_number":17,"context_line":"    https://docs.oasis-open.org/virtio/virtio/v1.1/csprd01/virtio-v1.1-csprd01.html"},{"line_number":18,"context_line":"    https://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/virtio_packedring_configuration_support.html"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1eff3499_aef2f124","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":11},"in_reply_to":"c345d503_05d2aa62","updated":"2023-09-20 11:59:51.000000000","message":"Done","commit_id":"e73248edaf3d98f037260ab92ac3017e4dd32159"}]}