)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0b6a7601e678ecaa94690dadd4490d15844164c0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     René Ribaud \u003crribaud@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-20 14:34:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reproducers for bug 1869804"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds reproducers live migrated an instance and various combinations of"},{"line_number":10,"context_line":"cpu_shared_set configuration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f1153a7d_e69891a1","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":27},"updated":"2023-03-21 07:07:45.000000000","message":"If you use brief description instead of bug 1869804 will be better than now.","commit_id":"1fe55d2085ce5a9df0b71d73653b47ac79e1f5aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6265edec6b823855d97ed6e21666ae7c15e91eae","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     René Ribaud \u003crribaud@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-03-20 14:34:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reproducers for bug 1869804"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds reproducers live migrated an instance and various combinations of"},{"line_number":10,"context_line":"cpu_shared_set configuration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ee265f08_438b154f","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":27},"in_reply_to":"f1153a7d_e69891a1","updated":"2023-03-22 17:15:24.000000000","message":"I have added a description of the bug below. Let me know if it is not ok.","commit_id":"1fe55d2085ce5a9df0b71d73653b47ac79e1f5aa"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0b6a7601e678ecaa94690dadd4490d15844164c0","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This also adds the required changes to the libvirt fixture to manage"},{"line_number":16,"context_line":"cpuset inside the vcpu tag."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib294a9d3c25b9a8548347dbe00416a55db567773"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0aa06415_7e2b3aed","line":17,"updated":"2023-03-21 07:07:45.000000000","message":"Related-Bug: #1869804","commit_id":"1fe55d2085ce5a9df0b71d73653b47ac79e1f5aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6265edec6b823855d97ed6e21666ae7c15e91eae","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This also adds the required changes to the libvirt fixture to manage"},{"line_number":16,"context_line":"cpuset inside the vcpu tag."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib294a9d3c25b9a8548347dbe00416a55db567773"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"01cea82f_6c0e90c8","line":17,"in_reply_to":"0aa06415_7e2b3aed","updated":"2023-03-22 17:15:24.000000000","message":"Done","commit_id":"1fe55d2085ce5a9df0b71d73653b47ac79e1f5aa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c31db178fd5a109c7211b28176fcb5f9677d4824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"072b2444_0e434a11","updated":"2023-03-17 16:21:24.000000000","message":"Overall looks good, left a note and an idea inline.\n\nAlso, while I understand why we need different classes for each test (different order of host startup, different config flags), it turns out to be more confusing to read that I thought. I would either add comments, or switch to a single class, and just have the test methods do their own setup instead of using setUp().","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d60b844aca11e26942406a4aafc14b8b6d80982f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c59e9b1_5c4a7363","updated":"2023-03-17 20:02:11.000000000","message":"Looks good, just the inline nit if you happen to respin.","commit_id":"6e494d6ba774cd519a975ed3935f664cc9bfd36a"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9a24e8b2ddf89a343a4ea0f985ddb1757f093b2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0daaeefc_d3cc44ec","updated":"2023-03-20 19:31:51.000000000","message":"Thanks for the comment fixes, I\u0027m still happy with this!","commit_id":"1fe55d2085ce5a9df0b71d73653b47ac79e1f5aa"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"9025c7c30cab54f04b540179038f27f530cd9be6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3cb91ed_2707f9c6","updated":"2023-03-22 17:18:13.000000000","message":"recheck","commit_id":"fca05591c0e0b4add4492b31133b1705056f9cb4"}],"nova/tests/functional/libvirt/test_live_migration.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c31db178fd5a109c7211b28176fcb5f9677d4824","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    \"\"\""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":227,"context_line":"    microversion \u003d \u00272.74\u0027"},{"line_number":228,"context_line":"    ADMIN_API \u003d True"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d861e9d_0f941a62","line":227,"updated":"2023-03-17 16:21:24.000000000","message":"nit: maybe a note on why we need this microversion","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"771b1a40e8392c7e91e71e0601122d72a7dd5984","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    \"\"\""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":227,"context_line":"    microversion \u003d \u00272.74\u0027"},{"line_number":228,"context_line":"    ADMIN_API \u003d True"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"2fc8a447_a7b78417","line":227,"in_reply_to":"1d861e9d_0f941a62","updated":"2023-03-17 16:29:08.000000000","message":"To be honest I don\u0027t know. 😊\nI have just copy/paste from existing tests.","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6b53d3c6389704a9d2d577a128bdff8c4b6ca632","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    \"\"\""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":227,"context_line":"    microversion \u003d \u00272.74\u0027"},{"line_number":228,"context_line":"    ADMIN_API \u003d True"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"72f5e456_f6221084","line":227,"in_reply_to":"21a0e4d1_a4904118","updated":"2023-03-20 15:08:49.000000000","message":"Done","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d60b844aca11e26942406a4aafc14b8b6d80982f","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    \"\"\""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":227,"context_line":"    microversion \u003d \u00272.74\u0027"},{"line_number":228,"context_line":"    ADMIN_API \u003d True"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"21a0e4d1_a4904118","line":227,"in_reply_to":"2fc8a447_a7b78417","updated":"2023-03-17 20:02:11.000000000","message":"It\u0027s to boot a server on a specific host [1], which is indeed used here, so just add a comment explaining that.\n\n[1] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"271e8626aecf64637f900b55dd39c0d4c9a20e60","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        server \u003d self.api.get_server(server_id)"},{"line_number":291,"context_line":"        return server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def test_live_migration(self):"},{"line_number":294,"context_line":"        self.server \u003d self._create_server(host\u003d\u0027src\u0027, networks\u003d\u0027none\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        conn \u003d self.src.driver._host.get_connection()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6281ab7f_52a463f8","line":293,"updated":"2023-03-17 09:38:10.000000000","message":"This test is passing but does not show the real issue.\nFlag configuration is global for both nodes and not unset on the destination node.\nI\u0027m still working on that one but leave it as is for a first-round review.","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"771b1a40e8392c7e91e71e0601122d72a7dd5984","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        server \u003d self.api.get_server(server_id)"},{"line_number":291,"context_line":"        return server[\u0027OS-EXT-SRV-ATTR:host\u0027]"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def test_live_migration(self):"},{"line_number":294,"context_line":"        self.server \u003d self._create_server(host\u003d\u0027src\u0027, networks\u003d\u0027none\u0027)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        conn \u003d self.src.driver._host.get_connection()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c3eb59d_8bfcf808","line":293,"in_reply_to":"6281ab7f_52a463f8","updated":"2023-03-17 16:29:08.000000000","message":"Done","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ee0cb2ff656010a35efa4de2aebd95966b2397e9","unresolved":true,"context_lines":[{"line_number":222,"context_line":"    destination host with a different cpu_shared_set should be updated to use"},{"line_number":223,"context_line":"    the destination cpu_shared_set."},{"line_number":224,"context_line":"    \"\"\""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":227,"context_line":"    # Microversion 2.74 is required to boot a server on a specific host,"},{"line_number":228,"context_line":"    # which is used in the below tests."}],"source_content_type":"text/x-python","patch_set":4,"id":"5eb82c2b_bf235461","line":225,"updated":"2023-03-22 16:47:24.000000000","message":"As setup and get_host method are almost same (flag)\ncan we have a single class having 3 TC\u0027s, something like\ntest_live_mig_diff_cpu_share_set()\ntest_live_mig_no_cpu_share_set()\ntest_live_mig_no_cpu_share_set_to_share_set()","commit_id":"fca05591c0e0b4add4492b31133b1705056f9cb4"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"081b27ffe909ff62573fe24a986ffb3f316189b0","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    destination host with a different cpu_shared_set should be updated to use"},{"line_number":223,"context_line":"    the destination cpu_shared_set."},{"line_number":224,"context_line":"    \"\"\""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":227,"context_line":"    # Microversion 2.74 is required to boot a server on a specific host,"},{"line_number":228,"context_line":"    # which is used in the below tests."}],"source_content_type":"text/x-python","patch_set":4,"id":"30b025f0_5e444ba8","line":225,"in_reply_to":"5eb82c2b_bf235461","updated":"2023-03-22 19:35:17.000000000","message":"Thank you Amit for pointing out this issue to me. The setups were slightly different, but I unified them to have only one class.","commit_id":"fca05591c0e0b4add4492b31133b1705056f9cb4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"874c9e4e4cbfceb93b037ec292a2e4d68402690b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        \"\"\""},{"line_number":246,"context_line":"        self.flags(cpu_shared_set\u003d\u00270,1\u0027, group\u003d\u0027compute\u0027)"},{"line_number":247,"context_line":"        self.restart_compute_service(\u0027src\u0027)"},{"line_number":248,"context_line":"        self.restart_compute_service(\u0027dest\u0027)"},{"line_number":249,"context_line":"        self.server \u003d self._create_server(host\u003d\u0027src\u0027, networks\u003d\u0027none\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        conn \u003d self.src.driver._host.get_connection()"}],"source_content_type":"text/x-python","patch_set":6,"id":"13136011_ed8a792c","line":248,"updated":"2024-03-11 13:49:29.000000000","message":"I don\u0027t get why we need to update this config here if we change it later, but OK.","commit_id":"5b7dde4379092a40b473e2a45092ba3d13a93846"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"874c9e4e4cbfceb93b037ec292a2e4d68402690b","unresolved":true,"context_lines":[{"line_number":261,"context_line":"        conn \u003d self.dest.driver._host.get_connection()"},{"line_number":262,"context_line":"        dom \u003d conn.lookupByUUIDString(self.server[\u0027id\u0027])"},{"line_number":263,"context_line":"        xml \u003d dom.XMLDesc(0)"},{"line_number":264,"context_line":"        # The destination should be updated to \"3-4\" but it is not the case."},{"line_number":265,"context_line":"        self.assertIn(\u0027\u003cvcpu cpuset\u003d\"0-1\"\u003e1\u003c/vcpu\u003e\u0027, xml)"},{"line_number":266,"context_line":"        self.assertNotIn(\u0027\u003cvcpu cpuset\u003d\"3-4\"\u003e1\u003c/vcpu\u003e\u0027, xml)"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"725732d8_787e713c","line":264,"range":{"start_line":264,"start_character":8,"end_line":264,"end_character":10},"updated":"2024-03-11 13:49:29.000000000","message":"nit : usually, we add a FIXME(artom) to explain we\u0027ll fix it in a later change, but meh to me.","commit_id":"5b7dde4379092a40b473e2a45092ba3d13a93846"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a4a756d0a6fb5a222d44d1f4c6a12ebe28a3ed0","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        xml \u003d dom.XMLDesc(0)"},{"line_number":264,"context_line":"        # The destination should be updated to \"3-4\" but it is not the case."},{"line_number":265,"context_line":"        self.assertIn(\u0027\u003cvcpu cpuset\u003d\"0-1\"\u003e1\u003c/vcpu\u003e\u0027, xml)"},{"line_number":266,"context_line":"        self.assertNotIn(\u0027\u003cvcpu cpuset\u003d\"3-4\"\u003e1\u003c/vcpu\u003e\u0027, xml)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def test_live_migration_to_no_cpu_shared_set(self):"},{"line_number":269,"context_line":"        \"\"\"Reproducer for bug 1869804 #2."}],"source_content_type":"text/x-python","patch_set":6,"id":"c5489a8b_1c25f6da","line":266,"updated":"2023-12-21 01:43:01.000000000","message":"very good test.\n\nwe have to be careful with updatign the config and restarting the compute service like that as it can break the resouce tracker and placment if there are instances on the host however if its empty like this its fine","commit_id":"5b7dde4379092a40b473e2a45092ba3d13a93846"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"874c9e4e4cbfceb93b037ec292a2e4d68402690b","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        self.restart_compute_service(\u0027dest\u0027)"},{"line_number":277,"context_line":"        self.server \u003d self._create_server(host\u003d\u0027src\u0027, networks\u003d\u0027none\u0027)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        self.reset_flags(\u0027cpu_shared_set\u0027, group\u003d\u0027compute\u0027)"},{"line_number":280,"context_line":"        self.restart_compute_service(\u0027src\u0027)"},{"line_number":281,"context_line":"        self.restart_compute_service(\u0027dest\u0027)"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"209a426f_12332904","line":279,"updated":"2024-03-11 13:49:29.000000000","message":"note to myself: OK, I see why you want to have a new reset_flags() method.","commit_id":"5b7dde4379092a40b473e2a45092ba3d13a93846"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"874c9e4e4cbfceb93b037ec292a2e4d68402690b","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        conn \u003d self.dest.driver._host.get_connection()"},{"line_number":302,"context_line":"        dom \u003d conn.lookupByUUIDString(self.server[\u0027id\u0027])"},{"line_number":303,"context_line":"        xml \u003d dom.XMLDesc(0)"},{"line_number":304,"context_line":"        # The destination cpuset should be removed because the"},{"line_number":305,"context_line":"        # host has no cpu_shared_set configured. Which is not the case due to"},{"line_number":306,"context_line":"        # the bug."},{"line_number":307,"context_line":"        self.assertIn(\u0027\u003cvcpu cpuset\u003d\"0-1\"\u003e1\u003c/vcpu\u003e\u0027, xml)"}],"source_content_type":"text/x-python","patch_set":6,"id":"26ccf917_1895b479","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":10},"updated":"2024-03-11 13:49:29.000000000","message":"nit: ditto here, miss a FIXME.","commit_id":"5b7dde4379092a40b473e2a45092ba3d13a93846"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a4a756d0a6fb5a222d44d1f4c6a12ebe28a3ed0","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        # host has no cpu_shared_set configured. Which is not the case due to"},{"line_number":306,"context_line":"        # the bug."},{"line_number":307,"context_line":"        self.assertIn(\u0027\u003cvcpu cpuset\u003d\"0-1\"\u003e1\u003c/vcpu\u003e\u0027, xml)"},{"line_number":308,"context_line":"        self.assertNotIn(\u0027\u003cvcpu\u003e1\u003c/vcpu\u003e\u0027, xml)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def test_live_migration_from_no_cpu_shared_set_to_cpu_shared_set(self):"},{"line_number":311,"context_line":"        \"\"\"Reproducer for bug 1869804 #3."}],"source_content_type":"text/x-python","patch_set":6,"id":"8186c931_2c74644c","line":308,"updated":"2023-12-21 01:43:01.000000000","message":"yep this is also true we should be removing it","commit_id":"5b7dde4379092a40b473e2a45092ba3d13a93846"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a4a756d0a6fb5a222d44d1f4c6a12ebe28a3ed0","unresolved":true,"context_lines":[{"line_number":330,"context_line":"        xml \u003d dom.XMLDesc(0)"},{"line_number":331,"context_line":"        # The destination should be updated to \"0-1\"."},{"line_number":332,"context_line":"        self.assertIn(\u0027\u003cvcpu\u003e1\u003c/vcpu\u003e\u0027, xml)"},{"line_number":333,"context_line":"        self.assertNotIn(\u0027\u003cvcpu cpuset\u003d\"0-1\"\u003e1\u003c/vcpu\u003e\u0027, xml)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e53d97eb_17bff1e4","line":333,"updated":"2023-12-21 01:43:01.000000000","message":"+1 you have coverd the 3 imporant test cases\n\nthe other one where the vaules are the same on both hosts is tested elsewhere and works today so we dont need to test that here","commit_id":"5b7dde4379092a40b473e2a45092ba3d13a93846"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c31db178fd5a109c7211b28176fcb5f9677d4824","unresolved":true,"context_lines":[{"line_number":7799,"context_line":"            # TODO(stephenfin): Remove this in U"},{"line_number":7800,"context_line":"            shared_cpus \u003d hardware.get_vcpu_pin_set()"},{"line_number":7801,"context_line":"        elif CONF.compute.cpu_shared_set:"},{"line_number":7802,"context_line":"            shared_cpus \u003d hardware.get_cpu_shared_set()"},{"line_number":7803,"context_line":"        elif CONF.compute.cpu_dedicated_set:"},{"line_number":7804,"context_line":"            return set()"},{"line_number":7805,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7167778a_224b9499","line":7802,"updated":"2023-03-17 16:21:24.000000000","message":"I suspect you\u0027ll have no choice but to mock this method in the libvirt driver of the host you want to have no cpu_shared_set to return None. I don\u0027t see a way around the global CONF object.","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6265edec6b823855d97ed6e21666ae7c15e91eae","unresolved":false,"context_lines":[{"line_number":7799,"context_line":"            # TODO(stephenfin): Remove this in U"},{"line_number":7800,"context_line":"            shared_cpus \u003d hardware.get_vcpu_pin_set()"},{"line_number":7801,"context_line":"        elif CONF.compute.cpu_shared_set:"},{"line_number":7802,"context_line":"            shared_cpus \u003d hardware.get_cpu_shared_set()"},{"line_number":7803,"context_line":"        elif CONF.compute.cpu_dedicated_set:"},{"line_number":7804,"context_line":"            return set()"},{"line_number":7805,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd19d28d_e27d26ee","line":7802,"in_reply_to":"05aa6af4_2bfa1061","updated":"2023-03-22 17:15:24.000000000","message":"Done","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"771b1a40e8392c7e91e71e0601122d72a7dd5984","unresolved":true,"context_lines":[{"line_number":7799,"context_line":"            # TODO(stephenfin): Remove this in U"},{"line_number":7800,"context_line":"            shared_cpus \u003d hardware.get_vcpu_pin_set()"},{"line_number":7801,"context_line":"        elif CONF.compute.cpu_shared_set:"},{"line_number":7802,"context_line":"            shared_cpus \u003d hardware.get_cpu_shared_set()"},{"line_number":7803,"context_line":"        elif CONF.compute.cpu_dedicated_set:"},{"line_number":7804,"context_line":"            return set()"},{"line_number":7805,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"05aa6af4_2bfa1061","line":7802,"in_reply_to":"7167778a_224b9499","updated":"2023-03-17 16:29:08.000000000","message":"I have added a reset_flags helper to remove this mock. Please have a look and tell me what you think about it.","commit_id":"742663bf8586886a6f19200760bed3a5d5699051"}]}