)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d9a400bde7a4820e4f1ebfdbe120b2fc82d16a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"709c7593_d3986363","updated":"2023-04-06 10:32:45.000000000","message":"functionl test fail with a data race \"Cursor needed to be reset because of commit/rollback and can no longer be fetched from.\" in the placement fixture?\n\nthis might be related to this change.\nwe might be leaking the placement client between each test","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"981b6e7d2af54f740aaa0cc0db6e3badb9d467ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71ebc726_9a133976","updated":"2023-03-23 11:27:21.000000000","message":"i have not looked at the tests but the code looks reasonable.\nthis is small enough that im not really sure a release note is needed.\nill loop back to this after the ptg. ","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"23f33e9f3aa33d5bf685bc4d456f7607ebf6a95e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3db695d_2cc9e966","updated":"2023-04-04 17:28:27.000000000","message":"looks good. Thanks!","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f8bba726d3a1f35ae18625f22b7eaff82df8d227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d1460f8_709cf503","updated":"2023-04-06 17:33:28.000000000","message":"recheck","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"03324c120725d2daa63dca439fd042328811797f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e758cf5_53156f50","updated":"2023-04-06 19:25:55.000000000","message":"recheck clearly unrelated to scheduler startup","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9133d36fc093f78e82e2aba5fed4e79752485b05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8808ad19_96381d1b","updated":"2023-04-07 12:41:15.000000000","message":"recheck guest not sshable","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"68ab9c973ddbfbf11d95ee3ded4304642ee126db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34e50003_4230bde3","updated":"2023-04-07 17:02:03.000000000","message":"recheck job timeout","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f1fdcfe04ae7d3a0fc26590847648a39c7d68659","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"962342c0_1c3c4962","updated":"2023-04-09 17:43:45.000000000","message":"recheck nova-grenade-multinode","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"874f3e9c6a97e8c351926735f3e903d327386b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"90aacdd0_10f13042","updated":"2023-04-10 17:28:54.000000000","message":"recheck post_failure","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f49d966d42c68ad5b344c2ba992808c516fa9700","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecba363c_89f090b6","updated":"2023-04-05 19:40:47.000000000","message":"recheck unrelated guest kernel crash","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ddb80b204aeb28778add671452b76798a8eb64ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a5af4ff_6b136c94","updated":"2023-04-05 17:29:41.000000000","message":"thanks dan this looks good to me","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"}],"nova/scheduler/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"981b6e7d2af54f740aaa0cc0db6e3badb9d467ee","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            # Test our placement client during initialization"},{"line_number":75,"context_line":"            self.placement_client"},{"line_number":76,"context_line":"        except (ks_exc.EndpointNotFound,"},{"line_number":77,"context_line":"                ks_exc.DiscoveryFailure,"},{"line_number":78,"context_line":"                ks_exc.RequestTimeout,"},{"line_number":79,"context_line":"                ks_exc.GatewayTimeout,"},{"line_number":80,"context_line":"                ks_exc.ConnectFailure) as e:"},{"line_number":81,"context_line":"            # Non-fatal, likely transient (although not definitely);"},{"line_number":82,"context_line":"            # continue startup but log the warning so that when things"},{"line_number":83,"context_line":"            # fail later, it will be clear why we can not do certain"}],"source_content_type":"text/x-python","patch_set":1,"id":"f024550b_124600ca","line":80,"range":{"start_line":76,"start_character":7,"end_line":80,"end_character":44},"updated":"2023-03-23 11:27:21.000000000","message":"ok so this insulates use for keystone not being avaiable right now as well","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"981b6e7d2af54f740aaa0cc0db6e3badb9d467ee","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            LOG.warning(\u0027Unable to initialize placement client (%s); \u0027"},{"line_number":86,"context_line":"                        \u0027Continuing with startup, but scheduling \u0027"},{"line_number":87,"context_line":"                        \u0027will not be possible.\u0027, e)"},{"line_number":88,"context_line":"        except (ks_exc.MissingAuthPlugin,"},{"line_number":89,"context_line":"                ks_exc.Unauthorized) as e:"},{"line_number":90,"context_line":"            # This is almost definitely fatal mis-configuration. The"},{"line_number":91,"context_line":"            # Unauthorized error might be transient, but it is"},{"line_number":92,"context_line":"            # probably reasonable to consider it fatal."},{"line_number":93,"context_line":"            LOG.error(\u0027Fatal error initializing placement client; \u0027"},{"line_number":94,"context_line":"                      \u0027config is incorrect or incomplete: %s\u0027, e)"},{"line_number":95,"context_line":"            raise"},{"line_number":96,"context_line":"        except Exception as e:"},{"line_number":97,"context_line":"            # Unknown/unexpected errors here are fatal"},{"line_number":98,"context_line":"            LOG.error(\u0027Fatal error initializing placement client: %s\u0027, e)"},{"line_number":99,"context_line":"            raise"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        super().__init__(service_name\u003d\u0027scheduler\u0027, *args, **kwargs)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f69a414_f1660e49","line":99,"range":{"start_line":88,"start_character":2,"end_line":99,"end_character":17},"updated":"2023-03-23 11:27:21.000000000","message":"ah ok i was going to ask why not od this in the property but ok we ignore if placment is not aviabel but hard fail if the cofnig is wrong","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2f405fe3329a51f84043460b53ccef7b324c544","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            LOG.warning(\u0027Unable to initialize placement client (%s); \u0027"},{"line_number":86,"context_line":"                        \u0027Continuing with startup, but scheduling \u0027"},{"line_number":87,"context_line":"                        \u0027will not be possible.\u0027, e)"},{"line_number":88,"context_line":"        except (ks_exc.MissingAuthPlugin,"},{"line_number":89,"context_line":"                ks_exc.Unauthorized) as e:"},{"line_number":90,"context_line":"            # This is almost definitely fatal mis-configuration. The"},{"line_number":91,"context_line":"            # Unauthorized error might be transient, but it is"},{"line_number":92,"context_line":"            # probably reasonable to consider it fatal."},{"line_number":93,"context_line":"            LOG.error(\u0027Fatal error initializing placement client; \u0027"},{"line_number":94,"context_line":"                      \u0027config is incorrect or incomplete: %s\u0027, e)"},{"line_number":95,"context_line":"            raise"},{"line_number":96,"context_line":"        except Exception as e:"},{"line_number":97,"context_line":"            # Unknown/unexpected errors here are fatal"},{"line_number":98,"context_line":"            LOG.error(\u0027Fatal error initializing placement client: %s\u0027, e)"},{"line_number":99,"context_line":"            raise"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        super().__init__(service_name\u003d\u0027scheduler\u0027, *args, **kwargs)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"75f654d4_bb4ab417","line":99,"range":{"start_line":88,"start_character":2,"end_line":99,"end_character":17},"in_reply_to":"9f69a414_f1660e49","updated":"2023-03-23 13:48:25.000000000","message":"Yeah, and I copied the conductor behavior, FWIW. The goal is to make this raise for fundamental problems (to abort startup for config or other things), but not for keystone or placement being down. However, we want the property to raise everything so that subsequent failures get logged (and is catchable) fully after we\u0027ve finished startup.","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"}],"nova/tests/unit/scheduler/test_manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25e95d6c098586909942152d267f9c2a7024a0fc","unresolved":true,"context_lines":[{"line_number":1689,"context_line":"        mock_log_warning.assert_not_called()"},{"line_number":1690,"context_line":"        mock_log_debug.assert_called_once_with(msg)"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    @mock.patch(\u0027nova.scheduler.client.report.report_client_singleton\u0027)"},{"line_number":1693,"context_line":"    @mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":1694,"context_line":"    @mock.patch(\u0027nova.scheduler.host_manager.HostManager\u0027)"},{"line_number":1695,"context_line":"    @mock.patch(\u0027nova.servicegroup.API\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"33857cd2_cc9d56a4","line":1692,"updated":"2023-04-06 10:38:58.000000000","message":"i think we need to rest the singleton in the base test case setup function\ni think that is what \nhttps://github.com/openstack/nova/blob/master/nova/test.py#L306-L307\n\nbut the lazy loading seams to have altered that behavior","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d71cca4638b3a689a3e8b854677785de8b077c80","unresolved":true,"context_lines":[{"line_number":1689,"context_line":"        mock_log_warning.assert_not_called()"},{"line_number":1690,"context_line":"        mock_log_debug.assert_called_once_with(msg)"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    @mock.patch(\u0027nova.scheduler.client.report.report_client_singleton\u0027)"},{"line_number":1693,"context_line":"    @mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":1694,"context_line":"    @mock.patch(\u0027nova.scheduler.host_manager.HostManager\u0027)"},{"line_number":1695,"context_line":"    @mock.patch(\u0027nova.servicegroup.API\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"431015a8_f8f49b73","line":1692,"in_reply_to":"33857cd2_cc9d56a4","updated":"2023-04-06 14:38:19.000000000","message":"I don\u0027t think so, especially since we\u0027re using the same singleton behavior as we put in place for conductor. Also, this message has been showing up plenty of other places in nova functional jobs:\n\nhttps://opensearch.logs.openstack.org/_dashboards/app/discover#/?_g\u003d(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-30d,to:now))\u0026_a\u003d(columns:!(hosts_region,project),filters:!((\u0027$state\u0027:(store:appState),meta:(alias:!n,disabled:!f,index:\u002794869730-aea8-11ec-9e6a-83741af3fdcd\u0027,key:project,negate:!f,params:(query:openstack%2Fnova),type:phrase),query:(match_phrase:(project:openstack%2Fnova)))),index:\u002794869730-aea8-11ec-9e6a-83741af3fdcd\u0027,interval:d,query:(language:kuery,query:\u0027message:%22Cursor%20needed%20to%20be%20reset%22\u0027),sort:!())","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f8bba726d3a1f35ae18625f22b7eaff82df8d227","unresolved":true,"context_lines":[{"line_number":1689,"context_line":"        mock_log_warning.assert_not_called()"},{"line_number":1690,"context_line":"        mock_log_debug.assert_called_once_with(msg)"},{"line_number":1691,"context_line":""},{"line_number":1692,"context_line":"    @mock.patch(\u0027nova.scheduler.client.report.report_client_singleton\u0027)"},{"line_number":1693,"context_line":"    @mock.patch.object(manager, \u0027LOG\u0027)"},{"line_number":1694,"context_line":"    @mock.patch(\u0027nova.scheduler.host_manager.HostManager\u0027)"},{"line_number":1695,"context_line":"    @mock.patch(\u0027nova.servicegroup.API\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4349f87_af9a4483","line":1692,"in_reply_to":"431015a8_f8f49b73","updated":"2023-04-06 17:33:28.000000000","message":"looking at that i think im happy that its not intoduced by this change","commit_id":"d37cca361a4d575311318cb870da40079eb1617c"}]}