)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b38557a314299016cea0752814959f93b7baa66","unresolved":true,"context_lines":[{"line_number":9,"context_line":"These fields haven\u0027t been used for scheduling for many releases. Yet,"},{"line_number":10,"context_line":"the virt driver still verifies their values and sets the corresponding"},{"line_number":11,"context_line":"values from the flavor to instance_info (where they, to the best of my"},{"line_number":12,"context_line":"knowledge, have never been used for anything)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2588b55c19fb31734dd66b36bd149022f1ccdcc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2ab18f0a_01229f28","line":12,"updated":"2026-05-29 17:21:58.000000000","message":"actully we have recomemnd setign the correct flavor values to make the ironic sku for documation reasosn and or billing.\n\ni.e. for thing like the simple teneant usage api where you caluatle things like cpu hours and such.\n\nso to me this is not really impvoing anyting useful but it might break some workflows.\n\ni haveent really had tiem to look at teh effectct fo this end to end but i wonder what do we geain but making this change?","commit_id":"3ee7280098af682c68be54d6a29d893c162627c5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"01ab5ca1aac5e5948e45fac9a6e3f4757c62a766","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97aa014f_77b192ec","updated":"2023-03-23 14:38:40.000000000","message":"This looks sane to me, but we should get some extra eyes on this. \n\nJohn, does this look good to you?","commit_id":"60da0fdd667be2aed11aee2c9882b47f768bfb0a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3d0f2b1ff9eb485eebdfe5e9a3ad403eda40d860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d7d06c8_9fbb342f","updated":"2023-11-28 18:27:35.000000000","message":"recheck","commit_id":"60da0fdd667be2aed11aee2c9882b47f768bfb0a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a61e9c6e7b531fad016d9fd8a94c520872f95800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"660bf043_f578b486","updated":"2023-03-28 09:54:19.000000000","message":"recheck","commit_id":"60da0fdd667be2aed11aee2c9882b47f768bfb0a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f189c2a990c38bc4f7185aeba96f23b3769f95eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dddbf21a_d4643623","updated":"2024-02-23 12:09:57.000000000","message":"recheck","commit_id":"3ee7280098af682c68be54d6a29d893c162627c5"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b38557a314299016cea0752814959f93b7baa66","unresolved":true,"context_lines":[{"line_number":313,"context_line":"                    LOG.warning(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":314,"context_line":"                                \"Format should be \u0027key:val\u0027.\", capability)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        dic \u003d {"},{"line_number":317,"context_line":"            \u0027uuid\u0027: str(node.id),"},{"line_number":318,"context_line":"            \u0027hypervisor_hostname\u0027: str(node.id),"},{"line_number":319,"context_line":"            \u0027hypervisor_type\u0027: self._get_hypervisor_type(),"},{"line_number":320,"context_line":"            \u0027hypervisor_version\u0027: self._get_hypervisor_version(),"},{"line_number":321,"context_line":"            \u0027resource_class\u0027: node.resource_class,"},{"line_number":322,"context_line":"            # The Ironic driver manages multiple hosts, so there are"},{"line_number":323,"context_line":"            # likely many different CPU models in use. As such it is"},{"line_number":324,"context_line":"            # impossible to provide any meaningful info on the CPU"},{"line_number":325,"context_line":"            # model of the \"host\""},{"line_number":326,"context_line":"            \u0027cpu_info\u0027: None,"},{"line_number":327,"context_line":"            \u0027vcpus\u0027: 0,"},{"line_number":328,"context_line":"            \u0027vcpus_used\u0027: 0,"},{"line_number":329,"context_line":"            \u0027local_gb\u0027: 0,"},{"line_number":330,"context_line":"            \u0027local_gb_used\u0027: 0,"},{"line_number":331,"context_line":"            \u0027disk_available_least\u0027: 0,"},{"line_number":332,"context_line":"            \u0027memory_mb\u0027: 0,"},{"line_number":333,"context_line":"            \u0027memory_mb_used\u0027: 0,"},{"line_number":334,"context_line":"            \u0027supported_instances\u0027: _get_nodes_supported_instances(cpu_arch),"},{"line_number":335,"context_line":"            \u0027stats\u0027: nodes_extra_specs,"},{"line_number":336,"context_line":"            \u0027numa_topology\u0027: None,"},{"line_number":337,"context_line":"        }"},{"line_number":338,"context_line":"        return dic"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _set_instance_id(self, node, instance):"},{"line_number":341,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6e34e685_69eeb452","line":338,"range":{"start_line":316,"start_character":7,"end_line":338,"end_character":18},"updated":"2026-05-29 17:21:58.000000000","message":"i woudl have to check how this is used but is this used to populate the data sued for the hyperviors api respocne?\n\nthat is not something we likely shoudl change without a new api microversion or at least a wider discusion first.\n\nif this is just the resouce info sent to the scduerl im not sure thye really buy use anything as  we are still sedign the same number of feild now with just less useful data","commit_id":"3ee7280098af682c68be54d6a29d893c162627c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fb8110269fd8e4215fa30257fbfb3849f28cfb0d","unresolved":true,"context_lines":[{"line_number":313,"context_line":"                    LOG.warning(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":314,"context_line":"                                \"Format should be \u0027key:val\u0027.\", capability)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        dic \u003d {"},{"line_number":317,"context_line":"            \u0027uuid\u0027: str(node.id),"},{"line_number":318,"context_line":"            \u0027hypervisor_hostname\u0027: str(node.id),"},{"line_number":319,"context_line":"            \u0027hypervisor_type\u0027: self._get_hypervisor_type(),"},{"line_number":320,"context_line":"            \u0027hypervisor_version\u0027: self._get_hypervisor_version(),"},{"line_number":321,"context_line":"            \u0027resource_class\u0027: node.resource_class,"},{"line_number":322,"context_line":"            # The Ironic driver manages multiple hosts, so there are"},{"line_number":323,"context_line":"            # likely many different CPU models in use. As such it is"},{"line_number":324,"context_line":"            # impossible to provide any meaningful info on the CPU"},{"line_number":325,"context_line":"            # model of the \"host\""},{"line_number":326,"context_line":"            \u0027cpu_info\u0027: None,"},{"line_number":327,"context_line":"            \u0027vcpus\u0027: 0,"},{"line_number":328,"context_line":"            \u0027vcpus_used\u0027: 0,"},{"line_number":329,"context_line":"            \u0027local_gb\u0027: 0,"},{"line_number":330,"context_line":"            \u0027local_gb_used\u0027: 0,"},{"line_number":331,"context_line":"            \u0027disk_available_least\u0027: 0,"},{"line_number":332,"context_line":"            \u0027memory_mb\u0027: 0,"},{"line_number":333,"context_line":"            \u0027memory_mb_used\u0027: 0,"},{"line_number":334,"context_line":"            \u0027supported_instances\u0027: _get_nodes_supported_instances(cpu_arch),"},{"line_number":335,"context_line":"            \u0027stats\u0027: nodes_extra_specs,"},{"line_number":336,"context_line":"            \u0027numa_topology\u0027: None,"},{"line_number":337,"context_line":"        }"},{"line_number":338,"context_line":"        return dic"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _set_instance_id(self, node, instance):"},{"line_number":341,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"cc76d704_dadc031a","line":338,"range":{"start_line":316,"start_character":7,"end_line":338,"end_character":18},"in_reply_to":"6e34e685_69eeb452","updated":"2026-07-08 15:48:30.000000000","message":"You see that the values are hardcoded to zeroes on lines 325-327","commit_id":"3ee7280098af682c68be54d6a29d893c162627c5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e697f317219bd1c695c239cc4259f04ce2ebc57","unresolved":true,"context_lines":[{"line_number":313,"context_line":"                    LOG.warning(\"Ignoring malformed capability \u0027%s\u0027. \""},{"line_number":314,"context_line":"                                \"Format should be \u0027key:val\u0027.\", capability)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        dic \u003d {"},{"line_number":317,"context_line":"            \u0027uuid\u0027: str(node.id),"},{"line_number":318,"context_line":"            \u0027hypervisor_hostname\u0027: str(node.id),"},{"line_number":319,"context_line":"            \u0027hypervisor_type\u0027: self._get_hypervisor_type(),"},{"line_number":320,"context_line":"            \u0027hypervisor_version\u0027: self._get_hypervisor_version(),"},{"line_number":321,"context_line":"            \u0027resource_class\u0027: node.resource_class,"},{"line_number":322,"context_line":"            # The Ironic driver manages multiple hosts, so there are"},{"line_number":323,"context_line":"            # likely many different CPU models in use. As such it is"},{"line_number":324,"context_line":"            # impossible to provide any meaningful info on the CPU"},{"line_number":325,"context_line":"            # model of the \"host\""},{"line_number":326,"context_line":"            \u0027cpu_info\u0027: None,"},{"line_number":327,"context_line":"            \u0027vcpus\u0027: 0,"},{"line_number":328,"context_line":"            \u0027vcpus_used\u0027: 0,"},{"line_number":329,"context_line":"            \u0027local_gb\u0027: 0,"},{"line_number":330,"context_line":"            \u0027local_gb_used\u0027: 0,"},{"line_number":331,"context_line":"            \u0027disk_available_least\u0027: 0,"},{"line_number":332,"context_line":"            \u0027memory_mb\u0027: 0,"},{"line_number":333,"context_line":"            \u0027memory_mb_used\u0027: 0,"},{"line_number":334,"context_line":"            \u0027supported_instances\u0027: _get_nodes_supported_instances(cpu_arch),"},{"line_number":335,"context_line":"            \u0027stats\u0027: nodes_extra_specs,"},{"line_number":336,"context_line":"            \u0027numa_topology\u0027: None,"},{"line_number":337,"context_line":"        }"},{"line_number":338,"context_line":"        return dic"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _set_instance_id(self, node, instance):"},{"line_number":341,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"27e9c0d6_25f25e32","line":338,"range":{"start_line":316,"start_character":7,"end_line":338,"end_character":18},"in_reply_to":"cc76d704_dadc031a","updated":"2026-07-08 16:01:03.000000000","message":"oh your right they are, i guess we can proceed with this since your not changing the behvior.\n\ni guess at some point we stopped using the data form _parse_node_properties\nhttps://github.com/openstack/nova/commit/a985e34cdeef777fe7ff943e363a5f1be6d991b7","commit_id":"3ee7280098af682c68be54d6a29d893c162627c5"}]}