)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-09 19:13:18 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix trivial doc issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes some trivial doc issues, including typos,"},{"line_number":10,"context_line":"missing dot(.) at end of line and scheduler weighter name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"6088ba88_43594d78","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":11},"updated":"2024-05-13 12:32:35.000000000","message":"as noted in the inline comments you are making a number of opinionated style choices so I would not consider the patch to be a trivial change\n\nif you only addressed typos, markup issues and punctuation then this commit message would be accurate, however, you are also rewording some of the doc content and subtly changing the meaning.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajesh Tailor \u003cratailor@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-09 19:13:18 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix trivial doc issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change fixes some trivial doc issues, including typos,"},{"line_number":10,"context_line":"missing dot(.) at end of line and scheduler weighter name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"412478d6_5679b40b","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":11},"in_reply_to":"6088ba88_43594d78","updated":"2024-05-15 09:07:13.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"cb6bb00d75279cc18500c61ba914cbc69f1fb2ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"900bc55e_18af67c1","updated":"2023-03-28 14:29:05.000000000","message":"WIP","commit_id":"69b8db3bca645234037f1a81398a904a354d486f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a38b309_6de33d7b","updated":"2023-04-03 22:02:26.000000000","message":"This looks mostly correct, I have mostly added notes inline and only a couple of them are things that need to be fixed.","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f2c51425581f3c98d9427c7cc1f8fa9d299388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a6477a0_c3edce6d","updated":"2023-04-03 22:10:38.000000000","message":"i havent completed my review but i forgot to push this in the morning so ill push them now and take a look again later in the week","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"dea3b1a224aa50f3f9bf8d1b168ccabba09ba4e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a162fe49_5a1e6ad7","updated":"2023-03-31 10:06:23.000000000","message":"recheck nova-ceph-multistore \"tempest.api.volume.test_volumes_snapshots.VolumesSnapshotTestJSON.test_snapshot_create_delete_with_volume_in_use\" test Timeout","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9932fcb512a6ce33745bec00a68a93f27b65786e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54786fa9_8cab5f83","updated":"2023-03-31 12:33:22.000000000","message":"recheck nova-grenade-multinode \"tempest.exceptions.BuildErrorException\"","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"b438249166d4c1c5b4f48b4027a083da6ddabbb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0c448221_78d36d0d","updated":"2023-03-30 06:32:36.000000000","message":"recheck openstack-tox-pep8 \"PEP 484 prohibits implicit Optional\"","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"21055c7f2c319fcde06b9ca1ed4b6d3aa709589a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f45dcf6_105aac66","updated":"2023-04-02 06:53:48.000000000","message":"recheck tempest-integrated-compute-enforce-scope-new-defaults test failed","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08e39f92_581bde7a","updated":"2023-04-06 16:47:42.000000000","message":"A couple small nits inline. Otherwise happy with this.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9217bd5e_390cff79","updated":"2023-04-04 16:24:38.000000000","message":"Thanks for review, I have addressed comments and updated the patch.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"b54da1f77644a5b886198fa4ceb360e109c11108","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"46260c04_7d6e8972","updated":"2024-03-05 11:45:58.000000000","message":"recheck nova-lvm unrelated","commit_id":"cd9da8833c21c277528b4fdd68ac5d0a0ca22673"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"80d349a5a35a9f77bce01ba583b6dfed10386dfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c766411b_3872bcd3","updated":"2024-04-09 14:57:42.000000000","message":"Thanks Gmann for review.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"796392bd3a0b2cea38510ffba735e26726bd37c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7b13d149_8d775242","updated":"2024-05-10 16:54:07.000000000","message":"lgtm, thanks","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"60a9ecdf_43aef303","updated":"2024-05-15 09:07:13.000000000","message":"Thank you Sean for review.\nI have some inline queries, could you please provide your suggestion there ?","commit_id":"f151bc8fb167b04a7f5a008ad4e576ce9c43e263"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"eb6ef6a9dd621041a497b73491412a082eb7bc50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"08e3e7c4_f89def9a","updated":"2024-08-23 14:51:56.000000000","message":"recheck","commit_id":"2aa3f854b32bd9e0947dc07e230e0c1db0bbfb8e"}],"doc/source/admin/aggregates.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f2c51425581f3c98d9427c7cc1f8fa9d299388","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Host aggregates started out as a way to use Xen hypervisor resource pools, but"},{"line_number":11,"context_line":"have been generalized to provide a mechanism to allow administrators to assign"},{"line_number":12,"context_line":"key-value pairs to groups of machines. Each node can have multiple aggregates,"},{"line_number":13,"context_line":"each aggregate can have multiple key-value pairs, and the same key-value pair"},{"line_number":14,"context_line":"can be assigned to multiple aggregates. This information can be used in the"},{"line_number":15,"context_line":"scheduler to enable advanced scheduling, to set up Xen hypervisor resource"}],"source_content_type":"text/x-rst","patch_set":2,"id":"17b494d5_52679319","side":"PARENT","line":12,"range":{"start_line":12,"start_character":53,"end_line":12,"end_character":57},"updated":"2023-04-03 22:10:38.000000000","message":"this is correct changing it to be in is just personal preference and is not required.","commit_id":"402b155043a51a71670476c1b693135f35d9b0cd"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Host aggregates started out as a way to use Xen hypervisor resource pools, but"},{"line_number":11,"context_line":"have been generalized to provide a mechanism to allow administrators to assign"},{"line_number":12,"context_line":"key-value pairs to groups of machines. Each node can have multiple aggregates,"},{"line_number":13,"context_line":"each aggregate can have multiple key-value pairs, and the same key-value pair"},{"line_number":14,"context_line":"can be assigned to multiple aggregates. This information can be used in the"},{"line_number":15,"context_line":"scheduler to enable advanced scheduling, to set up Xen hypervisor resource"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6a4b356b_b05ed136","side":"PARENT","line":12,"range":{"start_line":12,"start_character":53,"end_line":12,"end_character":57},"in_reply_to":"17b494d5_52679319","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"402b155043a51a71670476c1b693135f35d9b0cd"}],"doc/source/admin/architecture.rst":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e6c0685369a428632e26b1fad61adb791133726e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"* **Conductor**: Handles requests that need coordination (build/resize), acts"},{"line_number":55,"context_line":"  as a database proxy, or handles object conversions."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* :placement-doc:`Placement \u003c\u003e`: Tracks resource provider inventories and"},{"line_number":58,"context_line":"  usages."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"While all services are designed to be horizontally scalable, you should have"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ceb1f7e2_764fe505","line":57,"updated":"2023-04-05 10:20:46.000000000","message":"this become only link earlier it was bold\nshall we make it bold-link ?\n\nhttps://d746e7a68c9276b36e1b-935e188dfa3a1a49945ee8787d93930a.ssl.cf1.rackcdn.com/878779/3/check/openstack-tox-docs/f4f284b/docs/admin/architecture.html","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"* **Conductor**: Handles requests that need coordination (build/resize), acts"},{"line_number":55,"context_line":"  as a database proxy, or handles object conversions."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* :placement-doc:`Placement \u003c\u003e`: Tracks resource provider inventories and"},{"line_number":58,"context_line":"  usages."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"While all services are designed to be horizontally scalable, you should have"}],"source_content_type":"text/x-rst","patch_set":3,"id":"13fb9b12_a376e582","line":57,"in_reply_to":"ceb1f7e2_764fe505","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e6c0685369a428632e26b1fad61adb791133726e","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":118,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":119,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":120,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage the amount of networks that can"},{"line_number":121,"context_line":"be created within a project."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"0ee90f26_be2c3bc3","line":119,"range":{"start_line":119,"start_character":51,"end_line":119,"end_character":58},"updated":"2023-04-05 10:20:46.000000000","message":"Neutron, because name of service and Nova service is also written in capital.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":118,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":119,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":120,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage the amount of networks that can"},{"line_number":121,"context_line":"be created within a project."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa25f8b_238a0466","line":119,"range":{"start_line":119,"start_character":51,"end_line":119,"end_character":58},"in_reply_to":"0ee90f26_be2c3bc3","updated":"2023-04-06 16:47:42.000000000","message":"I agree, but we\u0027re very inconsistent with these, so meh :)","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":118,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":119,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":120,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage the amount of networks that can"},{"line_number":121,"context_line":"be created within a project."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"d1cd4084_57d5dd9d","line":119,"range":{"start_line":119,"start_character":51,"end_line":119,"end_character":58},"in_reply_to":"1aa25f8b_238a0466","updated":"2023-04-11 10:07:02.000000000","message":"Ack","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e6c0685369a428632e26b1fad61adb791133726e","unresolved":true,"context_lines":[{"line_number":117,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":118,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":119,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":120,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage the amount of networks that can"},{"line_number":121,"context_line":"be created within a project."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Roles control the actions a user is allowed to perform. By default, most"}],"source_content_type":"text/x-rst","patch_set":3,"id":"98fd4c53_03c92c9c","line":120,"updated":"2023-04-05 10:20:46.000000000","message":"manage number of networks","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":118,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":119,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":120,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage the amount of networks that can"},{"line_number":121,"context_line":"be created within a project."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Roles control the actions a user is allowed to perform. By default, most"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ef478b90_c87c568c","line":120,"in_reply_to":"54ea2ebc_0998756c","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":117,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":118,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":119,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":120,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage the amount of networks that can"},{"line_number":121,"context_line":"be created within a project."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Roles control the actions a user is allowed to perform. By default, most"}],"source_content_type":"text/x-rst","patch_set":3,"id":"54ea2ebc_0998756c","line":120,"in_reply_to":"98fd4c53_03c92c9c","updated":"2023-04-06 16:47:42.000000000","message":"+1","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e6c0685369a428632e26b1fad61adb791133726e","unresolved":true,"context_lines":[{"line_number":126,"context_line":"that a user must have the ``admin`` role in order to be able to allocate a"},{"line_number":127,"context_line":"public IP address."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"A project limits users\u0027 access to particular images. Each user is assigned a"},{"line_number":130,"context_line":"user name and password. Keypairs granting access to an instance are enabled for"},{"line_number":131,"context_line":"each user, but quotas are set, so that each project can control resource"},{"line_number":132,"context_line":"consumption across available hardware resources."}],"source_content_type":"text/x-rst","patch_set":3,"id":"b8661ee3_3d143fb7","line":129,"range":{"start_line":129,"start_character":22,"end_line":129,"end_character":23},"updated":"2023-04-05 10:20:46.000000000","message":"is this typo.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9586fd275fc77e9b53a3b99f0c4af507810c7a4c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"that a user must have the ``admin`` role in order to be able to allocate a"},{"line_number":127,"context_line":"public IP address."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"A project limits users\u0027 access to particular images. Each user is assigned a"},{"line_number":130,"context_line":"user name and password. Keypairs granting access to an instance are enabled for"},{"line_number":131,"context_line":"each user, but quotas are set, so that each project can control resource"},{"line_number":132,"context_line":"consumption across available hardware resources."}],"source_content_type":"text/x-rst","patch_set":3,"id":"20376d3b_c66043b7","line":129,"range":{"start_line":129,"start_character":22,"end_line":129,"end_character":23},"in_reply_to":"ac1d714a_c123ccea","updated":"2023-05-05 03:31:38.000000000","message":"Ack","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":126,"context_line":"that a user must have the ``admin`` role in order to be able to allocate a"},{"line_number":127,"context_line":"public IP address."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"A project limits users\u0027 access to particular images. Each user is assigned a"},{"line_number":130,"context_line":"user name and password. Keypairs granting access to an instance are enabled for"},{"line_number":131,"context_line":"each user, but quotas are set, so that each project can control resource"},{"line_number":132,"context_line":"consumption across available hardware resources."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ac1d714a_c123ccea","line":129,"range":{"start_line":129,"start_character":22,"end_line":129,"end_character":23},"in_reply_to":"b8661ee3_3d143fb7","updated":"2023-04-06 16:47:42.000000000","message":"No, in English a plural possessive is like this. If you need to do something like \"users\u0027s\" then you\u0027re supposed to do \"users\u0027\".","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e6c0685369a428632e26b1fad61adb791133726e","unresolved":true,"context_lines":[{"line_number":199,"context_line":"---------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"In OpenStack the base operating system is usually copied from an image stored"},{"line_number":202,"context_line":"in the OpenStack Image service, glance. This is the most common case and"},{"line_number":203,"context_line":"results in an ephemeral instance that starts from a known template state and"},{"line_number":204,"context_line":"loses all accumulated states on virtual machine deletion. It is also possible"},{"line_number":205,"context_line":"to put an operating system on a persistent volume in the OpenStack Block"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2f7ec582_4332c099","line":202,"range":{"start_line":202,"start_character":32,"end_line":202,"end_character":38},"updated":"2023-04-05 10:20:46.000000000","message":"Glance","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":true,"context_lines":[{"line_number":199,"context_line":"---------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"In OpenStack the base operating system is usually copied from an image stored"},{"line_number":202,"context_line":"in the OpenStack Image service, glance. This is the most common case and"},{"line_number":203,"context_line":"results in an ephemeral instance that starts from a known template state and"},{"line_number":204,"context_line":"loses all accumulated states on virtual machine deletion. It is also possible"},{"line_number":205,"context_line":"to put an operating system on a persistent volume in the OpenStack Block"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7d0eb080_71a0b731","line":202,"range":{"start_line":202,"start_character":32,"end_line":202,"end_character":38},"in_reply_to":"2f7ec582_4332c099","updated":"2023-04-11 10:07:02.000000000","message":"we are inconsistent about these, so leave it as it is.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9586fd275fc77e9b53a3b99f0c4af507810c7a4c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"---------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"In OpenStack the base operating system is usually copied from an image stored"},{"line_number":202,"context_line":"in the OpenStack Image service, glance. This is the most common case and"},{"line_number":203,"context_line":"results in an ephemeral instance that starts from a known template state and"},{"line_number":204,"context_line":"loses all accumulated states on virtual machine deletion. It is also possible"},{"line_number":205,"context_line":"to put an operating system on a persistent volume in the OpenStack Block"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8d819141_8e9f6d29","line":202,"range":{"start_line":202,"start_character":32,"end_line":202,"end_character":38},"in_reply_to":"7d0eb080_71a0b731","updated":"2023-05-05 03:31:38.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":114,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":115,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":116,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":117,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage number of networks that can"},{"line_number":118,"context_line":"be created within a project."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Roles control the actions a user is allowed to perform. By default, most"}],"source_content_type":"text/x-rst","patch_set":11,"id":"823f0c33_69bd2bb0","line":117,"range":{"start_line":117,"start_character":47,"end_line":117,"end_character":53},"updated":"2024-05-13 12:32:35.000000000","message":"`the amount` was more correct then `number`","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"183fb069c8cf1afbfe3499b65d668c876e673061","unresolved":false,"context_lines":[{"line_number":114,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":115,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"},{"line_number":116,"context_line":"on their own resources. For example, :neutron-doc:`neutron"},{"line_number":117,"context_line":"\u003c/admin/ops-quotas.html\u003e` allows you to manage number of networks that can"},{"line_number":118,"context_line":"be created within a project."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Roles control the actions a user is allowed to perform. By default, most"}],"source_content_type":"text/x-rst","patch_set":11,"id":"62387315_6113be0e","line":117,"range":{"start_line":117,"start_character":47,"end_line":117,"end_character":53},"in_reply_to":"823f0c33_69bd2bb0","updated":"2024-05-15 11:52:51.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"doc/source/admin/availability-zones.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f2c51425581f3c98d9427c7cc1f8fa9d299388","unresolved":true,"context_lines":[{"line_number":22,"context_line":"attaching specific metadata information to an"},{"line_number":23,"context_line":":doc:`aggregate \u003c/admin/aggregates\u003e` The addition of this specific metadata to"},{"line_number":24,"context_line":"an aggregate makes the aggregate visible from an end-user perspective and"},{"line_number":25,"context_line":"consequently allows users to schedule instances to a specific set of hosts, the"},{"line_number":26,"context_line":"ones belonging to the aggregate. There are a few additional differences to note"},{"line_number":27,"context_line":"when comparing availability zones and host aggregates:"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5c1c69f3_949e0bd4","side":"PARENT","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"updated":"2023-04-03 22:10:38.000000000","message":"the removal of a is incorrect here.","commit_id":"402b155043a51a71670476c1b693135f35d9b0cd"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"attaching specific metadata information to an"},{"line_number":23,"context_line":":doc:`aggregate \u003c/admin/aggregates\u003e` The addition of this specific metadata to"},{"line_number":24,"context_line":"an aggregate makes the aggregate visible from an end-user perspective and"},{"line_number":25,"context_line":"consequently allows users to schedule instances to a specific set of hosts, the"},{"line_number":26,"context_line":"ones belonging to the aggregate. There are a few additional differences to note"},{"line_number":27,"context_line":"when comparing availability zones and host aggregates:"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c28177a6_0b1d9e89","side":"PARENT","line":25,"range":{"start_line":25,"start_character":51,"end_line":25,"end_character":53},"in_reply_to":"5c1c69f3_949e0bd4","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"402b155043a51a71670476c1b693135f35d9b0cd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Availability zones are not modeled in the database; rather, they are defined by"},{"line_number":22,"context_line":"attaching specific metadata information to an"},{"line_number":23,"context_line":":doc:`aggregate \u003c/admin/aggregates\u003e`. The addition of this specific metadata to"},{"line_number":24,"context_line":"an aggregate, makes the aggregate visible from an end-user perspective and"},{"line_number":25,"context_line":"consequently allows users to schedule instances to specific set of hosts, the"},{"line_number":26,"context_line":"ones belonging to the aggregate. There are a few additional differences to note"},{"line_number":27,"context_line":"when comparing availability zones and host aggregates:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"021977c9_9fd9b3e4","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":13},"updated":"2023-04-03 22:02:26.000000000","message":"Nit: I don\u0027t think you need this comma.","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Availability zones are not modeled in the database; rather, they are defined by"},{"line_number":22,"context_line":"attaching specific metadata information to an"},{"line_number":23,"context_line":":doc:`aggregate \u003c/admin/aggregates\u003e`. The addition of this specific metadata to"},{"line_number":24,"context_line":"an aggregate, makes the aggregate visible from an end-user perspective and"},{"line_number":25,"context_line":"consequently allows users to schedule instances to specific set of hosts, the"},{"line_number":26,"context_line":"ones belonging to the aggregate. There are a few additional differences to note"},{"line_number":27,"context_line":"when comparing availability zones and host aggregates:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b3b93ea5_bf2337a7","line":24,"range":{"start_line":24,"start_character":12,"end_line":24,"end_character":13},"in_reply_to":"021977c9_9fd9b3e4","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  availability zone."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- By default a host is part of a default availability zone even if it doesn\u0027t"},{"line_number":33,"context_line":"  belong to any aggregate. The name of this default availability zone can be"},{"line_number":34,"context_line":"  configured using :oslo.config:option:`default_availability_zone` config"},{"line_number":35,"context_line":"  option."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7be4f5_fbf9420f","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":15},"updated":"2023-04-03 22:02:26.000000000","message":"I think \"an\" was fine here but \"any\" works too.","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f2c51425581f3c98d9427c7cc1f8fa9d299388","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  availability zone."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- By default a host is part of a default availability zone even if it doesn\u0027t"},{"line_number":33,"context_line":"  belong to any aggregate. The name of this default availability zone can be"},{"line_number":34,"context_line":"  configured using :oslo.config:option:`default_availability_zone` config"},{"line_number":35,"context_line":"  option."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9acb9bc7_3f7f5505","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":15},"updated":"2023-04-03 22:10:38.000000000","message":"any also works but an was equally valid.","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c843626f3ba88c98ab13cd88d26f3c2f8bdd266d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  availability zone."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- By default a host is part of a default availability zone even if it doesn\u0027t"},{"line_number":33,"context_line":"  belong to any aggregate. The name of this default availability zone can be"},{"line_number":34,"context_line":"  configured using :oslo.config:option:`default_availability_zone` config"},{"line_number":35,"context_line":"  option."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4e1f58fc_b51d99a9","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":15},"in_reply_to":"5f7be4f5_fbf9420f","updated":"2023-11-24 06:59:53.000000000","message":"Acknowledged","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  availability zone."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- By default a host is part of a default availability zone even if it doesn\u0027t"},{"line_number":33,"context_line":"  belong to any aggregate. The name of this default availability zone can be"},{"line_number":34,"context_line":"  configured using :oslo.config:option:`default_availability_zone` config"},{"line_number":35,"context_line":"  option."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"88d3e441_8f672dab","line":33,"range":{"start_line":33,"start_character":12,"end_line":33,"end_character":15},"in_reply_to":"9acb9bc7_3f7f5505","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":39,"context_line":"      The use of the default availability zone name in requests can be very"},{"line_number":40,"context_line":"      error-prone. Since the user can see the list of availability zones, they"},{"line_number":41,"context_line":"      have no way to know whether the default availability zone name (currently"},{"line_number":42,"context_line":"      ``nova``) is provided because a host belongs to an aggregate whose AZ"},{"line_number":43,"context_line":"      metadata key is set to ``nova``, or because there is at least one host"},{"line_number":44,"context_line":"      not belonging to any aggregate.  Consequently, it is highly recommended"},{"line_number":45,"context_line":"      for users to never ever ask for booting an instance by specifying an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a1e85e92_7a9ba4cb","line":42,"updated":"2023-04-03 22:02:26.000000000","message":"Oops, I had pointed out this typo for a new contributor to learn how to use gerrit because I didn\u0027t find this patch:\n\nhttps://review.opendev.org/c/openstack/nova/+/878797","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"      The use of the default availability zone name in requests can be very"},{"line_number":40,"context_line":"      error-prone. Since the user can see the list of availability zones, they"},{"line_number":41,"context_line":"      have no way to know whether the default availability zone name (currently"},{"line_number":42,"context_line":"      ``nova``) is provided because a host belongs to an aggregate whose AZ"},{"line_number":43,"context_line":"      metadata key is set to ``nova``, or because there is at least one host"},{"line_number":44,"context_line":"      not belonging to any aggregate.  Consequently, it is highly recommended"},{"line_number":45,"context_line":"      for users to never ever ask for booting an instance by specifying an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"afb715c7_6b6410e7","line":42,"in_reply_to":"a1e85e92_7a9ba4cb","updated":"2023-04-04 16:24:38.000000000","message":"Ack, I will revert this in favour of below change.\nhttps://review.opendev.org/c/openstack/nova/+/878797","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"c843626f3ba88c98ab13cd88d26f3c2f8bdd266d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      The use of the default availability zone name in requests can be very"},{"line_number":40,"context_line":"      error-prone. Since the user can see the list of availability zones, they"},{"line_number":41,"context_line":"      have no way to know whether the default availability zone name (currently"},{"line_number":42,"context_line":"      ``nova``) is provided because a host belongs to an aggregate whose AZ"},{"line_number":43,"context_line":"      metadata key is set to ``nova``, or because there is at least one host"},{"line_number":44,"context_line":"      not belonging to any aggregate.  Consequently, it is highly recommended"},{"line_number":45,"context_line":"      for users to never ever ask for booting an instance by specifying an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4bec718f_65bd83cb","line":42,"in_reply_to":"afb715c7_6b6410e7","updated":"2023-11-24 06:59:53.000000000","message":"Acknowledged","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"}],"doc/source/admin/cells.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f2c51425581f3c98d9427c7cc1f8fa9d299388","unresolved":true,"context_lines":[{"line_number":104,"context_line":"   the :oslo.config:option:`transport_url` and"},{"line_number":105,"context_line":"   :oslo.config:option:`database.connection` configuration options of the"},{"line_number":106,"context_line":"   lower-level services. See the ``nova-manage`` :ref:`man-page-cells-v2`"},{"line_number":107,"context_line":"   commands for more information about how to create and examine these records."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The following section goes into more detail about the difference between"},{"line_number":110,"context_line":"single-cell and multi-cell deployments."}],"source_content_type":"text/x-rst","patch_set":2,"id":"cd8885d6_a534317d","side":"PARENT","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":12},"updated":"2023-04-03 22:10:38.000000000","message":"why did you remove commands \n\nwe were directing them to review the docs for the nova mange commands","commit_id":"402b155043a51a71670476c1b693135f35d9b0cd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"   the :oslo.config:option:`transport_url` and"},{"line_number":105,"context_line":"   :oslo.config:option:`database.connection` configuration options of the"},{"line_number":106,"context_line":"   lower-level services. See the ``nova-manage`` :ref:`man-page-cells-v2`"},{"line_number":107,"context_line":"   commands for more information about how to create and examine these records."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The following section goes into more detail about the difference between"},{"line_number":110,"context_line":"single-cell and multi-cell deployments."}],"source_content_type":"text/x-rst","patch_set":2,"id":"637d660f_a14e0696","side":"PARENT","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":12},"in_reply_to":"79677de9_15dc67ff","updated":"2023-04-06 16:47:42.000000000","message":"Done","commit_id":"402b155043a51a71670476c1b693135f35d9b0cd"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":true,"context_lines":[{"line_number":104,"context_line":"   the :oslo.config:option:`transport_url` and"},{"line_number":105,"context_line":"   :oslo.config:option:`database.connection` configuration options of the"},{"line_number":106,"context_line":"   lower-level services. See the ``nova-manage`` :ref:`man-page-cells-v2`"},{"line_number":107,"context_line":"   commands for more information about how to create and examine these records."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The following section goes into more detail about the difference between"},{"line_number":110,"context_line":"single-cell and multi-cell deployments."}],"source_content_type":"text/x-rst","patch_set":2,"id":"79677de9_15dc67ff","side":"PARENT","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":12},"in_reply_to":"cd8885d6_a534317d","updated":"2023-04-04 16:24:38.000000000","message":"sorry, it was removed by mistake.","commit_id":"402b155043a51a71670476c1b693135f35d9b0cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f2c51425581f3c98d9427c7cc1f8fa9d299388","unresolved":true,"context_lines":[{"line_number":32,"context_line":"This means a multi-cell deployment will not be radically different from a"},{"line_number":33,"context_line":"\"standard\" nova deployment."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Considering such a deployment, it will consists of the following components:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."}],"source_content_type":"text/x-rst","patch_set":2,"id":"90b9b0e9_bf4ae7d0","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":75},"updated":"2023-04-03 22:10:38.000000000","message":"again this is just personal preference the original doc text was valid\n\nyou have just changed the paceing and tense.\n\nyou described this change as \"trivial doc issues, including typos, missing dot(.)\" \n\nthis is changing the content and style of the docs which really i not something that should be considered a trivial doc issues.","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":32,"context_line":"This means a multi-cell deployment will not be radically different from a"},{"line_number":33,"context_line":"\"standard\" nova deployment."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Considering such a deployment, it will consists of the following components:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."}],"source_content_type":"text/x-rst","patch_set":2,"id":"a77a5f94_12a4ceea","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":47},"updated":"2023-04-03 22:02:26.000000000","message":"consist","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"This means a multi-cell deployment will not be radically different from a"},{"line_number":33,"context_line":"\"standard\" nova deployment."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Considering such a deployment, it will consists of the following components:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff827212_2b587539","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":75},"in_reply_to":"90b9b0e9_bf4ae7d0","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"This means a multi-cell deployment will not be radically different from a"},{"line_number":33,"context_line":"\"standard\" nova deployment."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Considering such a deployment, it will consists of the following components:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."}],"source_content_type":"text/x-rst","patch_set":2,"id":"c6ae9b81_fd04dbcd","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":47},"in_reply_to":"a77a5f94_12a4ceea","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- The :program:`nova-scheduler` and `placement` services which are"},{"line_number":41,"context_line":"  responsible for tracking resources and deciding which compute node instances"},{"line_number":42,"context_line":"  should be on."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4d4ad4e9_6de32ed7","line":40,"range":{"start_line":40,"start_character":36,"end_line":40,"end_character":47},"updated":"2023-04-03 22:02:26.000000000","message":"I think this should probably be :program:``placement-api`` to be consistent with the rest of the services mentioned in this section?","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f2c51425581f3c98d9427c7cc1f8fa9d299388","unresolved":true,"context_lines":[{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- The :program:`nova-scheduler` and `placement` services which are"},{"line_number":41,"context_line":"  responsible for tracking resources and deciding which compute node instances"},{"line_number":42,"context_line":"  should be on."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4db0b0d6_c41d0240","line":40,"range":{"start_line":40,"start_character":35,"end_line":40,"end_character":47},"updated":"2023-04-03 22:10:38.000000000","message":"this was ``placement`` so that it would be bold `placement` renders in italics\n\nso this shoudl either remain ``placement`` or be :program:`placement`","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- The :program:`nova-scheduler` and `placement` services which are"},{"line_number":41,"context_line":"  responsible for tracking resources and deciding which compute node instances"},{"line_number":42,"context_line":"  should be on."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f14d07c_5e4ad936","line":40,"range":{"start_line":40,"start_character":36,"end_line":40,"end_character":47},"in_reply_to":"4d4ad4e9_6de32ed7","updated":"2023-04-04 16:24:38.000000000","message":"Ack","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- The :program:`nova-scheduler` and `placement` services which are"},{"line_number":41,"context_line":"  responsible for tracking resources and deciding which compute node instances"},{"line_number":42,"context_line":"  should be on."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ca2e50b9_e9e55b92","line":40,"range":{"start_line":40,"start_character":35,"end_line":40,"end_character":47},"in_reply_to":"4db0b0d6_c41d0240","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":32,"context_line":"This means a multi-cell deployment will not be radically different from a"},{"line_number":33,"context_line":"\"standard\" nova deployment."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Consider such a deployment, it will consist of the following components:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4ff7f42e_fd439f35","line":35,"updated":"2023-04-06 16:47:42.000000000","message":"The original line is not great, but this one is not better, IMHO. If you take this but s/it will/which will/, then I think it\u0027s better.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"This means a multi-cell deployment will not be radically different from a"},{"line_number":33,"context_line":"\"standard\" nova deployment."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Consider such a deployment, it will consist of the following components:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- The :program:`nova-api` service which provides the external REST API to"},{"line_number":38,"context_line":"  users."}],"source_content_type":"text/x-rst","patch_set":3,"id":"89b36d7a_530d1113","line":35,"in_reply_to":"4ff7f42e_fd439f35","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":697,"context_line":"  not need to replicate all the data at the top level."},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"- It draws a clear line between global and local data elements. Things like"},{"line_number":700,"context_line":"  flavors and keypairs are clearly global concepts that need to only live at the"},{"line_number":701,"context_line":"  top level. Providing this separation allows compute nodes to become even more"},{"line_number":702,"context_line":"  stateless and insulated from things like deleted/changed global data."},{"line_number":703,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"e52b1d58_47f5a979","line":700,"range":{"start_line":700,"start_character":60,"end_line":700,"end_character":63},"updated":"2024-05-13 12:32:35.000000000","message":"this is incorrect, it was correct before.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f8ac9abcc422a4450d3b8c68af6acc155afce4d0","unresolved":true,"context_lines":[{"line_number":697,"context_line":"  not need to replicate all the data at the top level."},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"- It draws a clear line between global and local data elements. Things like"},{"line_number":700,"context_line":"  flavors and keypairs are clearly global concepts that need to only live at the"},{"line_number":701,"context_line":"  top level. Providing this separation allows compute nodes to become even more"},{"line_number":702,"context_line":"  stateless and insulated from things like deleted/changed global data."},{"line_number":703,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"6fab4429_3ca96b7a","line":700,"range":{"start_line":700,"start_character":60,"end_line":700,"end_character":63},"in_reply_to":"3c7dbce1_8ae796d9","updated":"2024-05-15 11:49:41.000000000","message":"no the existing text\n```\nThings like flavors and keypairs are clearly global concepts that need only live at the top level.\n```\n\nis valid as is and read better form a native speaker perspective.\n\nyou could remove \"clearly\" to make it more authoritative but you do not need to modify this line   form the oginal content.\n\n```\nThings like flavors and keypairs are global concepts that need only live at the top level.\n```\n\nif you wanted to make it more formal then we would remove the Anthropomorphism\n\n\n```\nThings like flavors and keypairs are global concepts that are defined in the top-level API DB.\n```","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"eb6ef6a9dd621041a497b73491412a082eb7bc50","unresolved":false,"context_lines":[{"line_number":697,"context_line":"  not need to replicate all the data at the top level."},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"- It draws a clear line between global and local data elements. Things like"},{"line_number":700,"context_line":"  flavors and keypairs are clearly global concepts that need to only live at the"},{"line_number":701,"context_line":"  top level. Providing this separation allows compute nodes to become even more"},{"line_number":702,"context_line":"  stateless and insulated from things like deleted/changed global data."},{"line_number":703,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"fe05a1d2_cdb4e94a","line":700,"range":{"start_line":700,"start_character":60,"end_line":700,"end_character":63},"in_reply_to":"6fab4429_3ca96b7a","updated":"2024-08-23 14:51:56.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":true,"context_lines":[{"line_number":697,"context_line":"  not need to replicate all the data at the top level."},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"- It draws a clear line between global and local data elements. Things like"},{"line_number":700,"context_line":"  flavors and keypairs are clearly global concepts that need to only live at the"},{"line_number":701,"context_line":"  top level. Providing this separation allows compute nodes to become even more"},{"line_number":702,"context_line":"  stateless and insulated from things like deleted/changed global data."},{"line_number":703,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3c7dbce1_8ae796d9","line":700,"range":{"start_line":700,"start_character":60,"end_line":700,"end_character":63},"in_reply_to":"e52b1d58_47f5a979","updated":"2024-05-15 09:07:13.000000000","message":"should I modify it like this -\u003e s/that need only live at/that only need to live at/","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"doc/source/admin/configuring-migrations.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":112,"context_line":"#. Enable password-less SSH so that root on one compute host can log on to any"},{"line_number":113,"context_line":"   other compute host without providing a password.  The ``libvirtd`` daemon,"},{"line_number":114,"context_line":"   which runs as root, uses the SSH protocol to copy the instance to the"},{"line_number":115,"context_line":"   destination and don\u0027t know the passwords of all compute hosts."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   You may, for example, compile root\u0027s public SSH keys on all compute hosts"},{"line_number":118,"context_line":"   into an ``authorized_keys`` file and deploy that file to the compute hosts."}],"source_content_type":"text/x-rst","patch_set":2,"id":"202036e7_5483fb32","line":115,"range":{"start_line":115,"start_character":19,"end_line":115,"end_character":24},"updated":"2023-04-03 22:02:26.000000000","message":"doesn\u0027t","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"#. Enable password-less SSH so that root on one compute host can log on to any"},{"line_number":113,"context_line":"   other compute host without providing a password.  The ``libvirtd`` daemon,"},{"line_number":114,"context_line":"   which runs as root, uses the SSH protocol to copy the instance to the"},{"line_number":115,"context_line":"   destination and don\u0027t know the passwords of all compute hosts."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   You may, for example, compile root\u0027s public SSH keys on all compute hosts"},{"line_number":118,"context_line":"   into an ``authorized_keys`` file and deploy that file to the compute hosts."}],"source_content_type":"text/x-rst","patch_set":2,"id":"db623d2f_ec72e5bb","line":115,"range":{"start_line":115,"start_character":19,"end_line":115,"end_character":24},"in_reply_to":"0f67c42a_02724d01","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50bd93d796006a6b6f3ca3e19ebff7e97107c25f","unresolved":true,"context_lines":[{"line_number":112,"context_line":"#. Enable password-less SSH so that root on one compute host can log on to any"},{"line_number":113,"context_line":"   other compute host without providing a password.  The ``libvirtd`` daemon,"},{"line_number":114,"context_line":"   which runs as root, uses the SSH protocol to copy the instance to the"},{"line_number":115,"context_line":"   destination and don\u0027t know the passwords of all compute hosts."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   You may, for example, compile root\u0027s public SSH keys on all compute hosts"},{"line_number":118,"context_line":"   into an ``authorized_keys`` file and deploy that file to the compute hosts."}],"source_content_type":"text/x-rst","patch_set":2,"id":"0f67c42a_02724d01","line":115,"range":{"start_line":115,"start_character":19,"end_line":115,"end_character":24},"in_reply_to":"202036e7_5483fb32","updated":"2023-04-03 22:12:38.000000000","message":"can\u0027t or doesn\u0027t are correct but don\u0027t is wrong","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":66,"context_line":"   different host in the same cell, but not across cells. Refer to the"},{"line_number":67,"context_line":"   :ref:`cells v2 documentation \u003ccells-v2-caveats\u003e`. for more information."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The following sections describe how to configure your hosts for live migrations"},{"line_number":70,"context_line":"using the libvirt virt driver and KVM hypervisor."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":".. _configuring-migrations-kvm-libvirt:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ed10b1f1_e12fdd4f","side":"PARENT","line":69,"range":{"start_line":69,"start_character":64,"end_line":69,"end_character":79},"updated":"2024-05-13 12:32:35.000000000","message":"this is more personal test using the plural form is not wrong but singular is perhaps less confusion to non native speakers.","commit_id":"1bca24aeb0323d70f053d18c61bd0b94e211f5f8"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"eb6ef6a9dd621041a497b73491412a082eb7bc50","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   different host in the same cell, but not across cells. Refer to the"},{"line_number":67,"context_line":"   :ref:`cells v2 documentation \u003ccells-v2-caveats\u003e`. for more information."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The following sections describe how to configure your hosts for live migrations"},{"line_number":70,"context_line":"using the libvirt virt driver and KVM hypervisor."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":".. _configuring-migrations-kvm-libvirt:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"875ceb18_f44690a1","side":"PARENT","line":69,"range":{"start_line":69,"start_character":64,"end_line":69,"end_character":79},"in_reply_to":"ed10b1f1_e12fdd4f","updated":"2024-08-23 14:51:56.000000000","message":"Done","commit_id":"1bca24aeb0323d70f053d18c61bd0b94e211f5f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":112,"context_line":"#. Enable password-less SSH so that root on one compute host can log on to any"},{"line_number":113,"context_line":"   other compute host without providing a password.  The ``libvirtd`` daemon,"},{"line_number":114,"context_line":"   which runs as root, uses the SSH protocol to copy the instance to the"},{"line_number":115,"context_line":"   destination and doesn\u0027t know the passwords of all compute hosts."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   You may, for example, compile root\u0027s public SSH keys on all compute hosts"},{"line_number":118,"context_line":"   into an ``authorized_keys`` file and deploy that file to the compute hosts."}],"source_content_type":"text/x-rst","patch_set":11,"id":"5f6b8057_ef6b3741","line":115,"range":{"start_line":115,"start_character":19,"end_line":115,"end_character":27},"updated":"2024-05-13 12:32:35.000000000","message":"can\u0027t is not incorrect this is again a preference not a typo or grammer fix.\n\ni would personally perfer can\u0027t.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"183fb069c8cf1afbfe3499b65d668c876e673061","unresolved":false,"context_lines":[{"line_number":112,"context_line":"#. Enable password-less SSH so that root on one compute host can log on to any"},{"line_number":113,"context_line":"   other compute host without providing a password.  The ``libvirtd`` daemon,"},{"line_number":114,"context_line":"   which runs as root, uses the SSH protocol to copy the instance to the"},{"line_number":115,"context_line":"   destination and doesn\u0027t know the passwords of all compute hosts."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   You may, for example, compile root\u0027s public SSH keys on all compute hosts"},{"line_number":118,"context_line":"   into an ``authorized_keys`` file and deploy that file to the compute hosts."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9f8ed748_8f6c4c2c","line":115,"range":{"start_line":115,"start_character":19,"end_line":115,"end_character":27},"in_reply_to":"5f6b8057_ef6b3741","updated":"2024-05-15 11:52:51.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"doc/source/admin/evacuate.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":11,"context_line":"current VM host is not operational. Otherwise, the evacuation fails."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There are two different ways to evacuate instances from a failed compute"},{"line_number":14,"context_line":"node. The first one using the :command:`nova evacuate` command, which can be"},{"line_number":15,"context_line":"used to evacuate a single instance from a failed node. In some cases where"},{"line_number":16,"context_line":"the node in question hosted many instances, it might be easier to use"},{"line_number":17,"context_line":":command:`nova host-evacuate` to evacuate them all in one shot."}],"source_content_type":"text/x-rst","patch_set":2,"id":"25c5fb74_2fe2b130","line":14,"range":{"start_line":14,"start_character":62,"end_line":14,"end_character":69},"updated":"2023-04-03 22:02:26.000000000","message":"I don\u0027t think this is an improvement over what\u0027s already there. It should be either \"The first one using the command\" or \"The first one uses the command, which\", IMHO.","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"current VM host is not operational. Otherwise, the evacuation fails."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There are two different ways to evacuate instances from a failed compute"},{"line_number":14,"context_line":"node. The first one using the :command:`nova evacuate` command, which can be"},{"line_number":15,"context_line":"used to evacuate a single instance from a failed node. In some cases where"},{"line_number":16,"context_line":"the node in question hosted many instances, it might be easier to use"},{"line_number":17,"context_line":":command:`nova host-evacuate` to evacuate them all in one shot."}],"source_content_type":"text/x-rst","patch_set":2,"id":"54cf48c2_6a870925","line":14,"range":{"start_line":14,"start_character":62,"end_line":14,"end_character":69},"in_reply_to":"25c5fb74_2fe2b130","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There are two different ways to evacuate instances from a failed compute"},{"line_number":14,"context_line":"node. The first one using the :command:`nova evacuate` command can be used to"},{"line_number":15,"context_line":"evacuate a single instance from a failed node. In some cases where the node"},{"line_number":16,"context_line":"in question hosted many instances, it might be easier to use"},{"line_number":17,"context_line":":command:`nova host-evacuate` to evacuate them all in one shot."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Evacuate a single instance"},{"line_number":20,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ccf0b798_d9c9ed08","line":17,"range":{"start_line":15,"start_character":46,"end_line":17,"end_character":62},"updated":"2024-05-13 12:32:35.000000000","message":"nit: if we are updating this we could also not that using nova host-evacuated is not recommended and considered deprecated.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"doc/source/admin/scheduling.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"    :oslo.config:option:`filter_scheduler.available_filters` config option in"},{"line_number":1413,"context_line":"    addition to enabling them via the"},{"line_number":1414,"context_line":"    :oslo.config:option:`filter_scheduler.enabled_filters` config option. The"},{"line_number":1415,"context_line":"    default ``nova.scheduler.filters.all_filters`` value for the former, only"},{"line_number":1416,"context_line":"    includes the filters shipped with nova."},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"With these settings, all of the standard nova filters and the custom"}],"source_content_type":"text/x-rst","patch_set":2,"id":"014cf997_b74ff7a6","line":1415,"range":{"start_line":1415,"start_character":71,"end_line":1415,"end_character":72},"updated":"2023-04-03 22:02:26.000000000","message":"This is not needed IMO.","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"    :oslo.config:option:`filter_scheduler.available_filters` config option in"},{"line_number":1413,"context_line":"    addition to enabling them via the"},{"line_number":1414,"context_line":"    :oslo.config:option:`filter_scheduler.enabled_filters` config option. The"},{"line_number":1415,"context_line":"    default ``nova.scheduler.filters.all_filters`` value for the former, only"},{"line_number":1416,"context_line":"    includes the filters shipped with nova."},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"With these settings, all of the standard nova filters and the custom"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2660edcf_fdaf652e","line":1415,"range":{"start_line":1415,"start_character":71,"end_line":1415,"end_character":72},"in_reply_to":"014cf997_b74ff7a6","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"}],"doc/source/admin/upgrades.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0d2bfcae7b8a2d3014a45dade2c06eb8fe60c9ca","unresolved":true,"context_lines":[{"line_number":119,"context_line":"     there are no old orphaned service records using ``nova service-list``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"   * Now that all services are upgraded, we need to send the SIG_HUP signal, so all"},{"line_number":122,"context_line":"     the services to clear any cached service version data. When a new service"},{"line_number":123,"context_line":"     starts, it automatically detects which version of the compute RPC protocol"},{"line_number":124,"context_line":"     to use, and it can decide if it is safe to do any online data migrations."},{"line_number":125,"context_line":"     Note, if you used a static value for the upgrade_level, such as"}],"source_content_type":"text/x-rst","patch_set":2,"id":"02508cf1_ab5fa634","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":20},"updated":"2023-04-03 22:02:26.000000000","message":"Adding this is not correct grammar. If you want to say \"to clear\" then I think you need to change \"so all\" to \"to all\" and remove the comma after \"signal\".","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"d1239b9e07cb8933f06cee8c5de944751a17cb8c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"     there are no old orphaned service records using ``nova service-list``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"   * Now that all services are upgraded, we need to send the SIG_HUP signal, so all"},{"line_number":122,"context_line":"     the services to clear any cached service version data. When a new service"},{"line_number":123,"context_line":"     starts, it automatically detects which version of the compute RPC protocol"},{"line_number":124,"context_line":"     to use, and it can decide if it is safe to do any online data migrations."},{"line_number":125,"context_line":"     Note, if you used a static value for the upgrade_level, such as"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1338f56a_bb347b1e","line":122,"range":{"start_line":122,"start_character":18,"end_line":122,"end_character":20},"in_reply_to":"02508cf1_ab5fa634","updated":"2023-04-04 16:24:38.000000000","message":"Done","commit_id":"6143912620626928ef38477a4c133875c3cb4aff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  is the only choice."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* During upgrade be aware that there will be additional load on nova-conductor."},{"line_number":35,"context_line":"  You may find that you need to add extra nova-conductor workers to deal with the"},{"line_number":36,"context_line":"  additional upgrade related load."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Rolling upgrade process"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a9dd5306_20d36088","line":35,"updated":"2023-04-06 16:47:42.000000000","message":"I don\u0027t think this change is really necessary, although it\u0027s fine. Can you fix the wrapping you\u0027re breaking here though?","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  is the only choice."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* During upgrade be aware that there will be additional load on nova-conductor."},{"line_number":35,"context_line":"  You may find that you need to add extra nova-conductor workers to deal with the"},{"line_number":36,"context_line":"  additional upgrade related load."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Rolling upgrade process"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b0485388_490991ec","line":35,"in_reply_to":"a9dd5306_20d36088","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   * Using the newly installed nova code, run the DB sync. First run"},{"line_number":73,"context_line":"     ``nova-manage api_db sync``, then ``nova-manage db sync``. The ``nova-manage"},{"line_number":74,"context_line":"     db sync`` should be run for all cell databases, including ``cell0``. If"},{"line_number":75,"context_line":"     necessary, the ``--config-file`` argument can be used to point to the"},{"line_number":76,"context_line":"     correct ``nova.conf`` file for the given cell."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"b65c3a7e_a517df9c","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":21},"updated":"2023-04-06 16:47:42.000000000","message":"If you add \"The\" in front like you do, then you should put something like \"command\" here before \"should\".","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   * Using the newly installed nova code, run the DB sync. First run"},{"line_number":73,"context_line":"     ``nova-manage api_db sync``, then ``nova-manage db sync``. The ``nova-manage"},{"line_number":74,"context_line":"     db sync`` should be run for all cell databases, including ``cell0``. If"},{"line_number":75,"context_line":"     necessary, the ``--config-file`` argument can be used to point to the"},{"line_number":76,"context_line":"     correct ``nova.conf`` file for the given cell."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"a53bc8dd_cf31b663","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":21},"in_reply_to":"b65c3a7e_a517df9c","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":76,"context_line":"     correct ``nova.conf`` file for the given cell."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"     These schema change operations should have minimal or no effect on"},{"line_number":79,"context_line":"     performance, and should not cause any operation to fail."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   * At this point, new columns and tables may exist in the database. These"},{"line_number":82,"context_line":"     DB schema changes are done in a way that both the N and N+1 release can"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b0ff811f_3fe85b8c","line":79,"range":{"start_line":79,"start_character":43,"end_line":79,"end_character":52},"updated":"2023-04-06 16:47:42.000000000","message":"I think \"operations\" sounded better.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"     correct ``nova.conf`` file for the given cell."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"     These schema change operations should have minimal or no effect on"},{"line_number":79,"context_line":"     performance, and should not cause any operation to fail."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   * At this point, new columns and tables may exist in the database. These"},{"line_number":82,"context_line":"     DB schema changes are done in a way that both the N and N+1 release can"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e078b2b5_dc05b337","line":79,"range":{"start_line":79,"start_character":43,"end_line":79,"end_character":52},"in_reply_to":"b0ff811f_3fe85b8c","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   * Several nova services rely on the external placement service being at the"},{"line_number":88,"context_line":"     latest level. Therefore, you must upgrade placement before any nova"},{"line_number":89,"context_line":"     service. See the"},{"line_number":90,"context_line":"     :placement-doc:`placement upgrade notes \u003cadmin/upgrade-notes.html\u003e` for"},{"line_number":91,"context_line":"     more details on upgrading the placement service."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"38212c8f_cbe7cd40","line":89,"updated":"2023-04-06 16:47:42.000000000","message":"I also don\u0027t think this is better than the original plural.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   * Several nova services rely on the external placement service being at the"},{"line_number":88,"context_line":"     latest level. Therefore, you must upgrade placement before any nova"},{"line_number":89,"context_line":"     service. See the"},{"line_number":90,"context_line":"     :placement-doc:`placement upgrade notes \u003cadmin/upgrade-notes.html\u003e` for"},{"line_number":91,"context_line":"     more details on upgrading the placement service."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"2be5e814_4136d016","line":89,"in_reply_to":"38212c8f_cbe7cd40","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5edfb900f47f56631fcfbc0ee8d255a28e4b960d","unresolved":true,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    .. note::"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"      The procedure for rolling upgrades with multiple cells (cells-v2) is not"},{"line_number":275,"context_line":"      yet determined."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Online Configuration Reload"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f9f0e83f_12799011","line":274,"updated":"2023-04-06 16:47:42.000000000","message":"You can just remove the parenthetical here. Before v2, there was v1 and we had to distinguish, but that\u0027s no longer needed, IMHO, so just remove it.","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"7f9662c435e7fa003e3243bfa98c785ce09c1aa2","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    .. note::"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"      The procedure for rolling upgrades with multiple cells (cells-v2) is not"},{"line_number":275,"context_line":"      yet determined."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Online Configuration Reload"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ce034c1a_0ff9a628","line":274,"in_reply_to":"f9f0e83f_12799011","updated":"2023-04-11 10:07:02.000000000","message":"Done","commit_id":"0c9ca4d6f9afb412f03643cf015e61db8027e715"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  is the only choice."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* During upgrade be aware that there will be additional load on nova-conductor."},{"line_number":35,"context_line":"  You may find that you need to add extra nova-conductor workers to deal with"},{"line_number":36,"context_line":"  the additional upgrade related load."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Rolling upgrade process"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e706d7aa_ec6dc296","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":19},"updated":"2024-05-13 12:32:35.000000000","message":"`that` in this context is a filler word.\nit does not really improve the readability of the sentence and is not required for it to be correct. \n\nif anything I would be more inclined to add a comma after find rather than `that`\n\n\nalternatively i would rewrite this as \n\n\n` You may find you need to add extra nova-conductor workers to deal with the\n  additional upgrade related load.`\n-\u003e\n`Depending on the load generated by the upgrade process, you may need to add extra nova-conductor workers.`","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  is the only choice."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* During upgrade be aware that there will be additional load on nova-conductor."},{"line_number":35,"context_line":"  You may find that you need to add extra nova-conductor workers to deal with"},{"line_number":36,"context_line":"  the additional upgrade related load."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Rolling upgrade process"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9841044f_71e65fcd","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":19},"in_reply_to":"e706d7aa_ec6dc296","updated":"2024-05-15 09:07:13.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":74,"context_line":"     ``nova-manage db sync`` command should be run for all cell databases,"},{"line_number":75,"context_line":"     including ``cell0``. If necessary, the ``--config-file`` argument can be"},{"line_number":76,"context_line":"     used to point to the correct ``nova.conf`` file for the given cell."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"     These schema change operations should have minimal or no effect on"},{"line_number":79,"context_line":"     performance, and should not cause any operations to fail."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"85a9279c_47833f10","line":77,"updated":"2024-05-13 12:32:35.000000000","message":"this is not necessarily wrong but this is again not a trivial typo fix.\n\nyou are rewording the content of the document to your commit message is not correct.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":74,"context_line":"     ``nova-manage db sync`` command should be run for all cell databases,"},{"line_number":75,"context_line":"     including ``cell0``. If necessary, the ``--config-file`` argument can be"},{"line_number":76,"context_line":"     used to point to the correct ``nova.conf`` file for the given cell."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"     These schema change operations should have minimal or no effect on"},{"line_number":79,"context_line":"     performance, and should not cause any operations to fail."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"7ca06af2_158bad0c","line":77,"in_reply_to":"85a9279c_47833f10","updated":"2024-05-15 09:07:13.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":111,"context_line":"     with: ``[upgrade_levels]compute\u003dauto``. If this batch-based approach"},{"line_number":112,"context_line":"     is used, only a few compute nodes will have any delayed API"},{"line_number":113,"context_line":"     actions, and to ensure there is enough capacity online to service"},{"line_number":114,"context_line":"     any boot request that happens during this time."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"#. After maintenance window:"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"a74cb8d2_2b18bc02","line":114,"updated":"2024-05-13 12:32:35.000000000","message":"this is technically not required.\n\nthis is subtle changing the meaning of this sentence.\n\npreviously we were saying the previous sentence applied to \"all parallel boot requests that happen in this time period\" after we are saying  the previous statements apply to \"any single request that happens during the time period\"\n\nthe effective meaning remains the same but this is not a type fix this is just a style preference.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":111,"context_line":"     with: ``[upgrade_levels]compute\u003dauto``. If this batch-based approach"},{"line_number":112,"context_line":"     is used, only a few compute nodes will have any delayed API"},{"line_number":113,"context_line":"     actions, and to ensure there is enough capacity online to service"},{"line_number":114,"context_line":"     any boot request that happens during this time."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"#. After maintenance window:"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"af92311e_2081e4e6","line":114,"in_reply_to":"a74cb8d2_2b18bc02","updated":"2024-05-15 09:07:13.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":119,"context_line":"     there are no old orphaned service records using ``nova service-list``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"   * Now that all services are upgraded, we need to send the SIG_HUP signal to all"},{"line_number":122,"context_line":"     the services to clear any cached service version data. When a new service"},{"line_number":123,"context_line":"     starts, it automatically detects which version of the compute RPC protocol"},{"line_number":124,"context_line":"     to use, and it can decide if it is safe to do any online data migrations."},{"line_number":125,"context_line":"     Note, if you used a static value for the upgrade_level, such as"}],"source_content_type":"text/x-rst","patch_set":11,"id":"0232d607_8eaea10a","line":122,"updated":"2024-05-13 12:32:35.000000000","message":"nit: again this is not a typo or grammar fix, it was correct before but you are just changing the voice/style of the sentence to be imperative rather than passive.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":119,"context_line":"     there are no old orphaned service records using ``nova service-list``."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"   * Now that all services are upgraded, we need to send the SIG_HUP signal to all"},{"line_number":122,"context_line":"     the services to clear any cached service version data. When a new service"},{"line_number":123,"context_line":"     starts, it automatically detects which version of the compute RPC protocol"},{"line_number":124,"context_line":"     to use, and it can decide if it is safe to do any online data migrations."},{"line_number":125,"context_line":"     Note, if you used a static value for the upgrade_level, such as"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e48e107c_163a5bf3","line":122,"in_reply_to":"0232d607_8eaea10a","updated":"2024-05-15 09:07:13.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":272,"context_line":"    .. note::"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"      The procedure for rolling upgrades with multiple cells is not yet"},{"line_number":275,"context_line":"      determined."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Online Configuration Reload"},{"line_number":278,"context_line":"    During the upgrade, we pin new services at the older RPC version. When all"}],"source_content_type":"text/x-rst","patch_set":11,"id":"495169fc_5f5a43bb","line":275,"updated":"2024-05-13 12:32:35.000000000","message":"i would just remove this note entirly honestly","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    .. note::"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"      The procedure for rolling upgrades with multiple cells is not yet"},{"line_number":275,"context_line":"      determined."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"Online Configuration Reload"},{"line_number":278,"context_line":"    During the upgrade, we pin new services at the older RPC version. When all"}],"source_content_type":"text/x-rst","patch_set":11,"id":"f05ffe51_6588f3e4","line":275,"in_reply_to":"495169fc_5f5a43bb","updated":"2024-05-15 09:07:13.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":283,"context_line":"    running process to use the latest configuration."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Graceful service shutdown"},{"line_number":286,"context_line":"    Many nova services are python processes listening for messages on an"},{"line_number":287,"context_line":"    AMQP queue, including nova-compute. When sending the SIGTERM signal to"},{"line_number":288,"context_line":"    the process, the process stops getting new work from its queue, completes"},{"line_number":289,"context_line":"    any outstanding work, then terminates. During this process, messages can"},{"line_number":290,"context_line":"    be left on the queue for when the python process starts back up."}],"source_content_type":"text/x-rst","patch_set":11,"id":"6485ccf3_8967f71c","line":287,"range":{"start_line":286,"start_character":70,"end_line":287,"end_character":9},"updated":"2024-05-13 12:32:35.000000000","message":"we should acttully use say `a message queue` as we may not be using amqp","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    running process to use the latest configuration."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Graceful service shutdown"},{"line_number":286,"context_line":"    Many nova services are python processes listening for messages on an"},{"line_number":287,"context_line":"    AMQP queue, including nova-compute. When sending the SIGTERM signal to"},{"line_number":288,"context_line":"    the process, the process stops getting new work from its queue, completes"},{"line_number":289,"context_line":"    any outstanding work, then terminates. During this process, messages can"},{"line_number":290,"context_line":"    be left on the queue for when the python process starts back up."}],"source_content_type":"text/x-rst","patch_set":11,"id":"adffe562_f1d1857c","line":287,"range":{"start_line":286,"start_character":70,"end_line":287,"end_character":9},"in_reply_to":"6485ccf3_8967f71c","updated":"2024-05-15 09:07:13.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"doc/source/reference/glossary.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        :term:`Availability Zone`; while availability zones are visible to"},{"line_number":45,"context_line":"        users, host aggregates are only visible to administrators. Host"},{"line_number":46,"context_line":"        aggregates provide a mechanism to allow administrators to assign"},{"line_number":47,"context_line":"        key-value pairs to groups of machines. Each node can be in multiple"},{"line_number":48,"context_line":"        aggregates, each aggregate can have multiple key-value pairs, and the"},{"line_number":49,"context_line":"        same key-value pair can be assigned to multiple aggregates."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"cd3ff684_dc4cb867","line":47,"range":{"start_line":47,"start_character":61,"end_line":47,"end_character":66},"updated":"2024-05-13 12:32:35.000000000","message":"nit: again this is just a style choice, not a grammar one.\nboth are correct.\n\nhave does not strictly mean the same thing as contained.\n\nin this case, it means associated with.\n\na person can have multiple outstanding speeding tickets\n\ni.e. a person can be associated with multiple outstanding speeding tickets\n\na node can have multiple aggregates \ni.e. a node can be associated with multiple aggregates.\n\n\nbe in is a more explicit way to denote that\n\nbut I would not consider style changes to be trivial.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        :term:`Availability Zone`; while availability zones are visible to"},{"line_number":45,"context_line":"        users, host aggregates are only visible to administrators. Host"},{"line_number":46,"context_line":"        aggregates provide a mechanism to allow administrators to assign"},{"line_number":47,"context_line":"        key-value pairs to groups of machines. Each node can be in multiple"},{"line_number":48,"context_line":"        aggregates, each aggregate can have multiple key-value pairs, and the"},{"line_number":49,"context_line":"        same key-value pair can be assigned to multiple aggregates."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"f6c77b0e_7486281c","line":47,"range":{"start_line":47,"start_character":61,"end_line":47,"end_character":66},"in_reply_to":"cd3ff684_dc4cb867","updated":"2024-05-15 09:07:13.000000000","message":"Acknowledged","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"nova/conf/compute.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":627,"context_line":"        default\u003d30,"},{"line_number":628,"context_line":"        min\u003d0,"},{"line_number":629,"context_line":"        help\u003d\"\"\""},{"line_number":630,"context_line":"Maximum number of 1 second retries in live_migration. It specifies number"},{"line_number":631,"context_line":"of retries to iptables when it complains. It happens when a user continuously"},{"line_number":632,"context_line":"sends live-migration request to same host leading to concurrent request"},{"line_number":633,"context_line":"to iptables."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"Possible values:"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"* Any positive integer representing retry count."}],"source_content_type":"text/x-python","patch_set":11,"id":"7174f72a_38a6d85e","line":634,"range":{"start_line":630,"start_character":0,"end_line":634,"end_character":1},"updated":"2024-05-13 12:32:35.000000000","message":"```\nMaximum number of 1 second retries in live_migration. It specifies the number\nof retries to iptables when it complains. It happens when a user continuously\nsends live-migration request to same host leading to concurrent request\nto iptables.\n```\n\nyou need to add `the` before number on the second sentence\n\nalthough perhaps the larger issues is that nova does not talke to iptables....\n\nand it has not for a long time.\nthis is used in exactly one place now\n\nhttps://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L11238-L11254\n\nso this should read\n\n```\nThis option controls the maximum number of attempts to plug VIFs on the destination host. Historically this could fail due to rate limiting in iptables. Operators should not need to modify this value from its default.\n```\n\ni would also add advanced\u003dtrue to the option.\n\nhttps://docs.openstack.org/oslo.config/latest/reference/defining.html#advanced-option","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"9c5d94e94e97da51b59272634da84f59795b1b73","unresolved":true,"context_lines":[{"line_number":627,"context_line":"        default\u003d30,"},{"line_number":628,"context_line":"        min\u003d0,"},{"line_number":629,"context_line":"        help\u003d\"\"\""},{"line_number":630,"context_line":"Maximum number of 1 second retries in live_migration. It specifies number"},{"line_number":631,"context_line":"of retries to iptables when it complains. It happens when a user continuously"},{"line_number":632,"context_line":"sends live-migration request to same host leading to concurrent request"},{"line_number":633,"context_line":"to iptables."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"Possible values:"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"* Any positive integer representing retry count."}],"source_content_type":"text/x-python","patch_set":11,"id":"91519e7e_2711f8f6","line":634,"range":{"start_line":630,"start_character":0,"end_line":634,"end_character":1},"in_reply_to":"7174f72a_38a6d85e","updated":"2024-05-15 09:07:13.000000000","message":"Should we do it in a separate change, rewording the help message as well as adding advanced option ?","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f8ac9abcc422a4450d3b8c68af6acc155afce4d0","unresolved":true,"context_lines":[{"line_number":627,"context_line":"        default\u003d30,"},{"line_number":628,"context_line":"        min\u003d0,"},{"line_number":629,"context_line":"        help\u003d\"\"\""},{"line_number":630,"context_line":"Maximum number of 1 second retries in live_migration. It specifies number"},{"line_number":631,"context_line":"of retries to iptables when it complains. It happens when a user continuously"},{"line_number":632,"context_line":"sends live-migration request to same host leading to concurrent request"},{"line_number":633,"context_line":"to iptables."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"Possible values:"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"* Any positive integer representing retry count."}],"source_content_type":"text/x-python","patch_set":11,"id":"4ab158aa_08e6ca55","line":634,"range":{"start_line":630,"start_character":0,"end_line":634,"end_character":1},"in_reply_to":"91519e7e_2711f8f6","updated":"2024-05-15 11:49:41.000000000","message":"only if you do not modify this at all in this change.\n\nyou are making enough other changes that are not trivial typo fixes that including this is fine.","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"nova/db/main/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":4237,"context_line":""},{"line_number":4238,"context_line":"    Logic is: find the tables that reference the table passed to this method"},{"line_number":4239,"context_line":"    and walk the tree of references by FK. As child records are found, prepend"},{"line_number":4240,"context_line":"    them to dequeues to execute later in a single database transaction (to"},{"line_number":4241,"context_line":"    avoid orphaning related records if any one insert/delete fails or the"},{"line_number":4242,"context_line":"    archive process is otherwise interrupted)."},{"line_number":4243,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"be815c83_29f130ff","line":4240,"range":{"start_line":4240,"start_character":12,"end_line":4240,"end_character":20},"updated":"2024-05-13 12:32:35.000000000","message":"the python datastucture is called a deque\n\n\n\nwhile that does stand for double ended queue\nthe plural of deque is deques\n\nform the python docs https://docs.python.org/3/library/collections.html#collections.deque\n\n```\nDeques are a generalization of stacks and queues (the name is pronounced “deck” and is short for “double-ended queue”). \n```","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"183fb069c8cf1afbfe3499b65d668c876e673061","unresolved":false,"context_lines":[{"line_number":4237,"context_line":""},{"line_number":4238,"context_line":"    Logic is: find the tables that reference the table passed to this method"},{"line_number":4239,"context_line":"    and walk the tree of references by FK. As child records are found, prepend"},{"line_number":4240,"context_line":"    them to dequeues to execute later in a single database transaction (to"},{"line_number":4241,"context_line":"    avoid orphaning related records if any one insert/delete fails or the"},{"line_number":4242,"context_line":"    archive process is otherwise interrupted)."},{"line_number":4243,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"eaa173cc_6d95bf23","line":4240,"range":{"start_line":4240,"start_character":12,"end_line":4240,"end_character":20},"in_reply_to":"be815c83_29f130ff","updated":"2024-05-15 11:52:51.000000000","message":"Done","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"nova/tests/functional/notification_sample_tests/test_flavor.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"784b6ca64c389448b6beff29149799a5cf2ac344","unresolved":true,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    MAX_MICROVERSION \u003d \u00272.55\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_flavor_update_with_description(self):"},{"line_number":96,"context_line":"        # First create a flavor without a description."},{"line_number":97,"context_line":"        body \u003d {"},{"line_number":98,"context_line":"            \"flavor\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"a06b7ed0_9d13f295","line":95,"updated":"2024-05-13 12:32:35.000000000","message":"nit: this is not wrong but this is not a docs change.\n\nyou do mention \"This change also fixes typos in test names\"\nbut again the initial summary implies this patch would only be docs fixes","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"183fb069c8cf1afbfe3499b65d668c876e673061","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    MAX_MICROVERSION \u003d \u00272.55\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_flavor_update_with_description(self):"},{"line_number":96,"context_line":"        # First create a flavor without a description."},{"line_number":97,"context_line":"        body \u003d {"},{"line_number":98,"context_line":"            \"flavor\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"773e367c_80df63f6","line":95,"in_reply_to":"a06b7ed0_9d13f295","updated":"2024-05-15 11:52:51.000000000","message":"Acknowledged","commit_id":"92527097c4208cca8d45ad6b2a31106747a50347"}],"nova/virt/hyperv/vmops.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"805706e025b2f73f39f0c3663ffa1cd941ac63e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7e4f3f56_6ccb580e","updated":"2024-04-08 17:48:14.000000000","message":"This file has been removed, maybe you accidently added it?","commit_id":"cd9da8833c21c277528b4fdd68ac5d0a0ca22673"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"80d349a5a35a9f77bce01ba583b6dfed10386dfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"612b79ea_38885fdb","in_reply_to":"7e4f3f56_6ccb580e","updated":"2024-04-09 14:57:42.000000000","message":"Done","commit_id":"cd9da8833c21c277528b4fdd68ac5d0a0ca22673"}]}