)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"241533c5b7478632b4b9a32481cbee70ee994e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4984c684_1a3720a1","updated":"2023-06-06 17:55:01.000000000","message":"As far as I could test this still holds true for Cinder volumes, so maybe we should just modify when to log the debug message.","commit_id":"ecd27b33b2bd50b326537cc2d28153a16d59a44d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4dff7dff7ee6dc6628f175f34c536d7187d31e59","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3693708d_75c275dc","updated":"2023-06-06 17:58:54.000000000","message":"For example sparseness doesn\u0027t work on RBD volumes with the virtio bus, we need to use IDE, SCSI, or SATA.  :-(\n\nNothing breaks on the Nova side, the VM works just fine, but the discard doesn\u0027t work and space is not reclaimed.","commit_id":"ecd27b33b2bd50b326537cc2d28153a16d59a44d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b97b6fe51d232cf0b6488f79bd25e12165c51f17","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e328706_a87109a7","in_reply_to":"1569bb5e_8957eff0","updated":"2023-06-06 18:41:59.000000000","message":"ok looking at https://github.com/openstack-k8s-operators/nova-operator/commit/d3c655813f86318405ba57bb48e12f3b1f4d6de1#diff-2f09928534c8686d4f5f3db06dde824dd2857d2338c5850c24e13777cfc8ebd8L158\n\ni think i hit this issue with local qcow + ceph backed cinder.","commit_id":"ecd27b33b2bd50b326537cc2d28153a16d59a44d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e08b1f82fa31b91186d91995c287174da634b45","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1569bb5e_8957eff0","in_reply_to":"3693708d_75c275dc","updated":"2023-06-06 18:38:32.000000000","message":"i think we need to retest with \n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#libvirt.driver_discard\u003dunmap\n\nand confirm for diffent nova and cidner backends.\n\nthis patch is inteded to make discard wrok for local storage with virtio-blk and \n[libvirt]hw_disk_discard\u003dunmap\n\ni think your right that this is not workign the way im expectign\n\nhttps://github.com/openstack/nova/blob/971809b4d4db39e98d6534531e55d5b8fcde49cb/nova/virt/libvirt/imagebackend.py#L114\n\nwe use libvirt.driver_discard to set the discard mode in the imagebackend code which is for nova provisioned sotrage. i realsied reading the code change agains tthe code path i modifed was for attach volume. i was pretty sure that log message i swaw was the same but perhaps it was for BFV not local storage.\n\ni need to recondider this.","commit_id":"ecd27b33b2bd50b326537cc2d28153a16d59a44d"}]}