)]}'
{"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b8e9aa20636819d768d55077749e06b4b625fe98","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"            self.network_info))"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def test_destroy_instance_without_compute(self):"},{"line_number":1250,"context_line":"        self.assertIsNone(self.conn.destroy(self.context,"},{"line_number":1251,"context_line":"                                            self.instance_without_compute,"},{"line_number":1252,"context_line":"                                            self.network_info))"},{"line_number":1253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F7l8%3D","line":1250,"updated":"2014-04-16 12:46:13.000000000","message":"not sure that i understand this test - the destroy method always returns None.\nWe need to test here that the vmops.destroy method is not called","commit_id":"775301d286bb9d1733d35b24c166ee3c502be931"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"b2a1c007984ddf5ddddae3d78242e980362e75cc","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"            self.network_info))"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def test_destroy_instance_without_compute(self):"},{"line_number":1250,"context_line":"        self.assertIsNone(self.conn.destroy(self.context,"},{"line_number":1251,"context_line":"                                            self.instance_without_compute,"},{"line_number":1252,"context_line":"                                            self.network_info))"},{"line_number":1253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2Fxxs%3D","line":1250,"in_reply_to":"AAAAXH%2F%2F7l8%3D","updated":"2014-04-17 14:34:30.000000000","message":"Done","commit_id":"775301d286bb9d1733d35b24c166ee3c502be931"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b8e9aa20636819d768d55077749e06b4b625fe98","unresolved":false,"context_lines":[{"line_number":2262,"context_line":""},{"line_number":2263,"context_line":"    def test_destroy_non_existent(self):"},{"line_number":2264,"context_line":"        self._create_instance()"},{"line_number":2265,"context_line":"        self.assertIsNone(self.conn.destroy(self.context, self.instance,"},{"line_number":2266,"context_line":"            self.network_info))"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def test_destroy_instance_without_compute(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F7lo%3D","line":2265,"updated":"2014-04-16 12:46:13.000000000","message":"same as above, but here we shold test that the vmops method is called","commit_id":"775301d286bb9d1733d35b24c166ee3c502be931"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"b2a1c007984ddf5ddddae3d78242e980362e75cc","unresolved":false,"context_lines":[{"line_number":2262,"context_line":""},{"line_number":2263,"context_line":"    def test_destroy_non_existent(self):"},{"line_number":2264,"context_line":"        self._create_instance()"},{"line_number":2265,"context_line":"        self.assertIsNone(self.conn.destroy(self.context, self.instance,"},{"line_number":2266,"context_line":"            self.network_info))"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def test_destroy_instance_without_compute(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FxxY%3D","line":2265,"in_reply_to":"AAAAXH%2F%2F7lo%3D","updated":"2014-04-17 14:34:30.000000000","message":"Done","commit_id":"775301d286bb9d1733d35b24c166ee3c502be931"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b8e9aa20636819d768d55077749e06b4b625fe98","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"            self.network_info))"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def test_destroy_instance_without_compute(self):"},{"line_number":2269,"context_line":"        self.assertIsNone(self.conn.destroy(self.context,"},{"line_number":2270,"context_line":"                                            self.instance_without_compute,"},{"line_number":2271,"context_line":"                                            self.network_info))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F7lg%3D","line":2269,"updated":"2014-04-16 12:46:13.000000000","message":"ditto","commit_id":"775301d286bb9d1733d35b24c166ee3c502be931"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"b2a1c007984ddf5ddddae3d78242e980362e75cc","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"            self.network_info))"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"    def test_destroy_instance_without_compute(self):"},{"line_number":2269,"context_line":"        self.assertIsNone(self.conn.destroy(self.context,"},{"line_number":2270,"context_line":"                                            self.instance_without_compute,"},{"line_number":2271,"context_line":"                                            self.network_info))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2FxxU%3D","line":2269,"in_reply_to":"AAAAXH%2F%2F7lg%3D","updated":"2014-04-17 14:34:30.000000000","message":"Done","commit_id":"775301d286bb9d1733d35b24c166ee3c502be931"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":1248,"context_line":"                         network_info, destroy_disks):"},{"line_number":1249,"context_line":"            self.destroy_called \u003d True"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":1252,"context_line":"        self._create_instance()"},{"line_number":1253,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":1254,"context_line":"        self.assertTrue(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv44%3D","line":1251,"updated":"2014-04-17 18:30:17.000000000","message":"can you please make use of Mock","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":1248,"context_line":"                         network_info, destroy_disks):"},{"line_number":1249,"context_line":"            self.destroy_called \u003d True"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":1252,"context_line":"        self._create_instance()"},{"line_number":1253,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":1254,"context_line":"        self.assertTrue(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpXk%3D","line":1251,"in_reply_to":"AAAAXH%2F%2Fv44%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"                         network_info, destroy_disks):"},{"line_number":1261,"context_line":"            self.destroy_called \u003d True"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":1264,"context_line":"        self.conn.destroy(self.context, self.instance_without_compute,"},{"line_number":1265,"context_line":"                           self.network_info)"},{"line_number":1266,"context_line":"        self.assertFalse(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv40%3D","line":1263,"updated":"2014-04-17 18:30:17.000000000","message":"ditto","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"                         network_info, destroy_disks):"},{"line_number":1261,"context_line":"            self.destroy_called \u003d True"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":1264,"context_line":"        self.conn.destroy(self.context, self.instance_without_compute,"},{"line_number":1265,"context_line":"                           self.network_info)"},{"line_number":1266,"context_line":"        self.assertFalse(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpXY%3D","line":1263,"in_reply_to":"AAAAXH%2F%2Fv40%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"                                   \u0027node\u0027: self.instance_node})"},{"line_number":2254,"context_line":"        self._check_vm_info(info, power_state.RUNNING)"},{"line_number":2255,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2256,"context_line":"        self.assertEqual(len(instances), 1)"},{"line_number":2257,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2258,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2259,"context_line":"        self.assertEqual(len(instances), 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv4o%3D","line":2256,"updated":"2014-04-17 18:30:17.000000000","message":"the expected value should be first","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"                                   \u0027node\u0027: self.instance_node})"},{"line_number":2254,"context_line":"        self._check_vm_info(info, power_state.RUNNING)"},{"line_number":2255,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2256,"context_line":"        self.assertEqual(len(instances), 1)"},{"line_number":2257,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2258,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2259,"context_line":"        self.assertEqual(len(instances), 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpXQ%3D","line":2256,"in_reply_to":"AAAAXH%2F%2Fv4o%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":2256,"context_line":"        self.assertEqual(len(instances), 1)"},{"line_number":2257,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2258,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2259,"context_line":"        self.assertEqual(len(instances), 0)"},{"line_number":2260,"context_line":"        self.assertIsNone(vm_util.vm_ref_cache_get(self.uuid))"},{"line_number":2261,"context_line":""},{"line_number":2262,"context_line":"    def test_destroy_no_datastore(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv4k%3D","line":2259,"updated":"2014-04-17 18:30:17.000000000","message":"ditto","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":2256,"context_line":"        self.assertEqual(len(instances), 1)"},{"line_number":2257,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2258,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2259,"context_line":"        self.assertEqual(len(instances), 0)"},{"line_number":2260,"context_line":"        self.assertIsNone(vm_util.vm_ref_cache_get(self.uuid))"},{"line_number":2261,"context_line":""},{"line_number":2262,"context_line":"    def test_destroy_no_datastore(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpXI%3D","line":2259,"in_reply_to":"AAAAXH%2F%2Fv4k%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":2265,"context_line":"                                   \u0027node\u0027: self.instance_node})"},{"line_number":2266,"context_line":"        self._check_vm_info(info, power_state.RUNNING)"},{"line_number":2267,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2268,"context_line":"        self.assertEqual(len(instances), 1)"},{"line_number":2269,"context_line":"        # Overwrite the vmPathName"},{"line_number":2270,"context_line":"        vms \u003d vmwareapi_fake._get_objects(\"VirtualMachine\")"},{"line_number":2271,"context_line":"        vm \u003d vms.objects[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv4g%3D","line":2268,"updated":"2014-04-17 18:30:17.000000000","message":"ditto","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":2265,"context_line":"                                   \u0027node\u0027: self.instance_node})"},{"line_number":2266,"context_line":"        self._check_vm_info(info, power_state.RUNNING)"},{"line_number":2267,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2268,"context_line":"        self.assertEqual(len(instances), 1)"},{"line_number":2269,"context_line":"        # Overwrite the vmPathName"},{"line_number":2270,"context_line":"        vms \u003d vmwareapi_fake._get_objects(\"VirtualMachine\")"},{"line_number":2271,"context_line":"        vm \u003d vms.objects[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpXE%3D","line":2268,"in_reply_to":"AAAAXH%2F%2Fv4g%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":2272,"context_line":"        vm.set(\"config.files.vmPathName\", None)"},{"line_number":2273,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2274,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2275,"context_line":"        self.assertEqual(len(instances), 0)"},{"line_number":2276,"context_line":""},{"line_number":2277,"context_line":"    def test_destroy_non_existent(self):"},{"line_number":2278,"context_line":"        self.destroy_called \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv4Y%3D","line":2275,"updated":"2014-04-17 18:30:17.000000000","message":"ditto","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":2272,"context_line":"        vm.set(\"config.files.vmPathName\", None)"},{"line_number":2273,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2274,"context_line":"        instances \u003d self.conn.list_instances()"},{"line_number":2275,"context_line":"        self.assertEqual(len(instances), 0)"},{"line_number":2276,"context_line":""},{"line_number":2277,"context_line":"    def test_destroy_non_existent(self):"},{"line_number":2278,"context_line":"        self.destroy_called \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpXA%3D","line":2275,"in_reply_to":"AAAAXH%2F%2Fv4Y%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":2281,"context_line":"                         network_info, destroy_disks):"},{"line_number":2282,"context_line":"            self.destroy_called \u003d True"},{"line_number":2283,"context_line":""},{"line_number":2284,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":2285,"context_line":"        self._create_instance()"},{"line_number":2286,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2287,"context_line":"        self.assertTrue(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv4Q%3D","line":2284,"updated":"2014-04-17 18:30:17.000000000","message":"please use Mock","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":2281,"context_line":"                         network_info, destroy_disks):"},{"line_number":2282,"context_line":"            self.destroy_called \u003d True"},{"line_number":2283,"context_line":""},{"line_number":2284,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":2285,"context_line":"        self._create_instance()"},{"line_number":2286,"context_line":"        self.conn.destroy(self.context, self.instance, self.network_info)"},{"line_number":2287,"context_line":"        self.assertTrue(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpW8%3D","line":2284,"in_reply_to":"AAAAXH%2F%2Fv4Q%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ec8e24e772522e0f659c4fbfe3b29f1689ab2ca6","unresolved":false,"context_lines":[{"line_number":2293,"context_line":"                         network_info, destroy_disks):"},{"line_number":2294,"context_line":"            self.destroy_called \u003d True"},{"line_number":2295,"context_line":""},{"line_number":2296,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":2297,"context_line":"        self.conn.destroy(self.context, self.instance_without_compute,"},{"line_number":2298,"context_line":"                          self.network_info)"},{"line_number":2299,"context_line":"        self.assertFalse(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Fv4M%3D","line":2296,"updated":"2014-04-17 18:30:17.000000000","message":"please use Mock","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"},{"author":{"_account_id":2067,"name":"sagar-r-nikam","email":"nikam@hp.com","username":"sagar-r-nikam"},"change_message_id":"48ebfb30ed761a4d9b9885537cbdb1a12eff153d","unresolved":false,"context_lines":[{"line_number":2293,"context_line":"                         network_info, destroy_disks):"},{"line_number":2294,"context_line":"            self.destroy_called \u003d True"},{"line_number":2295,"context_line":""},{"line_number":2296,"context_line":"        self.stubs.Set(self.conn._vmops, \"destroy\", fake_destroy)"},{"line_number":2297,"context_line":"        self.conn.destroy(self.context, self.instance_without_compute,"},{"line_number":2298,"context_line":"                          self.network_info)"},{"line_number":2299,"context_line":"        self.assertFalse(self.destroy_called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FpW4%3D","line":2296,"in_reply_to":"AAAAXH%2F%2Fv4M%3D","updated":"2014-04-18 14:52:57.000000000","message":"Done","commit_id":"cd988f7c1ba52853632ee4856fdef939d4e20a76"}]}