)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6a625261b874e10e185e3262ef80fa0c9661c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bbc67d3d_feb0ae75","updated":"2023-04-06 20:52:42.000000000","message":"Still working on everything above this","commit_id":"fabc851d9be50aa6ed4e836185f760a644f687c8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6b50f8219b8120c2168cd4e1d318b2aa8c0c3fd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bb55f310_ee2e3211","updated":"2023-05-08 19:56:14.000000000","message":"recheck ceph job timeout","commit_id":"084b6f384e81fd39e45dd35e7d0cb163eb23d2ea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"55d4409a64a6e9f9001eca0a308bcd8c2f2af580","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd75dbe3_99d3ab79","updated":"2023-05-08 16:59:59.000000000","message":"recheck nova-next live migration failure which happens elsewhere so clearly unrelated","commit_id":"084b6f384e81fd39e45dd35e7d0cb163eb23d2ea"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"62c115f8066cc905f83fd3ac7b5629290baf30ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c98e8288_626e6231","updated":"2023-05-18 17:53:14.000000000","message":"recheck functional weird libvirt import known issue","commit_id":"8bdb419c12e7c6138310970d766e0b974fedbb6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc5d930bb6f040657d6d77f08068a13b2e5bfd1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a299c5be_69f495ad","updated":"2023-07-14 01:52:54.000000000","message":"+1 for now just wondering why the extra index for deleted and the compute_node_id","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"68f857a62a5d30f5dcad17f58f2c520fddf17c78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7ac2974c_cf880369","updated":"2023-06-26 15:58:33.000000000","message":"LGTM but I have a question about the integer size.\nDo you think some operators would exhaust the integer size with a very large number of computes in the same cell ? seems quite huge and nearly impossible to me, unless they scale down/up very frequently (and in this case, we should update the ComputeNode table then)","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6a5f79fd5bdad34f3e05c6c7838aabd03f0668c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"31b5c251_46bf8007","updated":"2023-07-17 21:19:25.000000000","message":"recheck bug 2024859","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bd47cc1b1adc76011788f30eaf4ff8d0c8092871","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fe6fb64b_fd38bd5d","updated":"2023-07-18 13:35:19.000000000","message":"recheck cephadm syntax error?","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"53c4caff8c20e11965d6c7ef3e9c4362aaa3a584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0cc6a827_7f323457","updated":"2023-07-18 16:58:54.000000000","message":"recheck guest kernel crash","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"37645b4e89e521ddfddf2df4c7ffe7438c61548f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"067f01f5_e69f51c2","updated":"2023-07-17 13:54:09.000000000","message":"recheck guest kernel panic","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"eeea46b6b62ec555516ed57eb9bd62e5832ba704","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"eadbca6c_fdeccdb5","updated":"2023-07-17 16:48:30.000000000","message":"recheck known mkfs timeout","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"89636510e0b654233e869a44dfafcc9b0753a423","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6f020ddf_bff17bca","updated":"2023-07-20 13:22:48.000000000","message":"recheck legit timeout but was making progress","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2ac088915b33de1c14e2a4307915068380668d01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"29c9532a_bcacb302","updated":"2023-07-24 17:33:27.000000000","message":"recheck live migration clearly unrelated","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5fc13f5e23d2700eb9a9a35d86a9ade218a7aaf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"42e572c9_b3c6220b","updated":"2023-07-20 20:22:28.000000000","message":"recheck podman failure in devstack setup","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"35b0a90b9b78a31757aa0020fd395eb26ba41254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a9fbec04_c3e30e3f","updated":"2023-07-19 20:55:24.000000000","message":"recheck ubuntu curl bug fixed: https://bugs.launchpad.net/ubuntu/+source/curl/+bug/2028170","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"edd5c6c2d3b9fb8ff010b5aaf4368320551eb9e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3aafb432_622d8c01","updated":"2023-07-19 13:42:44.000000000","message":"recheck unrelated rebuild server failed (maybe didn\u0027t actually rebuild?)","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"03b6fb849f2a36489d7719cf583d6b6508d4f973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"44951e3a_3f33a23d","updated":"2023-07-18 19:24:04.000000000","message":"recheck volume detach failure?","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"063f7e08118bac9e46983ef52d78ae4518410301","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dbeafafb_5d0832f6","updated":"2023-07-14 13:02:19.000000000","message":"thanks thats what i was expecting more or less so happy to upgrade to +2w","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6417d72b56d02e926974017e9b1ea9f399e66eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b694c413_c7c68b25","in_reply_to":"7ac2974c_cf880369","updated":"2023-06-26 16:10:15.000000000","message":"I thought the goal was to use BigInt from now on for database ID columns to avoid that problem? It\u0027s not about the maximum number of *active* records of course, it\u0027s about the total number since the beginning of time. ComputeNodes should surely be created and destroyed less often than instances, but CI or hardware test workloads could be adding/removing ironic compute nodes, or even virtual computes for something like CI. Since we know it has been hit for instances it seems prudent to stick to BigInt for these things going forward, IMHO.","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"523975f338d2cb6bca6e1dc7c2cc1deb4a8154bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"89b25455_c01e0b68","in_reply_to":"b694c413_c7c68b25","updated":"2023-07-11 12:35:24.000000000","message":"Fair enough ditto 👍","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"}],"nova/db/main/migrations/versions/1acf2c98e646_add_compute_id_to_instance.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc5d930bb6f040657d6d77f08068a13b2e5bfd1d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                sa.Column("},{"line_number":37,"context_line":"                    \u0027compute_id\u0027, sa.BigInteger(), nullable\u003dTrue))"},{"line_number":38,"context_line":"            if not prefix:"},{"line_number":39,"context_line":"                batch_op.create_index(\u0027instances_compute_id_deleted_idx\u0027,"},{"line_number":40,"context_line":"                                      (\u0027compute_id\u0027, \u0027deleted\u0027))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        table_name \u003d prefix + \u0027migrations\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"7dc5903c_7ff44a23","line":39,"updated":"2023-07-14 01:52:54.000000000","message":"so in the the main instance table we are creating a index of the compute_id and deleted filed.\n\nis this just to spead up listing delete or non deleted instance by using the compute id?\n\nis this a known perfomice hot spot or are you just doing this because you think it will be beniffical in general.","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b5cf68314005710a6237dcf2888dbf8b7077fe9","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                sa.Column("},{"line_number":37,"context_line":"                    \u0027compute_id\u0027, sa.BigInteger(), nullable\u003dTrue))"},{"line_number":38,"context_line":"            if not prefix:"},{"line_number":39,"context_line":"                batch_op.create_index(\u0027instances_compute_id_deleted_idx\u0027,"},{"line_number":40,"context_line":"                                      (\u0027compute_id\u0027, \u0027deleted\u0027))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        table_name \u003d prefix + \u0027migrations\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"afb3e418_817c6d8e","line":39,"in_reply_to":"7dc5903c_7ff44a23","updated":"2023-07-14 12:50:43.000000000","message":"We have an index on host/node right now because the compute node is constantly doing \"get me all my instances\" and this is the mirror of that. It would be bad to have to scan all instances in the system every time we need to do that. Of course deleted is in there because usually we only want non-deleted ones.","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"063f7e08118bac9e46983ef52d78ae4518410301","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                sa.Column("},{"line_number":37,"context_line":"                    \u0027compute_id\u0027, sa.BigInteger(), nullable\u003dTrue))"},{"line_number":38,"context_line":"            if not prefix:"},{"line_number":39,"context_line":"                batch_op.create_index(\u0027instances_compute_id_deleted_idx\u0027,"},{"line_number":40,"context_line":"                                      (\u0027compute_id\u0027, \u0027deleted\u0027))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        table_name \u003d prefix + \u0027migrations\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"c3a0fd5c_f46c25ca","line":39,"in_reply_to":"afb3e418_817c6d8e","updated":"2023-07-14 13:02:19.000000000","message":"Ack","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"}],"nova/db/main/models.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"68f857a62a5d30f5dcad17f58f2c520fddf17c78","unresolved":true,"context_lines":[{"line_number":350,"context_line":"    # This identifies the ComputeNode object that this instance resides"},{"line_number":351,"context_line":"    # on and should be equivalent to the one referenced by the \u0027node\u0027"},{"line_number":352,"context_line":"    # field above."},{"line_number":353,"context_line":"    compute_id \u003d sa.Column(sa.BigInteger())"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    # *not* flavorid, this is the internal primary_key"},{"line_number":356,"context_line":"    instance_type_id \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":10,"id":"be5eb1eb_848d61de","line":353,"range":{"start_line":353,"start_character":30,"end_line":353,"end_character":40},"updated":"2023-06-26 15:58:33.000000000","message":"any reason why you made it BigInteger while the DB model for ComputeNode is just Integer ? \nhttps://github.com/openstack/nova/blob/d56d1a828df512136645aa257082bc929a4e353d/nova/db/main/models.py#L183\n\nIn general, I wouldn\u0027t nitpick on such thing but `instances` is quite a large table with many entries.","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"063f7e08118bac9e46983ef52d78ae4518410301","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    # This identifies the ComputeNode object that this instance resides"},{"line_number":351,"context_line":"    # on and should be equivalent to the one referenced by the \u0027node\u0027"},{"line_number":352,"context_line":"    # field above."},{"line_number":353,"context_line":"    compute_id \u003d sa.Column(sa.BigInteger())"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    # *not* flavorid, this is the internal primary_key"},{"line_number":356,"context_line":"    instance_type_id \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":10,"id":"47ab721b_12947f0c","line":353,"range":{"start_line":353,"start_character":30,"end_line":353,"end_character":40},"in_reply_to":"048876cb_503ab298","updated":"2023-07-14 13:02:19.000000000","message":"Ack","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b5cf68314005710a6237dcf2888dbf8b7077fe9","unresolved":true,"context_lines":[{"line_number":350,"context_line":"    # This identifies the ComputeNode object that this instance resides"},{"line_number":351,"context_line":"    # on and should be equivalent to the one referenced by the \u0027node\u0027"},{"line_number":352,"context_line":"    # field above."},{"line_number":353,"context_line":"    compute_id \u003d sa.Column(sa.BigInteger())"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    # *not* flavorid, this is the internal primary_key"},{"line_number":356,"context_line":"    instance_type_id \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":10,"id":"048876cb_503ab298","line":353,"range":{"start_line":353,"start_character":30,"end_line":353,"end_character":40},"in_reply_to":"ae65f34a_78e1ce71","updated":"2023-07-14 12:50:43.000000000","message":"Right, I see no point in creating new non-BigInt primary keys we might have to migrate later.","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc5d930bb6f040657d6d77f08068a13b2e5bfd1d","unresolved":true,"context_lines":[{"line_number":350,"context_line":"    # This identifies the ComputeNode object that this instance resides"},{"line_number":351,"context_line":"    # on and should be equivalent to the one referenced by the \u0027node\u0027"},{"line_number":352,"context_line":"    # field above."},{"line_number":353,"context_line":"    compute_id \u003d sa.Column(sa.BigInteger())"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    # *not* flavorid, this is the internal primary_key"},{"line_number":356,"context_line":"    instance_type_id \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ae65f34a_78e1ce71","line":353,"range":{"start_line":353,"start_character":30,"end_line":353,"end_character":40},"in_reply_to":"be5eb1eb_848d61de","updated":"2023-07-14 01:52:54.000000000","message":"i would assume this is because we discused the fact we will need to move all our preiamry keys to BigInteger in the future so dan is avoiding a future migration by just making it a big int now.\n\ni think we even disucssed this in the ptg but i dont recall all the details","commit_id":"a47fdef1bfba8b1e2c3279f2c51eda3d8a985ec1"}]}