)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0d5f192cafaf407e0f97202f7d7ef7a17ef17e12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"eddb2f2c_3cb257eb","updated":"2023-05-30 19:56:04.000000000","message":"recheck legit timeout but tempest was making progress","commit_id":"5f5cc235e6076ba308dcd5622bf977d1e67b7450"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8991d226c35f020f9ba82646a4aca4a2c7f023a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f5594830_439beb9a","updated":"2023-07-13 10:53:57.000000000","message":"LGTM it took me a lot of time to make sure we were providing all the compute_id modifications.","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"37d6b0aef776615e03f20be63de96ed304a25a5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aa71a669_7bed2bf6","updated":"2023-07-26 13:50:21.000000000","message":"recheck dep changed","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"db423a0fda35d18cb7a47188ac8e4a4f9e7474e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"67b7d068_b73b0bbd","updated":"2023-07-26 19:18:08.000000000","message":"recheck guest kernel crashed during live migration","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ca11febaa13bc2a5d6f71cb274543af5ee5c5fa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f02f56d3_d170d932","updated":"2023-06-01 18:31:51.000000000","message":"recheck job timeout but tempest was making progress","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0a14a0e429d3deceb855669684b31e1c0ecd347d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0734f069_9c1f5250","updated":"2023-05-31 17:43:56.000000000","message":"recheck known spurious and unrelated functional failure","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c686d092a2372712d95ac3beb46aaed626df9051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aadeb1c0_20bb602d","updated":"2023-06-02 13:55:47.000000000","message":"recheck timeout but tempest was making progress","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0385fb9e131ade3c6ff29bafef546dfeb40df6a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7b79d962_0fb2fad5","updated":"2023-06-02 17:31:23.000000000","message":"recheck unrelated unit failure","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c872ffeba6c5e2dbbcbb6c89dbff5e64f024fa50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"46ae373f_22a763d5","updated":"2023-07-26 21:38:20.000000000","message":"recheck volume fail","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"}],"nova/compute/manager.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8991d226c35f020f9ba82646a4aca4a2c7f023a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"78a7f1c4_210a7fd6","updated":"2023-07-13 10:53:57.000000000","message":"good work for finding all the places where we need to nullify the compute_id in case of a problem.","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e5dfddf8598680850d2e8c0d84392f6aef51e96c","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        \"\"\""},{"line_number":572,"context_line":"        instance.host \u003d None"},{"line_number":573,"context_line":"        instance.node \u003d None"},{"line_number":574,"context_line":"        instance.compute_id \u003d None"},{"line_number":575,"context_line":"        instance.save()"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE, fair\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":11,"id":"4a12eb39_264a83ef","line":574,"updated":"2023-07-14 16:52:46.000000000","message":"meh, the compute_id is still a reference to the node so sure doing it here is fine i guess without updatign the fucntion name.\n\nits still basically doing the same thing in the new way.","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8991d226c35f020f9ba82646a4aca4a2c7f023a3","unresolved":false,"context_lines":[{"line_number":2262,"context_line":"        # Reset all changes to the instance to make sure that we can detect"},{"line_number":2263,"context_line":"        # any manipulation after the failure."},{"line_number":2264,"context_line":"        orig_node \u003d self.instance.node"},{"line_number":2265,"context_line":"        self.assertNotIn(\u0027compute_id\u0027, self.instance)"},{"line_number":2266,"context_line":"        self.instance.obj_reset_changes(recursive\u003dTrue)"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"        with mock.patch.object(self.instance, \u0027save\u0027) as mock_save:"}],"source_content_type":"text/x-python","patch_set":11,"id":"6376d820_be58f58d","line":2265,"updated":"2023-07-13 10:53:57.000000000","message":"++","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"}],"nova/tests/unit/compute/test_shelve.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8991d226c35f020f9ba82646a4aca4a2c7f023a3","unresolved":false,"context_lines":[{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        self.compute.unshelve_instance("},{"line_number":648,"context_line":"            self.context, instance, image\u003dNone,"},{"line_number":649,"context_line":"            filter_properties\u003d{}, node\u003d\u0027fakenode1\u0027, request_spec\u003drequest_spec,"},{"line_number":650,"context_line":"            accel_uuids\u003d[])"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        mock_update_pci.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":11,"id":"e2c50ac6_415a7f15","line":649,"range":{"start_line":649,"start_character":34,"end_line":649,"end_character":50},"updated":"2023-07-13 10:53:57.000000000","message":"hmmm, yeah, so you fixed a wrong thing, for sure.","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e5dfddf8598680850d2e8c0d84392f6aef51e96c","unresolved":true,"context_lines":[{"line_number":338,"context_line":"        # Try to update node without compute_id and make sure save() does not"},{"line_number":339,"context_line":"        # fail for this older version"},{"line_number":340,"context_line":"        instance.node \u003d \u0027foo\u0027"},{"line_number":341,"context_line":"        instance.save()"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    def test_create_with_host_not_compute_id(self):"},{"line_number":344,"context_line":"        instance \u003d objects.Instance(self.context, uuid\u003duuids.instance,"}],"source_content_type":"text/x-python","patch_set":11,"id":"989af3e6_c6679af3","line":341,"updated":"2023-07-14 16:52:46.000000000","message":"ack so this would raise  exception.ObjectActionError in 2.8+\n\nhere https://review.opendev.org/c/openstack/nova/+/879500/11/nova/objects/instance.py#809\n\nwhich is tested in the previous test case above","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e5dfddf8598680850d2e8c0d84392f6aef51e96c","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        # does not fail for this older version"},{"line_number":372,"context_line":"        instance._context \u003d self.context"},{"line_number":373,"context_line":"        instance.node \u003d \u0027foo\u0027"},{"line_number":374,"context_line":"        instance.create()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    @mock.patch.object(db, \u0027instance_get\u0027)"},{"line_number":377,"context_line":"    def test_get_by_id(self, mock_get):"}],"source_content_type":"text/x-python","patch_set":11,"id":"24ed09e3_2fda984a","line":374,"updated":"2023-07-14 16:52:46.000000000","message":"nit: my brain for some reason expected you to test the old vertion then the new so i had to keep reminding myself that the excption for the non backleved version was asserted in teh previous test case.","commit_id":"625fb569a763f08c55f844034775da2ccf23517e"}]}