)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"34d5c071a49b338eb02c46df35a9dd1b8458de0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9df7fb8a_30efe558","updated":"2023-05-30 19:55:12.000000000","message":"recheck grenade failed to create a volume","commit_id":"9ecbf8892d2271f42835949bec23bebbb8806e7a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"198f117ef601b839518d0c4868a0d6408ca46b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7e19585b_d433de6d","updated":"2023-07-11 13:19:32.000000000","message":"LGTM, no concerns.","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8b485694ba90c2699d24fbd5954daa0704bdc44e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dcdf12e9_9820c9c5","updated":"2023-05-31 17:43:32.000000000","message":"recheck OOM during test","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d967c428f82bbe2b5e3470e610c2c7067fb3c213","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e5d560e4_4d03d2f0","updated":"2023-07-25 13:36:29.000000000","message":"recheck dep merged","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9e0eab20abaebe82869b357e218f2c8d7b0cbaba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"55968a10_e6e9191b","updated":"2023-07-25 16:01:21.000000000","message":"recheck rabbit went down or dropped some things","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d3c644a86526229da07628f617849136cbc7860c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"46ed540d_50d9ca2b","updated":"2023-07-25 19:17:11.000000000","message":"recheck triple volume test failure, unrelated","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8c45b00966c1afb4e4c8ff645817333a7d7de2c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4837fea9_bb5e1545","updated":"2023-07-25 21:28:25.000000000","message":"recheck yet another volume fail","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"198f117ef601b839518d0c4868a0d6408ca46b90","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            self._claim_existing_migration(migration, cn)"},{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            migration \u003d self._create_migration("},{"line_number":312,"context_line":"                context, instance, new_flavor, cn, move_type)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        # TODO(moshele): we are recreating the pci requests even if"},{"line_number":315,"context_line":"        # there was no change on resize. This will cause allocating"}],"source_content_type":"text/x-python","patch_set":8,"id":"d36fd3c4_f240e302","line":312,"updated":"2023-07-11 13:19:32.000000000","message":"cool, you now use the cn.","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"}],"nova/objects/migration.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"198f117ef601b839518d0c4868a0d6408ca46b90","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    def is_same_host_resize(self):"},{"line_number":244,"context_line":"        return self.is_resize and self.source_node \u003d\u003d self.dest_node"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def get_dest_compute_id(self):"},{"line_number":247,"context_line":"        \"\"\"Try to determine the ComputeNode id this migration targets."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        This should be just the dest_compute_id field, but for migrations"}],"source_content_type":"text/x-python","patch_set":8,"id":"09f4de67_9dbcd098","line":246,"updated":"2023-07-11 13:19:32.000000000","message":"note to reviewers : this is not a remotable RPC method, just for locally get the id.","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"198f117ef601b839518d0c4868a0d6408ca46b90","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        \"\"\""},{"line_number":255,"context_line":"        if \u0027dest_compute_id\u0027 not in self:"},{"line_number":256,"context_line":"            self.dest_compute_id \u003d ("},{"line_number":257,"context_line":"                objects.ComputeNode.get_by_host_and_nodename("},{"line_number":258,"context_line":"                    self._context,"},{"line_number":259,"context_line":"                    self.dest_compute,"},{"line_number":260,"context_line":"                    self.dest_node).id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"6a31bafd_488ff459","line":257,"updated":"2023-07-11 13:19:32.000000000","message":"but here, this is a remotable one ;)","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"}],"nova/tests/unit/objects/test_migration.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d66069e0e2252f9724f82969c30a9e3f4dc61a1","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        mig.migration_type \u003d \u0027resize\u0027"},{"line_number":164,"context_line":"        mig.uuid \u003d uuidsentinel.migration"},{"line_number":165,"context_line":"        mig.dest_node \u003d \u0027foo\u0027"},{"line_number":166,"context_line":"        self.assertRaises(exception.ObjectActionError, mig.create)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        mig2 \u003d objects.Migration.obj_from_primitive("},{"line_number":169,"context_line":"            mig.obj_to_primitive(target_version\u003d\u00271.7\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5be512b7_17a90f77","line":166,"updated":"2023-07-14 16:34:48.000000000","message":"ok so this fails because the dest_compute_id is now requried","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d66069e0e2252f9724f82969c30a9e3f4dc61a1","unresolved":true,"context_lines":[{"line_number":168,"context_line":"        mig2 \u003d objects.Migration.obj_from_primitive("},{"line_number":169,"context_line":"            mig.obj_to_primitive(target_version\u003d\u00271.7\u0027))"},{"line_number":170,"context_line":"        mig2._context \u003d ctxt"},{"line_number":171,"context_line":"        mig2.create()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @mock.patch.object(objects.ComputeNode, \u0027get_by_host_and_nodename\u0027)"},{"line_number":174,"context_line":"    def test_get_dest_compute_id(self, mock_get):"}],"source_content_type":"text/x-python","patch_set":8,"id":"8f8f4066_e1b25ca7","line":171,"updated":"2023-07-14 16:34:48.000000000","message":"and then you are backleveling the object as we woudl when talkign to a old compute\nwhich removed the need for the node_id\nso create() does not cause an error\n\nhttps://review.opendev.org/c/openstack/nova/+/879682/8/nova/objects/migration.py#197\n\n+1","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d66069e0e2252f9724f82969c30a9e3f4dc61a1","unresolved":true,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # Now it should be set"},{"line_number":195,"context_line":"        self.assertIn(\u0027dest_compute_id\u0027, mig)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    @mock.patch.object(db, \u0027migration_create\u0027)"},{"line_number":198,"context_line":"    def test_recreate_fails(self, mock_create):"},{"line_number":199,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":8,"id":"68f0732e_5eb2a48a","line":196,"updated":"2023-07-14 16:34:48.000000000","message":"+1","commit_id":"70516d4ff9d0cc74059f147b4dfcaf7405b70643"}]}