)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"578fe1d221c6da54eb79d30a00f7d46c5d4f42a1","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            # TODO(jaypipes): Remove all the disabled junk from the resource"},{"line_number":168,"context_line":"            # tracker. Servicegroup API-level active-checking belongs in the"},{"line_number":169,"context_line":"            # nova-compute manager."},{"line_number":170,"context_line":"            raise Exception(\u0027THIS SHOULD NOT HAPPEN\u0027)"},{"line_number":171,"context_line":"            self._set_instance_host_and_node(instance, None)"},{"line_number":172,"context_line":"            return claims.NopClaim()"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"317a246c_f26a5891","line":170,"updated":"2023-04-13 17:15:45.000000000","message":"i said this i on irc but the only way i can think of getting here is as follows.\n\n\nif the node is enabled when we schdule the vm and calim its allcoation in the conducotro but is disabled vai the api before the build request is recoived by the comptue then we can try to do an instance claim and for a disable node assuming this has not been detected in the compute manager before this point.","commit_id":"9fd693f1204ec2629b4e4480a51ee565727b90d5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6b608c890c65cb86d9c7f8d5da13b5e4019abbca","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            # TODO(jaypipes): Remove all the disabled junk from the resource"},{"line_number":168,"context_line":"            # tracker. Servicegroup API-level active-checking belongs in the"},{"line_number":169,"context_line":"            # nova-compute manager."},{"line_number":170,"context_line":"            raise Exception(\u0027THIS SHOULD NOT HAPPEN\u0027)"},{"line_number":171,"context_line":"            self._set_instance_host_and_node(instance, None)"},{"line_number":172,"context_line":"            return claims.NopClaim()"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"2ce2dbca_8cd0e55c","line":170,"in_reply_to":"317a246c_f26a5891","updated":"2023-04-13 17:26:27.000000000","message":"No, disabled here is not the same (or at all related) to a disabled nova-cpu service. For non-ironic nodes, it is \"do we know about this compute node locally on the hypervisor.\" That means if we get here, it\u0027s because we were sent a migration (or instance boot) for a node that is not ours. That\u0027s a big problem and not something we should just quietly paper over, as this and the move claim does. I noticed this while working on the compute ids stuff, but it\u0027s unrelated.","commit_id":"9fd693f1204ec2629b4e4480a51ee565727b90d5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"578fe1d221c6da54eb79d30a00f7d46c5d4f42a1","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        image_meta \u003d image_meta or {}"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if self.disabled(nodename):"},{"line_number":292,"context_line":"            raise Exception(\u0027THIS SHOULD NOT HAPPEN\u0027)"},{"line_number":293,"context_line":"            # NOTE(danms): We really should not get here, and if we do, we"},{"line_number":294,"context_line":"            # will silently return without doing any resource tracking. This"},{"line_number":295,"context_line":"            # appears to be historical cruft that needs to be cleaned up, as"}],"source_content_type":"text/x-python","patch_set":5,"id":"96e1225f_9023ae21","line":292,"updated":"2023-04-13 17:15:45.000000000","message":"the same edgace wopuld apply here but in this case it woudl be a move operaton not server create.\n\nif we selected a destination host before it was disabel in the api and the move calim was aquired after it was disabled hten we could end up here.\n\nsince disabling a node does not prevent it reciving rpcs it just prevents the schduler from selecting it.","commit_id":"9fd693f1204ec2629b4e4480a51ee565727b90d5"}]}