)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"231c02c7c1efc244dcf941689db627d55500f86c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"fields, where necessary, while updating node resources. This is done"},{"line_number":11,"context_line":"separately from the earlier patch to do new instances just to"},{"line_number":12,"context_line":"demonstrate in CI that we\u0027re still able to run in such a partially-"},{"line_number":13,"context_line":"migrated state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related to blueprint compute-object-ids"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"4d2857c5_0ffc472e","line":13,"updated":"2023-07-14 17:01:34.000000000","message":"+1","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"05fad80bcf8c92e9b3c1be9006d10a0714039fa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"59245e26_23747ce3","updated":"2023-04-10 17:37:23.000000000","message":"recheck post failure seems unrelated?","commit_id":"b19ddc713f5130effc0c742e54cac99e9f947c96"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a0c02ba1b15594c3be1d360bc6c1f101bba1b986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3ee8675_ec41c0e2","updated":"2023-05-22 15:58:41.000000000","message":"recheck failed to ssh to server","commit_id":"e34e4fe1344a29612d15c9bde3706304d7d54766"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"050b820700802d16c7d66c2ac2c1a0d22f36c905","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dfa08858_7a3c55c6","updated":"2023-07-13 10:58:47.000000000","message":"Ah that one is simplier to review :-)","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5254cb571d17dfc684606140300dbf91280c93e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8087a88e_8d602c8f","updated":"2023-07-27 13:34:54.000000000","message":"recheck dep merged","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c15b935b5c79499d3715010f9017b42be626726c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b1b395dc_94e6d147","updated":"2023-07-27 15:42:22.000000000","message":"recheck functional spurious fail","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7781a39ea66b82b563ab57188ba146d647b71837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a61ce5cd_e5d539fa","updated":"2023-05-31 17:44:22.000000000","message":"recheck grenade failed creating volumes","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e58e0f45db7cde1c8cd20a97110ecbd36aa7737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"331239c7_173f714c","updated":"2023-07-28 13:49:30.000000000","message":"recheck known mkfs timeout issue","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8af3e47123f4c00f86ef0527d2ea11bd25d94c8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b1cc0a71_87630421","updated":"2023-07-27 19:47:38.000000000","message":"recheck ssh timeout","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f209f52c0e16abfa94da905fe9de37c4fe7d8d1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ebd7562c_b7f2e273","updated":"2023-07-27 22:21:27.000000000","message":"recheck timeout sshing to guest","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"231c02c7c1efc244dcf941689db627d55500f86c","unresolved":true,"context_lines":[{"line_number":963,"context_line":"                LOG.warning("},{"line_number":964,"context_line":"                    \u0027Correcting compute_id\u003d%i from %i for instance %s\u0027,"},{"line_number":965,"context_line":"                    node.id, instance.compute_id, instance.uuid)"},{"line_number":966,"context_line":"                instance.compute_id \u003d node.id"},{"line_number":967,"context_line":"                changed \u003d True"},{"line_number":968,"context_line":"            if changed:"},{"line_number":969,"context_line":"                # NOTE(danms): Only save if we made a change here, even if"}],"source_content_type":"text/x-python","patch_set":8,"id":"52d8c2f9_afc2793d","line":966,"updated":"2023-07-14 17:01:34.000000000","message":"im still not quite sure when this would happen but yes it is good to correct it if it is out of sync.\n\ni would assuem it would only happen in some migration failures or some other edge case where we had to role back but only did it partly.","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"231c02c7c1efc244dcf941689db627d55500f86c","unresolved":true,"context_lines":[{"line_number":4074,"context_line":""},{"line_number":4075,"context_line":"        # Make sure everyone is set to our node id now"},{"line_number":4076,"context_line":"        for inst in instances:"},{"line_number":4077,"context_line":"            self.assertEqual(123, inst.compute_id)"},{"line_number":4078,"context_line":""},{"line_number":4079,"context_line":""},{"line_number":4080,"context_line":"class TestInstanceInResizeState(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3297ef43_0da1014c","line":4077,"updated":"2023-07-14 17:01:34.000000000","message":"i gues this works\n\nyou have an instance object where compute_id is unset\none where its set to none.\none where its set to the wrong value\nand finally on ewehre it set to the correct value.\n\nyou asserted there were 3 mock calls to the last object was not updated\nand finally asseted all 4 have the deires compute_id set.\n\n\nnormally i would prefer this to be 4 seperate test so its simpler to knwo which failed but this is ok.\n\nwe can split it in the future if we have a bug and we need the granularity","commit_id":"84e7bed27e5842b233a332b570f46c9a6c2e0e17"}]}