)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e64f8c35965d86ad00339dc4b1f55c0994ba55b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95bf507d_a510f17c","updated":"2023-04-12 21:05:48.000000000","message":"Clever :)","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"41dc4e32fd3f324fac9282e958d246139ad83713","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06d9d81e_b3adea4f","updated":"2023-04-13 14:12:08.000000000","message":"Thanks for doing this.","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"48cbdd16b326b5e2edfced8e94fa01b4ac16d691","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"834a35c9_c4ba4289","updated":"2023-04-13 13:56:21.000000000","message":"some minor nits, otherwise LGTM.","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29bb3652f2a8f26fecda712cd54c3fe6b119203c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6013c70d_9c41385c","updated":"2023-04-14 08:26:40.000000000","message":"I have one doc and one implementation suggestion.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7fbf685c_0b9bb8b7","updated":"2023-04-14 09:06:18.000000000","message":"I think we should document the fact that this weigher only support to weigh hosts if all of them are using the same virt driver.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5664b2a01abc96f21fd83e9d5142fe710d691be3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fb335ca6_10b79a0b","in_reply_to":"7fbf685c_0b9bb8b7","updated":"2023-04-14 11:23:50.000000000","message":"that not acttuly ture but it is true that if they use different driver the weights will be in comparable.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d9d9099f5b84cd5d553419ec62bee4e61a3a3a88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1c357cdf_b2c2a778","updated":"2023-04-19 14:52:11.000000000","message":"Actually, the docs job is failing for a good reason.","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e31f1de7c2f9b62744091319e91931f963bd57dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1b765c59_7c685221","updated":"2023-04-20 13:04:14.000000000","message":"My comments where resolved. I have nothing else top of Sylvain\u0027s requests. So I\u0027m +1","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"52a1010c_d16bdfd5","updated":"2023-04-19 14:47:18.000000000","message":"Thanks for the modifications. Just a few nits but nothing holding the merge.","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c017a1d2e9e9990324a3a5390a1cfd7691a14e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ce0b8380_69d3c8a8","updated":"2023-04-21 07:54:11.000000000","message":"Thanks Sean, you own the first implemented blueprint for 2023.2 :) \nhttps://blueprints.launchpad.net/nova/+spec/weigh-host-by-hypervisor-version","commit_id":"e38d6a356b8238038f11565662eaacff2ec2c2df"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cc114823321fb46c677da45f3689a33d3640b52b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5cdce55a_aa797a39","updated":"2023-04-21 07:49:19.000000000","message":"looks good","commit_id":"e38d6a356b8238038f11565662eaacff2ec2c2df"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ce5d5c588f7eb0b9c632d8e60f8b60f8eef0ce9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dc584b95_6b86d495","updated":"2023-04-23 17:46:27.000000000","message":"recheck Exhausted all hosts available for retrying build failures for instance","commit_id":"e38d6a356b8238038f11565662eaacff2ec2c2df"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4d012a1e25ad3c26a85f357d87963b3a68e5713d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"caf4e7bb_d463e75c","updated":"2023-05-03 21:44:36.000000000","message":"recheck tooz dep should be resolved now","commit_id":"e38d6a356b8238038f11565662eaacff2ec2c2df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"91730f5c214b78173f210cede01e3a5a83c2bf42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"214fa446_fed64014","updated":"2023-04-20 21:59:26.000000000","message":"recheck unrelated timeout issues","commit_id":"e38d6a356b8238038f11565662eaacff2ec2c2df"}],"doc/source/admin/scheduling.rst":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"48cbdd16b326b5e2edfced8e94fa01b4ac16d691","unresolved":true,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relitive hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fce134ed_d23d22a4","line":1057,"range":{"start_line":1057,"start_character":21,"end_line":1057,"end_character":29},"updated":"2023-04-13 13:56:21.000000000","message":"s/relitive/relative","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d7719fde72887b2fd072c6ea8613079807a22","unresolved":false,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relitive hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b36b3eb4_7d371bfb","line":1057,"range":{"start_line":1057,"start_character":21,"end_line":1057,"end_character":29},"in_reply_to":"fce134ed_d23d22a4","updated":"2023-04-13 18:42:56.000000000","message":"Done","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29bb3652f2a8f26fecda712cd54c3fe6b119203c","unresolved":true,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relative hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"adb0e32a_7d60e23c","line":1057,"updated":"2023-04-14 08:26:40.000000000","message":"I would not here that for a compute configured with the libvirt driver this will use the version of libvirt as the version of the hypervisor.\n\nCan we also have similar statement for the other virt drivers? E.g. for ironic virt driver it is the major version of the Ironic API that is used as a hypervisor_version, which is always 1 as far as I see. For hyperv it is the windows kernel version. For vmware I cannot really decode what get_about_info returns from the hypervisor","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relative hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"095f1c25_6223f689","line":1057,"range":{"start_line":1057,"start_character":30,"end_line":1057,"end_character":39},"updated":"2023-04-14 09:06:18.000000000","message":"nit: hypervisor","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":false,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relative hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c07c059b_fdc3ff2c","line":1057,"range":{"start_line":1057,"start_character":30,"end_line":1057,"end_character":39},"in_reply_to":"095f1c25_6223f689","updated":"2023-04-18 19:20:38.000000000","message":"Done","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":false,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relative hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ed4a7862_970cebd8","line":1057,"in_reply_to":"74562ab0_cd19f821","updated":"2023-04-18 19:20:38.000000000","message":"Done","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd44e5ea0f8ad96d79027a446c52c26f0c8e21d8","unresolved":true,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relative hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"74562ab0_cd19f821","line":1057,"in_reply_to":"a038cce9_002d4fa1","updated":"2023-04-17 11:29:16.000000000","message":"i didnt really want to be specific since it was virt dirver dependent but i can give some examples\n\nill note that for the libvirt driver its the libvirt verion and the ironic dirver it is the microverion of ironic api.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relative hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e8d569c1_134fd3ad","line":1057,"in_reply_to":"adb0e32a_7d60e23c","updated":"2023-04-14 09:06:18.000000000","message":"Maybe we should say : \"weigh hosts by their internal  hypervisor version that depends on the virtual driver\" to be honest.\n\nWe could also explain that the value is related to the ImagePropertiesFilter filter that verifies the hypervisor version by the image property named \u0027img_hv_requested_version\u0027","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e13ea057c363f214d38c922e7ccd496558f436da","unresolved":true,"context_lines":[{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":".. versionadded:: 28.0.0 (Bobcat)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"Weigh hosts by their relative hypervior version."},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":1060,"context_line":"to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"a038cce9_002d4fa1","line":1057,"in_reply_to":"e8d569c1_134fd3ad","updated":"2023-04-17 08:09:33.000000000","message":"I think we need to be specific about which version the weigher uses. Imagine that you are about to do a minor rolling upgrade and learned from the reno that you can prefer newer hosts now with the weigher. So you set this up with a big positive ratio assuming that the scheduler will prefer the upgraded hosts now. Then you notice that it doesn\u0027t work even though you have newer kernel and qemu on your upgraded host. Right now you have to dig the nova code to figure out that the reason is that your minor upgrade did not touched the libvirt version on the hypervisor and hence the weigher cannot work.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":true,"context_lines":[{"line_number":1070,"context_line":"case nothing special needs to be done. ironic nodes are scheduled using custom"},{"line_number":1071,"context_line":"resource classes so ironic flavors will never match non-ironic compute nodes."},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"if a deployment has multiple non-ironic virt drivers it is recommended to use aggregates"},{"line_number":1074,"context_line":"to group host by virt driver. while this is not strictly required is"},{"line_number":1075,"context_line":"desirable to avoid bias towards one virt driver."},{"line_number":1076,"context_line":"see :ref:`_filtering_hosts_by_isolating_aggregates` and :ref:`AggregateImagePropertiesIsolation`"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5b232729_c7bc801c","line":1073,"range":{"start_line":1073,"start_character":0,"end_line":1073,"end_character":2},"updated":"2023-04-19 14:47:18.000000000","message":"femtonit: *If* with a capital letter.","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"91730f5c214b78173f210cede01e3a5a83c2bf42","unresolved":false,"context_lines":[{"line_number":1070,"context_line":"case nothing special needs to be done. ironic nodes are scheduled using custom"},{"line_number":1071,"context_line":"resource classes so ironic flavors will never match non-ironic compute nodes."},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"if a deployment has multiple non-ironic virt drivers it is recommended to use aggregates"},{"line_number":1074,"context_line":"to group host by virt driver. while this is not strictly required is"},{"line_number":1075,"context_line":"desirable to avoid bias towards one virt driver."},{"line_number":1076,"context_line":"see :ref:`_filtering_hosts_by_isolating_aggregates` and :ref:`AggregateImagePropertiesIsolation`"}],"source_content_type":"text/x-rst","patch_set":9,"id":"8a2f5979_1a10575d","line":1073,"range":{"start_line":1073,"start_character":0,"end_line":1073,"end_character":2},"in_reply_to":"5b232729_c7bc801c","updated":"2023-04-20 21:59:26.000000000","message":"Done","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":true,"context_lines":[{"line_number":1071,"context_line":"resource classes so ironic flavors will never match non-ironic compute nodes."},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"if a deployment has multiple non-ironic virt drivers it is recommended to use aggregates"},{"line_number":1074,"context_line":"to group host by virt driver. while this is not strictly required is"},{"line_number":1075,"context_line":"desirable to avoid bias towards one virt driver."},{"line_number":1076,"context_line":"see :ref:`_filtering_hosts_by_isolating_aggregates` and :ref:`AggregateImagePropertiesIsolation`"},{"line_number":1077,"context_line":"for more information."}],"source_content_type":"text/x-rst","patch_set":9,"id":"0622012f_66a53438","line":1074,"range":{"start_line":1074,"start_character":9,"end_line":1074,"end_character":13},"updated":"2023-04-19 14:47:18.000000000","message":"nit: hosts (plural)","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"91730f5c214b78173f210cede01e3a5a83c2bf42","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"resource classes so ironic flavors will never match non-ironic compute nodes."},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"if a deployment has multiple non-ironic virt drivers it is recommended to use aggregates"},{"line_number":1074,"context_line":"to group host by virt driver. while this is not strictly required is"},{"line_number":1075,"context_line":"desirable to avoid bias towards one virt driver."},{"line_number":1076,"context_line":"see :ref:`_filtering_hosts_by_isolating_aggregates` and :ref:`AggregateImagePropertiesIsolation`"},{"line_number":1077,"context_line":"for more information."}],"source_content_type":"text/x-rst","patch_set":9,"id":"aaa3402e_ee4d87db","line":1074,"range":{"start_line":1074,"start_character":9,"end_line":1074,"end_character":13},"in_reply_to":"0622012f_66a53438","updated":"2023-04-20 21:59:26.000000000","message":"Done","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d9d9099f5b84cd5d553419ec62bee4e61a3a3a88","unresolved":true,"context_lines":[{"line_number":1073,"context_line":"if a deployment has multiple non-ironic virt drivers it is recommended to use aggregates"},{"line_number":1074,"context_line":"to group host by virt driver. while this is not strictly required is"},{"line_number":1075,"context_line":"desirable to avoid bias towards one virt driver."},{"line_number":1076,"context_line":"see :ref:`_filtering_hosts_by_isolating_aggregates` and :ref:`AggregateImagePropertiesIsolation`"},{"line_number":1077,"context_line":"for more information."},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"The default behavior of the HypervisorVersionWeigher is to select newer hosts."}],"source_content_type":"text/x-rst","patch_set":9,"id":"fc08cf7a_f5b86119","line":1076,"updated":"2023-04-19 14:52:11.000000000","message":"oh, actually, you need to remove the underscore, since the target is \u0027filtering_hosts_by_isolating_aggregates\u0027 only.","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"91730f5c214b78173f210cede01e3a5a83c2bf42","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"if a deployment has multiple non-ironic virt drivers it is recommended to use aggregates"},{"line_number":1074,"context_line":"to group host by virt driver. while this is not strictly required is"},{"line_number":1075,"context_line":"desirable to avoid bias towards one virt driver."},{"line_number":1076,"context_line":"see :ref:`_filtering_hosts_by_isolating_aggregates` and :ref:`AggregateImagePropertiesIsolation`"},{"line_number":1077,"context_line":"for more information."},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"The default behavior of the HypervisorVersionWeigher is to select newer hosts."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9317ea2e_abe1d03b","line":1076,"in_reply_to":"fc08cf7a_f5b86119","updated":"2023-04-20 21:59:26.000000000","message":"Done","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"to group host by virt driver. while this is not strictly required is"},{"line_number":1075,"context_line":"desirable to avoid bias towards one virt driver."},{"line_number":1076,"context_line":"see :ref:`_filtering_hosts_by_isolating_aggregates` and :ref:`AggregateImagePropertiesIsolation`"},{"line_number":1077,"context_line":"for more information."},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"The default behavior of the HypervisorVersionWeigher is to select newer hosts."},{"line_number":1080,"context_line":"If you prefer to invert the behavior set the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7155650a_a46ae678","line":1077,"updated":"2023-04-19 14:47:18.000000000","message":"++ for the explanation.","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"}],"doc/source/reference/isolate-aggregates.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":true,"context_lines":[{"line_number":11,"context_line":"      distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"      WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"      under the License."},{"line_number":15,"context_line":".. _filtering_hosts_by_isolating_aggregates:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Filtering hosts by isolating aggregates"}],"source_content_type":"text/x-rst","patch_set":9,"id":"70bd7153_9ebc7745","line":14,"updated":"2023-04-19 14:47:18.000000000","message":"nit: you could have added an empty line here","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"91730f5c214b78173f210cede01e3a5a83c2bf42","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"      WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"      under the License."},{"line_number":15,"context_line":".. _filtering_hosts_by_isolating_aggregates:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Filtering hosts by isolating aggregates"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ce9d5046_3ff9fd03","line":14,"in_reply_to":"70bd7153_9ebc7745","updated":"2023-04-20 21:59:26.000000000","message":"Done","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"}],"nova/conf/scheduler.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e64f8c35965d86ad00339dc4b1f55c0994ba55b4","unresolved":true,"context_lines":[{"line_number":469,"context_line":"        help\u003d\"\"\""},{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"94405657_382ae0d6","line":472,"range":{"start_line":472,"start_character":30,"end_line":472,"end_character":36},"updated":"2023-04-12 21:05:48.000000000","message":"\"hosts\"","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e64f8c35965d86ad00339dc4b1f55c0994ba55b4","unresolved":true,"context_lines":[{"line_number":469,"context_line":"        help\u003d\"\"\""},{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5afa3fe1_350dd7c8","line":472,"range":{"start_line":472,"start_character":59,"end_line":472,"end_character":66},"updated":"2023-04-12 21:05:48.000000000","message":"\"hypervisor version\"","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7fccce927bfe3ad33e868579028205a14019c412","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        help\u003d\"\"\""},{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5e59827e_3b77b88d","line":472,"range":{"start_line":472,"start_character":59,"end_line":472,"end_character":66},"in_reply_to":"5afa3fe1_350dd7c8","updated":"2023-04-13 13:37:22.000000000","message":"Done","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7fccce927bfe3ad33e868579028205a14019c412","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        help\u003d\"\"\""},{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1012131f_7cf7a728","line":472,"range":{"start_line":472,"start_character":30,"end_line":472,"end_character":36},"in_reply_to":"94405657_382ae0d6","updated":"2023-04-13 13:37:22.000000000","message":"Done","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e64f8c35965d86ad00339dc4b1f55c0994ba55b4","unresolved":true,"context_lines":[{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3cb55ac_a1136578","line":473,"range":{"start_line":473,"start_character":42,"end_line":473,"end_character":46},"updated":"2023-04-12 21:05:48.000000000","message":"\"hosts\"","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7fccce927bfe3ad33e868579028205a14019c412","unresolved":false,"context_lines":[{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d2bf27c_32e09770","line":473,"range":{"start_line":473,"start_character":42,"end_line":473,"end_character":46},"in_reply_to":"e3cb55ac_a1136578","updated":"2023-04-13 13:37:22.000000000","message":"Done","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e64f8c35965d86ad00339dc4b1f55c0994ba55b4","unresolved":true,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"Possible values:"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"354ce76f_9766905b","line":474,"range":{"start_line":474,"start_character":15,"end_line":474,"end_character":19},"updated":"2023-04-12 21:05:48.000000000","message":"\"aid\"","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7fccce927bfe3ad33e868579028205a14019c412","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosted based on the reported version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older host, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aide with upgrades."},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"Possible values:"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"53a6c422_2cb2ad25","line":474,"range":{"start_line":474,"start_character":15,"end_line":474,"end_character":19},"in_reply_to":"354ce76f_9766905b","updated":"2023-04-13 13:37:22.000000000","message":"Done","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"41dc4e32fd3f324fac9282e958d246139ad83713","unresolved":true,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"Possible values:"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"* An integer or float value, where the value corresponds to the multipler"},{"line_number":479,"context_line":"  ratio for this weigher."},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"Related options:"},{"line_number":482,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"80073f91_82e4ebbc","line":479,"range":{"start_line":478,"start_character":1,"end_line":479,"end_character":25},"updated":"2023-04-13 14:12:08.000000000","message":"It would be useful for operators to have a specific example of the above possible value.","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d7719fde72887b2fd072c6ea8613079807a22","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"Possible values:"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"* An integer or float value, where the value corresponds to the multipler"},{"line_number":479,"context_line":"  ratio for this weigher."},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"Related options:"},{"line_number":482,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9941c990_e7b7f21e","line":479,"range":{"start_line":478,"start_character":1,"end_line":479,"end_character":25},"in_reply_to":"80073f91_82e4ebbc","updated":"2023-04-13 18:42:56.000000000","message":"Done","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":469,"context_line":"        help\u003d\"\"\""},{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosts based on the reported hypervisor version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older hosts, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aid with upgrades."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a33898f5_34ccd284","line":472,"range":{"start_line":472,"start_character":49,"end_line":472,"end_character":76},"updated":"2023-04-14 09:06:18.000000000","message":"reported hv *by the virt driver*.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":true,"context_lines":[{"line_number":469,"context_line":"        help\u003d\"\"\""},{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosts based on the reported hypervisor version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older hosts, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aid with upgrades."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a57fd25d_13f8dd31","line":472,"range":{"start_line":472,"start_character":49,"end_line":472,"end_character":76},"in_reply_to":"a33898f5_34ccd284","updated":"2023-04-18 19:20:38.000000000","message":"i think this makes the sentance more verbose but not cleaner.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":false,"context_lines":[{"line_number":469,"context_line":"        help\u003d\"\"\""},{"line_number":470,"context_line":"Hypervisor Version weight multiplier ratio."},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"Multiplier used for weighting hosts based on the reported hypervisor version."},{"line_number":473,"context_line":"Negative numbers indicate prefering older hosts, the default is to prefer"},{"line_number":474,"context_line":"newer hosts to aid with upgrades."},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ebc58745_5e938112","line":472,"range":{"start_line":472,"start_character":49,"end_line":472,"end_character":76},"in_reply_to":"a57fd25d_13f8dd31","updated":"2023-04-19 14:47:18.000000000","message":"Ack","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":495,"context_line":"    [filter_scheduler]"},{"line_number":496,"context_line":"    hypervisor_version_weight_multiplier\u003d2.5"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"* disable weigher influence"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"  .. code-block:: ini"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    [filter_scheduler]"},{"line_number":503,"context_line":"    hypervisor_version_weight_multiplier\u003d0"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"Related options:"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"05f5c156_977037c8","line":503,"range":{"start_line":498,"start_character":0,"end_line":503,"end_character":42},"updated":"2023-04-14 09:06:18.000000000","message":"sure, but that\u0027s not really related to this weigher, rather for any weigher.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5664b2a01abc96f21fd83e9d5142fe710d691be3","unresolved":true,"context_lines":[{"line_number":495,"context_line":"    [filter_scheduler]"},{"line_number":496,"context_line":"    hypervisor_version_weight_multiplier\u003d2.5"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"* disable weigher influence"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"  .. code-block:: ini"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    [filter_scheduler]"},{"line_number":503,"context_line":"    hypervisor_version_weight_multiplier\u003d0"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"Related options:"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6dae3bb8_5d48a0a1","line":503,"range":{"start_line":498,"start_character":0,"end_line":503,"end_character":42},"in_reply_to":"05f5c156_977037c8","updated":"2023-04-14 11:23:50.000000000","message":"i added it for because there are two ways to disable the weigher this is the simplest the other way is to define [filter_scheduler] weight_classes\nto be all weigher except this which is error prone so i wanted to push people to just settign the multipler to 0 instead","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    [filter_scheduler]"},{"line_number":496,"context_line":"    hypervisor_version_weight_multiplier\u003d2.5"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"* disable weigher influence"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"  .. code-block:: ini"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    [filter_scheduler]"},{"line_number":503,"context_line":"    hypervisor_version_weight_multiplier\u003d0"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"Related options:"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"359c3720_e2cf7712","line":503,"range":{"start_line":498,"start_character":0,"end_line":503,"end_character":42},"in_reply_to":"6dae3bb8_5d48a0a1","updated":"2023-04-19 14:47:18.000000000","message":"Ok, fair enough.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"}],"nova/scheduler/weights/hypervisor_version.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e64f8c35965d86ad00339dc4b1f55c0994ba55b4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Hypervisor Version Weigher.  Weigh hosts by their relitive hypervior version."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":19,"context_line":"to invent the behaivor  set the \u0027hypervisor_version_weight_multiplier\u0027 option"},{"line_number":20,"context_line":"to a negative number and the weighing has the opposite effect of the default."},{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"35be00a6_cc377141","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":22},"updated":"2023-04-12 21:05:48.000000000","message":"\"behavior\"","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e64f8c35965d86ad00339dc4b1f55c0994ba55b4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Hypervisor Version Weigher.  Weigh hosts by their relitive hypervior version."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":19,"context_line":"to invent the behaivor  set the \u0027hypervisor_version_weight_multiplier\u0027 option"},{"line_number":20,"context_line":"to a negative number and the weighing has the opposite effect of the default."},{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4e46d71d_f6645836","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":9},"updated":"2023-04-12 21:05:48.000000000","message":"\"invert\"","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7fccce927bfe3ad33e868579028205a14019c412","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Hypervisor Version Weigher.  Weigh hosts by their relitive hypervior version."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":19,"context_line":"to invent the behaivor  set the \u0027hypervisor_version_weight_multiplier\u0027 option"},{"line_number":20,"context_line":"to a negative number and the weighing has the opposite effect of the default."},{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"083cf74e_f44bcc09","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":22},"in_reply_to":"35be00a6_cc377141","updated":"2023-04-13 13:37:22.000000000","message":"Done","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7fccce927bfe3ad33e868579028205a14019c412","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Hypervisor Version Weigher.  Weigh hosts by their relitive hypervior version."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":19,"context_line":"to invent the behaivor  set the \u0027hypervisor_version_weight_multiplier\u0027 option"},{"line_number":20,"context_line":"to a negative number and the weighing has the opposite effect of the default."},{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"456b87ef_ff00d7e8","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":9},"in_reply_to":"4e46d71d_f6645836","updated":"2023-04-13 13:37:22.000000000","message":"Done","commit_id":"d3d9862d1a0e7a39e923215fe193fc4baffde5df"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"48cbdd16b326b5e2edfced8e94fa01b4ac16d691","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Hypervisor Version Weigher.  Weigh hosts by their relitive hypervior version."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":19,"context_line":"to invert the behavior set the \u0027hypervisor_version_weight_multiplier\u0027 option"}],"source_content_type":"text/x-python","patch_set":5,"id":"05c846b3_14a23bd4","line":16,"range":{"start_line":16,"start_character":50,"end_line":16,"end_character":58},"updated":"2023-04-13 13:56:21.000000000","message":"s/relitive/relative","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d7719fde72887b2fd072c6ea8613079807a22","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Hypervisor Version Weigher.  Weigh hosts by their relitive hypervior version."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The default is to select newer hosts.  If you prefer"},{"line_number":19,"context_line":"to invert the behavior set the \u0027hypervisor_version_weight_multiplier\u0027 option"}],"source_content_type":"text/x-python","patch_set":5,"id":"52190da6_9a1fcea2","line":16,"range":{"start_line":16,"start_character":50,"end_line":16,"end_character":58},"in_reply_to":"05c846b3_14a23bd4","updated":"2023-04-13 18:42:56.000000000","message":"Done","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29bb3652f2a8f26fecda712cd54c3fe6b119203c","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"d439e068_ad8b0131","line":38,"updated":"2023-04-14 08:26:40.000000000","message":"I guess the intention is to convert None to an integer, which is OK. \nHowever it has a side effect that makes Node(hypervisor_version\u003d0) and Node(hypervisor_version\u003d1) equally new for this weigher.\n\nI would say\n```\nif host_state.hypervisor_version is None:\n    return 1\n\nreturn host_State.hypervisor_version\n```","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"ecae1fe9_59c8d1a7","line":38,"updated":"2023-04-14 09:06:18.000000000","message":"I think about one thing tho : if an environment is using multiple computes with different virt drivers for each of them, then the weigher would probably wrongly normalize the versions between, say Ironic and libvirt.\n\nWe should explain that this weigher should only weigh between hosts using the same virt driver, and operators should either only use one virt driver for all of the computes, or trying to use something like aggregates or traits for only getting accepted hosts to be weighted by only one virt driver.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e13ea057c363f214d38c922e7ccd496558f436da","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"70e7ed92_623fb352","line":38,"in_reply_to":"30fa69da_80409182","updated":"2023-04-17 08:09:33.000000000","message":"\u003e Yeah, tbc I don\u0027t want to change the implementation for checking the hypervisor types, I just want to add a phrase in the config option documentation to say if you use more than one virt driver, then you should make sure this weigher will only verify hosts with the same driver.\n\n+1","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"91af9204_593e3711","line":38,"in_reply_to":"70e7ed92_623fb352","updated":"2023-04-18 19:20:38.000000000","message":"Done","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8fb61d1c58835ed5cebba6cb5e202b4415cced4c","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"30fa69da_80409182","line":38,"in_reply_to":"8f08cd03_beed5197","updated":"2023-04-14 14:30:03.000000000","message":"Yeah, tbc I don\u0027t want to change the implementation for checking the hypervisor types, I just want to add a phrase in the config option documentation to say if you use more than one virt driver, then you should make sure this weigher will only verify hosts with the same driver.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5664b2a01abc96f21fd83e9d5142fe710d691be3","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"f68940e3_0feb56e3","line":38,"in_reply_to":"d439e068_ad8b0131","updated":"2023-04-14 11:23:50.000000000","message":"i could set this to 0 yes.\n\nfor what its worht i dont think this is ever None for real virt drivers\nbut when i was adding the unit test i used the cpu weigher as a reference and it had some testign for None so i wanted to keep this simple and always return an int\n\n0 is as good as any other value in this regard so ill make that change.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5664b2a01abc96f21fd83e9d5142fe710d691be3","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f08cd03_beed5197","line":38,"in_reply_to":"ecae1fe9_59c8d1a7","updated":"2023-04-14 11:23:50.000000000","message":"so i did think about this being differnt for diffent driver and my view was this.\n\nin general while a flavor can be portabel across hypervireos they often are not.\n\nin the case of ironic the resouce classes for cpu/ram/disk will be set to 0 and a custom resouce class is used to select the ironic host.\n\nso if your using an ironic flavor the weigher will only ever see ironic hosts.\nfor libvirt or other vm based drivers a flaovr will request cpu/ram resouce that wont be be avaiabel on ironci RPs so again there is no confict with ironic.\n\n\nthe most common deployemnt type is 1 vert driver or 1 + ironic.\n\nthe next most common woudl be libvirt for linux guest and hyperv for windows \n\nin such a confiugriont the isolated aggreate feature is recomemned \nhttps://docs.openstack.org/nova/latest/reference/isolate-aggregates.html\nfailing that the AggregateImagePropertiesIsolation  is used to match on the OS_TYPE key.\n\nso again by the time we get to weighign we woudl expect not to have a mix of hypervirors in most cases.\n\n\nwhere there is a mix ti would prefer libvirt because of how we convert its version to an int.\n\n\ni can add references to this in the docs but i think the implemnation is likely correct.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        return host_state.hypervisor_version or 1"}],"source_content_type":"text/x-python","patch_set":7,"id":"821c4b23_c4f40ac3","line":38,"in_reply_to":"f68940e3_0feb56e3","updated":"2023-04-18 19:20:38.000000000","message":"Done","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e31f1de7c2f9b62744091319e91931f963bd57dd","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _weigh_object(self, host_state, weight_properties):"},{"line_number":37,"context_line":"        \"\"\"Higher weights win.  We want newer hosts by default.\"\"\""},{"line_number":38,"context_line":"        # convert None to 0"},{"line_number":39,"context_line":"        return host_state.hypervisor_version or 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"a48daf8e_53fd5ebb","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":49},"updated":"2023-04-20 13:04:14.000000000","message":"OK, that works for me.","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"}],"nova/tests/unit/scheduler/weights/test_weights_hypervisor_version.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_all_hosts(self):"},{"line_number":35,"context_line":"        host_values \u003d ["},{"line_number":36,"context_line":"            (\u0027host1\u0027, \u0027node1\u0027, {\u0027hypervisor_version\u0027: 1}),"},{"line_number":37,"context_line":"            (\u0027host2\u0027, \u0027node2\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":38,"context_line":"            (\u0027host3\u0027, \u0027node3\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":39,"context_line":"            (\u0027host4\u0027, \u0027node4\u0027, {\u0027hypervisor_version\u0027: 3}),"}],"source_content_type":"text/x-python","patch_set":7,"id":"8a124979_171ae591","line":36,"range":{"start_line":36,"start_character":54,"end_line":36,"end_character":55},"updated":"2023-04-14 09:06:18.000000000","message":"I\u0027d prefer if you could add larger values like 10, 100, 200 and 1000 to see how the weigher normalizes the values.\n\neg. :\n\n- 1 would be 0.0\n- 1000 would be 1.0\n- 100 would be 0.1\n- 200 would be 0.2","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5664b2a01abc96f21fd83e9d5142fe710d691be3","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_all_hosts(self):"},{"line_number":35,"context_line":"        host_values \u003d ["},{"line_number":36,"context_line":"            (\u0027host1\u0027, \u0027node1\u0027, {\u0027hypervisor_version\u0027: 1}),"},{"line_number":37,"context_line":"            (\u0027host2\u0027, \u0027node2\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":38,"context_line":"            (\u0027host3\u0027, \u0027node3\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":39,"context_line":"            (\u0027host4\u0027, \u0027node4\u0027, {\u0027hypervisor_version\u0027: 3}),"}],"source_content_type":"text/x-python","patch_set":7,"id":"988fc306_b70ce2ac","line":36,"range":{"start_line":36,"start_character":54,"end_line":36,"end_character":55},"in_reply_to":"8a124979_171ae591","updated":"2023-04-14 11:23:50.000000000","message":"sure although 1 would be 1/1000 or 0.001 not 0  :)","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8fb61d1c58835ed5cebba6cb5e202b4415cced4c","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_all_hosts(self):"},{"line_number":35,"context_line":"        host_values \u003d ["},{"line_number":36,"context_line":"            (\u0027host1\u0027, \u0027node1\u0027, {\u0027hypervisor_version\u0027: 1}),"},{"line_number":37,"context_line":"            (\u0027host2\u0027, \u0027node2\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":38,"context_line":"            (\u0027host3\u0027, \u0027node3\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":39,"context_line":"            (\u0027host4\u0027, \u0027node4\u0027, {\u0027hypervisor_version\u0027: 3}),"}],"source_content_type":"text/x-python","patch_set":7,"id":"98c863d0_924d7263","line":36,"range":{"start_line":36,"start_character":54,"end_line":36,"end_character":55},"in_reply_to":"988fc306_b70ce2ac","updated":"2023-04-14 14:30:03.000000000","message":"No, unless I\u0027m wrong : \nhttps://github.com/openstack/nova/blob/ae42400b7663bc58d5562de99e976c95131b77a9/nova/weights.py#L30-L56\n\nthe minval value would be 1.0 so :\n((i - minval) / range_ for i in weight_list) \u003d (1 - 1.0) / (1000 - 1) \u003d 0 😄","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_all_hosts(self):"},{"line_number":35,"context_line":"        host_values \u003d ["},{"line_number":36,"context_line":"            (\u0027host1\u0027, \u0027node1\u0027, {\u0027hypervisor_version\u0027: 1}),"},{"line_number":37,"context_line":"            (\u0027host2\u0027, \u0027node2\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":38,"context_line":"            (\u0027host3\u0027, \u0027node3\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":39,"context_line":"            (\u0027host4\u0027, \u0027node4\u0027, {\u0027hypervisor_version\u0027: 3}),"}],"source_content_type":"text/x-python","patch_set":7,"id":"d4f098a7_4a8da78d","line":36,"range":{"start_line":36,"start_character":54,"end_line":36,"end_character":55},"in_reply_to":"98c863d0_924d7263","updated":"2023-04-18 19:20:38.000000000","message":"ill add the values and add one test to show the total ordering but i don think we shoudl be testing the normalisation in this test that is generic and not related to this weigher.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_all_hosts(self):"},{"line_number":35,"context_line":"        host_values \u003d ["},{"line_number":36,"context_line":"            (\u0027host1\u0027, \u0027node1\u0027, {\u0027hypervisor_version\u0027: 1}),"},{"line_number":37,"context_line":"            (\u0027host2\u0027, \u0027node2\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":38,"context_line":"            (\u0027host3\u0027, \u0027node3\u0027, {\u0027hypervisor_version\u0027: 2}),"},{"line_number":39,"context_line":"            (\u0027host4\u0027, \u0027node4\u0027, {\u0027hypervisor_version\u0027: 3}),"}],"source_content_type":"text/x-python","patch_set":7,"id":"92487a30_5819438e","line":36,"range":{"start_line":36,"start_character":54,"end_line":36,"end_character":55},"in_reply_to":"d4f098a7_4a8da78d","updated":"2023-04-19 14:47:18.000000000","message":"Yeah, true, we shouldn\u0027t check the normalized value or the test would depend on another method and wouldn\u0027t longer be isolated.","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10752f2138e5ff2111b0bec3c33d74535db4182a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            (\u0027host1\u0027, \u0027node1\u0027, {\u0027hypervisor_version\u0027: 1}),"},{"line_number":37,"context_line":"            (\u0027host2\u0027, \u0027node2\u0027, {\u0027hypervisor_version\u0027: 200}),"},{"line_number":38,"context_line":"            (\u0027host3\u0027, \u0027node3\u0027, {\u0027hypervisor_version\u0027: 100}),"},{"line_number":39,"context_line":"            (\u0027host4\u0027, \u0027node4\u0027, {\u0027hypervisor_version\u0027: 1000}),"},{"line_number":40,"context_line":"        ]"},{"line_number":41,"context_line":"        return [fakes.FakeHostState(host, node, values)"},{"line_number":42,"context_line":"                for host, node, values in host_values]"}],"source_content_type":"text/x-python","patch_set":9,"id":"20edf216_bd41868d","line":39,"updated":"2023-04-19 14:47:18.000000000","message":"thanks for the changes.","commit_id":"308da69144db396bad4aae65ce6905f7341d5140"}],"releasenotes/notes/hypervisor-version-weigher-d0bba77e720edafe.yaml":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"48cbdd16b326b5e2edfced8e94fa01b4ac16d691","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    A new hypervisor version weigher has been added that will prefer selecting"},{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior eitehr remove"},{"line_number":16,"context_line":"    the weigher form the list of enabeld weigher or set"},{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"def36dec_67314ff5","line":15,"range":{"start_line":15,"start_character":62,"end_line":15,"end_character":68},"updated":"2023-04-13 13:56:21.000000000","message":"s/eitehr/either","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d7719fde72887b2fd072c6ea8613079807a22","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    A new hypervisor version weigher has been added that will prefer selecting"},{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior eitehr remove"},{"line_number":16,"context_line":"    the weigher form the list of enabeld weigher or set"},{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c7c36bac_24f81cfd","line":15,"range":{"start_line":15,"start_character":62,"end_line":15,"end_character":68},"in_reply_to":"def36dec_67314ff5","updated":"2023-04-13 18:42:56.000000000","message":"Done","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"48cbdd16b326b5e2edfced8e94fa01b4ac16d691","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior eitehr remove"},{"line_number":16,"context_line":"    the weigher form the list of enabeld weigher or set"},{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"},{"line_number":19,"context_line":"    preferance is given to new hosts, higher values will make the effect"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c29f6d92_e093eaa2","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":20},"updated":"2023-04-13 13:56:21.000000000","message":"from ?","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"48cbdd16b326b5e2edfced8e94fa01b4ac16d691","unresolved":true,"context_lines":[{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior eitehr remove"},{"line_number":16,"context_line":"    the weigher form the list of enabeld weigher or set"},{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"},{"line_number":19,"context_line":"    preferance is given to new hosts, higher values will make the effect"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d4695767_e221d9c6","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":40},"updated":"2023-04-13 13:56:21.000000000","message":"s/enabeld/enabled","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d7719fde72887b2fd072c6ea8613079807a22","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior eitehr remove"},{"line_number":16,"context_line":"    the weigher form the list of enabeld weigher or set"},{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"},{"line_number":19,"context_line":"    preferance is given to new hosts, higher values will make the effect"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7b4d57dc_2bc7df6f","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":20},"in_reply_to":"c29f6d92_e093eaa2","updated":"2023-04-13 18:42:56.000000000","message":"Done","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d7719fde72887b2fd072c6ea8613079807a22","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior eitehr remove"},{"line_number":16,"context_line":"    the weigher form the list of enabeld weigher or set"},{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"},{"line_number":19,"context_line":"    preferance is given to new hosts, higher values will make the effect"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"08eb6dfd_aa6d62ac","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":40},"in_reply_to":"d4695767_e221d9c6","updated":"2023-04-13 18:42:56.000000000","message":"Done","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"48cbdd16b326b5e2edfced8e94fa01b4ac16d691","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"},{"line_number":19,"context_line":"    preferance is given to new hosts, higher values will make the effect"},{"line_number":20,"context_line":"    more pronounced and negitive values will prefer older hosts."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4eacae79_f0c3d85f","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":32},"updated":"2023-04-13 13:56:21.000000000","message":"s/negitive/negative","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"833d7719fde72887b2fd072c6ea8613079807a22","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    ``[filter_scheduler]hypervisor_version_weight_multiplier\u003d0``. the default"},{"line_number":18,"context_line":"    value of the hypervisor_version_weight_multiplier is 1 so only a mild"},{"line_number":19,"context_line":"    preferance is given to new hosts, higher values will make the effect"},{"line_number":20,"context_line":"    more pronounced and negitive values will prefer older hosts."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4cbd37db_af86b055","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":32},"in_reply_to":"4eacae79_f0c3d85f","updated":"2023-04-13 18:42:56.000000000","message":"Done","commit_id":"9c9dfa1302669b2911231080e88a846f6285956d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new hypervisor version weigher has been added to prefer selecting hosts"},{"line_number":5,"context_line":"    with newer hyperviors installed. For the libvirt driver this is the version"},{"line_number":6,"context_line":"    of libvirt on the compute node not the version of qemu. As with all"},{"line_number":7,"context_line":"    weighers this is enabled by default and its behavior can be modified using"},{"line_number":8,"context_line":"    the new ``hypervisor_version_weight_multiplier`` config option in the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"698ae40c_eb4e819d","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":25},"updated":"2023-04-14 09:06:18.000000000","message":"nit: hypervisors","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A new hypervisor version weigher has been added to prefer selecting hosts"},{"line_number":5,"context_line":"    with newer hyperviors installed. For the libvirt driver this is the version"},{"line_number":6,"context_line":"    of libvirt on the compute node not the version of qemu. As with all"},{"line_number":7,"context_line":"    weighers this is enabled by default and its behavior can be modified using"},{"line_number":8,"context_line":"    the new ``hypervisor_version_weight_multiplier`` config option in the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c54e7cda_e84231ec","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":25},"in_reply_to":"698ae40c_eb4e819d","updated":"2023-04-18 19:20:38.000000000","message":"Done","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e46f914f3ea3600fb3f11a0d3db87bfe62d0186d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    A new hypervisor version weigher has been added that will prefer selecting"},{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior either remove"},{"line_number":16,"context_line":"    the weigher from the list of enabled weighers or set"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"21b8cd0c_a9b7d99d","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":34},"updated":"2023-04-14 09:06:18.000000000","message":"nit: hypervisor","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4dcc2a4ca3b4eeb5dcce052de411535113beb06d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - |"},{"line_number":12,"context_line":"    A new hypervisor version weigher has been added that will prefer selecting"},{"line_number":13,"context_line":"    hosts with a newer hypervisors installed. This can help simplfy rolling"},{"line_number":14,"context_line":"    upgrades by prefering the already upgraded hosts when moving workloads around"},{"line_number":15,"context_line":"    using live or cold migration. To restore the old behavior either remove"},{"line_number":16,"context_line":"    the weigher from the list of enabled weighers or set"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"50d9fbdc_758b0407","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":34},"in_reply_to":"21b8cd0c_a9b7d99d","updated":"2023-04-18 19:20:38.000000000","message":"Done","commit_id":"d760a9f15e1568097f0688839554610cfbac1faf"}]}