)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1b09eb991a7e48e45b5f49c7d2cc7fac50ac2a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc300553_418b53fe","updated":"2023-04-14 23:01:12.000000000","message":"I repro\u0027ed the buggy behavior in a local devstack and can also confirm that this patch fixes the issue. We don\u0027t really have a facility for testing the actual CLI invocation itself, so I am OK with this patch not having test coverage.\n\nThanks for catching this.","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"9d836a3f8ca6679a154b909ec2948b7d4c578282","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c419396a_2b31f7a7","updated":"2023-04-18 22:01:47.000000000","message":"recheck","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f4af6043321e9f4751e6cc81e44f99fb39b981e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87089bd5_d82fb201","updated":"2023-12-19 03:13:43.000000000","message":"recheck [ERROR] /opt/stack/new/grenade/projects/70_cinder/resources.sh:199 SSH to the client did not work, something very wrong","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"245d7e50d49ef41aa6a3db6d517096f6447e1290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44f39cb0_5f0e83ac","updated":"2023-11-30 21:53:40.000000000","message":"recheck get new logs","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2b03d24aab452ba465c3d01c4c908ab6799f65b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d35a6a37_f0698fdd","updated":"2023-12-08 21:04:32.000000000","message":"recheck guest kernel panic in nova-next","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"370153f0b13107e8862d8360039c0eb86fad3856","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a28d639b_f6c10b96","updated":"2024-03-26 19:02:18.000000000","message":"Looks good, thanks","commit_id":"1c02c0da1702ab1f58e930782a8866ed683c3c7d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dc37fe7c09a59809f23ec37dd736363a046f328a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ba441c5_81c9bcf7","updated":"2024-03-26 19:48:18.000000000","message":"ok i tested that locally i can repoduce the error without this patch and that with it it proceed to trying to connect ot the db so this appears to be correct.\nim less happy that we dont have test the actual parsing logic.\n\nthis is somethign we could test in functioanl tests but we do not ahve any test infra set up to do that currently so ill approve this as is for now.\n\nwe shoudl fix that testing gap at some point","commit_id":"1c02c0da1702ab1f58e930782a8866ed683c3c7d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5ad0dbe5f4cc5bcd7707867995ab255384188d37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a340624_9f6aa0c3","updated":"2024-03-27 14:28:46.000000000","message":"recheck grenade issue, looks like bug https://bugs.launchpad.net/nova/+bug/2033141","commit_id":"1c02c0da1702ab1f58e930782a8866ed683c3c7d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f08b2b022c9d3851ace74f7b40f8b5c566f20542","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0aa0e875_1257bb0f","updated":"2024-03-26 22:09:38.000000000","message":"recheck tempest-integrated-compute TIMED_OUT no tests failed","commit_id":"1c02c0da1702ab1f58e930782a8866ed683c3c7d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"61d9a2a4fd257ecf63818ef6760dd88e175415ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d3fd1d1_12d1b410","updated":"2024-03-27 03:08:07.000000000","message":"recheck test_server_basic_ops tempest.lib.exceptions.SSHExecCommandFailed: Command \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; curl http://169.254.169.254/latest/meta-data/public-ipv4\u0027, exit status: 28, stderr: curl: (28) Failed to connect to 169.254.169.254 port 80 after 130283 ms: Connection timed out","commit_id":"1c02c0da1702ab1f58e930782a8866ed683c3c7d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6980d1f559298ec6afbe3bd5df4f800db29e944a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6759547_9eb510e6","updated":"2024-03-09 21:50:23.000000000","message":"recheck timeout in tempest-integrated-compute","commit_id":"1c02c0da1702ab1f58e930782a8866ed683c3c7d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"72a0792d179d5d6c32ebebed50a21b404901e23e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f14ec118_72e84e02","updated":"2024-03-27 14:23:21.000000000","message":"works for me, \nerr without patch, no error with patch.","commit_id":"1c02c0da1702ab1f58e930782a8866ed683c3c7d"}],"nova/cmd/manage.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1b09eb991a7e48e45b5f49c7d2cc7fac50ac2a09","unresolved":true,"context_lines":[{"line_number":3195,"context_line":"        \u0027instance_uuid\u0027, metavar\u003d\u0027\u003cinstance_uuid\u003e\u0027,"},{"line_number":3196,"context_line":"        help\u003d\u0027UUID of the instance\u0027)"},{"line_number":3197,"context_line":"    @args("},{"line_number":3198,"context_line":"        \u0027image_property\u0027, metavar\u003d\u0027\u003cimage_property\u003e\u0027,"},{"line_number":3199,"context_line":"        help\u003d\u0027Image property to show\u0027)"},{"line_number":3200,"context_line":"    def show(self, instance_uuid\u003dNone, image_property\u003dNone):"},{"line_number":3201,"context_line":"        \"\"\"Show value of a given instance image property."}],"source_content_type":"text/x-python","patch_set":1,"id":"83ab3067_8861c615","line":3198,"updated":"2023-04-14 23:01:12.000000000","message":"Oops ... I think I had meant to use dest\u003d\u0027image_property\u0027 here and make \u0027property\u0027 the arg name shown in the command help.\n\nBut when I test locally, it doesn\u0027t seem like the arg name is ever shown to the user in the command help or anywhere else, so \u0027property\u0027, dest\u003d\u0027image_property\u0027 and \u0027image_property\u0027 seem to have an identical result.","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"9d836a3f8ca6679a154b909ec2948b7d4c578282","unresolved":false,"context_lines":[{"line_number":3195,"context_line":"        \u0027instance_uuid\u0027, metavar\u003d\u0027\u003cinstance_uuid\u003e\u0027,"},{"line_number":3196,"context_line":"        help\u003d\u0027UUID of the instance\u0027)"},{"line_number":3197,"context_line":"    @args("},{"line_number":3198,"context_line":"        \u0027image_property\u0027, metavar\u003d\u0027\u003cimage_property\u003e\u0027,"},{"line_number":3199,"context_line":"        help\u003d\u0027Image property to show\u0027)"},{"line_number":3200,"context_line":"    def show(self, instance_uuid\u003dNone, image_property\u003dNone):"},{"line_number":3201,"context_line":"        \"\"\"Show value of a given instance image property."}],"source_content_type":"text/x-python","patch_set":1,"id":"9b0d189b_e0e0ee69","line":3198,"in_reply_to":"83ab3067_8861c615","updated":"2023-04-18 22:01:47.000000000","message":"Ack","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1b09eb991a7e48e45b5f49c7d2cc7fac50ac2a09","unresolved":true,"context_lines":[{"line_number":3213,"context_line":"            with context.target_cell(ctxt, im.cell_mapping) as cctxt:"},{"line_number":3214,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":3215,"context_line":"                    cctxt, instance_uuid, expected_attrs\u003d[\u0027system_metadata\u0027])"},{"line_number":3216,"context_line":"                image_property \u003d instance.system_metadata.get("},{"line_number":3217,"context_line":"                    f\u0027image_{image_property}\u0027)"},{"line_number":3218,"context_line":"                if image_property:"},{"line_number":3219,"context_line":"                    print(image_property)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd7c9dd1_88e4dbfa","line":3216,"updated":"2023-04-14 23:01:12.000000000","message":"Another bug I noticed while trying your patch is that here the image_property kwarg is being overwritten, so if the image property is not found, it makes the error message wrong on L3222, for example: Image property None not found for instance 23955506-ff3c-4ad5-8946-7c2f8c80a256.\n\nIt should have been something like property_value \u003d ... and then if property_value: print(property_value)","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2e0b51969bd432be3d987cb735ab658aecfb8491","unresolved":false,"context_lines":[{"line_number":3213,"context_line":"            with context.target_cell(ctxt, im.cell_mapping) as cctxt:"},{"line_number":3214,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":3215,"context_line":"                    cctxt, instance_uuid, expected_attrs\u003d[\u0027system_metadata\u0027])"},{"line_number":3216,"context_line":"                image_property \u003d instance.system_metadata.get("},{"line_number":3217,"context_line":"                    f\u0027image_{image_property}\u0027)"},{"line_number":3218,"context_line":"                if image_property:"},{"line_number":3219,"context_line":"                    print(image_property)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3512f318_95c4bd60","line":3216,"in_reply_to":"9dd3bd8b_aab10426","updated":"2024-03-09 11:30:29.000000000","message":"Done","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b21d782c5b09c3e727302e0a015f08733528ee8","unresolved":true,"context_lines":[{"line_number":3213,"context_line":"            with context.target_cell(ctxt, im.cell_mapping) as cctxt:"},{"line_number":3214,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":3215,"context_line":"                    cctxt, instance_uuid, expected_attrs\u003d[\u0027system_metadata\u0027])"},{"line_number":3216,"context_line":"                image_property \u003d instance.system_metadata.get("},{"line_number":3217,"context_line":"                    f\u0027image_{image_property}\u0027)"},{"line_number":3218,"context_line":"                if image_property:"},{"line_number":3219,"context_line":"                    print(image_property)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9dd3bd8b_aab10426","line":3216,"in_reply_to":"fd7c9dd1_88e4dbfa","updated":"2023-12-20 01:37:18.000000000","message":"this should proably be fixed before merging this","commit_id":"b4cb0f3127f87f1acd0f8ca053ea0b02dff3477d"}]}