)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"6de1a72c2ccececc9554b62f225beb4b9ac80a0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ff74e76_65cbae13","updated":"2026-02-26 11:34:10.000000000","message":"😮 no regression in 3 years - smooth 😄","commit_id":"848bffaa0b64023102e06c6b0077492ae3e985b4"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5ef479dee5f916bfacd23c27e5f9ff0ddb31a6a1","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"        # the instance directory and disk.info on init, this condition will"},{"line_number":1852,"context_line":"        # need to be re-visited to make sure that backend doesn\u0027t re-create"},{"line_number":1853,"context_line":"        # the disk. Refer to bugs: 1666831 1728603 1769131"},{"line_number":1854,"context_line":"        if self.image_backend.backend().SUPPORTS_CLONE:"},{"line_number":1855,"context_line":"            root_disk \u003d self.image_backend.by_name(instance, \u0027disk\u0027)"},{"line_number":1856,"context_line":"            if root_disk.exists():"},{"line_number":1857,"context_line":"                root_disk.remove_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"52fdb503_626bb4b3","line":1854,"range":{"start_line":1854,"start_character":8,"end_line":1854,"end_character":55},"updated":"2023-10-27 14:09:21.000000000","message":"OK so backend() and backend(CONF.libvirt.image_type) brings the exactly same result.\n\nhttps://github.com/openstack/nova/blob/b37d50fecc92c17c3b30e41f6ad8869e1f9bd2ef/nova/virt/libvirt/imagebackend.py#L1334-L1336\n\nI\u0027m wondering if we eventually want to remove the argument from the backend method.","commit_id":"848bffaa0b64023102e06c6b0077492ae3e985b4"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5f2dbefd1a92dc2aa34682f0360d1d0402e165b4","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"        # the instance directory and disk.info on init, this condition will"},{"line_number":1852,"context_line":"        # need to be re-visited to make sure that backend doesn\u0027t re-create"},{"line_number":1853,"context_line":"        # the disk. Refer to bugs: 1666831 1728603 1769131"},{"line_number":1854,"context_line":"        if self.image_backend.backend().SUPPORTS_CLONE:"},{"line_number":1855,"context_line":"            root_disk \u003d self.image_backend.by_name(instance, \u0027disk\u0027)"},{"line_number":1856,"context_line":"            if root_disk.exists():"},{"line_number":1857,"context_line":"                root_disk.remove_snap(libvirt_utils.RESIZE_SNAPSHOT_NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b24f5_4829f55c","line":1854,"range":{"start_line":1854,"start_character":8,"end_line":1854,"end_character":55},"in_reply_to":"52fdb503_626bb4b3","updated":"2024-02-26 08:41:40.000000000","message":"+1, yeah, this call with images_type is used here and nowhere else.\nit can be removed in this patch itself.","commit_id":"848bffaa0b64023102e06c6b0077492ae3e985b4"}]}