)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dfe62d4310ca7af89a22a7fc95757e2f64228fa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f10b6ef_0c57319e","updated":"2023-05-04 08:19:25.000000000","message":"Looks good. Neutron API tend to be loosely defined in this regard.","commit_id":"6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1574b136be97e18a58cc310293092f1e97e90b8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2dcb6b8b_def9ded2","updated":"2023-05-04 05:43:09.000000000","message":"have an inline question,\nchanges lgtm.","commit_id":"6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f7eb64554f78b27b26eb8fb6b6c2732e6607c1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fedab8c3_f53feb4c","updated":"2023-05-03 21:37:03.000000000","message":"recheck one unrelated failure and another network-ish one, but that I\u0027ve seen multiple times today on other patches.","commit_id":"6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1"}],"nova/network/neutron.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bf5aaaf14bdac27b73248b0f69130aa5a95335e0","unresolved":true,"context_lines":[{"line_number":3901,"context_line":"            # API is borked and returns both segments but also segmentation IDs"},{"line_number":3902,"context_line":"            # of a provider network if any."},{"line_number":3903,"context_line":"            subnets \u003d client.list_subnets(network_id\u003dnetwork_id,"},{"line_number":3904,"context_line":"                                          fields\u003d\u0027segment_id\u0027)[\u0027subnets\u0027]"},{"line_number":3905,"context_line":"        except neutron_client_exc.NeutronClientException as e:"},{"line_number":3906,"context_line":"            raise exception.InvalidRoutedNetworkConfiguration("},{"line_number":3907,"context_line":"                \u0027Failed to get segment IDs for network %s\u0027 % network_id) from e"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e7acecf_32d37342","line":3904,"updated":"2023-05-04 08:22:44.000000000","message":"It\u0027s weird from neutron to return subnets without segment_id field...","commit_id":"6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1"}],"nova/tests/unit/network/test_neutron.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1574b136be97e18a58cc310293092f1e97e90b8a","unresolved":false,"context_lines":[{"line_number":7425,"context_line":"        ):"},{"line_number":7426,"context_line":"            res \u003d self.api.get_segment_ids_for_network("},{"line_number":7427,"context_line":"                self.context, uuids.network_id)"},{"line_number":7428,"context_line":"        self.assertEqual([], res)"},{"line_number":7429,"context_line":"        mock_client.assert_called_once_with(self.context, admin\u003dTrue)"},{"line_number":7430,"context_line":"        mocked_client.list_subnets.assert_called_once_with("},{"line_number":7431,"context_line":"            network_id\u003duuids.network_id, fields\u003d\u0027segment_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f19e8e13_fabbd30a","line":7428,"updated":"2023-05-04 05:43:09.000000000","message":"no segments","commit_id":"6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1574b136be97e18a58cc310293092f1e97e90b8a","unresolved":true,"context_lines":[{"line_number":7432,"context_line":""},{"line_number":7433,"context_line":"    @mock.patch.object(neutronapi, \u0027get_client\u0027)"},{"line_number":7434,"context_line":"    def test_get_segment_ids_for_network_with_no_segments(self, mock_client):"},{"line_number":7435,"context_line":"        subnets \u003d {\u0027subnets\u0027: [{}]}"},{"line_number":7436,"context_line":"        mocked_client \u003d mock.create_autospec(client.Client)"},{"line_number":7437,"context_line":"        mock_client.return_value \u003d mocked_client"},{"line_number":7438,"context_line":"        mocked_client.list_subnets.return_value \u003d subnets"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e066ba6_c590f576","line":7435,"updated":"2023-05-04 05:43:09.000000000","message":"for my understanding only\ncould check in only devstack and tripleO, is this possible subnet not having a field segment_id, it can be segment_id: None, but no segment_id ?","commit_id":"6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1574b136be97e18a58cc310293092f1e97e90b8a","unresolved":false,"context_lines":[{"line_number":7441,"context_line":"        ):"},{"line_number":7442,"context_line":"            res \u003d self.api.get_segment_ids_for_network("},{"line_number":7443,"context_line":"                self.context, uuids.network_id)"},{"line_number":7444,"context_line":"        self.assertEqual([], res)"},{"line_number":7445,"context_line":"        mock_client.assert_called_once_with(self.context, admin\u003dTrue)"},{"line_number":7446,"context_line":"        mocked_client.list_subnets.assert_called_once_with("},{"line_number":7447,"context_line":"            network_id\u003duuids.network_id, fields\u003d\u0027segment_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"00e4fbf2_d63fd292","line":7444,"updated":"2023-05-04 05:43:09.000000000","message":"no segments","commit_id":"6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1"}]}