)]}'
{"id":"openstack%2Fnova~883317","triplet_id":"openstack%2Fnova~master~Ia916310522b007061660172fa4d63d0fde9a55ac","project":"openstack/nova","branch":"master","topic":"bug/1946339","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2023-05-17 09:20:59.000000000","reason":"Change was submitted"},"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2023-05-17 09:20:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia916310522b007061660172fa4d63d0fde9a55ac","subject":"tests: Use GreenThreadPoolExecutor.shutdown(wait\u003dTrue)","status":"MERGED","created":"2023-05-17 00:16:59.000000000","updated":"2023-05-17 09:22:12.000000000","submitted":"2023-05-17 09:20:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"883317-bug/1946339","meta_rev_id":"7b11eff888469d0a9e52c30d135721fd4a659e87","_number":883317,"virtual_id_number":883317,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-05-17 09:20:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":2,"date":"2023-05-17 07:28:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-05-17 08:45:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-05-17 08:45:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-17 00:34:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-17 00:46:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-17 01:35:10.000000000","updated_by":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"reviewer":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"state":"CC"},{"updated":"2023-05-17 07:28:00.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2023-05-17 08:45:47.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"f7d9a25e424ca1fedaf4bc4a347ac3c21435a8ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-05-17 00:16:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e9f6d3373751be7dce8cccc41db410c51cd43584","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 00:34:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c4f5ffb3d7a0405d953f8fd0be1ce7ca\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/31c4ae59329a48f0a45171e403685d24 : SUCCESS in 9m 27s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/09fd27bed767441390dd29382c7b86ce : SUCCESS in 16m 24s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/c08b5e288f1043d49cf02928f1a25fe4 : SUCCESS in 9m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c6df6456df5f821310a474d9aafab73e079122c4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 00:46:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/a46d486d827f47809a781e4188ae58cf\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/474d7cedff2c42b4b76baaea55d5207d : SUCCESS in 13m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/497f475275f6457789f78df7308a81aa : FAILURE in 7m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/969601c7cdc545948f5c203a8527fe5a : SUCCESS in 10m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7089c9a992b54937ae492afac07e4946 : SUCCESS in 9m 44s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/09b0881f87cd4eaa993b0b5c752006c0 : SUCCESS in 13m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/28ecfb9581f847afbe638d5d78fe2ef3 : SUCCESS in 11m 01s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/af4e834012504a4aa05497bc303ed0b4 : SUCCESS in 4m 10s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/7311a5238424448c9853766177f21c70 : SUCCESS in 24m 10s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/2502fc79c4b248c28d5d19bec0083f9a : SUCCESS in 19m 10s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/a2568a97eef44683adfcd9377a325fbc : SUCCESS in 21m 37s","accounts_in_message":[],"_revision_number":1},{"id":"e3196ee3c1999adca56fbe780631db7079dbab09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-05-17 00:58:04.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"a8a9673be5eb156d37e3a33702337d4554cc7789","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 01:27:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/750f6f7cdc8d432fb94e5801796a57b2\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/14f4e60f24e24041afd1d791679d423b : SUCCESS in 16m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/00150843caf44bba82624e8d8671ab40 : SUCCESS in 9m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/377a5727fc27469a87da71b15e99005a : SUCCESS in 12m 01s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7e022c96d823469f9d671b28ca0645ef : SUCCESS in 10m 42s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9de84f93a9f54a21aca88e9907cfaa96 : SUCCESS in 11m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/30b1fbb897a648c9b3ead1c71c8defd3 : SUCCESS in 8m 41s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/6f460cf61f484fdf9de8c43e250cd125 : SUCCESS in 4m 30s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/3927cd58bdfe422cb2bb6d8d1d3e2a22 : SUCCESS in 20m 53s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a62fbab0c0d949c6ad81f311f90d3477 : SUCCESS in 21m 48s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/554ada6d2f5a48cb83038f4cb87b1376 : SUCCESS in 23m 38s","accounts_in_message":[],"_revision_number":2},{"id":"d756c3c6c51bcba7bc118c203f8a4399b20858c0","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 01:27:52.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/30f17c4bc40c42a8b1ea636644c6c9a3\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/02ad2597b66242e08aadf3bd1f4d135b : SUCCESS in 10m 10s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/155c6f2e3b324c328325510be2a48376 : SUCCESS in 10m 12s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/72ad5ec4e5784397be1f12cf83c055d8 : SUCCESS in 29m 25s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4a17900d740b38c4a7016425de79dc9cffb698ad","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":34420,"name":"openstack lightbits","display_name":"Lightbits CI","email":"openstack@lightbitslabs.com","username":"openstack_lightbits"},"date":"2023-05-17 01:35:10.000000000","message":"Patch Set 2:\n\nBuild succeeded. log path: ${LOG_PATH}\nLeave a comment with \u0027run-Lightbits CI\u0027 to trigger a recheck. \nFor more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/LightbitsLabs_CI","accounts_in_message":[],"_revision_number":2},{"id":"00d05a924d8b10ad6808eefa8fcb10a3146b7325","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2023-05-17 07:28:00.000000000","message":"Patch Set 2: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e85b9714c8a7eb3e5dd09f00a31f98517ed29f7a","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2023-05-17 08:45:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7aae3f5ec7e600a5ae3967db3a1876e8c1bf9910","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 08:46:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"7cd09634535964d9ab2d93563e62e1c178af54bb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 09:20:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d1c047a55ff44c06a03384ee5f793a8a\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7d3db30ab90149b5b27f303b981995e3 : SUCCESS in 11m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/78ffaf9c20124da7b95bcb09cd2d3f29 : SUCCESS in 12m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/131699ca7d8a4b4485a64aceece8008a : SUCCESS in 11m 46s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/4a1e8b5e725d44d3800113653436651c : SUCCESS in 15m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e9d056c9209f43c8a3fd0457eb566fce : SUCCESS in 10m 16s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/66b06c6c2a274178aaafba4a74a3ad56 : SUCCESS in 24m 20s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/815ff13b61d24071b06504110bf950d3 : SUCCESS in 23m 34s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/52a87f45324442ccb59f6f83e987d16f : SUCCESS in 4m 40s","accounts_in_message":[],"_revision_number":2},{"id":"6837ae30d739f7796549dc419441383f69adb233","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 09:20:59.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"7b11eff888469d0a9e52c30d135721fd4a659e87","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-17 09:22:12.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1bc4d18aff954b5193bcd3cfcf53757e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/588a651b356848c3ab3215e00bd8e740 : SUCCESS in 54s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c095cfe04e2c71efcfbfdd95948af080a98065e6","revisions":{"8454a6d455afb7b2f75237114d5074447db7d6d4":{"kind":"REWORK","_number":1,"created":"2023-05-17 00:16:59.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/17/883317/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/17/883317/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/883317/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/883317/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/883317/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/17/883317/1"}}},"commit":{"parents":[{"commit":"e9a54ff3508efbb1dea6b80fc5d970a8385c6ed4","subject":"Merge \"Bump nova-ceph-multstore timeout\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e9a54ff3508efbb1dea6b80fc5d970a8385c6ed4"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-05-11 19:23:52.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-05-17 00:08:57.000000000","tz":0},"subject":"tests: Use GreenThreadPoolExecutor.shutdown(wait\u003dTrue)","message":"tests: Use GreenThreadPoolExecutor.shutdown(wait\u003dTrue)\n\nWe are still having some issues in the gate where greenlets from\nprevious tests continue to run while the next test starts, causing\nfalse negative failures in unit or functional test jobs.\n\nThis adds a new fixture that will ensure\nGreenThreadPoolExecutor.shutdown() is called with wait\u003dTrue, to wait\nfor greenlets in the pool to finish running before moving on.\n\nIn local testing, doing this does not appear to adversely affect test\nrun times, which was my primary concern.\n\nAs a baseline, I ran a subset of functional tests in a loop\nuntil failure without the patch and after 11 hours, I got a failure\nreproducing the bug. With the patch, running the same subset of\nfunctional tests in a loop has been running for 24 hours and has not\nfailed yet.\n\nBased on this, I think it may be worth trying this out to see if it\nwill help stability of our unit and functional test jobs. And if it\nends up impacting test run times or causes other issues, we can\nrevert it.\n\nPartial-Bug: #1946339\n\nChange-Id: Ia916310522b007061660172fa4d63d0fde9a55ac\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8454a6d455afb7b2f75237114d5074447db7d6d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8454a6d455afb7b2f75237114d5074447db7d6d4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"e9a54ff3508efbb1dea6b80fc5d970a8385c6ed4","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"c095cfe04e2c71efcfbfdd95948af080a98065e6":{"kind":"REWORK","_number":2,"created":"2023-05-17 00:58:04.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/17/883317/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/17/883317/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/883317/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/883317/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/17/883317/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/17/883317/2"}}},"commit":{"parents":[{"commit":"e9a54ff3508efbb1dea6b80fc5d970a8385c6ed4","subject":"Merge \"Bump nova-ceph-multstore timeout\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e9a54ff3508efbb1dea6b80fc5d970a8385c6ed4"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-05-11 19:23:52.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-05-17 00:57:37.000000000","tz":0},"subject":"tests: Use GreenThreadPoolExecutor.shutdown(wait\u003dTrue)","message":"tests: Use GreenThreadPoolExecutor.shutdown(wait\u003dTrue)\n\nWe are still having some issues in the gate where greenlets from\nprevious tests continue to run while the next test starts, causing\nfalse negative failures in unit or functional test jobs.\n\nThis adds a new fixture that will ensure\nGreenThreadPoolExecutor.shutdown() is called with wait\u003dTrue, to wait\nfor greenlets in the pool to finish running before moving on.\n\nIn local testing, doing this does not appear to adversely affect test\nrun times, which was my primary concern.\n\nAs a baseline, I ran a subset of functional tests in a loop\nuntil failure without the patch and after 11 hours, I got a failure\nreproducing the bug. With the patch, running the same subset of\nfunctional tests in a loop has been running for 24 hours and has not\nfailed yet.\n\nBased on this, I think it may be worth trying this out to see if it\nwill help stability of our unit and functional test jobs. And if it\nends up impacting test run times or causes other issues, we can\nrevert it.\n\nPartial-Bug: #1946339\n\nChange-Id: Ia916310522b007061660172fa4d63d0fde9a55ac\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c095cfe04e2c71efcfbfdd95948af080a98065e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c095cfe04e2c71efcfbfdd95948af080a98065e6"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"e9a54ff3508efbb1dea6b80fc5d970a8385c6ed4","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}