)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a0d6937316beb66ef482d71a6359f4b1c267b18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cfbff6ba_80216bc6","updated":"2023-06-26 09:32:59.000000000","message":"im pretty happy with this over all. do you want to add a dprecation release note or do you think OPs will be happy enough with just the deprecation in the config options","commit_id":"19c90b332bd68710c5d75b5100ec6cc543520313"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b74034cc118741a988926b5cf9ad6765aea0795e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b9cf011_ee5043bc","in_reply_to":"cfbff6ba_80216bc6","updated":"2023-06-26 10:53:36.000000000","message":"hmm, good idea, I should add a release note for that.","commit_id":"19c90b332bd68710c5d75b5100ec6cc543520313"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5d8718cd61759f7100d7b98d67bd8f0c433039f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2faf2716_a2e11827","updated":"2023-07-28 14:46:53.000000000","message":"+1 with nits (you can create a follow-up patch if you prefer).\nThat said, I\u0027ll wait for +2ing until Jay or other Ironic cores can +1 this one.","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f3c65506b9fd645b93d67f412fb5e2044d242fda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cca91f87_4bc96c58","updated":"2023-08-29 16:26:19.000000000","message":"Please do not land this until we have a high level of confidence that we\u0027ll also land the sharding patches in this series.","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8361ad1afdcb042c9e7e919f3cdb21fc69aa2f1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f382e672_9ecb22ce","updated":"2023-07-12 13:42:53.000000000","message":"Please do not merge this until https://review.opendev.org/c/openstack/ironic/+/888277 or a more limited scope version (that just needs this change) has passed against Ironic integration tests.\n\nNote that this may require Ironic\u0027s integration tests to change to support setting up a shardy world properly.","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2370ca71_859fa5ae","updated":"2023-08-31 08:55:32.000000000","message":"Thanks all. FWIW, my take is we land this even without the other patches, as you can do active-passive today, which enough config changes.","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"233ffb88eb01df72f63581b19cc25486ff7f759a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9226cfb7_0b810505","updated":"2023-08-30 15:24:06.000000000","message":"Turning my vote to +2 since Ironic folks are happy.\nAs a reminder, nova cores, please hold +Wing this patch until all the series is accepted.","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"675ae05d1229179448074ac901ac2dec1d4e1def","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"79100dd3_fb494a93","updated":"2023-08-31 10:54:55.000000000","message":"John, are you planning to rebase today the rest of your series on this latest PS ? You unfortunately only provided the bottom patch in the series so the Gerrit relation chain is now broken.","commit_id":"cbf400df1dc3e26f4f2e655ca47db7fb097b3531"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b6f1fa3cbb2cf88758ab662e937c32339f7b60bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6b010c17_1c60e5f3","updated":"2023-08-31 10:53:20.000000000","message":"We\u0027ll need to see today if the rest of the series can be +2d before FF. If so, I\u0027m fine to give it a late go.","commit_id":"cbf400df1dc3e26f4f2e655ca47db7fb097b3531"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3d035b4074369e231713d4aa59a679b6a09786fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"46f8653c_1a227964","updated":"2023-08-31 14:12:57.000000000","message":"recheck  unrelated tox failure\n\nesttools.matchers._impl.MismatchError: !\u003d:\nreference \u003d {\u0027name\u0027: \u0027cpu.percent\u0027,\n \u0027source\u0027: \u0027nova.virt.libvirt.driver\u0027,\n \u0027timestamp\u0027: \u00272023-08-31T09:04:21\u0027,\n \u0027value\u0027: 0.17}\nactual    \u003d {\u0027name\u0027: \u0027cpu.percent\u0027,\n \u0027source\u0027: \u0027nova.virt.libvirt.driver\u0027,\n \u0027timestamp\u0027: \u00272023-08-31T09:04:21.000000\u0027,\n \u0027value\u0027: 0.17}\n\n\nthat might be pyhton version specific\n\nwe can proceed with the rename and deprecation regradelss with the rest of the serise so let start merging this to get it moving through the ci","commit_id":"cbf400df1dc3e26f4f2e655ca47db7fb097b3531"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5aaace27fad8cc2d9d3a06b999fb4003e3dcadd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a432ea48_5f4a3ad1","in_reply_to":"79100dd3_fb494a93","updated":"2023-08-31 13:31:48.000000000","message":"Yes, I am working through it, hit a bump in the next patch.","commit_id":"cbf400df1dc3e26f4f2e655ca47db7fb097b3531"}],"doc/source/admin/configuration/hypervisor-ironic.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5d8718cd61759f7100d7b98d67bd8f0c433039f9","unresolved":true,"context_lines":[{"line_number":40,"context_line":"Scaling and performance issues"},{"line_number":41,"context_line":"------------------------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- It it typical for a single nova-compute process to support several"},{"line_number":44,"context_line":"  hundred ironic nodes. There are known issues when you attempt to"},{"line_number":45,"context_line":"  support more than 1000 ironic nodes assoicated with a single"},{"line_number":46,"context_line":"  nova-compute process, even though Ironic is able to scale out"}],"source_content_type":"text/x-rst","patch_set":4,"id":"97c177af_e90a373b","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":7},"updated":"2023-07-28 14:46:53.000000000","message":"femtonit: is","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Scaling and performance issues"},{"line_number":41,"context_line":"------------------------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- It it typical for a single nova-compute process to support several"},{"line_number":44,"context_line":"  hundred ironic nodes. There are known issues when you attempt to"},{"line_number":45,"context_line":"  support more than 1000 ironic nodes assoicated with a single"},{"line_number":46,"context_line":"  nova-compute process, even though Ironic is able to scale out"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0ef36bd7_6550c886","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":7},"in_reply_to":"97c177af_e90a373b","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"48c434f07546008ddde8126b9b86af4ec33b251e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"------------------------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- It it typical for a single nova-compute process to support several"},{"line_number":44,"context_line":"  hundred ironic nodes. There are known issues when you attempt to"},{"line_number":45,"context_line":"  support more than 1000 ironic nodes assoicated with a single"},{"line_number":46,"context_line":"  nova-compute process, even though Ironic is able to scale out"},{"line_number":47,"context_line":"  a single conductor group to much larger sizes. There are many"}],"source_content_type":"text/x-rst","patch_set":4,"id":"0a855e5e_bfe66e50","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":16},"updated":"2023-08-30 19:44:06.000000000","message":"consistency: Ironic","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"------------------------------"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- It it typical for a single nova-compute process to support several"},{"line_number":44,"context_line":"  hundred ironic nodes. There are known issues when you attempt to"},{"line_number":45,"context_line":"  support more than 1000 ironic nodes assoicated with a single"},{"line_number":46,"context_line":"  nova-compute process, even though Ironic is able to scale out"},{"line_number":47,"context_line":"  a single conductor group to much larger sizes. There are many"}],"source_content_type":"text/x-rst","patch_set":4,"id":"eddc7fa6_2889340a","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":16},"in_reply_to":"0a855e5e_bfe66e50","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"48c434f07546008ddde8126b9b86af4ec33b251e","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- It it typical for a single nova-compute process to support several"},{"line_number":44,"context_line":"  hundred ironic nodes. There are known issues when you attempt to"},{"line_number":45,"context_line":"  support more than 1000 ironic nodes assoicated with a single"},{"line_number":46,"context_line":"  nova-compute process, even though Ironic is able to scale out"},{"line_number":47,"context_line":"  a single conductor group to much larger sizes. There are many"},{"line_number":48,"context_line":"  other factors that can affect what is the maximum practical size of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"64781748_32ff7eae","line":45,"range":{"start_line":45,"start_character":38,"end_line":45,"end_character":48},"updated":"2023-08-30 19:44:06.000000000","message":"associated","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- It it typical for a single nova-compute process to support several"},{"line_number":44,"context_line":"  hundred ironic nodes. There are known issues when you attempt to"},{"line_number":45,"context_line":"  support more than 1000 ironic nodes assoicated with a single"},{"line_number":46,"context_line":"  nova-compute process, even though Ironic is able to scale out"},{"line_number":47,"context_line":"  a single conductor group to much larger sizes. There are many"},{"line_number":48,"context_line":"  other factors that can affect what is the maximum practical size of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7d4e2a72_4e1efabc","line":45,"range":{"start_line":45,"start_character":38,"end_line":45,"end_character":48},"in_reply_to":"64781748_32ff7eae","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2ff70093989d35a1b53e3b3292612c0316c49a5","unresolved":true,"context_lines":[{"line_number":51,"context_line":"  managed by Ironic. Depending the number of nodes, it can take a lot of time."},{"line_number":52,"context_line":"  The nova-compute will not perform any other operations when this task is"},{"line_number":53,"context_line":"  running. You can use conductor groups to help shard your deployment"},{"line_number":54,"context_line":"  between mulitple nova-compute processes by setting"},{"line_number":55,"context_line":"  :oslo.config:option:`ironic.conductor_group`."},{"line_number":56,"context_line":"- The nova-compute process using the Ironic driver can be moved between"},{"line_number":57,"context_line":"  different physical servers using active/passive failover. But when doing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"020e7cd5_134c12fa","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":18},"updated":"2023-08-30 17:07:18.000000000","message":"\"multiple\"","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  managed by Ironic. Depending the number of nodes, it can take a lot of time."},{"line_number":52,"context_line":"  The nova-compute will not perform any other operations when this task is"},{"line_number":53,"context_line":"  running. You can use conductor groups to help shard your deployment"},{"line_number":54,"context_line":"  between mulitple nova-compute processes by setting"},{"line_number":55,"context_line":"  :oslo.config:option:`ironic.conductor_group`."},{"line_number":56,"context_line":"- The nova-compute process using the Ironic driver can be moved between"},{"line_number":57,"context_line":"  different physical servers using active/passive failover. But when doing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"689d9729_744f0db9","line":54,"range":{"start_line":54,"start_character":10,"end_line":54,"end_character":18},"in_reply_to":"020e7cd5_134c12fa","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7dfc1278fdba62141c8ca1c726059936e50be9c2","unresolved":true,"context_lines":[{"line_number":59,"context_line":"  no matter where the nova-compute process is running. Similarly you must"},{"line_number":60,"context_line":"  ensure there are at most one nova-compute processes running for each"},{"line_number":61,"context_line":"  conductor group."},{"line_number":62,"context_line":"- Running muiltiple nova-compute processes that point at the same"},{"line_number":63,"context_line":"  conductor group is now deprecated. Please never have more than one"},{"line_number":64,"context_line":"  host in the peer list: :oslo.config:option:`ironic.peer_list`"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"337ba468_8ef9bfd9","line":62,"updated":"2023-07-12 13:34:43.000000000","message":"spelling: multiple","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  no matter where the nova-compute process is running. Similarly you must"},{"line_number":60,"context_line":"  ensure there are at most one nova-compute processes running for each"},{"line_number":61,"context_line":"  conductor group."},{"line_number":62,"context_line":"- Running muiltiple nova-compute processes that point at the same"},{"line_number":63,"context_line":"  conductor group is now deprecated. Please never have more than one"},{"line_number":64,"context_line":"  host in the peer list: :oslo.config:option:`ironic.peer_list`"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"755f7fbc_01b9b920","line":62,"in_reply_to":"337ba468_8ef9bfd9","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"}],"nova/conf/ironic.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a0d6937316beb66ef482d71a6359f4b1c267b18","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        help\u003d\u0027Timeout (seconds) to wait for node serial console state \u0027"},{"line_number":70,"context_line":"             \u0027changed. Set to 0 to disable timeout.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt("},{"line_number":72,"context_line":"        \u0027conductor_group\u0027,"},{"line_number":73,"context_line":"        deprecated_name\u003d\u0027partition_key\u0027,"},{"line_number":74,"context_line":"        default\u003dNone,"},{"line_number":75,"context_line":"        mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"08e0bda6_7000d0c3","line":72,"range":{"start_line":72,"start_character":9,"end_line":72,"end_character":24},"updated":"2023-06-26 09:32:59.000000000","message":"given we will be adding a new shard key i think this will help also to distinguesh between the partition_key and shard key going forward","commit_id":"19c90b332bd68710c5d75b5100ec6cc543520313"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b664496c154ad07f1cc44f16140b44807e43780a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        help\u003d\u0027Timeout (seconds) to wait for node serial console state \u0027"},{"line_number":70,"context_line":"             \u0027changed. Set to 0 to disable timeout.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt("},{"line_number":72,"context_line":"        \u0027conductor_group\u0027,"},{"line_number":73,"context_line":"        deprecated_name\u003d\u0027partition_key\u0027,"},{"line_number":74,"context_line":"        default\u003dNone,"},{"line_number":75,"context_line":"        mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0d0f9c36_ab263205","line":72,"range":{"start_line":72,"start_character":9,"end_line":72,"end_character":24},"in_reply_to":"08e0bda6_7000d0c3","updated":"2023-06-28 14:43:42.000000000","message":"+1 that was my thinking here. The code for the shard key usage is up for review now too.","commit_id":"19c90b332bd68710c5d75b5100ec6cc543520313"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7a0d6937316beb66ef482d71a6359f4b1c267b18","unresolved":true,"context_lines":[{"line_number":88,"context_line":"        deprecated_since\u003d\u002728.0.0\u0027,"},{"line_number":89,"context_line":"        deprecated_reason\u003d\"\"\"\\"},{"line_number":90,"context_line":"        We do not recomend using nova-compute ha, please use passive"},{"line_number":91,"context_line":"        failover of a single nova-compute service instead.\"\"\","},{"line_number":92,"context_line":"        default\u003d[],"},{"line_number":93,"context_line":"        mutable\u003dTrue,"},{"line_number":94,"context_line":"        help\u003d\u0027List of hostnames for all nova-compute services (including \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"68543eba_1e02ce6c","line":91,"updated":"2023-06-26 09:32:59.000000000","message":"+1 we cant remove this in C since it needs to go out in a SLURP release\n\nbut assuming the shard work gets comppelted this cycle or next that puts us in a position to be able to remove it in the D cycle.","commit_id":"19c90b332bd68710c5d75b5100ec6cc543520313"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b664496c154ad07f1cc44f16140b44807e43780a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        deprecated_since\u003d\u002728.0.0\u0027,"},{"line_number":89,"context_line":"        deprecated_reason\u003d\"\"\"\\"},{"line_number":90,"context_line":"        We do not recomend using nova-compute ha, please use passive"},{"line_number":91,"context_line":"        failover of a single nova-compute service instead.\"\"\","},{"line_number":92,"context_line":"        default\u003d[],"},{"line_number":93,"context_line":"        mutable\u003dTrue,"},{"line_number":94,"context_line":"        help\u003d\u0027List of hostnames for all nova-compute services (including \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"06eaba07_8e288da1","line":91,"in_reply_to":"68543eba_1e02ce6c","updated":"2023-06-28 14:43:42.000000000","message":"Probably not until the next SLURP after that I guess? Either way, it has to say around for a bit.","commit_id":"19c90b332bd68710c5d75b5100ec6cc543520313"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"48c434f07546008ddde8126b9b86af4ec33b251e","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":88,"context_line":"        deprecated_since\u003d\u002728.0.0\u0027,"},{"line_number":89,"context_line":"        deprecated_reason\u003d\"\"\"\\"},{"line_number":90,"context_line":"        We do not recomend using nova-compute ha, please use passive"},{"line_number":91,"context_line":"        failover of a single nova-compute service instead.\"\"\","},{"line_number":92,"context_line":"        default\u003d[],"},{"line_number":93,"context_line":"        mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"94406269_8d653d72","line":90,"range":{"start_line":90,"start_character":46,"end_line":90,"end_character":48},"updated":"2023-08-30 19:44:06.000000000","message":"consistency: HA","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":88,"context_line":"        deprecated_since\u003d\u002728.0.0\u0027,"},{"line_number":89,"context_line":"        deprecated_reason\u003d\"\"\"\\"},{"line_number":90,"context_line":"        We do not recomend using nova-compute ha, please use passive"},{"line_number":91,"context_line":"        failover of a single nova-compute service instead.\"\"\","},{"line_number":92,"context_line":"        default\u003d[],"},{"line_number":93,"context_line":"        mutable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f251e0c_76dbe90d","line":90,"range":{"start_line":90,"start_character":46,"end_line":90,"end_character":48},"in_reply_to":"94406269_8d653d72","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5d8718cd61759f7100d7b98d67bd8f0c433039f9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"             \u0027Nodes matching the conductor_group value will be distributed \u0027"},{"line_number":97,"context_line":"             \u0027between all services specified here. \u0027"},{"line_number":98,"context_line":"             \u0027If conductor_group is unset, this option is ignored.\u0027),"},{"line_number":99,"context_line":"]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f6bdb21_6130bca9","line":99,"updated":"2023-07-28 14:46:53.000000000","message":"all above lgtm","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2ff70093989d35a1b53e3b3292612c0316c49a5","unresolved":true,"context_lines":[{"line_number":147,"context_line":"            raise exception.InvalidPeerList(host\u003dCONF.host)"},{"line_number":148,"context_line":"        if len(peer_list) \u003e 1:"},{"line_number":149,"context_line":"            LOG.warning(\u0027Having multiple compute services in your \u0027"},{"line_number":150,"context_line":"                        \u0027peer_list is now deprecated. We recomend moving \u0027"},{"line_number":151,"context_line":"                        \u0027to just a single node in your peer list.\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff5f6ba2_68bfdc81","line":150,"range":{"start_line":150,"start_character":57,"end_line":150,"end_character":65},"updated":"2023-08-30 17:07:18.000000000","message":"\"recommend\"","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            raise exception.InvalidPeerList(host\u003dCONF.host)"},{"line_number":148,"context_line":"        if len(peer_list) \u003e 1:"},{"line_number":149,"context_line":"            LOG.warning(\u0027Having multiple compute services in your \u0027"},{"line_number":150,"context_line":"                        \u0027peer_list is now deprecated. We recomend moving \u0027"},{"line_number":151,"context_line":"                        \u0027to just a single node in your peer list.\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"44a90d17_8e99b918","line":150,"range":{"start_line":150,"start_character":57,"end_line":150,"end_character":65},"in_reply_to":"ff5f6ba2_68bfdc81","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5d8718cd61759f7100d7b98d67bd8f0c433039f9","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        if len(peer_list) \u003e 1:"},{"line_number":149,"context_line":"            LOG.warning(\u0027Having multiple compute services in your \u0027"},{"line_number":150,"context_line":"                        \u0027peer_list is now deprecated. We recomend moving \u0027"},{"line_number":151,"context_line":"                        \u0027to just a single node in your peer list.\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class IronicDriver(virt_driver.ComputeDriver):"}],"source_content_type":"text/x-python","patch_set":4,"id":"78032603_80d61226","line":151,"updated":"2023-07-28 14:46:53.000000000","message":"++","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2ff70093989d35a1b53e3b3292612c0316c49a5","unresolved":true,"context_lines":[{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        if len(services) \u003e 1:"},{"line_number":742,"context_line":"            LOG.warning(\u0027Having multiple compute services in your \u0027"},{"line_number":743,"context_line":"                        \u0027deployment, for a single conductor gourp, \u0027"},{"line_number":744,"context_line":"                        \u0027is now deprecated. We recomend moving \u0027"},{"line_number":745,"context_line":"                        \u0027to just a single ironic nova compute service.\u0027)"},{"line_number":746,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"02ee11d6_8338d847","line":743,"range":{"start_line":743,"start_character":60,"end_line":743,"end_character":65},"updated":"2023-08-30 17:07:18.000000000","message":"\"group\"","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        if len(services) \u003e 1:"},{"line_number":742,"context_line":"            LOG.warning(\u0027Having multiple compute services in your \u0027"},{"line_number":743,"context_line":"                        \u0027deployment, for a single conductor gourp, \u0027"},{"line_number":744,"context_line":"                        \u0027is now deprecated. We recomend moving \u0027"},{"line_number":745,"context_line":"                        \u0027to just a single ironic nova compute service.\u0027)"},{"line_number":746,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"51b9e792_018c0220","line":743,"range":{"start_line":743,"start_character":60,"end_line":743,"end_character":65},"in_reply_to":"02ee11d6_8338d847","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2ff70093989d35a1b53e3b3292612c0316c49a5","unresolved":true,"context_lines":[{"line_number":741,"context_line":"        if len(services) \u003e 1:"},{"line_number":742,"context_line":"            LOG.warning(\u0027Having multiple compute services in your \u0027"},{"line_number":743,"context_line":"                        \u0027deployment, for a single conductor gourp, \u0027"},{"line_number":744,"context_line":"                        \u0027is now deprecated. We recomend moving \u0027"},{"line_number":745,"context_line":"                        \u0027to just a single ironic nova compute service.\u0027)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        self.hash_ring \u003d hash_ring.HashRing(services,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d8a4f946_e7890d62","line":744,"range":{"start_line":744,"start_character":47,"end_line":744,"end_character":55},"updated":"2023-08-30 17:07:18.000000000","message":"\"recommend \"","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        if len(services) \u003e 1:"},{"line_number":742,"context_line":"            LOG.warning(\u0027Having multiple compute services in your \u0027"},{"line_number":743,"context_line":"                        \u0027deployment, for a single conductor gourp, \u0027"},{"line_number":744,"context_line":"                        \u0027is now deprecated. We recomend moving \u0027"},{"line_number":745,"context_line":"                        \u0027to just a single ironic nova compute service.\u0027)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        self.hash_ring \u003d hash_ring.HashRing(services,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9dee079d_de392fcd","line":744,"range":{"start_line":744,"start_character":47,"end_line":744,"end_character":55},"in_reply_to":"d8a4f946_e7890d62","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"}],"releasenotes/notes/deprecate-ironic-peer-list-ff8a502935faa045.yaml":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f2ff70093989d35a1b53e3b3292612c0316c49a5","unresolved":true,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    We have deprecated the support for a group of ironic nova-compute"},{"line_number":5,"context_line":"    processess targeting a single set of nodes. There are so many bugs in"},{"line_number":6,"context_line":"    this support we now prefer statically sharding the nodes between multiple"},{"line_number":7,"context_line":"    nova-compute processes, such as a single peer targeting different"},{"line_number":8,"context_line":"    conductor groups, as using an active-passive HA solution to choose which"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8de2f129_e491a398","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":14},"updated":"2023-08-30 17:07:18.000000000","message":"\"processes\"","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5d8718cd61759f7100d7b98d67bd8f0c433039f9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    We have deprecated the support for a group of ironic nova-compute"},{"line_number":5,"context_line":"    processess targeting a single set of nodes. There are so many bugs in"},{"line_number":6,"context_line":"    this support we now prefer statically sharding the nodes between multiple"},{"line_number":7,"context_line":"    nova-compute processes, such as a single peer targeting different"},{"line_number":8,"context_line":"    conductor groups, as using an active-passive HA solution to choose which"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2cc15f99_2d718533","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":46},"updated":"2023-07-28 14:46:53.000000000","message":"please tell the config options that are now deprecated, please (even if the operator can see it directly by nova.conf)","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    We have deprecated the support for a group of ironic nova-compute"},{"line_number":5,"context_line":"    processess targeting a single set of nodes. There are so many bugs in"},{"line_number":6,"context_line":"    this support we now prefer statically sharding the nodes between multiple"},{"line_number":7,"context_line":"    nova-compute processes, such as a single peer targeting different"},{"line_number":8,"context_line":"    conductor groups, as using an active-passive HA solution to choose which"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5fedba8a_459c6b8c","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":46},"in_reply_to":"2cc15f99_2d718533","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    We have deprecated the support for a group of ironic nova-compute"},{"line_number":5,"context_line":"    processess targeting a single set of nodes. There are so many bugs in"},{"line_number":6,"context_line":"    this support we now prefer statically sharding the nodes between multiple"},{"line_number":7,"context_line":"    nova-compute processes, such as a single peer targeting different"},{"line_number":8,"context_line":"    conductor groups, as using an active-passive HA solution to choose which"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d648259a_7e3aa6b8","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":14},"in_reply_to":"8de2f129_e491a398","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7dfc1278fdba62141c8ca1c726059936e50be9c2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    nova-compute processes, such as a single peer targeting different"},{"line_number":8,"context_line":"    conductor groups, as using an active-passive HA solution to choose which"},{"line_number":9,"context_line":"    node that one nova-compute process can run on (assuming both processes have"},{"line_number":10,"context_line":"    the same value set of CONF.host).  "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9c3ce88d_c65ee394","line":10,"updated":"2023-07-12 13:34:43.000000000","message":"whitespace","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"700bffa8e15bd9b5e9a215099311b10d498722b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    nova-compute processes, such as a single peer targeting different"},{"line_number":8,"context_line":"    conductor groups, as using an active-passive HA solution to choose which"},{"line_number":9,"context_line":"    node that one nova-compute process can run on (assuming both processes have"},{"line_number":10,"context_line":"    the same value set of CONF.host).  "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaf396e_be4782e4","line":10,"in_reply_to":"9c3ce88d_c65ee394","updated":"2023-08-31 08:55:32.000000000","message":"Done","commit_id":"cd769b164b1e66267e4295ed49ea041e52c831f5"}]}