)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0472cf870b86a21fd54f99c99e6a6f33088210fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"986224aa_96282ee4","updated":"2024-07-02 11:34:47.000000000","message":"I small refactoring nit remains. I can be convinced to do that as a follow up, but there is plenty of other comments before this patch that requires a respin so you can include the refactor in the respin directly here.","commit_id":"93ae24851bc427c974ee3b8eb0e751a3ea2e7c98"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fe805ece5e7bccc7d907f1fd1d76e4e779d2cc98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"dc11bd62_1d08f1ef","updated":"2024-07-31 14:11:53.000000000","message":"While I think this code may work, I don\u0027t really appreciate how this is written. I really want ourselves to add more business logic in the compute service if we could put it either in the libvirt driver or rather in the object module (based on its state","commit_id":"5ffa96052644701a88f0d5f97364dc3a6b8e19cd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7d70272e99d78b56134cf5cfd70153535f8ae909","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"3723380f_acea2fcc","updated":"2024-08-28 12:36:29.000000000","message":"restating my -1","commit_id":"78f99da3c93c54850c27a9d828956704dba06efa"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"628d57b34801c58a7af7de4095b2d611de24dfd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"80328527_25f515cb","updated":"2024-10-11 11:56:14.000000000","message":"looks OK to me.","commit_id":"025cd8ee9231fb34b39fb10bfaa66237b2fb978f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"00c57676865a11442d525597fa38ff5eb7cc1b5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"f967cece_9f597545","updated":"2024-11-05 13:12:38.000000000","message":"Looks good the exception message change works for me locally.","commit_id":"b1f481d00392ea859c93260364ee539b66963af7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7aac54a7a4b99a8eafc725546fe35c33cd62781d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"26518ada_cae204b3","updated":"2024-11-18 18:02:38.000000000","message":"I did a bunch of tests with cephfs native backend and I found no problem. Thanks for the hard work.","commit_id":"194d43e42e14fb757db48edb599318cb5393d00f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"441d25f55a2fa4e80c3682a8e82bee4479da4c95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"b6225af8_b5fd5de2","updated":"2024-11-15 10:35:32.000000000","message":"still looks good.","commit_id":"194d43e42e14fb757db48edb599318cb5393d00f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b4ee076fd4c11fdb4fce27ed9ceb2af30d2fb644","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"31332e6e_de9f06d8","updated":"2024-11-21 09:45:12.000000000","message":"q","commit_id":"e4cb11eecf995e73df54fbe8b8fdd84672172475"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"90f56ab0cdecc087c78fa38a53c006c5d57d0c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"93b29ae4_303571e7","updated":"2024-11-28 08:54:44.000000000","message":"recheck grenade failed with guest kernel panic\n```\n/sbin/init: can\u0027t load library \u0027libtirpc.so.3\u0027\n[   18.211138] Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000\n```","commit_id":"cee77d87f32d53981c0763905804567d91a28081"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a0972e365dc1381ffdf1855791ff50adf48cd84d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"2468da0c_210ea578","updated":"2024-12-04 14:34:46.000000000","message":"recheck multi-cell ssh timeout on instances with cinder volumes tempest check.\n\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 65, in wrapper\n    return f(*func_args, **func_kwargs)\n  File \"/opt/stack/tempest/tempest/scenario/test_instances_with_cinder_volumes.py\", line 195, in test_instances_with_cinder_volumes_on_all_compute_nodes\n    timestamp_before \u003d self.create_timestamp(\n  File \"/opt/stack/tempest/tempest/scenario/manager.py\", line 1256, in create_timestamp\n    ssh_client.make_fs(dev_name, fs\u003dfs)\n  File \"/opt/stack/tempest/tempest/common/utils/linux/remote_client.py\", line 191, in make_fs\n    self.exec_command(cmd_mkfs)\n  File \"/opt/stack/tempest/tempest/lib/common/utils/linux/remote_client.py\", line 31, in wrapper\n    return function(self, *args, **kwargs)\n  File \"/opt/stack/tempest/tempest/lib/common/utils/linux/remote_client.py\", line 115, in exec_command\n    return self.ssh_client.exec_command(cmd)\n  File \"/opt/stack/tempest/tempest/lib/common/ssh.py\", line 207, in exec_command\n    raise exceptions.TimeoutException(\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: Command: \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; sudo mkfs -t vfat /dev/vdb\u0027 executed on host \u0027172.24.5.31\u0027.","commit_id":"cee77d87f32d53981c0763905804567d91a28081"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"770d8404e8f6a68404ee886378068f464f39daa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"ea78391c_81cb7975","updated":"2024-12-05 09:21:04.000000000","message":"recheck nova-lvm general slowness of the node","commit_id":"cee77d87f32d53981c0763905804567d91a28081"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1e5a8001e7fb8a11b0a492e5d0e60a81750c05e2","unresolved":true,"context_lines":[{"line_number":4619,"context_line":""},{"line_number":4620,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4621,"context_line":"        def _allow_share(context, instance, share_mapping):"},{"line_number":4622,"context_line":"            def _has_access():"},{"line_number":4623,"context_line":"                access \u003d self.manila_api.get_access("},{"line_number":4624,"context_line":"                    share_mapping.share_id,"},{"line_number":4625,"context_line":"                    access_type,"}],"source_content_type":"text/x-python","patch_set":19,"id":"27b22777_84202970","line":4622,"updated":"2024-06-11 12:14:11.000000000","message":"I would move these nested helpers either to the manila client code or to the ShareMapping object.","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"593f3bbeb0af91a592cad1a4a3be990b2f7d4709","unresolved":false,"context_lines":[{"line_number":4619,"context_line":""},{"line_number":4620,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4621,"context_line":"        def _allow_share(context, instance, share_mapping):"},{"line_number":4622,"context_line":"            def _has_access():"},{"line_number":4623,"context_line":"                access \u003d self.manila_api.get_access("},{"line_number":4624,"context_line":"                    share_mapping.share_id,"},{"line_number":4625,"context_line":"                    access_type,"}],"source_content_type":"text/x-python","patch_set":19,"id":"23908d93_bb922e28","line":4622,"in_reply_to":"27b22777_84202970","updated":"2024-06-18 08:18:23.000000000","message":"Done","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1e5a8001e7fb8a11b0a492e5d0e60a81750c05e2","unresolved":true,"context_lines":[{"line_number":4622,"context_line":"            def _has_access():"},{"line_number":4623,"context_line":"                access \u003d self.manila_api.get_access("},{"line_number":4624,"context_line":"                    share_mapping.share_id,"},{"line_number":4625,"context_line":"                    access_type,"},{"line_number":4626,"context_line":"                    access_to"},{"line_number":4627,"context_line":"                )"},{"line_number":4628,"context_line":"                return access is not None and access.state \u003d\u003d \u0027active\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"948baac6_48bb7b66","line":4625,"updated":"2024-06-11 12:14:11.000000000","message":"use share_mapping.access_type and .access_to","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"593f3bbeb0af91a592cad1a4a3be990b2f7d4709","unresolved":false,"context_lines":[{"line_number":4622,"context_line":"            def _has_access():"},{"line_number":4623,"context_line":"                access \u003d self.manila_api.get_access("},{"line_number":4624,"context_line":"                    share_mapping.share_id,"},{"line_number":4625,"context_line":"                    access_type,"},{"line_number":4626,"context_line":"                    access_to"},{"line_number":4627,"context_line":"                )"},{"line_number":4628,"context_line":"                return access is not None and access.state \u003d\u003d \u0027active\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"e720f884_aab169c0","line":4625,"in_reply_to":"948baac6_48bb7b66","updated":"2024-06-18 08:18:23.000000000","message":"Done","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1e5a8001e7fb8a11b0a492e5d0e60a81750c05e2","unresolved":true,"context_lines":[{"line_number":4633,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4634,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"},{"line_number":4635,"context_line":"                self.manila_api.allow("},{"line_number":4636,"context_line":"                    share_mapping.share_id, access_type, access_to, \"rw\""},{"line_number":4637,"context_line":"                )"},{"line_number":4638,"context_line":""},{"line_number":4639,"context_line":"            def _wait_policy_to_be_applied():"}],"source_content_type":"text/x-python","patch_set":19,"id":"e6cc0919_adca6ce8","line":4636,"updated":"2024-06-11 12:14:11.000000000","message":"if you use share_mapping.access_type and share_mapping.access_to here then you don\u0027t need the local variables access_type and access_to to be defined below. The _set_access_according_to_protocol already set these on the share_mapping.","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"593f3bbeb0af91a592cad1a4a3be990b2f7d4709","unresolved":false,"context_lines":[{"line_number":4633,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4634,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"},{"line_number":4635,"context_line":"                self.manila_api.allow("},{"line_number":4636,"context_line":"                    share_mapping.share_id, access_type, access_to, \"rw\""},{"line_number":4637,"context_line":"                )"},{"line_number":4638,"context_line":""},{"line_number":4639,"context_line":"            def _wait_policy_to_be_applied():"}],"source_content_type":"text/x-python","patch_set":19,"id":"f611bb32_8a1a8d06","line":4636,"in_reply_to":"e6cc0919_adca6ce8","updated":"2024-06-18 08:18:23.000000000","message":"Done","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1e5a8001e7fb8a11b0a492e5d0e60a81750c05e2","unresolved":true,"context_lines":[{"line_number":4740,"context_line":"                    # \"unrestrict\" parameter is passed"},{"line_number":4741,"context_line":"                    self.manila_api.deny("},{"line_number":4742,"context_line":"                        share_mapping.share_id,"},{"line_number":4743,"context_line":"                        access_type,"},{"line_number":4744,"context_line":"                        access_to,"},{"line_number":4745,"context_line":"                    )"},{"line_number":4746,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"256c8671_d1bb689b","line":4743,"updated":"2024-06-11 12:14:11.000000000","message":"you can use share_mapping.access_type and .access_to and get rid of the local variables.","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"593f3bbeb0af91a592cad1a4a3be990b2f7d4709","unresolved":false,"context_lines":[{"line_number":4740,"context_line":"                    # \"unrestrict\" parameter is passed"},{"line_number":4741,"context_line":"                    self.manila_api.deny("},{"line_number":4742,"context_line":"                        share_mapping.share_id,"},{"line_number":4743,"context_line":"                        access_type,"},{"line_number":4744,"context_line":"                        access_to,"},{"line_number":4745,"context_line":"                    )"},{"line_number":4746,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"46b945ec_cfd697db","line":4743,"in_reply_to":"256c8671_d1bb689b","updated":"2024-06-18 08:18:23.000000000","message":"Done","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1e5a8001e7fb8a11b0a492e5d0e60a81750c05e2","unresolved":true,"context_lines":[{"line_number":4783,"context_line":"                    access_type,"},{"line_number":4784,"context_line":"                    access_to"},{"line_number":4785,"context_line":"                )"},{"line_number":4786,"context_line":"                share_mapping.access_to \u003d access_to"},{"line_number":4787,"context_line":"                share_mapping.access_key \u003d access.access_key"},{"line_number":4788,"context_line":""},{"line_number":4789,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"926f2599_8b125a2e","line":4786,"updated":"2024-06-11 12:14:11.000000000","message":"share_mapping.access_to","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"593f3bbeb0af91a592cad1a4a3be990b2f7d4709","unresolved":false,"context_lines":[{"line_number":4783,"context_line":"                    access_type,"},{"line_number":4784,"context_line":"                    access_to"},{"line_number":4785,"context_line":"                )"},{"line_number":4786,"context_line":"                share_mapping.access_to \u003d access_to"},{"line_number":4787,"context_line":"                share_mapping.access_key \u003d access.access_key"},{"line_number":4788,"context_line":""},{"line_number":4789,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"b56cbda6_5e9485ff","line":4786,"in_reply_to":"926f2599_8b125a2e","updated":"2024-06-18 08:18:23.000000000","message":"Done","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1e5a8001e7fb8a11b0a492e5d0e60a81750c05e2","unresolved":true,"context_lines":[{"line_number":4790,"context_line":"                ("},{"line_number":4791,"context_line":"                    access_type,"},{"line_number":4792,"context_line":"                    access_to"},{"line_number":4793,"context_line":"                ) \u003d self._set_access_according_to_protocol(share_mapping)"},{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"                if share_mapping.share_proto \u003d\u003d ("},{"line_number":4796,"context_line":"                    fields.ShareMappingProto.CEPHFS):"}],"source_content_type":"text/x-python","patch_set":19,"id":"a5f1ae75_9201a24f","line":4793,"updated":"2024-06-11 12:14:11.000000000","message":"you can drop the local vars and use the share_mapping fields instead","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"593f3bbeb0af91a592cad1a4a3be990b2f7d4709","unresolved":false,"context_lines":[{"line_number":4790,"context_line":"                ("},{"line_number":4791,"context_line":"                    access_type,"},{"line_number":4792,"context_line":"                    access_to"},{"line_number":4793,"context_line":"                ) \u003d self._set_access_according_to_protocol(share_mapping)"},{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"                if share_mapping.share_proto \u003d\u003d ("},{"line_number":4796,"context_line":"                    fields.ShareMappingProto.CEPHFS):"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa52e5cb_0f17d196","line":4793,"in_reply_to":"a5f1ae75_9201a24f","updated":"2024-06-18 08:18:23.000000000","message":"Done","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1e5a8001e7fb8a11b0a492e5d0e60a81750c05e2","unresolved":true,"context_lines":[{"line_number":4864,"context_line":"            raise exception.ShareProtocolUnknown("},{"line_number":4865,"context_line":"                share_proto\u003dshare_mapping.share_proto"},{"line_number":4866,"context_line":"            )"},{"line_number":4867,"context_line":"        return (access_type, access_to)"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"    @wrap_instance_fault"},{"line_number":4870,"context_line":"    def _rotate_backups(self, context, instance, backup_type, rotation):"}],"source_content_type":"text/x-python","patch_set":19,"id":"0792dab8_19d7d25c","line":4867,"updated":"2024-06-11 12:14:11.000000000","message":"you don\u0027t have to return these, just use the share_mapping fields everywhere instead.","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"593f3bbeb0af91a592cad1a4a3be990b2f7d4709","unresolved":false,"context_lines":[{"line_number":4864,"context_line":"            raise exception.ShareProtocolUnknown("},{"line_number":4865,"context_line":"                share_proto\u003dshare_mapping.share_proto"},{"line_number":4866,"context_line":"            )"},{"line_number":4867,"context_line":"        return (access_type, access_to)"},{"line_number":4868,"context_line":""},{"line_number":4869,"context_line":"    @wrap_instance_fault"},{"line_number":4870,"context_line":"    def _rotate_backups(self, context, instance, backup_type, rotation):"}],"source_content_type":"text/x-python","patch_set":19,"id":"0c732763_e38b741e","line":4867,"in_reply_to":"0792dab8_19d7d25c","updated":"2024-06-18 08:18:23.000000000","message":"Done","commit_id":"a3228f245e1aa0875d762ddbc8f8520a20a4f877"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"66ec492ac9e119b7ea871d26f749eb641f0e077d","unresolved":true,"context_lines":[{"line_number":4633,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4634,"context_line":"        def _allow_share(context, instance, share_mapping):"},{"line_number":4635,"context_line":""},{"line_number":4636,"context_line":"            def _apply_policy():"},{"line_number":4637,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4638,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4639,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4640,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"},{"line_number":4641,"context_line":"                self.manila_api.allow("},{"line_number":4642,"context_line":"                    context,"},{"line_number":4643,"context_line":"                    share_mapping.share_id,"},{"line_number":4644,"context_line":"                    share_mapping.access_type,"},{"line_number":4645,"context_line":"                    share_mapping.access_to,"},{"line_number":4646,"context_line":"                    \"rw\","},{"line_number":4647,"context_line":"                )"},{"line_number":4648,"context_line":""},{"line_number":4649,"context_line":"            def _wait_policy_to_be_applied():"},{"line_number":4650,"context_line":"                # Ensure the share policy is updated, this will avoid"},{"line_number":4651,"context_line":"                # a race condition mounting the share if it is not the case."}],"source_content_type":"text/x-python","patch_set":22,"id":"2e123470_111b3089","line":4648,"range":{"start_line":4636,"start_character":0,"end_line":4648,"end_character":0},"updated":"2024-06-18 12:22:22.000000000","message":"this function is now a simple call to manila_api so you can inline it in all call places.","commit_id":"2be85f9495ec9f8b60547f090d686ea272c99741"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a97f352450a1096598f9df775f7aaed351200f61","unresolved":true,"context_lines":[{"line_number":4633,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4634,"context_line":"        def _allow_share(context, instance, share_mapping):"},{"line_number":4635,"context_line":""},{"line_number":4636,"context_line":"            def _apply_policy():"},{"line_number":4637,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4638,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4639,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4640,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"},{"line_number":4641,"context_line":"                self.manila_api.allow("},{"line_number":4642,"context_line":"                    context,"},{"line_number":4643,"context_line":"                    share_mapping.share_id,"},{"line_number":4644,"context_line":"                    share_mapping.access_type,"},{"line_number":4645,"context_line":"                    share_mapping.access_to,"},{"line_number":4646,"context_line":"                    \"rw\","},{"line_number":4647,"context_line":"                )"},{"line_number":4648,"context_line":""},{"line_number":4649,"context_line":"            def _wait_policy_to_be_applied():"},{"line_number":4650,"context_line":"                # Ensure the share policy is updated, this will avoid"},{"line_number":4651,"context_line":"                # a race condition mounting the share if it is not the case."}],"source_content_type":"text/x-python","patch_set":22,"id":"ad9bcf8a_4c17b41d","line":4648,"range":{"start_line":4636,"start_character":0,"end_line":4648,"end_character":0},"in_reply_to":"2e123470_111b3089","updated":"2024-09-09 16:13:25.000000000","message":"I would rather keep it unless you dislike that as it helps me identify the loop.","commit_id":"2be85f9495ec9f8b60547f090d686ea272c99741"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"75c61682066d8a32c651a61d989705a03a50af05","unresolved":false,"context_lines":[{"line_number":4633,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4634,"context_line":"        def _allow_share(context, instance, share_mapping):"},{"line_number":4635,"context_line":""},{"line_number":4636,"context_line":"            def _apply_policy():"},{"line_number":4637,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4638,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4639,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4640,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"},{"line_number":4641,"context_line":"                self.manila_api.allow("},{"line_number":4642,"context_line":"                    context,"},{"line_number":4643,"context_line":"                    share_mapping.share_id,"},{"line_number":4644,"context_line":"                    share_mapping.access_type,"},{"line_number":4645,"context_line":"                    share_mapping.access_to,"},{"line_number":4646,"context_line":"                    \"rw\","},{"line_number":4647,"context_line":"                )"},{"line_number":4648,"context_line":""},{"line_number":4649,"context_line":"            def _wait_policy_to_be_applied():"},{"line_number":4650,"context_line":"                # Ensure the share policy is updated, this will avoid"},{"line_number":4651,"context_line":"                # a race condition mounting the share if it is not the case."}],"source_content_type":"text/x-python","patch_set":22,"id":"e82b6ed9_56bf62e0","line":4648,"range":{"start_line":4636,"start_character":0,"end_line":4648,"end_character":0},"in_reply_to":"88b5ef2f_1e4ea61f","updated":"2024-11-18 14:34:15.000000000","message":"Acknowledged","commit_id":"2be85f9495ec9f8b60547f090d686ea272c99741"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7aac54a7a4b99a8eafc725546fe35c33cd62781d","unresolved":false,"context_lines":[{"line_number":4633,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4634,"context_line":"        def _allow_share(context, instance, share_mapping):"},{"line_number":4635,"context_line":""},{"line_number":4636,"context_line":"            def _apply_policy():"},{"line_number":4637,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4638,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4639,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4640,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"},{"line_number":4641,"context_line":"                self.manila_api.allow("},{"line_number":4642,"context_line":"                    context,"},{"line_number":4643,"context_line":"                    share_mapping.share_id,"},{"line_number":4644,"context_line":"                    share_mapping.access_type,"},{"line_number":4645,"context_line":"                    share_mapping.access_to,"},{"line_number":4646,"context_line":"                    \"rw\","},{"line_number":4647,"context_line":"                )"},{"line_number":4648,"context_line":""},{"line_number":4649,"context_line":"            def _wait_policy_to_be_applied():"},{"line_number":4650,"context_line":"                # Ensure the share policy is updated, this will avoid"},{"line_number":4651,"context_line":"                # a race condition mounting the share if it is not the case."}],"source_content_type":"text/x-python","patch_set":22,"id":"62ecaae1_97312837","line":4648,"range":{"start_line":4636,"start_character":0,"end_line":4648,"end_character":0},"in_reply_to":"88b5ef2f_1e4ea61f","updated":"2024-11-18 18:02:38.000000000","message":"Can we close this comment ? I don\u0027t see the related code","commit_id":"2be85f9495ec9f8b60547f090d686ea272c99741"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"628d57b34801c58a7af7de4095b2d611de24dfd5","unresolved":true,"context_lines":[{"line_number":4633,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4634,"context_line":"        def _allow_share(context, instance, share_mapping):"},{"line_number":4635,"context_line":""},{"line_number":4636,"context_line":"            def _apply_policy():"},{"line_number":4637,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4638,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4639,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4640,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"},{"line_number":4641,"context_line":"                self.manila_api.allow("},{"line_number":4642,"context_line":"                    context,"},{"line_number":4643,"context_line":"                    share_mapping.share_id,"},{"line_number":4644,"context_line":"                    share_mapping.access_type,"},{"line_number":4645,"context_line":"                    share_mapping.access_to,"},{"line_number":4646,"context_line":"                    \"rw\","},{"line_number":4647,"context_line":"                )"},{"line_number":4648,"context_line":""},{"line_number":4649,"context_line":"            def _wait_policy_to_be_applied():"},{"line_number":4650,"context_line":"                # Ensure the share policy is updated, this will avoid"},{"line_number":4651,"context_line":"                # a race condition mounting the share if it is not the case."}],"source_content_type":"text/x-python","patch_set":22,"id":"88b5ef2f_1e4ea61f","line":4648,"range":{"start_line":4636,"start_character":0,"end_line":4648,"end_character":0},"in_reply_to":"ad9bcf8a_4c17b41d","updated":"2024-10-11 11:56:14.000000000","message":"We can agree that we disagree. I rest my case as this is a minor thing.","commit_id":"2be85f9495ec9f8b60547f090d686ea272c99741"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fe805ece5e7bccc7d907f1fd1d76e4e779d2cc98","unresolved":true,"context_lines":[{"line_number":4808,"context_line":""},{"line_number":4809,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4810,"context_line":"        def _mount_share(context, instance, share_mapping):"},{"line_number":4811,"context_line":"            def _enhance_share_mapping_with_ceph_credentials():"},{"line_number":4812,"context_line":"                # Enhance the share_mapping object by adding Ceph"},{"line_number":4813,"context_line":"                # credential information"},{"line_number":4814,"context_line":"                access \u003d self.manila_api.get_access("}],"source_content_type":"text/x-python","patch_set":24,"id":"f57dabcd_9f7203de","line":4811,"updated":"2024-07-31 14:11:53.000000000","message":"I\u0027m not convinced we need such hacky conditionals to be put straight in our compute service. Couldn\u0027t the ShareMapping object be a little smarter and provide me some business logic in it ?","commit_id":"5ffa96052644701a88f0d5f97364dc3a6b8e19cd"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a97f352450a1096598f9df775f7aaed351200f61","unresolved":false,"context_lines":[{"line_number":4808,"context_line":""},{"line_number":4809,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4810,"context_line":"        def _mount_share(context, instance, share_mapping):"},{"line_number":4811,"context_line":"            def _enhance_share_mapping_with_ceph_credentials():"},{"line_number":4812,"context_line":"                # Enhance the share_mapping object by adding Ceph"},{"line_number":4813,"context_line":"                # credential information"},{"line_number":4814,"context_line":"                access \u003d self.manila_api.get_access("}],"source_content_type":"text/x-python","patch_set":24,"id":"275b2cb6_2239ae5d","line":4811,"in_reply_to":"f57dabcd_9f7203de","updated":"2024-09-09 16:13:25.000000000","message":"Done","commit_id":"5ffa96052644701a88f0d5f97364dc3a6b8e19cd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fe805ece5e7bccc7d907f1fd1d76e4e779d2cc98","unresolved":true,"context_lines":[{"line_number":4883,"context_line":"            instance, clean_task_state\u003dTrue"},{"line_number":4884,"context_line":"        )"},{"line_number":4885,"context_line":""},{"line_number":4886,"context_line":"    def _set_access_according_to_protocol(self, share_mapping):"},{"line_number":4887,"context_line":"        if share_mapping.share_proto \u003d\u003d fields.ShareMappingProto.NFS:"},{"line_number":4888,"context_line":"            share_mapping.access_type \u003d \u0027ip\u0027"},{"line_number":4889,"context_line":"            share_mapping.access_to \u003d CONF.my_shared_fs_storage_ip"}],"source_content_type":"text/x-python","patch_set":24,"id":"932692ec_2cbf1acc","line":4886,"updated":"2024-07-31 14:11:53.000000000","message":"can\u0027t that be part of the ShareMapping object module as a helper method or ideally something the object would automatically set based on its proto ?","commit_id":"5ffa96052644701a88f0d5f97364dc3a6b8e19cd"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a97f352450a1096598f9df775f7aaed351200f61","unresolved":false,"context_lines":[{"line_number":4883,"context_line":"            instance, clean_task_state\u003dTrue"},{"line_number":4884,"context_line":"        )"},{"line_number":4885,"context_line":""},{"line_number":4886,"context_line":"    def _set_access_according_to_protocol(self, share_mapping):"},{"line_number":4887,"context_line":"        if share_mapping.share_proto \u003d\u003d fields.ShareMappingProto.NFS:"},{"line_number":4888,"context_line":"            share_mapping.access_type \u003d \u0027ip\u0027"},{"line_number":4889,"context_line":"            share_mapping.access_to \u003d CONF.my_shared_fs_storage_ip"}],"source_content_type":"text/x-python","patch_set":24,"id":"fce31108_dd8869e7","line":4886,"in_reply_to":"932692ec_2cbf1acc","updated":"2024-09-09 16:13:25.000000000","message":"Done","commit_id":"5ffa96052644701a88f0d5f97364dc3a6b8e19cd"}],"nova/conf/libvirt.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5706dfc641b5e3cac5c280ff64bcc28a2fb9f790","unresolved":true,"context_lines":[{"line_number":1244,"context_line":"    cfg.StrOpt(\u0027ceph_mount_point_base\u0027,"},{"line_number":1245,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":1246,"context_line":"               help\u003d\"\"\""},{"line_number":1247,"context_line":"Directory where the ceph volume is mounted on the compute node."},{"line_number":1248,"context_line":"The default is \u0027mnt\u0027 directory of the location where nova\u0027s Python module"},{"line_number":1249,"context_line":"is installed."},{"line_number":1250,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3dd91604_b5506aa8","line":1247,"updated":"2024-01-30 12:11:48.000000000","message":"There will be a one ceph volume per share? If so then \"Directory where the ceph volume for each manila share is mounted\"","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a92cca43b6f7ebb964b86aed7e791ef44e087841","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"    cfg.StrOpt(\u0027ceph_mount_point_base\u0027,"},{"line_number":1245,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":1246,"context_line":"               help\u003d\"\"\""},{"line_number":1247,"context_line":"Directory where the ceph volume is mounted on the compute node."},{"line_number":1248,"context_line":"The default is \u0027mnt\u0027 directory of the location where nova\u0027s Python module"},{"line_number":1249,"context_line":"is installed."},{"line_number":1250,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"36b763c0_cc92884d","line":1247,"in_reply_to":"28d7aa3e_16ee36ab","updated":"2024-02-28 14:53:56.000000000","message":"Done","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"40d7350a034b1cf9748159154ee219b1094714b8","unresolved":true,"context_lines":[{"line_number":1244,"context_line":"    cfg.StrOpt(\u0027ceph_mount_point_base\u0027,"},{"line_number":1245,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt\u0027),"},{"line_number":1246,"context_line":"               help\u003d\"\"\""},{"line_number":1247,"context_line":"Directory where the ceph volume is mounted on the compute node."},{"line_number":1248,"context_line":"The default is \u0027mnt\u0027 directory of the location where nova\u0027s Python module"},{"line_number":1249,"context_line":"is installed."},{"line_number":1250,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"28d7aa3e_16ee36ab","line":1247,"in_reply_to":"3dd91604_b5506aa8","updated":"2024-02-16 14:41:04.000000000","message":"Ok, I\u0027will change it.","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5706dfc641b5e3cac5c280ff64bcc28a2fb9f790","unresolved":true,"context_lines":[{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"* A string representing absolute path of mount point."},{"line_number":1254,"context_line":"\"\"\"),"},{"line_number":1255,"context_line":"    cfg.StrOpt(\u0027ceph_mount_options\u0027,"},{"line_number":1256,"context_line":"               help\u003d\"\"\""},{"line_number":1257,"context_line":"Mount options passed to the ceph client. See section of the ceph man page"},{"line_number":1258,"context_line":"for details."}],"source_content_type":"text/x-python","patch_set":10,"id":"95090b8c_49984c42","line":1255,"updated":"2024-01-30 12:11:48.000000000","message":"Can we define this as a ListOpt and to avoid having a custom string parses in the code that splits it by commas ?","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a92cca43b6f7ebb964b86aed7e791ef44e087841","unresolved":false,"context_lines":[{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"* A string representing absolute path of mount point."},{"line_number":1254,"context_line":"\"\"\"),"},{"line_number":1255,"context_line":"    cfg.StrOpt(\u0027ceph_mount_options\u0027,"},{"line_number":1256,"context_line":"               help\u003d\"\"\""},{"line_number":1257,"context_line":"Mount options passed to the ceph client. See section of the ceph man page"},{"line_number":1258,"context_line":"for details."}],"source_content_type":"text/x-python","patch_set":10,"id":"8e00906f_367baac7","line":1255,"in_reply_to":"04ae9025_9986daf7","updated":"2024-02-28 14:53:56.000000000","message":"Done","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"40d7350a034b1cf9748159154ee219b1094714b8","unresolved":true,"context_lines":[{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"* A string representing absolute path of mount point."},{"line_number":1254,"context_line":"\"\"\"),"},{"line_number":1255,"context_line":"    cfg.StrOpt(\u0027ceph_mount_options\u0027,"},{"line_number":1256,"context_line":"               help\u003d\"\"\""},{"line_number":1257,"context_line":"Mount options passed to the ceph client. See section of the ceph man page"},{"line_number":1258,"context_line":"for details."}],"source_content_type":"text/x-python","patch_set":10,"id":"04ae9025_9986daf7","line":1255,"in_reply_to":"95090b8c_49984c42","updated":"2024-02-16 14:41:04.000000000","message":"I think so, I will change that.","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5706dfc641b5e3cac5c280ff64bcc28a2fb9f790","unresolved":true,"context_lines":[{"line_number":4161,"context_line":"            }"},{"line_number":4162,"context_line":"        }"},{"line_number":4163,"context_line":"        if share_mapping.share_proto \u003d\u003d fields.ShareMappingProto.CEPHFS:"},{"line_number":4164,"context_line":"            if ("},{"line_number":4165,"context_line":"                \"access_to\" in share_mapping and"},{"line_number":4166,"context_line":"                share_mapping.access_to is not None"},{"line_number":4167,"context_line":"            ):"},{"line_number":4168,"context_line":"                name_opt \u003d \"name\u003d\" + share_mapping.access_to"},{"line_number":4169,"context_line":"                secret_opt \u003d \"secret\u003d\" + share_mapping.access_key"},{"line_number":4170,"context_line":"                connection_info[\"data\"][\"options\"] \u003d [name_opt, secret_opt]"}],"source_content_type":"text/x-python","patch_set":10,"id":"bba1f0ec_a3f050a6","line":4167,"range":{"start_line":4164,"start_character":0,"end_line":4167,"end_character":14},"updated":"2024-01-30 12:11:48.000000000","message":"Is there a case when access_to is not provided for CEPHFS shares? If so, will the caller of _get_share_connection_info() work without the access_to ans secret_opts present in the returned connection_info?","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"a92cca43b6f7ebb964b86aed7e791ef44e087841","unresolved":true,"context_lines":[{"line_number":4161,"context_line":"            }"},{"line_number":4162,"context_line":"        }"},{"line_number":4163,"context_line":"        if share_mapping.share_proto \u003d\u003d fields.ShareMappingProto.CEPHFS:"},{"line_number":4164,"context_line":"            if ("},{"line_number":4165,"context_line":"                \"access_to\" in share_mapping and"},{"line_number":4166,"context_line":"                share_mapping.access_to is not None"},{"line_number":4167,"context_line":"            ):"},{"line_number":4168,"context_line":"                name_opt \u003d \"name\u003d\" + share_mapping.access_to"},{"line_number":4169,"context_line":"                secret_opt \u003d \"secret\u003d\" + share_mapping.access_key"},{"line_number":4170,"context_line":"                connection_info[\"data\"][\"options\"] \u003d [name_opt, secret_opt]"}],"source_content_type":"text/x-python","patch_set":10,"id":"eb50f69f_25a0d351","line":4167,"range":{"start_line":4164,"start_character":0,"end_line":4167,"end_character":14},"in_reply_to":"3d4cda65_908c97e4","updated":"2024-02-28 14:53:56.000000000","message":"In fact, I was wrong access_to and access_key can not be provided using CEPHFS when doing a umount, because it is not required.\nI also try to use the secret only when required.\nSo these lines are required.","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1fa0fb72ebf22b80ebc5c7f85a85894623704dea","unresolved":true,"context_lines":[{"line_number":4161,"context_line":"            }"},{"line_number":4162,"context_line":"        }"},{"line_number":4163,"context_line":"        if share_mapping.share_proto \u003d\u003d fields.ShareMappingProto.CEPHFS:"},{"line_number":4164,"context_line":"            if ("},{"line_number":4165,"context_line":"                \"access_to\" in share_mapping and"},{"line_number":4166,"context_line":"                share_mapping.access_to is not None"},{"line_number":4167,"context_line":"            ):"},{"line_number":4168,"context_line":"                name_opt \u003d \"name\u003d\" + share_mapping.access_to"},{"line_number":4169,"context_line":"                secret_opt \u003d \"secret\u003d\" + share_mapping.access_key"},{"line_number":4170,"context_line":"                connection_info[\"data\"][\"options\"] \u003d [name_opt, secret_opt]"}],"source_content_type":"text/x-python","patch_set":10,"id":"3d4cda65_908c97e4","line":4167,"range":{"start_line":4164,"start_character":0,"end_line":4167,"end_character":14},"in_reply_to":"4858b8a2_c831bd65","updated":"2024-02-19 16:53:17.000000000","message":"it depends. If it is external input, then we need some error handling yes. If this data is purely nova internal, then I would simply use the fields without checking, and have test to prove that the caller always provides it.","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"40d7350a034b1cf9748159154ee219b1094714b8","unresolved":true,"context_lines":[{"line_number":4161,"context_line":"            }"},{"line_number":4162,"context_line":"        }"},{"line_number":4163,"context_line":"        if share_mapping.share_proto \u003d\u003d fields.ShareMappingProto.CEPHFS:"},{"line_number":4164,"context_line":"            if ("},{"line_number":4165,"context_line":"                \"access_to\" in share_mapping and"},{"line_number":4166,"context_line":"                share_mapping.access_to is not None"},{"line_number":4167,"context_line":"            ):"},{"line_number":4168,"context_line":"                name_opt \u003d \"name\u003d\" + share_mapping.access_to"},{"line_number":4169,"context_line":"                secret_opt \u003d \"secret\u003d\" + share_mapping.access_key"},{"line_number":4170,"context_line":"                connection_info[\"data\"][\"options\"] \u003d [name_opt, secret_opt]"}],"source_content_type":"text/x-python","patch_set":10,"id":"4858b8a2_c831bd65","line":4167,"range":{"start_line":4164,"start_character":0,"end_line":4167,"end_character":14},"in_reply_to":"bba1f0ec_a3f050a6","updated":"2024-02-16 14:41:04.000000000","message":"You are right. \"access_to\" and \"access_key\" should always be provided for CEPHFS shares.\n\nFor CEPHFS, if this is not provided, it will not work.\n\nSo I guess you want me to raise an exception if access_to and access_key are empty ?","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"75c61682066d8a32c651a61d989705a03a50af05","unresolved":false,"context_lines":[{"line_number":4161,"context_line":"            }"},{"line_number":4162,"context_line":"        }"},{"line_number":4163,"context_line":"        if share_mapping.share_proto \u003d\u003d fields.ShareMappingProto.CEPHFS:"},{"line_number":4164,"context_line":"            if ("},{"line_number":4165,"context_line":"                \"access_to\" in share_mapping and"},{"line_number":4166,"context_line":"                share_mapping.access_to is not None"},{"line_number":4167,"context_line":"            ):"},{"line_number":4168,"context_line":"                name_opt \u003d \"name\u003d\" + share_mapping.access_to"},{"line_number":4169,"context_line":"                secret_opt \u003d \"secret\u003d\" + share_mapping.access_key"},{"line_number":4170,"context_line":"                connection_info[\"data\"][\"options\"] \u003d [name_opt, secret_opt]"}],"source_content_type":"text/x-python","patch_set":10,"id":"19dc916b_ce00e337","line":4167,"range":{"start_line":4164,"start_character":0,"end_line":4167,"end_character":14},"in_reply_to":"eb50f69f_25a0d351","updated":"2024-11-18 14:34:15.000000000","message":"Acknowledged","commit_id":"ac506922689390ca1a7304fbb0e25d4c722a29ec"}]}