)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c16fd68c808baeac51730c4605b182f894ac13d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"138f10bf_6c18c22b","updated":"2024-01-09 01:44:02.000000000","message":"recheck ERROR oslo.messaging._drivers.impl_rabbit [None req-4cea9f21-bc07-47db-baa7-ba48fab876d4 None None] Connection failed: timed out (retrying in 1.0 seconds): TimeoutError: timed out","commit_id":"0a93f38b0fbc2b323eefc3fecf9912c08ad1c374"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd232e6add4cbf27d1757088d4b733f687ebce1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"89c1ce2f_cbf34892","updated":"2024-02-13 08:42:39.000000000","message":"im not sure about the size check\n\ni have not manually tested this but if i have time i will\noverall the rest of the code looks ok.","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"493a00d44c964ff73979b9558fedf415394ca737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"db2e6ed0_a0217a3a","updated":"2024-02-23 21:27:57.000000000","message":"recheck https://review.opendev.org/c/openstack/nova/+/909859 has merged","commit_id":"a040aa00d3733a37ff0dace929f87e3e0079003a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"612a6ffb89be12206307258e48c5af34f1c72564","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"ae09f798_4401dca3","updated":"2024-02-24 00:15:08.000000000","message":"recheck swiftclient.exceptions.ClientException: put_object(\u0027glance\u0027, \u002773159f20-dfa3-4949-8838-efa694fda298-00001\u0027, ...) failure and no ability to reset contents for reupload.","commit_id":"a040aa00d3733a37ff0dace929f87e3e0079003a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8a237066c94975bb035be440ce2b3dcef318eb78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"1f91df0a_445443aa","updated":"2024-06-06 06:14:17.000000000","message":"recheck Jun 05 04:56:14.655503 np0037665059 nova-compute[86217]: ERROR os_brick.initiator.connectors.iscsi Stdout: \u0027SENDTARGETS:\\nNo targets found.\\niSNS:\\nNo targets found.\\nSTATIC:\\nNo targets found.\\nFIRMWARE:\\nNo targets found.\\n\u0027","commit_id":"883684f0683401eb3534e812ac3f84a1430fe218"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd232e6add4cbf27d1757088d4b733f687ebce1f","unresolved":true,"context_lines":[{"line_number":839,"context_line":"                encryption \u003d strutils.bool_from_string("},{"line_number":840,"context_line":"                    image_properties.get(\u0027hw_ephemeral_encryption\u0027))"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"                if image_size \u003e dest_size and not encryption:"},{"line_number":843,"context_line":"                    raise exception.FlavorDiskSmallerThanImage("},{"line_number":844,"context_line":"                        flavor_size\u003ddest_size, image_size\u003dimage_size)"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"914f980e_a1bfdf6d","line":842,"updated":"2024-02-13 08:42:39.000000000","message":"im not sure if we should be skipping this check entirely\n\nshould we do something like\n```\noverhead \u003d 0 if not encyption else 1 * units.Gi\nif image_size \u003e (dest_size + overhead):\n```\n\nmy logic is its ok for the images to be a few bytes or even a few mb larger because fo luks but it shoudl not be significantly larger.\n\nthis would be a security issue if some one maliausly uploaded an image, set its size to 10G and actully made the virtual size 10TB but bypased the image size check by marking it as requesting encyption.","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ee1aeb5f0e696ba8714deeae061c7c555848f53b","unresolved":true,"context_lines":[{"line_number":839,"context_line":"                encryption \u003d strutils.bool_from_string("},{"line_number":840,"context_line":"                    image_properties.get(\u0027hw_ephemeral_encryption\u0027))"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"                if image_size \u003e dest_size and not encryption:"},{"line_number":843,"context_line":"                    raise exception.FlavorDiskSmallerThanImage("},{"line_number":844,"context_line":"                        flavor_size\u003ddest_size, image_size\u003dimage_size)"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"f6dab481_9d8f8d9a","line":842,"in_reply_to":"914f980e_a1bfdf6d","updated":"2024-02-14 08:10:30.000000000","message":"I wondered the same thing ... the encryption overhead isn\u0027t a set amount, so I wasn\u0027t sure what/how to pick the allowable margin. I\u0027ll try your suggestion for the overhead calc.","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cc1ece6ece7dc25549a2f92c9b64e15a61d1a21a","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                encryption \u003d strutils.bool_from_string("},{"line_number":840,"context_line":"                    image_properties.get(\u0027hw_ephemeral_encryption\u0027))"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"                if image_size \u003e dest_size and not encryption:"},{"line_number":843,"context_line":"                    raise exception.FlavorDiskSmallerThanImage("},{"line_number":844,"context_line":"                        flavor_size\u003ddest_size, image_size\u003dimage_size)"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3b64ecb2_09d88f5f","line":842,"in_reply_to":"f6dab481_9d8f8d9a","updated":"2024-03-02 01:28:57.000000000","message":"Done","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd232e6add4cbf27d1757088d4b733f687ebce1f","unresolved":true,"context_lines":[{"line_number":5286,"context_line":"            inst_dirname \u003d os.path.dirname(target).rsplit(\u0027/\u0027)[-1]"},{"line_number":5287,"context_line":"            diskname \u003d os.path.basename(target)"},{"line_number":5288,"context_line":"            mapped_dev_name \u003d inst_dirname + \u0027.\u0027 + diskname"},{"line_number":5289,"context_line":"            # TODO(melwitt): Should we dmsetup remove and retry if this fails?"},{"line_number":5290,"context_line":"            # Or pass assuming it\u0027s already open? Or leave as-is and fail?"},{"line_number":5291,"context_line":"            nova.privsep.libvirt.dmcrypt_open_volume("},{"line_number":5292,"context_line":"                mapped_dev_name, target, dest_encryption.get(\u0027secret\u0027))"}],"source_content_type":"text/x-python","patch_set":29,"id":"d724b5a8_dc0a2817","line":5289,"updated":"2024-02-13 08:42:39.000000000","message":"when would this already be open?","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cc1ece6ece7dc25549a2f92c9b64e15a61d1a21a","unresolved":false,"context_lines":[{"line_number":5286,"context_line":"            inst_dirname \u003d os.path.dirname(target).rsplit(\u0027/\u0027)[-1]"},{"line_number":5287,"context_line":"            diskname \u003d os.path.basename(target)"},{"line_number":5288,"context_line":"            mapped_dev_name \u003d inst_dirname + \u0027.\u0027 + diskname"},{"line_number":5289,"context_line":"            # TODO(melwitt): Should we dmsetup remove and retry if this fails?"},{"line_number":5290,"context_line":"            # Or pass assuming it\u0027s already open? Or leave as-is and fail?"},{"line_number":5291,"context_line":"            nova.privsep.libvirt.dmcrypt_open_volume("},{"line_number":5292,"context_line":"                mapped_dev_name, target, dest_encryption.get(\u0027secret\u0027))"}],"source_content_type":"text/x-python","patch_set":29,"id":"ee7682d9_5ad28f16","line":5289,"in_reply_to":"bf0fa415_c7e8bbdb","updated":"2024-03-02 01:28:57.000000000","message":"Done","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ee1aeb5f0e696ba8714deeae061c7c555848f53b","unresolved":true,"context_lines":[{"line_number":5286,"context_line":"            inst_dirname \u003d os.path.dirname(target).rsplit(\u0027/\u0027)[-1]"},{"line_number":5287,"context_line":"            diskname \u003d os.path.basename(target)"},{"line_number":5288,"context_line":"            mapped_dev_name \u003d inst_dirname + \u0027.\u0027 + diskname"},{"line_number":5289,"context_line":"            # TODO(melwitt): Should we dmsetup remove and retry if this fails?"},{"line_number":5290,"context_line":"            # Or pass assuming it\u0027s already open? Or leave as-is and fail?"},{"line_number":5291,"context_line":"            nova.privsep.libvirt.dmcrypt_open_volume("},{"line_number":5292,"context_line":"                mapped_dev_name, target, dest_encryption.get(\u0027secret\u0027))"}],"source_content_type":"text/x-python","patch_set":29,"id":"bf0fa415_c7e8bbdb","line":5289,"in_reply_to":"d724b5a8_dc0a2817","updated":"2024-02-14 08:10:30.000000000","message":"I\u0027m not sure. I was thinking more along the lines of, what if something failed in the middle on a previous attempt and the file was left open? That happened in my local devstack when I didn\u0027t have things quite right in earlier iterations.","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7358466580d2a64c04ecefb496bab459bead7433","unresolved":true,"context_lines":[{"line_number":5312,"context_line":""},{"line_number":5313,"context_line":"        if dest_encryption:"},{"line_number":5314,"context_line":"            nova.privsep.libvirt.dmcrypt_close_volume(mapped_dev_name)"},{"line_number":5315,"context_line":""},{"line_number":5316,"context_line":"    @staticmethod"},{"line_number":5317,"context_line":"    def _create_swap(target, swap_mb, context\u003dNone, encryption\u003dNone,"},{"line_number":5318,"context_line":"                     dest_encryption\u003dNone):"}],"source_content_type":"text/x-python","patch_set":30,"id":"d1f5859a_e1b389ca","line":5315,"updated":"2024-02-14 10:56:47.000000000","message":"so maybe this is the problem.\n\nif mkfs raises then we would not call this. so we should either use exitstack or finally here to ensure we close this properly if we open it","commit_id":"17137caf35aad83879965d3811b09b33ca5ded60"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cc1ece6ece7dc25549a2f92c9b64e15a61d1a21a","unresolved":false,"context_lines":[{"line_number":5312,"context_line":""},{"line_number":5313,"context_line":"        if dest_encryption:"},{"line_number":5314,"context_line":"            nova.privsep.libvirt.dmcrypt_close_volume(mapped_dev_name)"},{"line_number":5315,"context_line":""},{"line_number":5316,"context_line":"    @staticmethod"},{"line_number":5317,"context_line":"    def _create_swap(target, swap_mb, context\u003dNone, encryption\u003dNone,"},{"line_number":5318,"context_line":"                     dest_encryption\u003dNone):"}],"source_content_type":"text/x-python","patch_set":30,"id":"b0c794ca_4aaf5341","line":5315,"in_reply_to":"d1f5859a_e1b389ca","updated":"2024-03-02 01:28:57.000000000","message":"Done","commit_id":"17137caf35aad83879965d3811b09b33ca5ded60"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd232e6add4cbf27d1757088d4b733f687ebce1f","unresolved":true,"context_lines":[{"line_number":629,"context_line":"    def _get_driver_format(self):"},{"line_number":630,"context_line":"        try:"},{"line_number":631,"context_line":"            data \u003d images.qemu_img_info(self.path)"},{"line_number":632,"context_line":"            # \u0027luks\u0027 is not a valid block driver format despite it being the"},{"line_number":633,"context_line":"            # disk image file format. For example, this XML raises an error:"},{"line_number":634,"context_line":"            #"},{"line_number":635,"context_line":"            # \u003cdisk type\u003d\"file\" device\u003d\"disk\"\u003e"}],"source_content_type":"text/x-python","patch_set":29,"id":"7b3c8653_6ad5533a","line":632,"updated":"2024-02-13 08:42:39.000000000","message":"ya luks is not the file format it the format\nits still a raw file that has a luks partion into wich a filesystem si created.","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7358466580d2a64c04ecefb496bab459bead7433","unresolved":false,"context_lines":[{"line_number":629,"context_line":"    def _get_driver_format(self):"},{"line_number":630,"context_line":"        try:"},{"line_number":631,"context_line":"            data \u003d images.qemu_img_info(self.path)"},{"line_number":632,"context_line":"            # \u0027luks\u0027 is not a valid block driver format despite it being the"},{"line_number":633,"context_line":"            # disk image file format. For example, this XML raises an error:"},{"line_number":634,"context_line":"            #"},{"line_number":635,"context_line":"            # \u003cdisk type\u003d\"file\" device\u003d\"disk\"\u003e"}],"source_content_type":"text/x-python","patch_set":29,"id":"c7d8a33b_e277a1e9","line":632,"in_reply_to":"7b3c8653_6ad5533a","updated":"2024-02-14 10:56:47.000000000","message":"actully just reread this yes it is the file format reported by qemu-img\n\nvenv) ubuntu@disk-encrypt-1:/opt/stack/nova$ qemu-img info --force-share /opt/stack/data/nova/instances/_base/61003586d575b01cb71b35f9686f7aea3800b1ce\nimage: /opt/stack/data/nova/instances/_base/61003586d575b01cb71b35f9686f7aea3800b1ce\nfile format: luks\nvirtual size: 1 GiB (1073741824 bytes)\ndisk size: 1 GiB\nencrypted: yes\n\nbut its not the value accpetd by libvirt in the driver element.\nits still a raw file from its drier persepctive just with a luks format.","commit_id":"accaf90a205145d0fc46b8f49f7430d86a15d6bb"}]}