)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6ac01c869520c3e244321ba58f7eff4dd23f94fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eecd2646_90b3c935","updated":"2023-05-30 19:56:42.000000000","message":"recheck legit timeout but tempest was making progress","commit_id":"8f0514eca5283b52cf5dcedf53f8a08f4f2be7ef"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"29f1f11b8c93275982610e3fd7d973f4fbb53113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc2542ee_306e7650","updated":"2023-05-31 13:52:53.000000000","message":"recheck nova-next ssh timeout to guest","commit_id":"8f0514eca5283b52cf5dcedf53f8a08f4f2be7ef"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f6cc459c28b611f6c105d2556bdec13fce7dc20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"252eb5fe_19da56ba","updated":"2023-07-13 11:07:40.000000000","message":"+1, just a naming nit.","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"12a229c6128aebbb341bd2126d53b2e8ce0f53df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3bf53be8_c1736b2e","updated":"2023-07-14 17:10:25.000000000","message":"Ack, I can do a reno and status check. I\u0027d like to get this merged, so I might do it as a follow-up, but it\u0027ll be next week regardless.","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8ae87a5dec774751c059709875fce49284270845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65a63a27_cae88020","updated":"2023-07-27 14:11:43.000000000","message":"All good, just checked the remaining patches in the series, so I can +W.","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c7d0a4157893d3c95cfe7ca4c5ba7661cf6c4b35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed9a99ad_46a1cdb0","updated":"2023-07-13 13:28:57.000000000","message":"Since the migration above this one is also just `count` I will put a patch on top of this to clean up both at the same time.","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6f109106b978fa84f3312a2030a27d3c18685a53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f99aa0c1_f358cbda","updated":"2023-07-13 13:25:14.000000000","message":"Will fix. I\u0027m sure `max_count` was mine in the first place :)","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7c1696ddf24dc46d9a0bfc4f499ccd91e299b081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70e551d2_5c81174f","updated":"2023-07-14 17:08:22.000000000","message":"i belive sylvains issue has been adressed in the follow up.\n\none addtional thing you could add to the series is a nova-status check to tell you if you unmapped isntances that need to be migrated but i think this is good overall.\n\ni might also consider a upgrades release note at this point now that we have a manual operation that they can/should run.\n\nit might also be good to add  doc patch to descibe how this work in the contribe refence docs althoug we do have the sepc too.\n\n+1 for now as i think the release note shoudl be ideally in thie patch but if you and sylvain are ok without oen then im not going to hold the patch for that.","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ea47f3ffeda93f0b5a5ee5cd0d64e0414c7b5eb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a6853f5_1185c616","updated":"2023-07-14 17:15:36.000000000","message":"ok less handel the reno with the status check in a follow up","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"be444331d445a5cd27c35879315b90151782db54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70edea8d_c553806f","updated":"2023-07-30 06:25:37.000000000","message":"recheck Unexpected response code received","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b86f19404a451354081666ef0632ad31640480f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd5a590a_ec3547eb","updated":"2023-08-01 17:14:01.000000000","message":"recheck devstack fix merged","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3adaf039bf4a72b0950316981c172f41937d83ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45c7a454_662d32f3","updated":"2023-07-28 20:58:18.000000000","message":"recheck grenade smoke failed","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7510b3a975f78bad32900b981b2da0c36045d0cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f40a61a7_8c03dadb","updated":"2023-07-31 13:26:59.000000000","message":"recheck mysql oom","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2cedee0befd8eff98bf5cc621920c6193c89f2fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c3158047_a1b711be","updated":"2023-07-28 23:50:02.000000000","message":"recheck mysql was OOM killed","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5f7cf9f1e452e808d9fe5ced3acbed327898ab03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69851b34_6c99742a","updated":"2023-06-01 18:33:01.000000000","message":"recheck something got hung in devstack/grenade and just stuck there for a long time until timeout","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bc8a3a322c9278a45fec4de883871b2cde955db8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4d88c4f_458db491","updated":"2023-07-28 18:37:24.000000000","message":"recheck ssh timeout to guest","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"22b581bfa6eec12778784d4125bd6fdd6d832836","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7049fecd_e64b59ef","updated":"2023-05-31 17:46:53.000000000","message":"recheck unrelated server boot failures","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"}],"nova/objects/instance.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7f6cc459c28b611f6c105d2556bdec13fce7dc20","unresolved":true,"context_lines":[{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"@db.pick_context_manager_writer"},{"line_number":1351,"context_line":"def populate_instance_compute_id(context, count):"},{"line_number":1352,"context_line":"    instances \u003d (context.session.query(models.Instance)."},{"line_number":1353,"context_line":"        filter(models.Instance.compute_id \u003d\u003d None).  # noqa E711"},{"line_number":1354,"context_line":"        limit(count).all())"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2fb23b5_6aef97db","line":1351,"range":{"start_line":1351,"start_character":42,"end_line":1351,"end_character":47},"updated":"2023-07-13 11:07:40.000000000","message":"nit : the parameter is usually named max_count but of course you can rename it as you want... I just think it\u0027s simplier to continue to have the same name.\n\nhttps://opendev.org/openstack/nova/src/commit/25be0306d7b6caa2ea02714b7ca40bec1ac2f26f/nova/cmd/manage.py#L570","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c7d0a4157893d3c95cfe7ca4c5ba7661cf6c4b35","unresolved":false,"context_lines":[{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"@db.pick_context_manager_writer"},{"line_number":1351,"context_line":"def populate_instance_compute_id(context, count):"},{"line_number":1352,"context_line":"    instances \u003d (context.session.query(models.Instance)."},{"line_number":1353,"context_line":"        filter(models.Instance.compute_id \u003d\u003d None).  # noqa E711"},{"line_number":1354,"context_line":"        limit(count).all())"}],"source_content_type":"text/x-python","patch_set":2,"id":"68c50ef1_36eb584e","line":1351,"range":{"start_line":1351,"start_character":42,"end_line":1351,"end_character":47},"in_reply_to":"7582dd2f_d0c96ec8","updated":"2023-07-13 13:28:57.000000000","message":"Ah I guess I copied L1334.","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6f109106b978fa84f3312a2030a27d3c18685a53","unresolved":false,"context_lines":[{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":""},{"line_number":1350,"context_line":"@db.pick_context_manager_writer"},{"line_number":1351,"context_line":"def populate_instance_compute_id(context, count):"},{"line_number":1352,"context_line":"    instances \u003d (context.session.query(models.Instance)."},{"line_number":1353,"context_line":"        filter(models.Instance.compute_id \u003d\u003d None).  # noqa E711"},{"line_number":1354,"context_line":"        limit(count).all())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7582dd2f_d0c96ec8","line":1351,"range":{"start_line":1351,"start_character":42,"end_line":1351,"end_character":47},"in_reply_to":"a2fb23b5_6aef97db","updated":"2023-07-13 13:25:14.000000000","message":"Ack","commit_id":"25be0306d7b6caa2ea02714b7ca40bec1ac2f26f"}]}