)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e1f1fa0b89ad3e57a50c7d98a5bb7a85bf193b3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To limit this class of bugs, we add a check to ensure a compute"},{"line_number":14,"context_line":"node is only ever deleted when it is known to have been deleted"},{"line_number":15,"context_line":"in Ironic."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"There is a risk this might leave orphaned compute nodes and"},{"line_number":18,"context_line":"resource providers that need manual clean up because users"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ef258059_975f5280","line":15,"updated":"2023-08-31 17:37:34.000000000","message":"ack that is this check here \nhttps://review.opendev.org/c/openstack/nova/+/887151/5/nova/compute/manager.py#10578","commit_id":"772f5a1ae4fa9f9a584f42f774894d540b4b168f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e1f1fa0b89ad3e57a50c7d98a5bb7a85bf193b3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from nova management. But on balance, it seems safer to leave"},{"line_number":21,"context_line":"these cases up to the operator to resolve manually, and collect"},{"line_number":22,"context_line":"feedback on how to better help those users."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"blueprint ironic-shards"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I7cd9e5ab878cea05462cac24de581dca6d50b3c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6a7d8d07_f3303f5c","line":23,"updated":"2023-08-31 17:37:34.000000000","message":"yep you have called it out in a warning level log which is correct as it notes\nthere is somethign the operator probably need to do .","commit_id":"772f5a1ae4fa9f9a584f42f774894d540b4b168f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c1bb26aa5fac674f693c7f9ba5a66fb16387abec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df85d947_b751227e","updated":"2023-08-08 20:18:27.000000000","message":"Ironic CI is passing on this current patchset: https://review.opendev.org/c/openstack/ironic/+/888277/2#message-1313fccebe0052159ed30ab6fee0cdc80449f8ad\n\nStill need manual devstack testing.","commit_id":"7f455a5c045a7b5330ad8a89b467d8ab7bf590c5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dad2e55e33438e394de26a08efe243baf148a931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"619ac242_49d97913","updated":"2023-08-10 00:18:44.000000000","message":"LGTM, although it could likely use a release note since technically this fixes a bug on the interface boundary.","commit_id":"7f455a5c045a7b5330ad8a89b467d8ab7bf590c5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e1673e013a55d630b56158771a301a2acead2b70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dcb6db68_f930d083","updated":"2023-08-30 16:52:22.000000000","message":"LGTM, no point to make here, thanks for all the fish you gave.\n\nHope we\u0027ll find some other folk to be able to review your series.","commit_id":"7f455a5c045a7b5330ad8a89b467d8ab7bf590c5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"27bca8051e3975834513cdf23a3726a12294679f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0ccb2f0f_555423ea","updated":"2023-08-31 17:31:40.000000000","message":"In case this helps with priorities, this is very bug fix-ey in nature, we just agreed to add this in the spec as extra protection :)","commit_id":"772f5a1ae4fa9f9a584f42f774894d540b4b168f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b3bc9a7e490daa9ef9192897a2a642764fb06fef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"36f1ec53_4bcb7301","updated":"2023-09-02 04:35:22.000000000","message":"recheck nova-multi-cell it looked like the VM couldn\u0027t reach metadata service?","commit_id":"772f5a1ae4fa9f9a584f42f774894d540b4b168f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b9683f85be35fa9c317794b6a6c6648c45873939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b7a412dd_6466d82b","updated":"2023-09-01 22:40:41.000000000","message":"recheck unrelated timeout on parent change","commit_id":"772f5a1ae4fa9f9a584f42f774894d540b4b168f"}],"nova/compute/manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dad2e55e33438e394de26a08efe243baf148a931","unresolved":false,"context_lines":[{"line_number":10564,"context_line":"                        {\u0027id\u0027: cn.id, \u0027hh\u0027: cn.hypervisor_hostname,"},{"line_number":10565,"context_line":"                         \u0027nodes\u0027: nodenames})"},{"line_number":10566,"context_line":"                    continue"},{"line_number":10567,"context_line":""},{"line_number":10568,"context_line":"                LOG.info(\"Deleting orphan compute node %(id)s \""},{"line_number":10569,"context_line":"                         \"hypervisor host is %(hh)s, \""},{"line_number":10570,"context_line":"                         \"nodes are %(nodes)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"b45d3f66_5e1e1cb0","line":10567,"updated":"2023-08-10 00:18:44.000000000","message":"Thanks for this change. I think this will actually be a huge improvement on it\u0027s own!","commit_id":"7f455a5c045a7b5330ad8a89b467d8ab7bf590c5"}],"nova/tests/functional/regressions/test_bug_1839560.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e1f1fa0b89ad3e57a50c7d98a5bb7a85bf193b3","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        # for each node."},{"line_number":59,"context_line":"        self.flags(compute_driver\u003d\u0027fake.PredictableNodeUUIDDriver\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch.object(fake_driver.FakeDriver, \u0027is_node_deleted\u0027)"},{"line_number":62,"context_line":"    def test_update_available_resource_node_recreate(self, mock_delete):"},{"line_number":63,"context_line":"        # make the fake driver allow nodes to be delete, like ironic driver"},{"line_number":64,"context_line":"        mock_delete.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"a763b0e3_1f2dd289","line":61,"range":{"start_line":61,"start_character":3,"end_line":61,"end_character":65},"updated":"2023-08-31 17:37:34.000000000","message":"nit: just an fyi you can also do \n\n```\n@mock.patch.object(fake_driver.FakeDriver, \u0027is_node_deleted\u0027, return_value\u003dtrue)\n```\n\nand if this is not needed as a parmater in  the fucntion\n```\n@mock.patch.object(fake_driver.FakeDriver, \u0027is_node_deleted\u0027, return_value\u003dtrue, new\u003dmock.Mock())\n```\nwhen you use new like that you done need to pass mock_delete into the function as a parmater.\n\ni tend to use \"new\" now when im just mocking something out that does not need any asserts.","commit_id":"772f5a1ae4fa9f9a584f42f774894d540b4b168f"}]}