)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b1c34e45ca90fe21939f021e6685094170d68a49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"add6947c_bc8454aa","updated":"2023-06-29 11:04:25.000000000","message":"this should have an upgrades releasee note to capture the acual version bump otherwise this looks fine.","commit_id":"229aae00cc5d12c01d67fb2a541d84ac993ed20d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"82b8bcd3d904816ddd633d7ef5415c88939ea307","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f78beedc_9d575cf7","in_reply_to":"add6947c_bc8454aa","updated":"2023-07-10 12:07:21.000000000","message":"Good catch; will fix in next revision.","commit_id":"229aae00cc5d12c01d67fb2a541d84ac993ed20d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dceba80f280aa9351fd2c46c405fffd885ab8279","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e4c3970f_40b9d086","updated":"2023-07-18 09:25:44.000000000","message":"Looks good but you can do some cleanups in the test I noted inline.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e21e90c7be79df46212864c492c33271a564bcf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"217a0e39_e2df14e3","updated":"2023-07-19 13:03:08.000000000","message":"Recheck\n\n(Unrelated time-out in test_resize_volume_backed_server_confirm)","commit_id":"0543646456a5b2b0d6fd4107b2782c053cc50446"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"31f89b5834562a159bbe27b060e118e098a4f930","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"95dfbc71_74db5c19","updated":"2023-07-20 13:45:15.000000000","message":"recheck\n\n(A bug in Ubuntu Curl package, it was solved by a revert now; thanks Dan Smith)","commit_id":"0543646456a5b2b0d6fd4107b2782c053cc50446"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"3c5ebfbb7521ef235e1afdfbd9b4e1a3b4d9c6c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1608f9ec_8baa040e","updated":"2023-07-20 13:11:46.000000000","message":"recheck\n\n(Unrelated timeout)","commit_id":"0543646456a5b2b0d6fd4107b2782c053cc50446"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7bfee45a2546a15fd703484df3a91ea9efdcee11","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c020b0bf_a6b9f17d","updated":"2023-09-01 09:49:28.000000000","message":"Hi nova team.\n\nIt appears that the change of this patch causes the following error in job on ubuntu-focal (Full log [1]):\n```\nnova-compute[54440]: ERROR oslo_service.service [None req-92555976-5638-4f1c-846b-6e140ae989ce None None] Error starting thread.: nova.exception.InternalError: Nova requires libvirt version 7.0.0 or greater.\nnova-compute[54440]: ERROR oslo_service.service Traceback (most recent call last):\nnova-compute[54440]: ERROR oslo_service.service   File \"/usr/local/lib/python3.8/dist-packages/oslo_service/service.py\", line 806, in run_service\nnova-compute[54440]: ERROR oslo_service.service     service.start()\nnova-compute[54440]: ERROR oslo_service.service   File \"/opt/stack/nova/nova/service.py\", line 162, in start\nnova-compute[54440]: ERROR oslo_service.service     self.manager.init_host(self.service_ref)\nnova-compute[54440]: ERROR oslo_service.service   File \"/opt/stack/nova/nova/compute/manager.py\", line 1610, in init_host\nnova-compute[54440]: ERROR oslo_service.service     self.driver.init_host(host\u003dself.host)\nnova-compute[54440]: ERROR oslo_service.service   File \"/opt/stack/nova/nova/virt/libvirt/driver.py\", line 763, in init_host\nnova-compute[54440]: ERROR oslo_service.service     raise exception.InternalError(\nnova-compute[54440]: ERROR oslo_service.service nova.exception.InternalError: Nova requires libvirt version 7.0.0 or greater.\nnova-compute[54440]: ERROR oslo_service.service \n```\n\nWe are testing on ubuntu-focal according to the test runtime [2], but will nova not allow on ubuntu-focal?\nOr let me know if there is any way to avoid it by zuul setting.\n\n[1] https://66ec8c172c90300111e4-a625256a267168a6c870a25017c7113f.ssl.cf5.rackcdn.com/886935/11/check/tacker-functional-devstack-multinode-sol-v2-ubuntu-focal/5f5edc1/compute1/logs/screen-n-cpu.txt\n[2] https://governance.openstack.org/tc/reference/runtimes/2023.1.html#additional-testing-for-smooth-upgrade","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"1c25218a9b949ce17e65bc496e53dad0603e8e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c8ff672f_c3efad54","updated":"2023-07-31 10:27:52.000000000","message":"recheck\n\n(It\u0027s an unrelated issue in \u0027nova-lvm\u0027 job test_get_console_output_server_id_in_shutoff_status - https://bugs.launchpad.net/nova/+bug/2028851. It is being skipped temporarily skipped in Tempest: https://review.opendev.org/c/openstack/tempest/+/889895)","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ab5ae1ce2bd56bb495fa0ae1d83bfd10702f5cac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"de3b963e_591086af","updated":"2023-07-25 11:36:22.000000000","message":"recheck\n\n(Unrelated timeout from evacuate-bfv-test)","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"2f4f6637d10aff883d8ab00e2807eda25117c9cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1d125435_51615d55","updated":"2023-08-28 15:34:27.000000000","message":"recheck\n\n(wait_for_ssh() timeout from in \u0027test_attach_attached_volume_to_different_server\u0027.  Looks sporadic)","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0aa795f9b4412c649b808b5b2bad240e0017b52d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"14c592f9_6a67e79e","updated":"2023-08-03 16:34:25.000000000","message":"recheck crazy slow worker didn\u0027t even finish devstack in 2h","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8c09d4b2316af8a31a080cc3ffed076f8785b35e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f89745ea_9b608384","updated":"2023-08-02 14:23:45.000000000","message":"recheck tempest and devstack improvements since last run","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c938973b14b5deed0b547eecd63afe27c9011b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b0b1a657_c26222b7","updated":"2023-08-31 12:11:12.000000000","message":"recheck timed out again.\n\ni have proposed a bump in https://review.opendev.org/c/openstack/nova/+/893360 but this only times out on slow nodes today hence the bump.\n\nthis change is not actually changing the version of libvirt we are running and there are no tests failing its just timeing out running them so this is not related to this patch.","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d446141586d740fe6717967ce2759a349440b3b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ec4fa38_3d150bc3","updated":"2023-09-01 00:36:00.000000000","message":"recheck unrelated snapshot http timeout","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d6e889b8e07a27f305699b845cddd2b5f2d424d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0128dd0c_664b05d2","updated":"2023-08-31 02:27:23.000000000","message":"recheck unrelted failures in snapshot/volume tests","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"bdbba26a09ee67a2d50c1b503b51833d105622aa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"53c9d0d0_4e06dbcd","in_reply_to":"721a03c0_46a0aa86","updated":"2023-09-01 14:04:06.000000000","message":"Thanks for your reply, I did see 2023.1 by mistake.. I\u0027m sorry.\nWe will proceed to drop the focal job from our gate. Thank you.","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"07dea77036822173ffe19e1fcf54a146a23d7630","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"721a03c0_46a0aa86","in_reply_to":"c020b0bf_a6b9f17d","updated":"2023-09-01 13:41:30.000000000","message":"This is going into master, which will be 2023.2. None of the openstack projects are expected to run 2023.2 on focal, per this:\n\nhttps://governance.openstack.org/tc/reference/runtimes/2023.2.html\n\nThis is not new, 2023.1 didn\u0027t run on focal either:\n\nhttps://governance.openstack.org/tc/reference/runtimes/2023.1.html","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"}],"doc/source/reference/libvirt-distro-support-matrix.rst":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"24aef69bd10c1efddcc5aa8897a46ededb9f0ae4","unresolved":true,"context_lines":[{"line_number":175,"context_line":"      - 7.0.0"},{"line_number":176,"context_line":"      - 4.2.0"},{"line_number":177,"context_line":"      - 5.2.0"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"OS distribution versions"},{"line_number":180,"context_line":"------------------------"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"634cdffb_0cbf6936","line":178,"updated":"2023-09-25 09:16:11.000000000","message":"Is it possible to update this page also? Would be really good to see in one page all the related qemu/libvirt versions in one page","commit_id":"b6cf8e6128a87fce1d59acec3cae629d540f4ac2"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c17e24d28e1bf1dbe13954492263ee050597dd29","unresolved":true,"context_lines":[{"line_number":1394,"context_line":"    NUM_PFS \u003d 1"},{"line_number":1395,"context_line":"    NUM_VFS \u003d 4"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 6_009_000  # 6.9.0"},{"line_number":1398,"context_line":"    FAKE_QEMU_VERSION \u003d 5_001_000  # 5.1.0"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    def setUp(self):"},{"line_number":1401,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"f18e971c_9912af38","line":1398,"range":{"start_line":1397,"start_character":0,"end_line":1398,"end_character":42},"updated":"2023-07-12 09:41:55.000000000","message":"these are too old now","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ccc58ab5dd598bf7d22f1dd5ff6fe0a92048498f","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"    NUM_PFS \u003d 1"},{"line_number":1395,"context_line":"    NUM_VFS \u003d 4"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 6_009_000  # 6.9.0"},{"line_number":1398,"context_line":"    FAKE_QEMU_VERSION \u003d 5_001_000  # 5.1.0"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    def setUp(self):"},{"line_number":1401,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7e00bcf_c7659a6e","line":1398,"range":{"start_line":1397,"start_character":0,"end_line":1398,"end_character":42},"in_reply_to":"806dbbd4_b64a96c7","updated":"2023-07-18 07:13:42.000000000","message":"Done","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"58f24e09c476a2f02026ab03b3c4443451b67c47","unresolved":true,"context_lines":[{"line_number":1394,"context_line":"    NUM_PFS \u003d 1"},{"line_number":1395,"context_line":"    NUM_VFS \u003d 4"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 6_009_000  # 6.9.0"},{"line_number":1398,"context_line":"    FAKE_QEMU_VERSION \u003d 5_001_000  # 5.1.0"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    def setUp(self):"},{"line_number":1401,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"806dbbd4_b64a96c7","line":1398,"range":{"start_line":1397,"start_character":0,"end_line":1398,"end_character":42},"in_reply_to":"f18e971c_9912af38","updated":"2023-07-12 11:53:48.000000000","message":"Ah, missed these; will update in the next revision.","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dceba80f280aa9351fd2c46c405fffd885ab8279","unresolved":true,"context_lines":[{"line_number":1394,"context_line":"    NUM_PFS \u003d 1"},{"line_number":1395,"context_line":"    NUM_VFS \u003d 4"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 7_000_000  # 7.0.0"},{"line_number":1398,"context_line":"    FAKE_QEMU_VERSION \u003d 5_002_000  # 5.2.0"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    def setUp(self):"},{"line_number":1401,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3b48f8bd_aa5ffc82","line":1398,"range":{"start_line":1397,"start_character":0,"end_line":1398,"end_character":42},"updated":"2023-07-18 09:25:44.000000000","message":"you can drop this as it is the same as the minimum now.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"97cd9a293fe801040cd768b8f9a2d53d67458361","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"    NUM_PFS \u003d 1"},{"line_number":1395,"context_line":"    NUM_VFS \u003d 4"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 7_000_000  # 7.0.0"},{"line_number":1398,"context_line":"    FAKE_QEMU_VERSION \u003d 5_002_000  # 5.2.0"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    def setUp(self):"},{"line_number":1401,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"679ea291_64e73b3f","line":1398,"range":{"start_line":1397,"start_character":0,"end_line":1398,"end_character":42},"in_reply_to":"3b48f8bd_aa5ffc82","updated":"2023-07-18 13:19:48.000000000","message":"Ah, okay; removed in next iteration.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dceba80f280aa9351fd2c46c405fffd885ab8279","unresolved":true,"context_lines":[{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"        return super().start_compute(hostname\u003dhostname,"},{"line_number":1447,"context_line":"            pci_info\u003dpci_info, vdpa_info\u003dvdpa_info,"},{"line_number":1448,"context_line":"            libvirt_version\u003dself.FAKE_LIBVIRT_VERSION,"},{"line_number":1449,"context_line":"            qemu_version\u003dself.FAKE_QEMU_VERSION)"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"    def create_vdpa_port(self):"},{"line_number":1452,"context_line":"        vdpa_port \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"425447ed_619d4e39","line":1449,"range":{"start_line":1448,"start_character":12,"end_line":1449,"end_character":47},"updated":"2023-07-18 09:25:44.000000000","message":"you can drop this as the default is the minimum supported version and that is high enough for vdpa to work unconditionally.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"97cd9a293fe801040cd768b8f9a2d53d67458361","unresolved":false,"context_lines":[{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"        return super().start_compute(hostname\u003dhostname,"},{"line_number":1447,"context_line":"            pci_info\u003dpci_info, vdpa_info\u003dvdpa_info,"},{"line_number":1448,"context_line":"            libvirt_version\u003dself.FAKE_LIBVIRT_VERSION,"},{"line_number":1449,"context_line":"            qemu_version\u003dself.FAKE_QEMU_VERSION)"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"    def create_vdpa_port(self):"},{"line_number":1452,"context_line":"        vdpa_port \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"b236daa9_8e81bca2","line":1449,"range":{"start_line":1448,"start_character":12,"end_line":1449,"end_character":47},"in_reply_to":"425447ed_619d4e39","updated":"2023-07-18 13:19:48.000000000","message":"Nice catch; fixed in next version.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c6d51502ef28a1161190245b0294aa8551f25339","unresolved":true,"context_lines":[{"line_number":1394,"context_line":"    NUM_PFS \u003d 1"},{"line_number":1395,"context_line":"    NUM_VFS \u003d 4"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 6_009_000  # 6.9.0"},{"line_number":1398,"context_line":"    FAKE_QEMU_VERSION \u003d 5_001_000  # 5.1.0"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e92533a7_1c5a6d27","side":"PARENT","line":1397,"updated":"2023-07-24 11:50:46.000000000","message":"ack so this is removed since our new min version is 7.0.0","commit_id":"c13a8080ea7c3147801f066c533d095e0f8224ba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c6d51502ef28a1161190245b0294aa8551f25339","unresolved":true,"context_lines":[{"line_number":1395,"context_line":"    NUM_VFS \u003d 4"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 6_009_000  # 6.9.0"},{"line_number":1398,"context_line":"    FAKE_QEMU_VERSION \u003d 5_001_000  # 5.1.0"},{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":"    def setUp(self):"},{"line_number":1401,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7e29dfb5_54bf2064","side":"PARENT","line":1398,"updated":"2023-07-24 11:50:46.000000000","message":"and our new min qemu is 5.2.0","commit_id":"c13a8080ea7c3147801f066c533d095e0f8224ba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c6d51502ef28a1161190245b0294aa8551f25339","unresolved":true,"context_lines":[{"line_number":3660,"context_line":"    vf_ratio \u003d NUM_VFS // NUM_PFS"},{"line_number":3661,"context_line":""},{"line_number":3662,"context_line":"    # Min Libvirt version that supports working with PCI VPD."},{"line_number":3663,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 7_009_000  # 7.9.0"},{"line_number":3664,"context_line":"    FAKE_QEMU_VERSION \u003d 5_001_000  # 5.1.0"},{"line_number":3665,"context_line":""},{"line_number":3666,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"580b83af_493b1abc","side":"PARENT","line":3663,"updated":"2023-07-24 11:50:46.000000000","message":"and this is still kept because its above our min version","commit_id":"c13a8080ea7c3147801f066c533d095e0f8224ba"}],"nova/tests/functional/libvirt/test_vpmem.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c17e24d28e1bf1dbe13954492263ee050597dd29","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class VPMEMTestBase(integrated_helpers.LibvirtProviderUsageBaseTestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 5000000"},{"line_number":34,"context_line":"    FAKE_QEMU_VERSION \u003d 3001000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(VPMEMTestBase, self).setUp()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ee105588_9bdc67f6","line":35,"range":{"start_line":33,"start_character":4,"end_line":35,"end_character":0},"updated":"2023-07-12 09:41:55.000000000","message":"These are too old now","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ccc58ab5dd598bf7d22f1dd5ff6fe0a92048498f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class VPMEMTestBase(integrated_helpers.LibvirtProviderUsageBaseTestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 5000000"},{"line_number":34,"context_line":"    FAKE_QEMU_VERSION \u003d 3001000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(VPMEMTestBase, self).setUp()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a09732c6_e7a79039","line":35,"range":{"start_line":33,"start_character":4,"end_line":35,"end_character":0},"in_reply_to":"1df771f6_caf98637","updated":"2023-07-18 07:13:42.000000000","message":"Done","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"58f24e09c476a2f02026ab03b3c4443451b67c47","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class VPMEMTestBase(integrated_helpers.LibvirtProviderUsageBaseTestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 5000000"},{"line_number":34,"context_line":"    FAKE_QEMU_VERSION \u003d 3001000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(VPMEMTestBase, self).setUp()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1df771f6_caf98637","line":35,"range":{"start_line":33,"start_character":4,"end_line":35,"end_character":0},"in_reply_to":"ee105588_9bdc67f6","updated":"2023-07-12 11:53:48.000000000","message":"Yep, will update in the next revision.","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dceba80f280aa9351fd2c46c405fffd885ab8279","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class VPMEMTestBase(integrated_helpers.LibvirtProviderUsageBaseTestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 7000000"},{"line_number":34,"context_line":"    FAKE_QEMU_VERSION \u003d 5002000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(VPMEMTestBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"8c25fbf9_ad6dc748","line":34,"range":{"start_line":33,"start_character":1,"end_line":34,"end_character":31},"updated":"2023-07-18 09:25:44.000000000","message":"you can drop this as it is the same as the minimum now.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"97cd9a293fe801040cd768b8f9a2d53d67458361","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class VPMEMTestBase(integrated_helpers.LibvirtProviderUsageBaseTestCase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    FAKE_LIBVIRT_VERSION \u003d 7000000"},{"line_number":34,"context_line":"    FAKE_QEMU_VERSION \u003d 5002000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        super(VPMEMTestBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7c492f4_25914db6","line":34,"range":{"start_line":33,"start_character":1,"end_line":34,"end_character":31},"in_reply_to":"8c25fbf9_ad6dc748","updated":"2023-07-18 13:19:48.000000000","message":"Yep; dropped in next version.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dceba80f280aa9351fd2c46c405fffd885ab8279","unresolved":true,"context_lines":[{"line_number":88,"context_line":"    def _get_connection(self, host_info, hostname\u003dNone):"},{"line_number":89,"context_line":"        fake_connection \u003d fakelibvirt.Connection("},{"line_number":90,"context_line":"            \u0027qemu:///system\u0027,"},{"line_number":91,"context_line":"            version\u003dself.FAKE_LIBVIRT_VERSION,"},{"line_number":92,"context_line":"            hv_version\u003dself.FAKE_QEMU_VERSION,"},{"line_number":93,"context_line":"            host_info\u003dhost_info,"},{"line_number":94,"context_line":"            hostname\u003dhostname)"},{"line_number":95,"context_line":"        return fake_connection"}],"source_content_type":"text/x-python","patch_set":4,"id":"696b9737_c650e13d","line":92,"range":{"start_line":91,"start_character":12,"end_line":92,"end_character":46},"updated":"2023-07-18 09:25:44.000000000","message":"you can drop this as the default is the minimum supported version and that is high enough now.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"97cd9a293fe801040cd768b8f9a2d53d67458361","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def _get_connection(self, host_info, hostname\u003dNone):"},{"line_number":89,"context_line":"        fake_connection \u003d fakelibvirt.Connection("},{"line_number":90,"context_line":"            \u0027qemu:///system\u0027,"},{"line_number":91,"context_line":"            version\u003dself.FAKE_LIBVIRT_VERSION,"},{"line_number":92,"context_line":"            hv_version\u003dself.FAKE_QEMU_VERSION,"},{"line_number":93,"context_line":"            host_info\u003dhost_info,"},{"line_number":94,"context_line":"            hostname\u003dhostname)"},{"line_number":95,"context_line":"        return fake_connection"}],"source_content_type":"text/x-python","patch_set":4,"id":"4dd88d67_1857dea4","line":92,"range":{"start_line":91,"start_character":12,"end_line":92,"end_character":46},"in_reply_to":"696b9737_c650e13d","updated":"2023-07-18 13:19:48.000000000","message":"Removed in next version.","commit_id":"28155024c511657dce97dfe9cd5e697507bd0390"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"08c5bc44a660151bba573bd74adc99a8939add31","unresolved":true,"context_lines":[{"line_number":11672,"context_line":"                instance)"},{"line_number":11673,"context_line":"        self.assertIsNone(ret)"},{"line_number":11674,"context_line":""},{"line_number":11675,"context_line":"    @mock.patch.object(nova.virt.libvirt, \u0027config\u0027)"},{"line_number":11676,"context_line":"    def test_compare_cpu_aarch64_skip_comparison(self,"},{"line_number":11677,"context_line":"                                                 mock_vconfig):"},{"line_number":11678,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":11679,"context_line":"        self.mock_uname.return_value \u003d fakelibvirt.os_uname("},{"line_number":11680,"context_line":"            \u0027Linux\u0027, \u0027\u0027, \u00275.4.0-0-generic\u0027, \u0027\u0027, fields.Architecture.AARCH64)"},{"line_number":11681,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":11682,"context_line":"        ret \u003d conn._compare_cpu(None, jsonutils.dumps(_fake_cpu_info_aarch64),"},{"line_number":11683,"context_line":"                instance)"},{"line_number":11684,"context_line":"        self.assertIsNone(ret)"},{"line_number":11685,"context_line":""},{"line_number":11686,"context_line":"    @mock.patch.object(host.Host, \u0027get_capabilities\u0027)"},{"line_number":11687,"context_line":"    @mock.patch.object(host.Host, \u0027compare_hypervisor_cpu\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a87bf34d_2e23f915","line":11684,"range":{"start_line":11675,"start_character":1,"end_line":11684,"end_character":30},"updated":"2023-07-18 08:08:09.000000000","message":"This test case tests that if libvirt is too old then on aarch64 the compare_cpu is skipped. However this patch bumps the minimum libvirt version to new enough that skipping the comparision is never needed. So this test case can be removed as the corresponding logic is removed from the driver, https://review.opendev.org/c/openstack/nova/+/887255/3/nova/virt/libvirt/driver.py#b9978","commit_id":"77bec1248a2dab124e2a668aad9bdc43ed31f240"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"f130f8e9bc3259ac91ade83b75161692eb27a0e6","unresolved":true,"context_lines":[{"line_number":11672,"context_line":"                instance)"},{"line_number":11673,"context_line":"        self.assertIsNone(ret)"},{"line_number":11674,"context_line":""},{"line_number":11675,"context_line":"    @mock.patch.object(nova.virt.libvirt, \u0027config\u0027)"},{"line_number":11676,"context_line":"    def test_compare_cpu_aarch64_skip_comparison(self,"},{"line_number":11677,"context_line":"                                                 mock_vconfig):"},{"line_number":11678,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":11679,"context_line":"        self.mock_uname.return_value \u003d fakelibvirt.os_uname("},{"line_number":11680,"context_line":"            \u0027Linux\u0027, \u0027\u0027, \u00275.4.0-0-generic\u0027, \u0027\u0027, fields.Architecture.AARCH64)"},{"line_number":11681,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":11682,"context_line":"        ret \u003d conn._compare_cpu(None, jsonutils.dumps(_fake_cpu_info_aarch64),"},{"line_number":11683,"context_line":"                instance)"},{"line_number":11684,"context_line":"        self.assertIsNone(ret)"},{"line_number":11685,"context_line":""},{"line_number":11686,"context_line":"    @mock.patch.object(host.Host, \u0027get_capabilities\u0027)"},{"line_number":11687,"context_line":"    @mock.patch.object(host.Host, \u0027compare_hypervisor_cpu\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f532f4b8_07249764","line":11684,"range":{"start_line":11675,"start_character":1,"end_line":11684,"end_character":30},"in_reply_to":"a87bf34d_2e23f915","updated":"2023-07-18 08:26:13.000000000","message":"Yeah, that makes sense.  After staring a bit more at the code I did come to that conclusion yesterday :) Fixing in next revision.\n\nThanks for the review!","commit_id":"77bec1248a2dab124e2a668aad9bdc43ed31f240"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"6488e7cfc4a264a526d76feb200c8b718be215d7","unresolved":false,"context_lines":[{"line_number":11672,"context_line":"                instance)"},{"line_number":11673,"context_line":"        self.assertIsNone(ret)"},{"line_number":11674,"context_line":""},{"line_number":11675,"context_line":"    @mock.patch.object(nova.virt.libvirt, \u0027config\u0027)"},{"line_number":11676,"context_line":"    def test_compare_cpu_aarch64_skip_comparison(self,"},{"line_number":11677,"context_line":"                                                 mock_vconfig):"},{"line_number":11678,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":11679,"context_line":"        self.mock_uname.return_value \u003d fakelibvirt.os_uname("},{"line_number":11680,"context_line":"            \u0027Linux\u0027, \u0027\u0027, \u00275.4.0-0-generic\u0027, \u0027\u0027, fields.Architecture.AARCH64)"},{"line_number":11681,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":11682,"context_line":"        ret \u003d conn._compare_cpu(None, jsonutils.dumps(_fake_cpu_info_aarch64),"},{"line_number":11683,"context_line":"                instance)"},{"line_number":11684,"context_line":"        self.assertIsNone(ret)"},{"line_number":11685,"context_line":""},{"line_number":11686,"context_line":"    @mock.patch.object(host.Host, \u0027get_capabilities\u0027)"},{"line_number":11687,"context_line":"    @mock.patch.object(host.Host, \u0027compare_hypervisor_cpu\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2cdb01c_a50cbb83","line":11684,"range":{"start_line":11675,"start_character":1,"end_line":11684,"end_character":30},"in_reply_to":"f532f4b8_07249764","updated":"2023-07-18 09:04:53.000000000","message":"Done","commit_id":"77bec1248a2dab124e2a668aad9bdc43ed31f240"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b1c34e45ca90fe21939f021e6685094170d68a49","unresolved":true,"context_lines":[{"line_number":8166,"context_line":"            libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV"},{"line_number":8167,"context_line":"        )"},{"line_number":8168,"context_line":""},{"line_number":8169,"context_line":"        dev_flags |\u003d libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA"},{"line_number":8170,"context_line":""},{"line_number":8171,"context_line":"        devices \u003d {"},{"line_number":8172,"context_line":"            dev.name(): dev for dev in"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8643f34_b0366e7f","line":8169,"range":{"start_line":8169,"start_character":7,"end_line":8169,"end_character":67},"updated":"2023-06-29 11:04:25.000000000","message":"nit this can not just go directly on line 8167\n\n        dev_flags \u003d (\n            libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_NET |\n            libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV |\n            libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA\n        )\n\nor we coudl do\n\n        dev_flags \u003d libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_NET \n        dev_flags |\u003d libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV\n        dev_flags |\u003d libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA\nto be consitant","commit_id":"229aae00cc5d12c01d67fb2a541d84ac993ed20d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"24e2e1a25a830e0340e0dc535e8027a392c3a8e5","unresolved":true,"context_lines":[{"line_number":8166,"context_line":"            libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV"},{"line_number":8167,"context_line":"        )"},{"line_number":8168,"context_line":""},{"line_number":8169,"context_line":"        dev_flags |\u003d libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA"},{"line_number":8170,"context_line":""},{"line_number":8171,"context_line":"        devices \u003d {"},{"line_number":8172,"context_line":"            dev.name(): dev for dev in"}],"source_content_type":"text/x-python","patch_set":1,"id":"b136e197_ed3b055b","line":8169,"range":{"start_line":8169,"start_character":7,"end_line":8169,"end_character":67},"in_reply_to":"5779aff3_c7bfe962","updated":"2023-07-10 12:33:43.000000000","message":"Actually, you\u0027re right.  We could just add it indeed as part of dev_flags.  Will fix in next rev.","commit_id":"229aae00cc5d12c01d67fb2a541d84ac993ed20d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"82b8bcd3d904816ddd633d7ef5415c88939ea307","unresolved":true,"context_lines":[{"line_number":8166,"context_line":"            libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV"},{"line_number":8167,"context_line":"        )"},{"line_number":8168,"context_line":""},{"line_number":8169,"context_line":"        dev_flags |\u003d libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA"},{"line_number":8170,"context_line":""},{"line_number":8171,"context_line":"        devices \u003d {"},{"line_number":8172,"context_line":"            dev.name(): dev for dev in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5779aff3_c7bfe962","line":8169,"range":{"start_line":8169,"start_character":7,"end_line":8169,"end_character":67},"in_reply_to":"a8643f34_b0366e7f","updated":"2023-07-10 12:07:21.000000000","message":"Yeah. That can be done in a separate change, right?  I\u0027d prefer to keep the bump-related changes apart from other improvements.","commit_id":"229aae00cc5d12c01d67fb2a541d84ac993ed20d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"14536658994fe09d641d5f4e0fc20ca1b76fa42e","unresolved":false,"context_lines":[{"line_number":8166,"context_line":"            libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV"},{"line_number":8167,"context_line":"        )"},{"line_number":8168,"context_line":""},{"line_number":8169,"context_line":"        dev_flags |\u003d libvirt.VIR_CONNECT_LIST_NODE_DEVICES_CAP_VDPA"},{"line_number":8170,"context_line":""},{"line_number":8171,"context_line":"        devices \u003d {"},{"line_number":8172,"context_line":"            dev.name(): dev for dev in"}],"source_content_type":"text/x-python","patch_set":1,"id":"edf34763_3bc3c551","line":8169,"range":{"start_line":8169,"start_character":7,"end_line":8169,"end_character":67},"in_reply_to":"b136e197_ed3b055b","updated":"2023-07-12 08:59:25.000000000","message":"Done","commit_id":"229aae00cc5d12c01d67fb2a541d84ac993ed20d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c17e24d28e1bf1dbe13954492263ee050597dd29","unresolved":true,"context_lines":[{"line_number":224,"context_line":"# vIOMMU model value `virtio` minimal support version"},{"line_number":225,"context_line":"MIN_LIBVIRT_VIOMMU_VIRTIO_MODEL \u003d (8, 3, 0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"MIN_LIBVIRT_AARCH64_CPU_COMPARE \u003d (6, 9, 0)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# Virtuozzo driver support"},{"line_number":230,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"28945e6a_75ed42dd","line":227,"updated":"2023-07-12 09:41:55.000000000","message":"MIN_LIBVIRT_VERSION is now higher than MIN_LIBVIRT_AARCH64_CPU_COMPARE so this can be dropped.","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"58f24e09c476a2f02026ab03b3c4443451b67c47","unresolved":true,"context_lines":[{"line_number":224,"context_line":"# vIOMMU model value `virtio` minimal support version"},{"line_number":225,"context_line":"MIN_LIBVIRT_VIOMMU_VIRTIO_MODEL \u003d (8, 3, 0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"MIN_LIBVIRT_AARCH64_CPU_COMPARE \u003d (6, 9, 0)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# Virtuozzo driver support"},{"line_number":230,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6bf54aca_deec1df5","line":227,"in_reply_to":"28945e6a_75ed42dd","updated":"2023-07-12 11:53:48.000000000","message":"Oops, forgot to drop it despite mentioning in the commit message.  Will fix in next revision.","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ccc58ab5dd598bf7d22f1dd5ff6fe0a92048498f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"# vIOMMU model value `virtio` minimal support version"},{"line_number":225,"context_line":"MIN_LIBVIRT_VIOMMU_VIRTIO_MODEL \u003d (8, 3, 0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"MIN_LIBVIRT_AARCH64_CPU_COMPARE \u003d (6, 9, 0)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"# Virtuozzo driver support"},{"line_number":230,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1e1009c8_645c896d","line":227,"in_reply_to":"6bf54aca_deec1df5","updated":"2023-07-18 07:13:42.000000000","message":"Done","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c17e24d28e1bf1dbe13954492263ee050597dd29","unresolved":true,"context_lines":[{"line_number":9969,"context_line":"                      \"CPUs are compared to check if they\u0027re compatible\""},{"line_number":9970,"context_line":"                      \"(the only use-case supported by libvirt for \""},{"line_number":9971,"context_line":"                      \"Arm64/AArch64)\")"},{"line_number":9972,"context_line":"            cpu \u003d host_cpu"},{"line_number":9973,"context_line":"            return"},{"line_number":9974,"context_line":""},{"line_number":9975,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""}],"source_content_type":"text/x-python","patch_set":2,"id":"75f1ae40_aeffbf47","line":9972,"updated":"2023-07-12 09:41:55.000000000","message":"This seems correct. We have new enough libvirt so we can always trigger the CPU comparision.","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dceba80f280aa9351fd2c46c405fffd885ab8279","unresolved":false,"context_lines":[{"line_number":9969,"context_line":"                      \"CPUs are compared to check if they\u0027re compatible\""},{"line_number":9970,"context_line":"                      \"(the only use-case supported by libvirt for \""},{"line_number":9971,"context_line":"                      \"Arm64/AArch64)\")"},{"line_number":9972,"context_line":"            cpu \u003d host_cpu"},{"line_number":9973,"context_line":"            return"},{"line_number":9974,"context_line":""},{"line_number":9975,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f6371ee_7df91838","line":9972,"in_reply_to":"75f1ae40_aeffbf47","updated":"2023-07-18 09:25:44.000000000","message":"Done","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b90375f1d1919ca09da265ae978797e8d3a08fde","unresolved":true,"context_lines":[{"line_number":9970,"context_line":"                      \"(the only use-case supported by libvirt for \""},{"line_number":9971,"context_line":"                      \"Arm64/AArch64)\")"},{"line_number":9972,"context_line":"            cpu \u003d host_cpu"},{"line_number":9973,"context_line":"            return"},{"line_number":9974,"context_line":""},{"line_number":9975,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""},{"line_number":9976,"context_line":"             \"virCPUCompareResult\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"8057b0f7_93b49369","line":9973,"updated":"2023-07-12 10:44:52.000000000","message":"But this return is wrong we only returned when the comparision was disabled due to to old libvirt version","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"58f24e09c476a2f02026ab03b3c4443451b67c47","unresolved":true,"context_lines":[{"line_number":9970,"context_line":"                      \"(the only use-case supported by libvirt for \""},{"line_number":9971,"context_line":"                      \"Arm64/AArch64)\")"},{"line_number":9972,"context_line":"            cpu \u003d host_cpu"},{"line_number":9973,"context_line":"            return"},{"line_number":9974,"context_line":""},{"line_number":9975,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""},{"line_number":9976,"context_line":"             \"virCPUCompareResult\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"d57a950d_51026558","line":9973,"in_reply_to":"8057b0f7_93b49369","updated":"2023-07-12 11:53:48.000000000","message":"Yes that makes sense; I\u0027m gonna remove that return in the next iteration.","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ccc58ab5dd598bf7d22f1dd5ff6fe0a92048498f","unresolved":false,"context_lines":[{"line_number":9970,"context_line":"                      \"(the only use-case supported by libvirt for \""},{"line_number":9971,"context_line":"                      \"Arm64/AArch64)\")"},{"line_number":9972,"context_line":"            cpu \u003d host_cpu"},{"line_number":9973,"context_line":"            return"},{"line_number":9974,"context_line":""},{"line_number":9975,"context_line":"        u \u003d (\"http://libvirt.org/html/libvirt-libvirt-host.html#\""},{"line_number":9976,"context_line":"             \"virCPUCompareResult\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1e8ed5fc_325fa349","line":9973,"in_reply_to":"d57a950d_51026558","updated":"2023-07-18 07:13:42.000000000","message":"Done","commit_id":"30d34acde9d30e9104d6e0c83aeee46dea3cb3fc"}]}