)]}'
{"nova/api/openstack/compute/contrib/evacuate.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f15f128e9d50a02b74a5e7a030a67066a2ef9821","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        elif not on_shared_storage:"},{"line_number":74,"context_line":"            password \u003d utils.generate_password()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if host:"},{"line_number":77,"context_line":"            try:"},{"line_number":78,"context_line":"                self.host_api.service_get_by_compute_host(context, host)"},{"line_number":79,"context_line":"            except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ae8d1ca_7826e5cf","line":76,"updated":"2014-05-29 09:15:18.000000000","message":"better to change here to\n\n if host is not None:\n\nfor checking \"\" of host.","commit_id":"ab616b0c78092902b6d87f1cd1c400be33e7b2bb"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"2cf056c23a26051679e1e3f1e899c25aa49014c4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        elif not on_shared_storage:"},{"line_number":74,"context_line":"            password \u003d utils.generate_password()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if host:"},{"line_number":77,"context_line":"            try:"},{"line_number":78,"context_line":"                self.host_api.service_get_by_compute_host(context, host)"},{"line_number":79,"context_line":"            except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ae8d1ca_3f5d1cea","line":76,"in_reply_to":"3ae8d1ca_7826e5cf","updated":"2014-05-29 13:21:52.000000000","message":"Done","commit_id":"ab616b0c78092902b6d87f1cd1c400be33e7b2bb"}],"nova/api/openstack/compute/contrib/extended_evacuate_find_host.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"7a4bb4415ef0b33a5775319e272b0c3088b8eb89","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Extended_evacuate_find_host(extensions.ExtensionDescriptor):"},{"line_number":19,"context_line":"    \"\"\"Enables server evacuation without target host. Scheduler will select"},{"line_number":20,"context_line":"       one to target."},{"line_number":21,"context_line":"    \"\"\""},{"line_number":22,"context_line":"    name \u003d \"ExtendedEvacuateFindHost\""},{"line_number":23,"context_line":"    alias \u003d \"os-extended-evacuate-find-host\""}],"source_content_type":"text/x-python","patch_set":22,"id":"baada198_90517638","line":20,"updated":"2014-07-04 15:44:16.000000000","message":"nit: Ideally this would be just one line.","commit_id":"7d9ce0cd277c42dfb536acb9c031ecef95ba4ad8"}],"nova/tests/api/openstack/compute/contrib/test_extended_evacuate_find_host.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f15f128e9d50a02b74a5e7a030a67066a2ef9821","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def fake_compute_api(*args, **kwargs):"},{"line_number":28,"context_line":"    return True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def fake_compute_api_get(self, context, instance_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ae8d1ca_d88ff9ca","line":28,"updated":"2014-05-29 09:15:18.000000000","message":"This method is used in ExtendedEvacuateFindHostTest, so how about moving it into the class? That would make its scope clear.","commit_id":"ab616b0c78092902b6d87f1cd1c400be33e7b2bb"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"2cf056c23a26051679e1e3f1e899c25aa49014c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def fake_compute_api(*args, **kwargs):"},{"line_number":28,"context_line":"    return True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def fake_compute_api_get(self, context, instance_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ae8d1ca_0d975ded","line":28,"in_reply_to":"3ae8d1ca_d88ff9ca","updated":"2014-05-29 13:21:52.000000000","message":"Done","commit_id":"ab616b0c78092902b6d87f1cd1c400be33e7b2bb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f15f128e9d50a02b74a5e7a030a67066a2ef9821","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    return {\u0027id\u0027: 1,"},{"line_number":33,"context_line":"            \u0027uuid\u0027: instance_id,"},{"line_number":34,"context_line":"            \u0027vm_state\u0027: vm_states.ACTIVE,"},{"line_number":35,"context_line":"            \u0027task_state\u0027: None, \u0027host\u0027: \u0027host1\u0027}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def fake_service_get_by_compute_host(self, context, host):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ae8d1ca_18c161e4","line":35,"updated":"2014-05-29 09:15:18.000000000","message":"ditto","commit_id":"ab616b0c78092902b6d87f1cd1c400be33e7b2bb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f15f128e9d50a02b74a5e7a030a67066a2ef9821","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    return {\u0027host_name\u0027: host,"},{"line_number":40,"context_line":"            \u0027service\u0027: \u0027compute\u0027,"},{"line_number":41,"context_line":"            \u0027zone\u0027: \u0027nova\u0027"},{"line_number":42,"context_line":"            }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ExtendedEvacuateFindHostTest(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ae8d1ca_b8ab0d1c","line":42,"updated":"2014-05-29 09:15:18.000000000","message":"ditto","commit_id":"ab616b0c78092902b6d87f1cd1c400be33e7b2bb"},{"author":{"_account_id":9275,"name":"Leandro Ignacio Costantino","email":"leandro.i.costantino@intel.com","username":"lcostantino"},"change_message_id":"2cf056c23a26051679e1e3f1e899c25aa49014c4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    return {\u0027host_name\u0027: host,"},{"line_number":40,"context_line":"            \u0027service\u0027: \u0027compute\u0027,"},{"line_number":41,"context_line":"            \u0027zone\u0027: \u0027nova\u0027"},{"line_number":42,"context_line":"            }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ExtendedEvacuateFindHostTest(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ae8d1ca_4da16546","line":42,"in_reply_to":"3ae8d1ca_b8ab0d1c","updated":"2014-05-29 13:21:52.000000000","message":"Done","commit_id":"ab616b0c78092902b6d87f1cd1c400be33e7b2bb"}]}