)]}'
{"id":"openstack%2Fnova~887985","triplet_id":"openstack%2Fnova~stable%2Fxena~I2209bf1b3320901cf603ec39163cf923b25b0359","project":"openstack/nova","branch":"stable/xena","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 19:12:49.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I2209bf1b3320901cf603ec39163cf923b25b0359","subject":"database: Archive parent and child rows \"trees\" one at a time","status":"ABANDONED","created":"2023-07-07 18:34:50.000000000","updated":"2024-03-05 19:12:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7ae0aec95be47e92d7a5e72af98e5b1713951147","_number":887985,"virtual_id_number":887985,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-07-07 20:12:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-07 18:50:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-07-07 20:12:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-05 19:12:49.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"abf5df452aff7d7824996f0060791e0c8f178671","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-07 18:34:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a91e1949631cedbeac384427be3c9907915e4c51","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-07 18:50:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/782a65d6005c42798c0da71fe3cb1adb\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/bda1837f8a7e406a9d00cd7b5741fb3a : SUCCESS in 8m 48s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/3fd396d9483441fb9f7c70c9c3f441fd : SUCCESS in 13m 14s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"10c7c254db29c2daa895b7b5e60e8990a48e196e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-07 20:12:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1a6db7929e304f21a3b56f8e5f4084ff\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/74c8b20f743b49d5914f4a891eeaf709 : SUCCESS in 59m 14s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/086a10291a054526abfbb8f3a7c69ed9 : FAILURE in 26m 32s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/5c7be61a64634f2982668d0946a2775a : SUCCESS in 50m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/911fb2f6d4e84ce3bb2c2e2f6f8e6854 : SUCCESS in 15m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f7f27229425c4c36b664dfa1cdcc7826 : SUCCESS in 7m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/28eea2ec0e4d4d6ebde53e4ce7893fa1 : SUCCESS in 10m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d345b0d113074a48af759dc082888a91 : SUCCESS in 8m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8a0e38c426d24685b179fc6eefc8caff : SUCCESS in 10m 18s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e9e7884916d14c8f8aa6eb04a29b64e4 : SUCCESS in 9m 41s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ebb4fc5cda8d4b69af3d75b927af6dc7 : SUCCESS in 25m 04s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/8ec9639bf0e54c1e8c0b66283dd39bde : SUCCESS in 59m 52s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c10a91dce8b348628824f4cfb8dff9f5 : SUCCESS in 1h 09m 27s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7c3d0892071940c193a86106425aa7d7 : SUCCESS in 39m 34s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/68c7b8ef768645bd861d262352b5faf6 : SUCCESS in 40m 17s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/cc8c6df5396a4c1881ffa1cc33cbb965 : SUCCESS in 1h 19m 33s\n- nova-next https://zuul.opendev.org/t/openstack/build/b36dbc667bf14bc29b42c1ad5116c0b2 : SUCCESS in 1h 29m 40s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/09827202e14c4424a2349d43216d184c : SUCCESS in 44m 14s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/d29b95c924774bbdba61c0e3dc09ee9c : FAILURE in 5m 37s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/42e96db14d1e40c4a36dbaf34a896d28 : SUCCESS in 23m 47s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f1a3b0f624454aafa8f85760b95e44d7 : SUCCESS in 18m 01s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/5a9be67536f24703b7c2bff01247add0 : SUCCESS in 22m 31s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/40ab6dba058f499eb7ebf7000eb06011 : SUCCESS in 53m 34s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5111ed5b66ea4db7a8689ed505c0964c : SUCCESS in 51m 33s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/b41be99e6102448faf936ac939cbce69 : SUCCESS in 34m 43s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/4becf3139b764e0aa496685bcbe47474 : FAILURE in 43m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7ae0aec95be47e92d7a5e72af98e5b1713951147","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 19:12:49.000000000","message":"Abandoned\n\nstable/xena branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/xena if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4dc6ec9dccba2695536cb3cbd5534e64003904c9","revisions":{"4dc6ec9dccba2695536cb3cbd5534e64003904c9":{"kind":"REWORK","_number":1,"created":"2023-07-07 18:34:50.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/85/887985/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/85/887985/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/887985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/887985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/85/887985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/85/887985/1"}}},"commit":{"parents":[{"commit":"600dba5571e830c1e274e391fe86d498efcd7e53","subject":"testing: Fix and robustify archive_deleted_rows test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/600dba5571e830c1e274e391fe86d498efcd7e53"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-02-22 23:58:33.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-07 18:32:45.000000000","tz":0},"subject":"database: Archive parent and child rows \"trees\" one at a time","message":"database: Archive parent and child rows \"trees\" one at a time\n\nPreviously, we archived deleted rows in batches of max_rows parents +\ntheir child rows in a single database transaction. Doing it that way\nlimited how high a value of max_rows could be specified by the caller\nbecause of the size of the database transaction it could generate.\n\nFor example, in a large scale deployment with hundreds of thousands of\ndeleted rows and constant server creation and deletion activity, a\nvalue of max_rows\u003d1000 might exceed the database\u0027s configured maximum\npacket size or timeout due to a database deadlock, forcing the operator\nto use a much lower max_rows value like 100 or 50.\n\nAnd when the operator has e.g. 500,000 deleted instances rows (and\nmillions of deleted rows total) they are trying to archive, being\nforced to use a max_rows value several orders of magnitude lower than\nthe number of rows they need to archive was a poor user experience.\n\nThis changes the logic to archive one parent row and its foreign key\nrelated child rows one at a time in a single database transaction\nwhile limiting the total number of rows per table as soon as it reaches\n\u003e\u003d max_rows. Doing this will allow operators to choose more predictable\nvalues for max_rows and get more progress per invocation of\narchive_deleted_rows.\n\nConflicts:\n    nova/db/main/api.py\n\nNOTE(melwitt): The conflicts are because the following changes are not\nin Xena:\n\n  * I36e43e30e07f4904c7b49925cefe804af45cff6c (db: Replace use of\n    legacy select() calling style)\n\n  * Ib5fcb841294b4e20fe085e8603d4132e97be7db9 (db: Replace\n    \u0027insert.inline\u0027 parameter with \u0027Insert.inline()\u0027 method)\n\nCloses-Bug: #2024258\n\nChange-Id: I2209bf1b3320901cf603ec39163cf923b25b0359\n(cherry picked from commit 697fa3c000696da559e52b664c04cbd8d261c037)\n(cherry picked from commit 75e4c86d90ae0229069fc2eb06bfb41436be7319)\n(cherry picked from commit 6972efdaa94d05952eb5b90e456b566c4c73360c)\n(cherry picked from commit b555279add583e6b0cee1bddb8d5642c68ad84a6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4dc6ec9dccba2695536cb3cbd5534e64003904c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4dc6ec9dccba2695536cb3cbd5534e64003904c9"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
