)]}'
{"id":"openstack%2Fnova~887998","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I2209bf1b3320901cf603ec39163cf923b25b0359","project":"openstack/nova","branch":"stable/victoria","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 18:56:27.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I2209bf1b3320901cf603ec39163cf923b25b0359","subject":"database: Archive parent and child rows \"trees\" one at a time","status":"ABANDONED","created":"2023-07-07 21:16:53.000000000","updated":"2024-03-05 18:56:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"86b66c51e0bb9803ba982c99b5596112580f1292","_number":887998,"virtual_id_number":887998,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-07-07 22:53:58.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-07 22:53:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-05 18:56:27.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"ff0a29e954150a3863f36a512f13852610f9e57e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-07 21:16:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"78c7e7967ed94df3e42b075f409536d3687a97e7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-07 22:53:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/bf9bbc0a7bcc4fb79266259123279b80\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/7ba799e81d494af8868414248bded6a8 : SUCCESS in 57m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5a2ab878d6c84014b9f01b4b8b2c1e72 : SUCCESS in 13m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9447d186cfa848b993d3442fc6877620 : SUCCESS in 6m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/026a0c36b491447cba4da51c1cd0c8af : SUCCESS in 10m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f943a250ef994c00a37d61548906147f : SUCCESS in 9m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77918156a6c44b4bacbd2a7dfc57beeb : SUCCESS in 9m 31s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/effc2da2c1034da39c7f0c92b0bd2b20 : SUCCESS in 26m 37s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/99cc180fcf174baea285ee176b8e6280 : SUCCESS in 1h 02m 01s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/29ca51d05f794a9b92736e59ea2d250d : SUCCESS in 1h 31m 14s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/16ba1062b66b443b9a91e6bbe747de91 : SUCCESS in 40m 00s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/0f8645bfadd541718e48432812fd5a79 : SUCCESS in 1h 05m 50s\n- nova-next https://zuul.opendev.org/t/openstack/build/2c3a294adc9e464f8f75649a8b75130b : SUCCESS in 1h 16m 03s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/eafa21bd7b1a4fd2a02f962357e8c660 : FAILURE in 5m 42s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/58c4a90dac244b4bb0cd2e6c17abb6df : SUCCESS in 21m 00s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a480167da63d4b1783b3295cd012cfbc : FAILURE in 1h 17m 26s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7817089547d14c04b0314d6ebf1a64f6 : SUCCESS in 1h 02m 56s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/37e6b89aad914976873860e06a4ccc4b : FAILURE in 25m 54s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/238fc5d0598947069ef901828c0e956b : FAILURE in 33m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"86b66c51e0bb9803ba982c99b5596112580f1292","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 18:56:27.000000000","message":"Abandoned\n\nstable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"125009b215f8d8ca0d28a3bbf06c9ade6e5840ab","revisions":{"125009b215f8d8ca0d28a3bbf06c9ade6e5840ab":{"kind":"REWORK","_number":1,"created":"2023-07-07 21:16:53.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/98/887998/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/98/887998/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/887998/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/887998/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/887998/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/98/887998/1"}}},"commit":{"parents":[{"commit":"afdf01aa1f95ab430f62661680b7b492f5f78ff8","subject":"testing: Fix and robustify archive_deleted_rows test","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/afdf01aa1f95ab430f62661680b7b492f5f78ff8"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-02-22 23:58:33.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-07 21:15:39.000000000","tz":0},"subject":"database: Archive parent and child rows \"trees\" one at a time","message":"database: Archive parent and child rows \"trees\" one at a time\n\nPreviously, we archived deleted rows in batches of max_rows parents +\ntheir child rows in a single database transaction. Doing it that way\nlimited how high a value of max_rows could be specified by the caller\nbecause of the size of the database transaction it could generate.\n\nFor example, in a large scale deployment with hundreds of thousands of\ndeleted rows and constant server creation and deletion activity, a\nvalue of max_rows\u003d1000 might exceed the database\u0027s configured maximum\npacket size or timeout due to a database deadlock, forcing the operator\nto use a much lower max_rows value like 100 or 50.\n\nAnd when the operator has e.g. 500,000 deleted instances rows (and\nmillions of deleted rows total) they are trying to archive, being\nforced to use a max_rows value several orders of magnitude lower than\nthe number of rows they need to archive was a poor user experience.\n\nThis changes the logic to archive one parent row and its foreign key\nrelated child rows one at a time in a single database transaction\nwhile limiting the total number of rows per table as soon as it reaches\n\u003e\u003d max_rows. Doing this will allow operators to choose more predictable\nvalues for max_rows and get more progress per invocation of\narchive_deleted_rows.\n\nConflicts:\n    nova/db/sqlalchemy/api.py\n\nNOTE(melwitt): The conflict is because change\nI23bb9e539d08f5c6202909054c2dd49b6c7a7a0e (Remove six.text_type (1/2))\nis not in Victoria.\n\nCloses-Bug: #2024258\n\nChange-Id: I2209bf1b3320901cf603ec39163cf923b25b0359\n(cherry picked from commit 697fa3c000696da559e52b664c04cbd8d261c037)\n(cherry picked from commit 75e4c86d90ae0229069fc2eb06bfb41436be7319)\n(cherry picked from commit 6972efdaa94d05952eb5b90e456b566c4c73360c)\n(cherry picked from commit b555279add583e6b0cee1bddb8d5642c68ad84a6)\n(cherry picked from commit 4dc6ec9dccba2695536cb3cbd5534e64003904c9)\n(cherry picked from commit 2d073fdd935d3df6511c16b0203dcc7933e68a89)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/125009b215f8d8ca0d28a3bbf06c9ade6e5840ab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/125009b215f8d8ca0d28a3bbf06c9ade6e5840ab"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}