)]}'
{"id":"openstack%2Fnova~888096","triplet_id":"openstack%2Fnova~stable%2Fyoga~I4ab97626c10052c7af9934a80ff8db9ddab82738","project":"openstack/nova","branch":"stable/yoga","topic":"bug/2003991","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-02-06 15:04:07.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4ab97626c10052c7af9934a80ff8db9ddab82738","subject":"Enforce quota usage from placement when unshelving","status":"ABANDONED","created":"2023-07-11 00:38:06.000000000","updated":"2024-02-06 15:04:07.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6ce6d177a8b7f3bf91f1efd77d9e64b0444d750c","_number":888096,"virtual_id_number":888096,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-07-11 02:37:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-11 00:53:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-07-11 02:37:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-06 15:04:07.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"652e8a95d070a35381f796954820dd8d4b16af49","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-11 00:38:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a2ab3938c28aad7e3e69fcc4a1a8f4aa2ae1083","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-11 00:53:57.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8895ce16e0694a92b5423a9f1a725625\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/cbaa575bf06846309988016e648b9869 : SUCCESS in 11m 08s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/3f3970cc222b4b7cac6d51b3164eb7d0 : SUCCESS in 11m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"04ce9249a5304b4cf3ed67052f261d257d0ff45c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-11 02:37:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/22c415186d4b4abebacf9803b1da9ec4\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/bc2b1c71b19147d89638ca14dc6807bb : SUCCESS in 1h 16m 25s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/23a6c5b01c654bbeba6d1369246c5888 : FAILURE in 25m 49s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/77979e77c5a44b37a68f798c388fe112 : SUCCESS in 43m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/00685b9d949f40e8885ab52ee2d982c1 : SUCCESS in 16m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/33a193b5969840ad8721aa1aeb4e41f3 : SUCCESS in 12m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e6efdff71a394e59ade6f33c93d58dde : SUCCESS in 13m 03s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9fa1126d555047af94282fb66658aae8 : SUCCESS in 11m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/21f92387b56b45a1886862be1e2ee98b : SUCCESS in 10m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/801a374c77df4fadb525a41f1cdd466f : SUCCESS in 22m 07s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/fb993e91cd234d638961eba5a417145f : SUCCESS in 1h 05m 44s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/10ccf14d3714486a8cb7046e02db11ee : SUCCESS in 54m 36s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/833cac3132d14fb78df09d1702832052 : SUCCESS in 54m 49s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/febb76f742fa4219b6fa809ad9100106 : FAILURE in 44m 18s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/064bca96f96f44d18882db645f708f82 : SUCCESS in 1h 51m 19s\n- nova-next https://zuul.opendev.org/t/openstack/build/eec7e19e00c3452f98aa03d18b20c1bf : SUCCESS in 1h 49m 44s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/91bb4870e9c0412ba901b196b235dbc4 : SUCCESS in 42m 17s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/61e557c872274abd91cc38870aa1bb87 : FAILURE in 4m 27s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/9e85c96ad9e44a14bee4a2f65e873628 : SUCCESS in 23m 23s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a1466ddfe4c44fe3892791eda1028250 : SUCCESS in 21m 26s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/52cd3338adb841b3a49df36c9d100ffb : SUCCESS in 22m 57s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/6b3b7fc718af46e7a5c8ef883c0ec064 : SUCCESS in 1h 12m 15s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d1159538b58e49cdb1dd812d6fa63bf8 : SUCCESS in 44m 34s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/618efbaa0d0749869dfd5674e13c2253 : SUCCESS in 20m 24s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/2941a3bce98b4497a882feb44c600dd1 : FAILURE in 34m 02s (non-voting)\n- tempest-centos8-stream-fips https://zuul.opendev.org/t/openstack/build/cf92f9f681af4e5fb62abc18c07acab9 : FAILURE in 27m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6ce6d177a8b7f3bf91f1efd77d9e64b0444d750c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-02-06 15:04:07.000000000","message":"Abandoned\n\nstable/yoga branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/yoga if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"da4b7d1e70486402635a009724b263981cd22861","revisions":{"da4b7d1e70486402635a009724b263981cd22861":{"kind":"REWORK","_number":1,"created":"2023-07-11 00:38:06.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/96/888096/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/96/888096/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/888096/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/888096/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/888096/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/96/888096/1"}}},"commit":{"parents":[{"commit":"291c02a7d51585551266fe5b7e7afd9726317671","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/291c02a7d51585551266fe5b7e7afd9726317671"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-11 00:36:44.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nConflicts:\n    nova/compute/api.py\n\nNOTE(melwitt): The conflict is because change\nIeb4766fdd88c469574fad823e05fe401537cdc30 (Allow unshelve to a specific\nhost (Compute API part)) is not in Yoga.\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/da4b7d1e70486402635a009724b263981cd22861"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/da4b7d1e70486402635a009724b263981cd22861"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}