)]}'
{"id":"openstack%2Fnova~888100","triplet_id":"openstack%2Fnova~stable%2Fxena~I4ab97626c10052c7af9934a80ff8db9ddab82738","project":"openstack/nova","branch":"stable/xena","topic":"bug/2003991","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 19:12:42.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4ab97626c10052c7af9934a80ff8db9ddab82738","subject":"Enforce quota usage from placement when unshelving","status":"ABANDONED","created":"2023-07-11 02:18:26.000000000","updated":"2024-03-05 19:12:42.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"90314bbc1e584b798aef9456a6b51480f1aeeac2","_number":888100,"virtual_id_number":888100,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-07-11 05:18:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-11 02:42:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-07-11 05:18:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-05 19:12:41.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"9f345e1c44bb8cfe5d4508f77fe3352ba7093949","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-11 02:18:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1aa9c80f98564d353d6431e644fe4b3a4725d22e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-11 02:42:37.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/345b066503024e3f8213a88c7c65bfd7\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/441869ae9259431cbb4ae5dfc38443a8 : SUCCESS in 22m 20s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/3aad806bce7f43069729786901a8f16a : NODE_FAILURE Node request 300-0021659093 failed in 0s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c21f19619eb46ad950fad60d3498478e92bde519","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-11 03:00:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"05a9e0c0939187503275c4b0bb62600026ac7e73","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-11 03:29:11.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7254157020da4fd0b1aa64d21c695909\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/29ed0725be694e8699b4d2f16d088914 : SUCCESS in 20m 23s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/cb929046876a41d481df863735aae42b : SUCCESS in 23m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a64a081a96defcd236f8a0b7c7eac4727601eb8c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-11 05:18:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4e52a98833874b2986e4048922e745ef\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/360ba65e92ba4567a29c2a8363fa382e : SUCCESS in 1h 13m 38s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/987b34a403094f2e84ea76c76621b8f0 : FAILURE in 51m 09s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9fa0d9f16f004f9188999c55f9a4dabe : SUCCESS in 1h 23m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/65929239fc8b4abfbae920f23e25306c : SUCCESS in 15m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/98184dc85e3d46cdb2d56753a66edb1d : SUCCESS in 7m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/36a1f030c084457f9d9399ce740688d4 : SUCCESS in 30m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/55cc1876317344bba56023ddcc6be14a : SUCCESS in 20m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/07a6b678a9374dd1a7b54749b5a7926f : SUCCESS in 11m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/454d81ae00fb443eb1ee966684a4ded3 : SUCCESS in 11m 40s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4c0c4dff34504b0893f6e20f9d4f589e : SUCCESS in 24m 11s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/46a68559ca264349915ef202ccf77a00 : SUCCESS in 1h 24m 22s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/77679fb0d1c242d3be6622b2cc845ce1 : SUCCESS in 1h 38m 43s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e3b761a3622e48f59362f2affc909b90 : SUCCESS in 1h 21m 17s (non-voting)\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/0c0022681c8144b6a741c874728a5d65 : SUCCESS in 1h 13m 56s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/114654d3fa2a489e84a62fbd184ec583 : SUCCESS in 1h 25m 40s\n- nova-next https://zuul.opendev.org/t/openstack/build/a8fca9fd3d6449db9e9a6da5879e708c : SUCCESS in 1h 46m 20s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/eefd5c1194c3475e844b36523fbbfc8f : SUCCESS in 1h 16m 55s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/5c1a4ba2e3d84ea8a81f505123666e7f : FAILURE in 8m 03s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/9f9982e563a7432a8d627df5575eee67 : SUCCESS in 41m 47s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/7b873616e53048308fe45d25b448877e : SUCCESS in 27m 13s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/86104ba61cea49efbc7395b3cdb437d8 : SUCCESS in 50m 33s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/24d7a689fc6d45849501852c53ac9a21 : SUCCESS in 1h 11m 15s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/71de3f7d3ad74b2e9af3d4c4c1b6436f : SUCCESS in 1h 14m 11s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/b25b79768a764f86b411305fb3f6cae4 : SUCCESS in 54m 24s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/5bf61217f71a4979ab3b987865ccabec : FAILURE in 1h 01m 20s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"90314bbc1e584b798aef9456a6b51480f1aeeac2","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 19:12:42.000000000","message":"Abandoned\n\nstable/xena branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/xena if you want to further work on this patch.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b8875b17bb43795ec7f90ad14c60bb19976b89ab","revisions":{"746bc7222276a8c6bb4f0f9317802e332d25b756":{"kind":"REWORK","_number":1,"created":"2023-07-11 02:18:26.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/00/888100/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/00/888100/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/00/888100/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/00/888100/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/00/888100/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/00/888100/1"}}},"commit":{"parents":[{"commit":"dc2d308118a126e087431d5c7810e1f958cbe895","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc2d308118a126e087431d5c7810e1f958cbe895"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-11 02:16:27.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nConflicts:\n    nova/compute/api.py\n    nova/conductor/manager.py\n    nova/limit/placement.py\n\nNOTE(melwitt): The conflicts and differences from the cherry-picked\nchange are resolved by removing bits related to unified limits because\nunified limits support is not present in Xena..\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/746bc7222276a8c6bb4f0f9317802e332d25b756"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/746bc7222276a8c6bb4f0f9317802e332d25b756"}]},"branch":"refs/heads/stable/xena"},"b8875b17bb43795ec7f90ad14c60bb19976b89ab":{"kind":"REWORK","_number":2,"created":"2023-07-11 03:00:39.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/00/888100/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/00/888100/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/00/888100/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/00/888100/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/00/888100/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/00/888100/2"}}},"commit":{"parents":[{"commit":"dc2d308118a126e087431d5c7810e1f958cbe895","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc2d308118a126e087431d5c7810e1f958cbe895"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-11 03:00:13.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nConflicts:\n    nova/compute/api.py\n    nova/conductor/manager.py\n    nova/limit/placement.py\n\nNOTE(melwitt): The conflicts and differences from the cherry-picked\nchange are resolved by removing bits related to unified limits because\nunified limits support is not present in Xena.\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8875b17bb43795ec7f90ad14c60bb19976b89ab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8875b17bb43795ec7f90ad14c60bb19976b89ab"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}