)]}'
{"id":"openstack%2Fnova~888104","triplet_id":"openstack%2Fnova~stable%2Fwallaby~I4ab97626c10052c7af9934a80ff8db9ddab82738","project":"openstack/nova","branch":"stable/wallaby","topic":"bug/2003991","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 19:04:54.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4ab97626c10052c7af9934a80ff8db9ddab82738","subject":"Enforce quota usage from placement when unshelving","status":"ABANDONED","created":"2023-07-11 02:58:51.000000000","updated":"2024-03-05 19:04:54.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"84a240177fd3025089b3315c4aaa53d236f8f0e3","_number":888104,"virtual_id_number":888104,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-07-11 05:33:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-11 03:25:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-07-11 05:33:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-05 19:04:54.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"004b2683ba81e7d21bf5ecf8cc5631d1449610be","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-11 02:58:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc04ec4982e1dfcfc550417e03ca17450df8171e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-11 03:25:28.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c0326267dc304f6482f69e8402212093\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ac6c17feb4b74851a170b91bbd3dbc85 : SUCCESS in 22m 42s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/5a63886fd1064fabb2fb74974cf5e726 : NODE_FAILURE Node request 300-0021659242 failed in 0s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0ce39fc93dfa6945d7e93fae99451d4a487b110c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-11 05:33:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/43ab186e10174e8ca52998bd1db93114\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/235b8ec6107e4a97a9145fa9edb06eb7 : SUCCESS in 1h 55m 24s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/bd8b020dcc6641c9b8c473c558056d9c : TIMED_OUT in 2h 03m 25s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6ad56ab8e73040f28387118271b2c6c5 : SUCCESS in 17m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7f8737b0c3ff43029d704fbee6e870a6 : SUCCESS in 6m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e269e31b066f468d97bae41331ce80ee : SUCCESS in 13m 12s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3a2e437e37b14d5aa6608bf4cf5e1382 : SUCCESS in 11m 14s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7012bde996d24569831af1ffcda23bf9 : SUCCESS in 15m 29s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f7595b5134d94341be6f177351e7fb14 : SUCCESS in 8m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/11eaf33957484e2c8e1b0e5b622e7f94 : SUCCESS in 20m 13s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/c65da81ca50a4660a5cc990a2bda5b30 : SUCCESS in 48m 06s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/ae35dfc2ad714096a77f64039e3f7794 : SUCCESS in 1h 00m 44s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/9698426c40aa48169609d3cb8de19250 : SUCCESS in 1h 20m 00s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/7e188f787f644ad5aa7d963fc9e57d9c : SUCCESS in 2h 05m 13s\n- nova-next https://zuul.opendev.org/t/openstack/build/a90b9ffbeb43455983f9aca4433d425b : SUCCESS in 1h 33m 23s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/4db3cfeb01ae44b5acbc610a1964edad : SUCCESS in 1h 08m 21s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/650039fe827c45d4bd8e53c9e3584f2c : FAILURE in 5m 13s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a2e08cf37da641079eb1acc6e92763dc : SUCCESS in 17m 49s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/6656237b47ec4b989761dce6cfe572e5 : SUCCESS in 18m 18s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/0d02623bfaf849219b718d83b4352eda : SUCCESS in 1h 05m 57s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/953f216c9def4efd9eb478d443234a03 : SUCCESS in 1h 27m 37s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/77c3deaca83d47148dc5a0ba489ecb8e : SUCCESS in 1h 06m 44s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/697ebf2c22d54407b2dcf0b5bc14fe4d : FAILURE in 1h 22m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"84a240177fd3025089b3315c4aaa53d236f8f0e3","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 19:04:54.000000000","message":"Abandoned\n\nstable/wallaby branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/wallaby if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c13c26f88edea2d762aef97013662859496dd3e6","revisions":{"c13c26f88edea2d762aef97013662859496dd3e6":{"kind":"REWORK","_number":1,"created":"2023-07-11 02:58:51.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/04/888104/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/04/888104/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/04/888104/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/04/888104/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/04/888104/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/04/888104/1"}}},"commit":{"parents":[{"commit":"1d91e71e74b57b0f2f108faeb522244a03540485","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1d91e71e74b57b0f2f108faeb522244a03540485"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-11 02:58:23.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nConflicts:\n    nova/compute/api.py\n\nNOTE(melwitt): The conflict is because change\nIbcf703e254e720b9a6de17527325758676628d48 (Support move ops with\nextended resource request) is not in Wallaby. The difference in\nnova/conductor/manager.py is because change\nIfe3c7a5a95c5d707983ab33fd2fbfc1cfb72f676 (Add force kwarg to\ndelete_allocation_for_instance) is not in Wallaby.\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c13c26f88edea2d762aef97013662859496dd3e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c13c26f88edea2d762aef97013662859496dd3e6"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}