)]}'
{"id":"openstack%2Fnova~888204","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I4ab97626c10052c7af9934a80ff8db9ddab82738","project":"openstack/nova","branch":"stable/victoria","topic":"bug/2003991","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2024-03-05 18:56:19.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4ab97626c10052c7af9934a80ff8db9ddab82738","subject":"Enforce quota usage from placement when unshelving","status":"ABANDONED","created":"2023-07-12 02:38:48.000000000","updated":"2024-03-05 18:56:19.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"90c4cd56279ee1dcde5325aefba856c9644a6b86","_number":888204,"virtual_id_number":888204,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-07-12 05:00:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-12 05:00:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-05 18:56:19.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"CC"}],"messages":[{"id":"b6d7be976251622e6dbee9b932e688ac707e2101","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-12 02:38:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cd322fd614a295722a26371f0d63e97360ff39a8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-12 05:00:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2f8defd873c849d49e0988f085bc6458\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1c156506e89a46d1807f58dcd31cbf58 : SUCCESS in 1h 38m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/09dfa7c4e3594e7d91ccb7b962197a15 : SUCCESS in 15m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d90a7e4d199c40609458003412f04b68 : SUCCESS in 7m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9c33e11d14e54685ba0fcdefd5912915 : SUCCESS in 11m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ad01227b011b408e96623dd8d6a97026 : SUCCESS in 12m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5f336b25a15a4711be0ea16995a63f77 : SUCCESS in 11m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9f2d3e0d76334a4581d66b0b9c3b3d0d : SUCCESS in 19m 54s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/54b0bed926754bf88fbf197d47ac797e : SUCCESS in 52m 57s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/5dd8537e147b46fa9c75d5d35bb34caf : SUCCESS in 1h 16m 42s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/fca94000c2ed438c8978c4fd1ddb0dd7 : SUCCESS in 39m 01s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/3e80fd9b95584057a3adc31967ea0bed : SUCCESS in 1h 18m 26s\n- nova-next https://zuul.opendev.org/t/openstack/build/571f113be0164e508881508170c5039b : SUCCESS in 1h 20m 20s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/8fe179aeedd34a26baa8ad6115b4d81c : FAILURE in 6m 01s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/116485b98c154414add65275bacadf01 : SUCCESS in 17m 31s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a56120e4143242bd9f95c6f48ad84dc9 : SUCCESS in 1h 39m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/cfee35a786b24da6ab718069ca3746d9 : SUCCESS in 1h 09m 08s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/917417c899f04fd0a98ffde7324e26bc : FAILURE in 44m 19s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/4252389ac62840ff861faa57ed077d94 : FAILURE in 45m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"90c4cd56279ee1dcde5325aefba856c9644a6b86","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2024-03-05 18:56:19.000000000","message":"Abandoned\n\nstable/victoria branch of openstack/nova is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/victoria if you want to further work on this patch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"da5e34e33d8ad0f85da1dd83c0e020efb6fc3978","revisions":{"da5e34e33d8ad0f85da1dd83c0e020efb6fc3978":{"kind":"REWORK","_number":1,"created":"2023-07-12 02:38:48.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/04/888204/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/04/888204/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/04/888204/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/04/888204/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/04/888204/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/04/888204/1"}}},"commit":{"parents":[{"commit":"c0f06628eb883aa6d213cc9b57ffb8f5b3a64372","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c0f06628eb883aa6d213cc9b57ffb8f5b3a64372"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-11 03:01:46.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n(cherry picked from commit c13c26f88edea2d762aef97013662859496dd3e6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/da5e34e33d8ad0f85da1dd83c0e020efb6fc3978"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/da5e34e33d8ad0f85da1dd83c0e020efb6fc3978"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}