)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4829ca037d241582e05feb8cb794129b518ffa6b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     alecorps \u003calban.lecorps@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-25 14:10:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Workaround for issues with ephemeral disk named disk.local during resize"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create backing file if disk.local in disk.info to ensure there no libvirt error."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e751f013_a0f6051e","line":7,"updated":"2024-06-26 15:59:04.000000000","message":"as a general comment you hsould first submit a unit or functional test repoducer for the bug as an initall chagne/patch. then a second review that updatees the repodcue and fixes the bug\n\ncan you submit a sepreate review to repoduce this in a fucntional tests \n\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_2007968.py is an regression test which uses resize to test resizeign between flavors that break the min memory requrieemtn of the image.\n\nyou should be able to cpy this for your bug and update the new and old flavors\nto have diffent ephmeral disk requirements.","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"16f67f0a56a06f79efe5979537480878749f1e5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d1eb796_c61ec757","updated":"2023-07-12 11:54:23.000000000","message":"I could not understand why this is required.\nis there any bug ?","commit_id":"2d9beac4e6077256d0128559557aa1a94f4823e5"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5d5d5c0e41141ed0364c2dce44d33ca4222f8bff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"46e139c4_c65b01b0","updated":"2023-07-25 09:36:37.000000000","message":"a nit for commit msg.\nwill look again in change later, couldn\u0027t do right now properly.","commit_id":"2d9beac4e6077256d0128559557aa1a94f4823e5"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"ecb41c3dfe815b91a108bfd4534624abcb09560d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"708a76b3_eab97f4e","updated":"2023-07-17 07:11:29.000000000","message":"recheck","commit_id":"2d9beac4e6077256d0128559557aa1a94f4823e5"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5d5d5c0e41141ed0364c2dce44d33ca4222f8bff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c787dcb_e3a99b33","in_reply_to":"422aa573_1fde437f","updated":"2023-07-25 09:36:37.000000000","message":"ack, so we need to mention the bug in commit msg, please see here: https://docs.opendev.org/opendev/infra-manual/latest/developers.html#working-on-bugs","commit_id":"2d9beac4e6077256d0128559557aa1a94f4823e5"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4626c26cb4e65c1f961cf4df38fba37847ac75ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e40253a2_4c58ec7c","in_reply_to":"46e139c4_c65b01b0","updated":"2023-08-10 12:47:16.000000000","message":"could not reproduce the issue, will add more experienced people.","commit_id":"2d9beac4e6077256d0128559557aa1a94f4823e5"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"e58c5149c17a3e786e8d70f76ecf976376aa6568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"422aa573_1fde437f","in_reply_to":"5d1eb796_c61ec757","updated":"2023-07-25 09:00:59.000000000","message":"Yes as described in https://bugs.launchpad.net/nova/+bug/2027553","commit_id":"2d9beac4e6077256d0128559557aa1a94f4823e5"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"c6c2b12abe8242dd3b4a0db73efa1a71f664dde5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03fa824f_af39a38b","in_reply_to":"7c787dcb_e3a99b33","updated":"2023-07-25 14:11:27.000000000","message":"Done","commit_id":"2d9beac4e6077256d0128559557aa1a94f4823e5"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"638ea8bc99e6d65ed3e1695231fb38cb1663fc82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a80dc64_2a303fd5","updated":"2023-07-27 10:47:57.000000000","message":"please hold your rechecks util bug in nova-lvm job resolved.\nhttps://bugs.launchpad.net/nova/+bug/2028851\n\nalso please have a look here for how to recheck \nhttps://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"f85cfefb79a0c180c6b6448b961497ca9bd6bae4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76a06f00_98a503a3","updated":"2023-07-27 09:04:31.000000000","message":"recheck","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"},{"author":{"_account_id":30609,"name":"Stanislav Dmitriev","email":"sdmitriev1@gmail.com","username":"sdmitriev"},"change_message_id":"5a8554f6aeb76707cd280b765e460684c8f5196b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9026ea76_4119e380","updated":"2024-06-26 15:26:34.000000000","message":"recheck","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"1d04dc29269327e959835693490fa78580f2a962","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5b0fd94_e7ac61e0","updated":"2023-07-26 06:59:48.000000000","message":"recheck","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4626c26cb4e65c1f961cf4df38fba37847ac75ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e78493f_d36e1cd6","updated":"2023-08-10 12:47:16.000000000","message":"recheck jobs are passing now gate seems better","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"},{"author":{"_account_id":33952,"name":"alecorps","display_name":"Alban Lecorps","email":"alban.lecorps@gmail.com","username":"alecorps7"},"change_message_id":"42795c909975dff4710b31bd262f2c672c8227ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4660bb52_992ef03d","updated":"2023-11-16 09:23:53.000000000","message":"thanks","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4829ca037d241582e05feb8cb794129b518ffa6b","unresolved":true,"context_lines":[{"line_number":11654,"context_line":"        # assume _create_image does nothing if a target file exists."},{"line_number":11655,"context_line":"        # NOTE: This has the intended side-effect of fetching a missing"},{"line_number":11656,"context_line":"        # backing file."},{"line_number":11657,"context_line":"        self._create_image(context, instance, block_disk_info[\u0027mapping\u0027],"},{"line_number":11658,"context_line":"                           block_device_info\u003dblock_device_info,"},{"line_number":11659,"context_line":"                           ignore_bdi_for_swap\u003dTrue,"},{"line_number":11660,"context_line":"                           fallback_from_host\u003dmigration.source_compute)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c6e75cf_4b693e23","line":11657,"range":{"start_line":11657,"start_character":13,"end_line":11657,"end_character":26},"updated":"2024-06-26 15:59:04.000000000","message":"this likely should be _create_images_and_backing instead.","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4829ca037d241582e05feb8cb794129b518ffa6b","unresolved":true,"context_lines":[{"line_number":11671,"context_line":"            disk_info) if \u0027disk.local\u0027 in info.get(\u0027path\u0027)]"},{"line_number":11672,"context_line":"        if disk_info_local:"},{"line_number":11673,"context_line":"            instance_dir \u003d libvirt_utils.get_instance_path(instance)"},{"line_number":11674,"context_line":"            self._create_images_and_backing(context, instance, instance_dir,"},{"line_number":11675,"context_line":"                                                       disk_info_local)"},{"line_number":11676,"context_line":"        # Convert raw disks to qcow2 if migrating to host which uses"},{"line_number":11677,"context_line":"        # qcow2 from host which uses raw."}],"source_content_type":"text/x-python","patch_set":2,"id":"65e95c88_fc79c690","line":11674,"updated":"2024-06-26 15:59:04.000000000","message":"if its safe to call _create_images_and_backing here it is also safe to call it where we are currently calling _create_image\n\ninternally _create_images_and_backing loos over the disk_info object and creates the backing file if it does not exist.\nit also only create the file if it does not already exits in the case there is no backign file.\n\nim not convinces at a glance that we need to prefilter the disk info\nwe should be abel to just call _create_images_and_backing on line 11657 above.","commit_id":"594a267f713bbb14736c41b1495b6d4642e14493"}]}