)]}'
{"id":"openstack%2Fnova~888509","triplet_id":"openstack%2Fnova~stable%2Ftrain~I4ab97626c10052c7af9934a80ff8db9ddab82738","project":"openstack/nova","branch":"stable/train","topic":"bug/2003991","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2023-09-01 16:52:49.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4ab97626c10052c7af9934a80ff8db9ddab82738","subject":"Enforce quota usage from placement when unshelving","status":"ABANDONED","created":"2023-07-13 22:40:42.000000000","updated":"2023-09-01 16:52:49.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0636a803407427ad63de3bf656c77fe46697327d","_number":888509,"virtual_id_number":888509,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-07-18 00:18:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-14 06:11:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"64d41402c4f08274ae51516dfa69d8ca5df8ea68","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-13 22:40:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"12ed032790968333ff1c5ba665d25a617a54fa7f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-14 00:27:59.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"301f37f7082127516b70541f3d854b0eb71b2ee7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-14 01:12:39.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"5c49eb916c78420c537035d98a0fd16d9155b8e8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-14 02:02:22.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"a5c88bdeba52910d4d782c892d5bc2914c33fe73","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-14 06:11:54.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/afc956aa713c4780b85daba20af784bc\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/64314f16e20e4531a82b0fb5d097e1af : SUCCESS in 1h 15m 46s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/69ce4fba4e00418ea62a15a728eb08b9 : POST_FAILURE in 39m 30s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dcb78e966c2149b78e7d2850f0e89aa9 : FAILURE in 16m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/551cf50a90154b6fb37026f2ae26fa4b : SUCCESS in 10m 02s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d11d6ce2b6854ae9a41f795366ba3232 : FAILURE in 5m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a636229aac404e3daa856d03ec7d128d : FAILURE in 10m 53s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/263cb130456340d0b0a0ff950c5d8ac3 : FAILURE in 15m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3c9a8ba3f2bb4983b31deb351c27a7d1 : SUCCESS in 11m 04s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/93585102b9594765ae217c1eb269df16 : SUCCESS in 21m 19s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/a536266c781d429d93a1eef699fbe968 : FAILURE in 28m 29s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/4811709815fa4853a2cbaafacdb9e8c1 : FAILURE in 28m 23s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/1c407a4e982d4b00acb79fc75534cb13 : SUCCESS in 1h 17m 34s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/11f96a655e184973a4cda8efd8b6e547 : SUCCESS in 48m 22s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/f29cde5caf7142c1ab0a625855fd776f : FAILURE in 2h 43m 22s\n- nova-next https://zuul.opendev.org/t/openstack/build/222d0fde4ec74ed9913574f08e07191c : SUCCESS in 1h 41m 54s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/e7e29463a94645bd97409d09ce70ec50 : FAILURE in 8m 25s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/230f569a8e3f4a2fb13e8b7f4f2698dc : SUCCESS in 21m 25s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/23a3d7238bd64a5595e21dc2ee3e3105 : FAILURE in 5m 09s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/ac576b1081c949afa22702d8b34e54a0 : SUCCESS in 1h 57m 57s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/677d7d4634764f68a04a0e91bc7b8997 : SUCCESS in 1h 06m 58s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/bdb6ef57b41a4bb69c923517ff8e308b : SUCCESS in 1h 21m 33s","accounts_in_message":[],"_revision_number":4},{"id":"e49759905e887f977a39102b835845f21002c5ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-14 22:18:25.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":5},{"id":"970fc4b1893a6ce5fde362f6a485b0943be95bbc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-14 23:57:50.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/db28247be03a409aa8ee0df674c02883\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/aeaa397dec9d49a8b00ec7f97fbec430 : SUCCESS in 1h 32m 28s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/86ee3de06e774173bf9b238e103e7c7b : POST_FAILURE in 16m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/15a8cb1dd3ef4c37a060f54a3be74fd2 : SUCCESS in 18m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ec02b7265bf94cf9b8ec5cb9292e29fa : SUCCESS in 7m 59s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3862949f002a48278848fe27f710fc67 : FAILURE in 6m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/14379d5761b94830957ffa4ca3c560a1 : SUCCESS in 14m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/32c08da602374f439d6a92b5065e6b33 : SUCCESS in 12m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/79c219c0dd5a45b187889591edcdd099 : SUCCESS in 10m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/773d8e26e0544afab52df313b311c2ef : SUCCESS in 26m 41s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/5b178449f5664e0db5450cf25d64ead6 : FAILURE in 29m 29s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/f60480f432ea4d9d9b3200cc3da9cc5f : FAILURE in 39m 39s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/1fe15873ae54424e856bb92c8560a1ca : SUCCESS in 55m 01s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/b672ef1d5df94eb0a90aef9f8de3d21a : SUCCESS in 45m 01s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/2dffbf4a950f4ceeb3acb8d60a3a3942 : FAILURE in 1h 32m 22s\n- nova-next https://zuul.opendev.org/t/openstack/build/0fd0c98d48fd4637a3d416efaf0a56ca : SUCCESS in 1h 12m 07s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/0af40fa4e60246629aec3cfb53270322 : FAILURE in 6m 08s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/775074496c97485ab1b21440ab3880e1 : SUCCESS in 18m 44s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/403d066d8b7b4c11b40954f63166f944 : FAILURE in 5m 26s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/8e95e38270bc4247955e057cb5ae6d71 : SUCCESS in 1h 37m 51s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/6886a0958e1341ba91f710214cd73381 : SUCCESS in 58m 02s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f9cdd7c26ccd41b6a9bf77a9e0277462 : SUCCESS in 50m 19s","accounts_in_message":[],"_revision_number":5},{"id":"bd24a14f6af8a16b11f04c82f73a9a74cc5356f1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2023-07-17 22:20:45.000000000","message":"Uploaded patch set 6.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":6},{"id":"e2f9eb7b168538d222bd721e857c1ff14708e214","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-18 00:18:52.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/c4e2466a45a24b458d5d9fb50c1b4328\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/3c5cfa1086b44fda8421d17c25e20b5c : SUCCESS in 1h 32m 59s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c7571402a42446dc89a867de185fcdbf : SUCCESS in 56m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6062eb7b787442698b45f92c40614d49 : SUCCESS in 16m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d676d87e42684a87946db319a3239b63 : SUCCESS in 11m 22s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/122df5d46549459eaa37b9563eb263ae : SUCCESS in 10m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cdb1471e2163467cbc45cf4020ef92bf : SUCCESS in 14m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fecd489cacdf42c1b72f49695b420fef : SUCCESS in 12m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/01d7dcaa6ed84f869ecb6ceb47398edb : SUCCESS in 11m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c57257cce28e4736aaf546a46024f8fc : SUCCESS in 19m 58s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/50e3bc6596e7404eaad1c547a4900f8a : SUCCESS in 59m 25s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/28193af1185d4d5ba4e1b9aeb52272b8 : SUCCESS in 1h 03m 59s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/aaa96fb72d9047c7952e1e299aeeb964 : SUCCESS in 46m 32s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/21c56abfdc29465ebdd90916c13166f0 : FAILURE in 54m 14s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/f463bc148eb04a9c881b4dcb927fc4b4 : SUCCESS in 1h 45m 59s\n- nova-next https://zuul.opendev.org/t/openstack/build/80999fcc49824f0fbeef8b605ef93ef7 : SUCCESS in 1h 07m 46s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/2048abf5cf4e419d805ecfbc0208532e : SUCCESS in 17m 52s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/a9a0a186c0054702885f337427ed3fce : SUCCESS in 21m 36s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/b0410af8e4c345f5ad4d66393c54f610 : FAILURE in 4m 10s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/c3f914dfa5aa4a04a22c2163cb2d731b : SUCCESS in 1h 45m 07s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f56ac0945aaf4470a5a54f877b9cc96f : FAILURE in 40m 42s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e0fef03178f04d3ca9d07d7f8019a5fe : SUCCESS in 1h 09m 54s","accounts_in_message":[],"_revision_number":6},{"id":"0636a803407427ad63de3bf656c77fe46697327d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 16:52:49.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"64c709ed589f1fb02b4f2b15c29bedcb5558051b","revisions":{"91364740da3650f22a567b564ddd2852013cf649":{"kind":"REWORK","_number":1,"created":"2023-07-13 22:40:42.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/09/888509/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/888509/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/888509/1"}}},"commit":{"parents":[{"commit":"90be9c66c25b38ef5ce8e6a81a9446988bbc4bb7","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/90be9c66c25b38ef5ce8e6a81a9446988bbc4bb7"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-13 22:38:42.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nNOTE(melwitt): The difference from the cherry picked change is\nbecause change I5d6db24a440397e588ba69f98a9cd2b8a846adc2 (tests: Add\nhelpers for rebuild, cold migrate, and shelve/unshelve) is not in\nUssuri.\n\nConflicts:\n    nova/conductor/manager.py\n    nova/tests/unit/conductor/test_conductor.py\n\nNOTE(melwitt): The conflicts are because the following changes are not\nin Train:\n\n  * I497180fb81fd966d1d3d4b54ac66d2609347583e (Restrict RequestSpec to\n    cell when evacuating)\n  * I52499ff6639c1a5815a8557b22dd33106dcc386b (Use provider mappings\n    from Placement (mostly))\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n(cherry picked from commit c13c26f88edea2d762aef97013662859496dd3e6)\n(cherry picked from commit da5e34e33d8ad0f85da1dd83c0e020efb6fc3978)\n(cherry picked from commit d5c9b39f6e5ccdefbc3e47645e6fc9e0b1c7e000)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/91364740da3650f22a567b564ddd2852013cf649"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/91364740da3650f22a567b564ddd2852013cf649"}]},"branch":"refs/heads/stable/train"},"58f5abfa07da39c1832b6910d8c4549912e12065":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-07-14 00:27:59.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/09/888509/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/888509/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/888509/2"}}},"commit":{"parents":[{"commit":"60fb01f496d3ef5056de68f50a6222ffaf9d2ce3","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/60fb01f496d3ef5056de68f50a6222ffaf9d2ce3"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-14 00:26:42.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nNOTE(melwitt): The difference from the cherry picked change is\nbecause change I5d6db24a440397e588ba69f98a9cd2b8a846adc2 (tests: Add\nhelpers for rebuild, cold migrate, and shelve/unshelve) is not in\nUssuri.\n\nConflicts:\n    nova/conductor/manager.py\n    nova/tests/unit/conductor/test_conductor.py\n\nNOTE(melwitt): The conflicts are because the following changes are not\nin Train:\n\n  * I497180fb81fd966d1d3d4b54ac66d2609347583e (Restrict RequestSpec to\n    cell when evacuating)\n  * I52499ff6639c1a5815a8557b22dd33106dcc386b (Use provider mappings\n    from Placement (mostly))\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n(cherry picked from commit c13c26f88edea2d762aef97013662859496dd3e6)\n(cherry picked from commit da5e34e33d8ad0f85da1dd83c0e020efb6fc3978)\n(cherry picked from commit d5c9b39f6e5ccdefbc3e47645e6fc9e0b1c7e000)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58f5abfa07da39c1832b6910d8c4549912e12065"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/58f5abfa07da39c1832b6910d8c4549912e12065"}]},"branch":"refs/heads/stable/train"},"a8fd5db06c8aeeb7d94ec06549851d8738fa10cb":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-07-14 01:12:39.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/09/888509/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/888509/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/888509/3"}}},"commit":{"parents":[{"commit":"48fc3cc4ce7b30f3c1971fed95e8e681cdcd0e2b","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/48fc3cc4ce7b30f3c1971fed95e8e681cdcd0e2b"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-14 01:11:54.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nNOTE(melwitt): The difference from the cherry picked change is\nbecause change I5d6db24a440397e588ba69f98a9cd2b8a846adc2 (tests: Add\nhelpers for rebuild, cold migrate, and shelve/unshelve) is not in\nUssuri.\n\nConflicts:\n    nova/conductor/manager.py\n    nova/tests/unit/conductor/test_conductor.py\n\nNOTE(melwitt): The conflicts are because the following changes are not\nin Train:\n\n  * I497180fb81fd966d1d3d4b54ac66d2609347583e (Restrict RequestSpec to\n    cell when evacuating)\n  * I52499ff6639c1a5815a8557b22dd33106dcc386b (Use provider mappings\n    from Placement (mostly))\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n(cherry picked from commit c13c26f88edea2d762aef97013662859496dd3e6)\n(cherry picked from commit da5e34e33d8ad0f85da1dd83c0e020efb6fc3978)\n(cherry picked from commit d5c9b39f6e5ccdefbc3e47645e6fc9e0b1c7e000)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8fd5db06c8aeeb7d94ec06549851d8738fa10cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8fd5db06c8aeeb7d94ec06549851d8738fa10cb"}]},"branch":"refs/heads/stable/train"},"6254c698ace8143c646e5623e7d0ca0bb83fa625":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-07-14 02:02:22.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/09/888509/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/888509/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/888509/4"}}},"commit":{"parents":[{"commit":"6e3c72a71d60df4bab2aaaec833dcca3d91b31ab","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6e3c72a71d60df4bab2aaaec833dcca3d91b31ab"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-14 02:01:04.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nNOTE(melwitt): The difference from the cherry picked change is\nbecause change I5d6db24a440397e588ba69f98a9cd2b8a846adc2 (tests: Add\nhelpers for rebuild, cold migrate, and shelve/unshelve) is not in\nUssuri.\n\nConflicts:\n    nova/conductor/manager.py\n    nova/tests/unit/conductor/test_conductor.py\n\nNOTE(melwitt): The conflicts are because the following changes are not\nin Train:\n\n  * I497180fb81fd966d1d3d4b54ac66d2609347583e (Restrict RequestSpec to\n    cell when evacuating)\n  * I52499ff6639c1a5815a8557b22dd33106dcc386b (Use provider mappings\n    from Placement (mostly))\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n(cherry picked from commit c13c26f88edea2d762aef97013662859496dd3e6)\n(cherry picked from commit da5e34e33d8ad0f85da1dd83c0e020efb6fc3978)\n(cherry picked from commit d5c9b39f6e5ccdefbc3e47645e6fc9e0b1c7e000)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6254c698ace8143c646e5623e7d0ca0bb83fa625"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6254c698ace8143c646e5623e7d0ca0bb83fa625"}]},"branch":"refs/heads/stable/train"},"ced8a9b76ff05f69f4b3d90ba77867bb2b0b5667":{"kind":"REWORK","_number":5,"created":"2023-07-14 22:18:25.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/09/888509/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/888509/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/888509/5"}}},"commit":{"parents":[{"commit":"6e3c72a71d60df4bab2aaaec833dcca3d91b31ab","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6e3c72a71d60df4bab2aaaec833dcca3d91b31ab"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-14 22:16:56.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nNOTE(melwitt): The difference from the cherry picked change is\nbecause change I5d6db24a440397e588ba69f98a9cd2b8a846adc2 (tests: Add\nhelpers for rebuild, cold migrate, and shelve/unshelve) is not in\nUssuri.\n\nConflicts:\n    nova/conductor/manager.py\n    nova/tests/unit/conductor/test_conductor.py\n\nNOTE(melwitt): The conflicts are because the following changes are not\nin Train:\n\n  * I497180fb81fd966d1d3d4b54ac66d2609347583e (Restrict RequestSpec to\n    cell when evacuating)\n  * I52499ff6639c1a5815a8557b22dd33106dcc386b (Use provider mappings\n    from Placement (mostly))\n\nand the difference in test_conductor.py from the cherry picked change\nis because change I3cfb1edc30b0bda4671e0d2cc2a8993055dcc9ff (Default\nuser_id when not specified in check_num_instances_quota) is not in\nTrain.\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n(cherry picked from commit c13c26f88edea2d762aef97013662859496dd3e6)\n(cherry picked from commit da5e34e33d8ad0f85da1dd83c0e020efb6fc3978)\n(cherry picked from commit d5c9b39f6e5ccdefbc3e47645e6fc9e0b1c7e000)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ced8a9b76ff05f69f4b3d90ba77867bb2b0b5667"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ced8a9b76ff05f69f4b3d90ba77867bb2b0b5667"}]},"branch":"refs/heads/stable/train"},"64c709ed589f1fb02b4f2b15c29bedcb5558051b":{"kind":"REWORK","_number":6,"created":"2023-07-17 22:20:45.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/09/888509/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/888509/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/888509/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/888509/6"}}},"commit":{"parents":[{"commit":"6e3c72a71d60df4bab2aaaec833dcca3d91b31ab","subject":"Reproducer for bug 2003991 unshelving offloaded instance","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6e3c72a71d60df4bab2aaaec833dcca3d91b31ab"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-01-27 03:08:09.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2023-07-17 22:19:30.000000000","tz":0},"subject":"Enforce quota usage from placement when unshelving","message":"Enforce quota usage from placement when unshelving\n\nWhen [quota]count_usage_from_placement \u003d true or\n[quota]driver \u003d nova.quota.UnifiedLimitsDriver, cores and ram quota\nusage are counted from placement. When an instance is SHELVED_OFFLOADED,\nit will not have allocations in placement, so its cores and ram should\nnot count against quota during that time.\n\nThis means however that when an instance is unshelved, there is a\npossibility of going over quota if the cores and ram it needs were\nallocated by some other instance(s) while it was SHELVED_OFFLOADED.\n\nThis fixes a bug where quota was not being properly enforced during\nunshelve of a SHELVED_OFFLOADED instance when quota usage is counted\nfrom placement. Test coverage is also added for the \"recheck\" quota\ncases.\n\nNOTE(melwitt): The difference from the cherry picked change is\nbecause change I5d6db24a440397e588ba69f98a9cd2b8a846adc2 (tests: Add\nhelpers for rebuild, cold migrate, and shelve/unshelve) is not in\nUssuri.\n\nConflicts:\n    nova/conductor/manager.py\n    nova/tests/unit/conductor/test_conductor.py\n\nNOTE(melwitt): The conflicts are because the following changes are not\nin Train:\n\n  * I497180fb81fd966d1d3d4b54ac66d2609347583e (Restrict RequestSpec to\n    cell when evacuating)\n  * I52499ff6639c1a5815a8557b22dd33106dcc386b (Use provider mappings\n    from Placement (mostly))\n\nand the difference in test_conductor.py from the cherry picked change\nis because change I3cfb1edc30b0bda4671e0d2cc2a8993055dcc9ff (Default\nuser_id when not specified in check_num_instances_quota) is not in\nTrain. Type hints have also been removed as they are not supported in\nPython 2.7.\n\nCloses-Bug: #2003991\n\nChange-Id: I4ab97626c10052c7af9934a80ff8db9ddab82738\n(cherry picked from commit 6f79d6321e7c3edaab2eb911198b7b7f851371b3)\n(cherry picked from commit c67e69c0e35d837fcefd7e4ea010a956569c3a55)\n(cherry picked from commit 490d5de6bb9ef3123cbbcea50e08ad0ad2edcbbe)\n(cherry picked from commit da4b7d1e70486402635a009724b263981cd22861)\n(cherry picked from commit 746bc7222276a8c6bb4f0f9317802e332d25b756)\n(cherry picked from commit c13c26f88edea2d762aef97013662859496dd3e6)\n(cherry picked from commit da5e34e33d8ad0f85da1dd83c0e020efb6fc3978)\n(cherry picked from commit d5c9b39f6e5ccdefbc3e47645e6fc9e0b1c7e000)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/64c709ed589f1fb02b4f2b15c29bedcb5558051b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/64c709ed589f1fb02b4f2b15c29bedcb5558051b"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}