)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35499,"name":"alisafari","email":"alisafar1212@gmail.com","username":"alisafari","status":"Software Engineer"},"change_message_id":"38cde6cf32acfe14ecdaa176ead767dabebe7719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c91d48b_38f68da3","updated":"2023-08-14 08:35:49.000000000","message":"Facing same issue on Antelope.\nSeems legit to me.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"11e844978176321ac7f5a111b2d5831e402f75e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"941a7c6f_d83534b7","updated":"2023-07-20 19:51:57.000000000","message":"INFO: The user who reported this bug downstream was able to test this patch with the same automation they were using to query the nova API when they encountered the bug and have confirmed that they no longer receive 500 errors with this patch applied.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7734a8dbc4b2ad6c6ff43d11c30bca52e41fb8f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"25496615_3a56d835","updated":"2023-08-15 12:23:58.000000000","message":"recheck nova CI is known unstable, so a few retries are expected and I\u0027ll leave it to others to find out whether this failure was a known one or not","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"656b9e1263c467d48a8b411d1d7997c05b58126c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ca068d1_df89561b","updated":"2023-08-15 23:19:19.000000000","message":"recheck urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host\u003d\u002710.209.65.8\u0027, port\u003d80): Read timed out. (read timeout\u003d60)","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"de66c11738dc9e6fee122d08377ec78d8ff2c0f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"801fece2_95393235","updated":"2023-08-15 18:50:22.000000000","message":"recheck zuul executors were out of disk space, fixed by opendev now","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a95f334d7a4839fa23bdeec3201e763692fdd55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2dbe717_d62dd033","in_reply_to":"25496615_3a56d835","updated":"2023-08-15 12:48:14.000000000","message":"i want to disagree with you but your not wrong...\n\nin this case neutron did not the metadata proxy properly \nso the could not reach it to inject the ssh key and we could not connect in the test\nchecking http://169.254.169.254/2009-04-04/instance-id\nfailed 1/20: up 17.42. request failed\nfailed 2/20: up 19.66. request failed\nfailed 3/20: up 21.86. request failed\nfailed 4/20: up 71.24. request failed\nfailed 5/20: up 120.46. request failed\n\nthat is not exactly an unknonw issue. ml2/ovn does not wait for the ovn metadata agent to conrigre metadtaa on the compute before saying the port is bound which is a know issue that has not been fixed in 2-3 years as far as i am aware.\n\nwe see this ocationally\n\ni tried to mitigate one casue of this with \n\nhttps://github.com/openstack/neutron/commit/5e0c102830a18850e35f746160867613e96d1dbc\n\n\nthe metadat agent recived the binding update \n\nand we can see that it considers it boudn before it provisions the metadata\n\nAug 14 14:52:10.011870 np0034942709 neutron-ovn-metadata-agent[38695]: INFO neutron.agent.ovn.metadata.agent [-] Port 883c31b6-519d-45a8-b665-28628f13a820 in datapath c4d87c85-fd68-4b2d-9a35-589e52c63ae7 bound to our chassis\nAug 14 14:52:10.012747 np0034942709 neutron-ovn-metadata-agent[38695]: INFO neutron.agent.ovn.metadata.agent [-] Provisioning metadata for network c4d87c85-fd68-4b2d-9a35-589e52c63ae7\n\nin this case we recived the network vif plugged event at \n\nAug 14 14:55:48.184821 np0034942709 nova-compute[40706]: DEBUG nova.compute.manager [req-b9e8cb9d-91d8-4bd8-bbcb-e4377ee958e1 req-c3fe16e1-80e7-40c2-bd31-bda31cd3a702 service nova] [instance: 5d5aa349-c689-465c-a13a-87a77a2c9198] Received event network-vif-plugged-883c31b6-519d-45a8-b665-28628f13a820 {{(pid\u003d40706) external_instance_event /opt/stack/nova/nova/compute/manager.py:11032}}\n\nit looks like the metadata agaent was started at \n\nAug 14 14:52:10.342046 np0034942709 neutron-ovn-metadata-agent[38695]: DEBUG neutron.agent.linux.utils [-] Running command (rootwrap daemon): [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, \u0027ovnmeta-c4d87c85-fd68-4b2d-9a35-589e52c63ae7\u0027, \u0027env\u0027, \u0027PROCESS_TAG\u003dhaproxy-c4d87c85-fd68-4b2d-9a35-589e52c63ae7\u0027, \u0027haproxy\u0027, \u0027-f\u0027, \u0027/opt/stack/data/neutron/ovn-metadata-proxy/c4d87c85-fd68-4b2d-9a35-589e52c63ae7.conf\u0027] {{(pid\u003d38695) execute_rootwrap_daemon /opt/stack/neutron/neutron/agent/linux/utils.py:108}}\n\nso in this case im not sure this is a race with that but its clear form the vm console log that this is a metadata issue and i have seen that more often on ovn based jobs so im not sure if this is a neutron bug or a node perforamnce issue.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbf1089314593b988a324af6cf4ed52812e5e977","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38b0d2eb_bb6bcca2","in_reply_to":"66b28c76_140761f8","updated":"2023-08-15 16:20:35.000000000","message":"the netowrking shoudl be ready before the vm boots that what the external events are for.\n\nso this should not actully need to rety at all normally\nso making the test wait longer is not really the issue.\n\nwhen we see this in ci we tend not to see later requests succeed.\n\nthat could be survior bias at play since we dont actuly check wehn the tests pass but i dont think waiting longer in this case woudl have helped.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"62bd226c3bcd5f7a4f00b62c12124928f320319d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66b28c76_140761f8","in_reply_to":"d2dbe717_d62dd033","updated":"2023-08-15 16:04:58.000000000","message":"\u003e failed 5/20: up 120.46. request failed\n\nSo the console log ends here, maybe the test just needs to wait longer? This was only attempt 5 out of 20.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"}],"nova/objects/flavor.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"628986cda4b65bc3810645675d18e7d79f542f97","unresolved":true,"context_lines":[{"line_number":270,"context_line":"        return flavor"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @staticmethod"},{"line_number":273,"context_line":"    def _flavor_get_query_from_db(context):"},{"line_number":274,"context_line":"        # We don\u0027t use a database context decorator on this method because this"},{"line_number":275,"context_line":"        # method is not executing a query, it\u0027s only building one."},{"line_number":276,"context_line":"        query \u003d context.session.query(api_models.Flavors).options("}],"source_content_type":"text/x-python","patch_set":1,"id":"b1184559_b8237a46","line":273,"range":{"start_line":273,"start_character":8,"end_line":273,"end_character":33},"updated":"2023-08-01 19:17:22.000000000","message":"the only test i can think to do is mock this and make it a spy and assert that before and after its called the connection and read context manager is still heald\n\nbut i am not sure how to do that and i dont nessisarly think we shoudl hold this on that.\n\nso if we figure out a way to test this in the future that is great.\nfor now colocating the decorator with the execution of the qury makes sense to me and ci seams to be green so i think we could proceed with this as is.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9b670c39ef1e9dfcd2f59c23c6ca1b3b051fb56f","unresolved":true,"context_lines":[{"line_number":320,"context_line":"        if not result:"},{"line_number":321,"context_line":"            raise exception.FlavorNotFound(flavor_id\u003dflavor_id)"},{"line_number":322,"context_line":"        return _dict_with_extra_specs(result)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @staticmethod"},{"line_number":325,"context_line":"    def _get_projects_from_db(context, flavorid):"},{"line_number":326,"context_line":"        return _get_projects_from_db(context, flavorid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e149a8b_80fbdedd","line":323,"updated":"2023-08-01 18:40:52.000000000","message":"Note to reviewers: I didn\u0027t include a test for this change because I couldn\u0027t think of a meaningful test for this. If you would like a test and have ideas what would be a good test, please let me know and maybe I could add something.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ef3b0c35547ee05a9fe5e052ac473dad88f5f3f2","unresolved":true,"context_lines":[{"line_number":320,"context_line":"        if not result:"},{"line_number":321,"context_line":"            raise exception.FlavorNotFound(flavor_id\u003dflavor_id)"},{"line_number":322,"context_line":"        return _dict_with_extra_specs(result)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @staticmethod"},{"line_number":325,"context_line":"    def _get_projects_from_db(context, flavorid):"},{"line_number":326,"context_line":"        return _get_projects_from_db(context, flavorid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6eb8d23_a1f1c7c5","line":323,"in_reply_to":"9214e33c_962bde0a","updated":"2023-08-14 13:32:31.000000000","message":"It\u0027s hard to test that decorators are applied because they\u0027re done at import time and thus before a test gets to run.","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"0b74f0ae347528f53afdf12e19ee19a66f8326c4","unresolved":true,"context_lines":[{"line_number":320,"context_line":"        if not result:"},{"line_number":321,"context_line":"            raise exception.FlavorNotFound(flavor_id\u003dflavor_id)"},{"line_number":322,"context_line":"        return _dict_with_extra_specs(result)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @staticmethod"},{"line_number":325,"context_line":"    def _get_projects_from_db(context, flavorid):"},{"line_number":326,"context_line":"        return _get_projects_from_db(context, flavorid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9214e33c_962bde0a","line":323,"in_reply_to":"9e149a8b_80fbdedd","updated":"2023-08-03 06:53:32.000000000","message":"will this help ?\nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_flavor.py#L73\ncalls\nhttps://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L377","commit_id":"9ae6240c92e212b2fa96d5163f68ef1b30ee03b7"}]}