)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d431b5cd463a9780e9dda0531eca09a59d2bd9cb","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Include multipath_id in BDM record for iSCSI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the multipath_id (which is also the SCSI WWID) is only"},{"line_number":10,"context_line":"included in case of Fibre Channel protocol[1]."},{"line_number":11,"context_line":"The multipath_id is also returned from the os-brick iSCSI connector[2]"},{"line_number":12,"context_line":"so it makes sense to include it in the nova BDM record."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"633d7228_38047b59","line":10,"updated":"2024-08-29 13:32:56.000000000","message":"oh just saw this again\n\nso it\u0027s with WWID that is stable once the device is exported right.\n\nif so then yes we could be able to store that.\n\nas long as this only change when we create a cidner attachment then its stable enouch to encode.","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e5f76fa44e50eaacac888826b5c5c1e3044c3e9","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Include multipath_id in BDM record for iSCSI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the multipath_id (which is also the SCSI WWID) is only"},{"line_number":10,"context_line":"included in case of Fibre Channel protocol[1]."},{"line_number":11,"context_line":"The multipath_id is also returned from the os-brick iSCSI connector[2]"},{"line_number":12,"context_line":"so it makes sense to include it in the nova BDM record."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"967d8506_a5d06f54","line":10,"in_reply_to":"633d7228_38047b59","updated":"2024-08-29 14:48:02.000000000","message":"this doesn\u0027t change for the lifetime of the volume/LUN so it\u0027s pretty stable.","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b8dd8d1d7d33760ca200dfd54b06631595151d59","unresolved":true,"context_lines":[{"line_number":18,"context_line":"AFTER"},{"line_number":19,"context_line":"connection_info: {\"driver_volume_type\": \"iscsi\", \"data\":"},{"line_number":20,"context_line":"{\"target_discovered\": false, ..., \"device_path\": \"/dev/dm-5\","},{"line_number":21,"context_line":"\"multipath_id\": \"3600140538f7bfe30f3e4440848e2475d\"}}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/fibrechannel.py#L58-L60"},{"line_number":24,"context_line":"[2] https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L541-L542"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8fe581_8b10af0f","line":21,"updated":"2024-08-29 13:30:05.000000000","message":"cant the multip path id change across reboot of the host?\n\nif so then including this would probably not be a good idea.\n\nin generaly we avoid storign extra info in the db just for debuging so what will this actully be used for.","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e5f76fa44e50eaacac888826b5c5c1e3044c3e9","unresolved":true,"context_lines":[{"line_number":18,"context_line":"AFTER"},{"line_number":19,"context_line":"connection_info: {\"driver_volume_type\": \"iscsi\", \"data\":"},{"line_number":20,"context_line":"{\"target_discovered\": false, ..., \"device_path\": \"/dev/dm-5\","},{"line_number":21,"context_line":"\"multipath_id\": \"3600140538f7bfe30f3e4440848e2475d\"}}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[1] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/fibrechannel.py#L58-L60"},{"line_number":24,"context_line":"[2] https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/iscsi.py#L541-L542"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e3a66838_09cb4825","line":21,"in_reply_to":"bf8fe581_8b10af0f","updated":"2024-08-29 14:48:02.000000000","message":"No, it won\u0027t. it is the SCSI WWID assigned to the LUN by the backend so for the life of the LUN/Volume, this will remain constant.\nWe already include it in FC and since both iSCSI and FC use SCSI devices, i think it makes sense to do it in iSCSI as well.\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/fibrechannel.py#L58-L60","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e5f76fa44e50eaacac888826b5c5c1e3044c3e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f32e5c6_45336517","updated":"2024-08-29 14:48:02.000000000","message":"Thanks Sean for the review.","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ace2b626ab798db0fa381e109b3220413f0f2dbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0fa32f3_9e7aa3a2","updated":"2024-08-30 00:27:19.000000000","message":"for context of others.\n\ni talked to rajat about this downstream\n\ni think an argument could be made to treat thsi as a whishlist bug \non the ground that without this information it can make debuging production problmes much harder.\n\nyou can in some instnace get the WWID form the libvirt xml if  the domain still exits. in some failure mode we can fail after we have deleted.\n\ncinder does not know the WWID generated for the volume attachment so you cannot simply use the volume id or attachment id to look up this info in the cinder db\nas only nova/osbrick knows it \n\n\nwhile i dont like storing info in the db (via the bdm) just for debuging im reluctantly open to this usecase.\n\nso if other agreee then i think it could be done as a whishlist bug.","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2a5fc44a6699322d3b07a355680876d33bb64606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d66d4068_e1ab7985","updated":"2024-07-10 12:21:46.000000000","message":"recheck for fresh logs","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a1bcf5ecfb80d7c7f9b3407526c5efecc3f2f892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d01caf7f_85bdb731","updated":"2023-08-01 06:50:10.000000000","message":"recheck nova-lvm job failed, unrelated test\n\ntempest.api.compute.servers.test_server_actions.ServerActionsTestOtherB","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f13c76982fde22eaf3c76ddae8c8612c237e7746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9775c87_cc200cbc","updated":"2023-07-27 04:46:06.000000000","message":"recheck nova-next failure in test tempest.scenario.test_stamp_pattern.TestStampPattern","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"38b66f0732ab76c27e1c664ccd9f25b4f273901d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e0ed10f_0580188f","updated":"2023-07-24 08:11:34.000000000","message":"recheck unrelated failure in nova-next","commit_id":"7f10f6ccb41e7f42cbbaf2dc9e8cb3d53bfad0a2"}]}