)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a66a5f4399c999a1aedd1b20272fdea3b78ce260","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52eaf1c9_73e4b9ce","updated":"2023-07-27 14:11:13.000000000","message":"Thanks, easy and helpful upgrade check. This one will be run at the correct release time, ie. after the compute_id automatic updates.","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"84492a243b31696667320f3f75b3464cfebdba39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"450eefe8_18fdd3e7","updated":"2023-08-08 13:31:34.000000000","message":"recheck dep failed","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c1d1a3d07437e128ef2b923b43a2fca878cbdbe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0d37dc1_7528095e","updated":"2023-08-14 21:00:21.000000000","message":"recheck dep merged","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"27c5c9f1eef25dbbffc1ebd7da98f1868d3c39d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"decf5638_fab8944d","updated":"2023-08-15 21:09:05.000000000","message":"recheck functional failure db cursor thing","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"57ec910587aff2218a44bf4e858117aaea066438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a267b03f_3a95d2a4","updated":"2023-08-16 16:16:11.000000000","message":"recheck guest kernel crash on volume test","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"76f07887296432b4bdb993ebd6e6f33dbd5da186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"793a4c6a_79ac45f9","updated":"2023-08-15 15:12:10.000000000","message":"recheck ssh timeout during volume test","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4a8c5669be6d2b00995795a2b132079d66b2317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"647774a7_5f73ae45","updated":"2023-08-16 13:36:14.000000000","message":"recheck ssh timeout to volume instance","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"}],"nova/cmd/status.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a66a5f4399c999a1aedd1b20272fdea3b78ce260","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        ctxt \u003d nova_context.get_admin_context()"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            cn_no_service \u003d main_db_api.compute_nodes_get_by_service_id("},{"line_number":287,"context_line":"                ctxt, None)"},{"line_number":288,"context_line":"        except exception.ServiceNotFound:"},{"line_number":289,"context_line":"            cn_no_service \u003d []"},{"line_number":290,"context_line":"        if cn_no_service:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6039916e_f4737679","line":287,"range":{"start_line":287,"start_character":22,"end_line":287,"end_character":26},"updated":"2023-07-27 14:11:13.000000000","message":"I don\u0027t really appreciate unnamed args when they pass \u0027None\u0027 and I prefer to signal that None here really means \"we want to check all the computes nodes with the exact record being None\" but I totally get your point and it\u0027s just me bikeshedding for the sake of other reviewers who could be confused 😄","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c980fc84220e212c8e336dd73df11fba202d6d77","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        ctxt \u003d nova_context.get_admin_context()"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            cn_no_service \u003d main_db_api.compute_nodes_get_by_service_id("},{"line_number":287,"context_line":"                ctxt, None)"},{"line_number":288,"context_line":"        except exception.ServiceNotFound:"},{"line_number":289,"context_line":"            cn_no_service \u003d []"},{"line_number":290,"context_line":"        if cn_no_service:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7d38e20c_ecdf3ac8","line":287,"range":{"start_line":287,"start_character":22,"end_line":287,"end_character":26},"in_reply_to":"6039916e_f4737679","updated":"2023-07-27 14:15:09.000000000","message":"It\u0027s not kwarg so passing the name isn\u0027t really correct, IMHO, regardless of the value. But, it\u0027s also just a status check and kindof an abuse of the low-level routine anyway. Regular code would use objects for this, but since this is a static check, we\u0027re doing something we wouldn\u0027t really do in production code anyway.","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b69c0be9da43b3a837ad82ff066b3146174a4cd0","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        ctxt \u003d nova_context.get_admin_context()"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            cn_no_service \u003d main_db_api.compute_nodes_get_by_service_id("},{"line_number":287,"context_line":"                ctxt, None)"},{"line_number":288,"context_line":"        except exception.ServiceNotFound:"},{"line_number":289,"context_line":"            cn_no_service \u003d []"},{"line_number":290,"context_line":"        if cn_no_service:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a29e0431_477b83cb","line":287,"range":{"start_line":287,"start_character":22,"end_line":287,"end_character":26},"in_reply_to":"7d38e20c_ecdf3ac8","updated":"2023-08-07 18:00:25.000000000","message":"i agree with dan here.\nhttps://github.com/openstack/nova/blob/master/nova/db/main/api.py#L664\nif its a postional arg, as it is in this case i woudl consider it bad pratic to invoke it as a keyword arg by nameing it service_id.\n\ni.e. while this works\n\nmain_db_api.compute_nodes_get_by_service_id(\n                context\u003dctxt, service_id\u003dNone\n)\n\ni consider that ot be bad pratice as those are not kwargs and they are not optional.\n\ninvoking them via the name implies they are optional and can make maintaining the code harder. \n\nif the parmatere were kwargs i would agree we shoudl not call them prositionally.","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b69c0be9da43b3a837ad82ff066b3146174a4cd0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            msg \u003d (_(\u0027Compute node objects without service_id linkage were \u0027"},{"line_number":292,"context_line":"                     \u0027found in the database. Ensure all non-deleted compute \u0027"},{"line_number":293,"context_line":"                     \u0027services have started with upgraded code.\u0027))"},{"line_number":294,"context_line":"            return upgradecheck.Result(upgradecheck.Code.FAILURE, msg)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        inst_no_compute \u003d main_db_api.instance_get_all_by_filters("},{"line_number":297,"context_line":"            ctxt, filters\u003d{\u0027compute_id\u0027: None}, limit\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3a3eaff_442f3515","line":294,"updated":"2023-08-07 18:00:25.000000000","message":"this is the check i was thining of when i asked for a nova status check","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b69c0be9da43b3a837ad82ff066b3146174a4cd0","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            msg \u003d (_(\u0027Non-deleted instances missing compute node linkage \u0027"},{"line_number":300,"context_line":"                     \u0027were found in the database. Online data migrations \u0027"},{"line_number":301,"context_line":"                     \u0027should be run.\u0027))"},{"line_number":302,"context_line":"            return upgradecheck.Result(upgradecheck.Code.FAILURE, msg)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ed538da3_4bff197c","line":302,"updated":"2023-08-07 18:00:25.000000000","message":"but your totally right we shoudl also be checkign this\n+1","commit_id":"27f384b7ac4f19ffaf884d77484814a220b2d51d"}]}