)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06d3658fe05f1253760057bfe1fff5bb62a1cdb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"2f4b0c8f_51594808","updated":"2024-02-13 17:59:42.000000000","message":"here are my nodes on the testing i did so far.\n\nhttps://hedgedoc.k8s.seanmooney.info/s/DUzCCtqSm#","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aef52f6afe7e5ceaa049c99b772d6b9523231202","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"271f9fe6_78f48482","updated":"2024-02-13 08:54:16.000000000","message":"im a little to tired after reviewing the rest of the series ot review this properly but over all i think this looks ok\n\nill rereview again tomrrow after i do some more local testing","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ce8b6dcfe54ce025883d29ca35ccccbc3111fec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"f88f8c1e_9e6a8bfd","updated":"2024-02-23 21:28:12.000000000","message":"recheck https://review.opendev.org/c/openstack/nova/+/909859 has merged","commit_id":"c3719abd658c6a277cffb5d4259f75ef9e4d894d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1f8eb6dc8e5e0d8476585bf007b791f436ced5bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"821c3045_b5d5d36e","updated":"2024-02-24 00:11:42.000000000","message":"recheck nova-ceph-multistore urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host\u003d\u0027158.69.72.136\u0027, port\u003d443): Read timed out. (read timeout\u003d60)","commit_id":"c3719abd658c6a277cffb5d4259f75ef9e4d894d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2dbfb878f90a4f17d8eaa4d047289bb1cec95c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"b52671ef_121b9a2e","updated":"2024-02-24 02:51:12.000000000","message":"recheck nova-lvm 2024-02-24 01:18:30,216 92829 WARNING  [urllib3.connectionpool] Retrying (Retry(total\u003d9, connect\u003dNone, read\u003dNone, redirect\u003d5, status\u003dNone)) after connection broken by \u0027ReadTimeoutError(\"HTTPSConnectionPool(host\u003d\u002710.209.128.224\u0027, port\u003d443): Read timed out. (read timeout\u003d60)\")\u0027: /compute/v2.1/os-keypairs/tempest-keypair-1675610207","commit_id":"c3719abd658c6a277cffb5d4259f75ef9e4d894d"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aef52f6afe7e5ceaa049c99b772d6b9523231202","unresolved":true,"context_lines":[{"line_number":5675,"context_line":"                            context, target, image_id, trusted_certs,"},{"line_number":5676,"context_line":"                            encryption\u003dencryption)"},{"line_number":5677,"context_line":"                    except NotImplementedError:"},{"line_number":5678,"context_line":"                        # TODO(melwitt): In Ceph v17 (Quincy) creating a cloned"},{"line_number":5679,"context_line":"                        # image with an encryption key different from its"},{"line_number":5680,"context_line":"                        # parent is not supported. Support should be available"},{"line_number":5681,"context_line":"                        # in v18 and when we can require \u003e\u003d v18 we can support"}],"source_content_type":"text/x-python","patch_set":33,"id":"d757560b_f0a6986d","line":5678,"updated":"2024-02-13 08:54:16.000000000","message":"it would be good to call this out in the relese note","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aef52f6afe7e5ceaa049c99b772d6b9523231202","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        info.source_path \u003d self.path"},{"line_number":190,"context_line":"        info.boot_order \u003d boot_order"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if disk_bus \u003d\u003d \u0027scsi\u0027:"},{"line_number":193,"context_line":"            self.disk_scsi(info, disk_unit)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        self.disk_qos(info, extra_specs)"}],"source_content_type":"text/x-python","patch_set":33,"id":"1ff6215a_d4cec397","line":192,"updated":"2024-02-13 08:54:16.000000000","message":"this is really just exiting code that was moved when disk_encryption was extracted","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dfb9129e8575c4e7e75dd4c91b3d32978e711abd","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        info.source_path \u003d self.path"},{"line_number":190,"context_line":"        info.boot_order \u003d boot_order"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if disk_bus \u003d\u003d \u0027scsi\u0027:"},{"line_number":193,"context_line":"            self.disk_scsi(info, disk_unit)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        self.disk_qos(info, extra_specs)"}],"source_content_type":"text/x-python","patch_set":33,"id":"73eff033_939d601f","line":192,"in_reply_to":"1ff6215a_d4cec397","updated":"2024-02-14 11:03:43.000000000","message":"Acknowledged","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aef52f6afe7e5ceaa049c99b772d6b9523231202","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"                src_fmt \u003d image_encryption.get(\u0027format\u0027)"},{"line_number":1167,"context_line":"            dest_fmt \u003d \u0027raw\u0027"},{"line_number":1168,"context_line":"            if bdm_encryption:"},{"line_number":1169,"context_line":"                dest_fmt \u003d bdm_encryption.get(\u0027format\u0027)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"            images.convert_image("},{"line_number":1172,"context_line":"                in_path, out_path, src_fmt, dest_fmt,"}],"source_content_type":"text/x-python","patch_set":33,"id":"4b724f25_1af24b06","line":1169,"updated":"2024-02-13 08:54:16.000000000","message":"this would be something like luks or plain right?","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dfb9129e8575c4e7e75dd4c91b3d32978e711abd","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"                src_fmt \u003d image_encryption.get(\u0027format\u0027)"},{"line_number":1167,"context_line":"            dest_fmt \u003d \u0027raw\u0027"},{"line_number":1168,"context_line":"            if bdm_encryption:"},{"line_number":1169,"context_line":"                dest_fmt \u003d bdm_encryption.get(\u0027format\u0027)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"            images.convert_image("},{"line_number":1172,"context_line":"                in_path, out_path, src_fmt, dest_fmt,"}],"source_content_type":"text/x-python","patch_set":33,"id":"418270d4_2868fbc4","line":1169,"in_reply_to":"157094ba_ab6e75db","updated":"2024-02-14 11:03:43.000000000","message":"didnt we already deprecte that or was it just fixed key and its still undeprecated if you use barbican\n——— later ———\ni guess it really isnt deprecated yet i tought we did that as part of this spec a few release ago\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#ephemeral-storage-encryption\n\ni think its imporant to do that this cycle as part of the slurp release.","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33f9a177e82161e5db758e097f20f1f1e3183d0d","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"                src_fmt \u003d image_encryption.get(\u0027format\u0027)"},{"line_number":1167,"context_line":"            dest_fmt \u003d \u0027raw\u0027"},{"line_number":1168,"context_line":"            if bdm_encryption:"},{"line_number":1169,"context_line":"                dest_fmt \u003d bdm_encryption.get(\u0027format\u0027)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"            images.convert_image("},{"line_number":1172,"context_line":"                in_path, out_path, src_fmt, dest_fmt,"}],"source_content_type":"text/x-python","patch_set":33,"id":"157094ba_ab6e75db","line":1169,"in_reply_to":"4b724f25_1af24b06","updated":"2024-02-14 08:10:35.000000000","message":"Right. In this series it\u0027s really only \u0027luks\u0027. And my understanding about \u0027plain\u0027 is that the intention was/is to change over the LVM ephemeral encryption that already exists to use this modeling, except with the \u0027plain\u0027 format. And to deprecate the existing \"legacy\" LVM ephemeral encryption modeling.","commit_id":"1132fbc367817ea21338b6718217b3d03b7c9ffa"}]}