)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5b0f42eb30c899c0a0961dac9d99c41a6f3d0a3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"682254f6_bfde839d","updated":"2024-01-30 12:28:21.000000000","message":"I don\u0027t get this patch. It adds a manila client feature but then it comments out the usage of that feature","commit_id":"54646d7703b7ec3f78251f0401784b653be15c0b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9d61755112ded058475595c12d2e8ecb209c18ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"70373c1d_f545c6c5","updated":"2024-08-26 19:05:40.000000000","message":"Hey, Rene! Again: thank you very much for working on this feature. There is a chance that I am confusing myself with the series, but left a suggestion inline :)","commit_id":"055519d663dab9182457c0902a8f6ccc67737795"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5b0f42eb30c899c0a0961dac9d99c41a6f3d0a3f","unresolved":true,"context_lines":[{"line_number":4604,"context_line":"            )"},{"line_number":4605,"context_line":""},{"line_number":4606,"context_line":"            if not check_access():"},{"line_number":4607,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4608,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4609,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4610,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"}],"source_content_type":"text/x-python","patch_set":4,"id":"28e7ab97_75266392","line":4607,"updated":"2024-01-30 12:28:21.000000000","message":"Do wee need the commented out code?\n\nAlso it seems to me this does not work in my env. See my comment https://review.opendev.org/c/openstack/nova/+/881472/12#message-dcf67178947096e308f745c8ef199ae1e9f3ad28","commit_id":"54646d7703b7ec3f78251f0401784b653be15c0b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"0c303c26d704b8d00ac1050850915e8c23241065","unresolved":true,"context_lines":[{"line_number":4604,"context_line":"            )"},{"line_number":4605,"context_line":""},{"line_number":4606,"context_line":"            if not check_access():"},{"line_number":4607,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4608,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4609,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4610,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"}],"source_content_type":"text/x-python","patch_set":4,"id":"e0da6dc4_75b58e7a","line":4607,"in_reply_to":"28e7ab97_75266392","updated":"2024-02-16 15:59:22.000000000","message":"Regarding the behavior that should be fixed.\nRegarding the comment I would say yes but it needs to be updated as restrict_visibility and restrict_deletion have been replaced.","commit_id":"54646d7703b7ec3f78251f0401784b653be15c0b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"6b44dc0b687e06f3defc6cf9ac556a38ba7b57d1","unresolved":false,"context_lines":[{"line_number":4604,"context_line":"            )"},{"line_number":4605,"context_line":""},{"line_number":4606,"context_line":"            if not check_access():"},{"line_number":4607,"context_line":"                # self.manila_api.lock(share_mapping.share_id)"},{"line_number":4608,"context_line":"                # Explicitly locking the share is not needed as"},{"line_number":4609,"context_line":"                # create_access_rule() from the sdk will do it if the"},{"line_number":4610,"context_line":"                # restrict_visibility and restrict_deletion flags are passed"}],"source_content_type":"text/x-python","patch_set":4,"id":"23bb4dc3_f5e73978","line":4607,"in_reply_to":"e0da6dc4_75b58e7a","updated":"2024-02-28 14:54:54.000000000","message":"Done","commit_id":"54646d7703b7ec3f78251f0401784b653be15c0b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5b0f42eb30c899c0a0961dac9d99c41a6f3d0a3f","unresolved":true,"context_lines":[{"line_number":4661,"context_line":"            )"},{"line_number":4662,"context_line":""},{"line_number":4663,"context_line":"            if not still_used:"},{"line_number":4664,"context_line":"                # self.manila_api.unlock(share_mapping.share_id)"},{"line_number":4665,"context_line":"                # Explicit unlocking the share is not needed as"},{"line_number":4666,"context_line":"                # delete_access_rule() from the sdk will do it if the"},{"line_number":4667,"context_line":"                # unrestrict parameter is passed"}],"source_content_type":"text/x-python","patch_set":4,"id":"ed14419e_23137412","line":4664,"updated":"2024-01-30 12:28:21.000000000","message":"ditto","commit_id":"54646d7703b7ec3f78251f0401784b653be15c0b"}],"nova/share/manila.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"421481e2085de21ef4695377e1298015084506b8","unresolved":true,"context_lines":[{"line_number":347,"context_line":"        else:"},{"line_number":348,"context_line":"            raise exception.ShareAccessNotFound(share_id\u003dshare_id)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def get_lock(self, share_id):"},{"line_number":351,"context_line":"        \"\"\"Get share lock"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        :param share_id: the id of the share to get"}],"source_content_type":"text/x-python","patch_set":8,"id":"08e19336_5d69873b","line":350,"updated":"2024-02-28 13:48:20.000000000","message":"are these used or we only use allow and deny? As far as I see these are unused and therefore can be dropped. Or will they be used in the near future?","commit_id":"39b07aa38f1de7f65b7e89cd89308ac2c734e9f6"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d0ca415174222da5da29bbe6dc0efcb2b1af5422","unresolved":true,"context_lines":[{"line_number":347,"context_line":"        else:"},{"line_number":348,"context_line":"            raise exception.ShareAccessNotFound(share_id\u003dshare_id)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def get_lock(self, share_id):"},{"line_number":351,"context_line":"        \"\"\"Get share lock"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        :param share_id: the id of the share to get"}],"source_content_type":"text/x-python","patch_set":8,"id":"fdd9770b_1e6ffa28","line":350,"in_reply_to":"08e19336_5d69873b","updated":"2024-03-11 15:46:25.000000000","message":"You are right there are not used. I kept them as maybe they will be used.","commit_id":"39b07aa38f1de7f65b7e89cd89308ac2c734e9f6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"421481e2085de21ef4695377e1298015084506b8","unresolved":true,"context_lines":[{"line_number":365,"context_line":"        for lock in lock_generator:"},{"line_number":366,"context_line":"            if ("},{"line_number":367,"context_line":"                lock.resource_type \u003d\u003d \u0027share\u0027 and"},{"line_number":368,"context_line":"                lock.lock_reason \u003d\u003d \u0027nova lock\u0027"},{"line_number":369,"context_line":"            ):"},{"line_number":370,"context_line":"                lock_list.append(lock)"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"2e4674b3_557084b6","line":368,"updated":"2024-02-28 13:48:20.000000000","message":"this is not matching with reason passed by allow(), so lets add a constant for that reason","commit_id":"39b07aa38f1de7f65b7e89cd89308ac2c734e9f6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"421481e2085de21ef4695377e1298015084506b8","unresolved":true,"context_lines":[{"line_number":392,"context_line":"                manilaclient().create_resource_lock("},{"line_number":393,"context_line":"                    resource_id\u003dshare_id,"},{"line_number":394,"context_line":"                    resource_type\u003d\"share\","},{"line_number":395,"context_line":"                    lock_reason\u003d\"nova lock\","},{"line_number":396,"context_line":"                )"},{"line_number":397,"context_line":"            )"},{"line_number":398,"context_line":"            return lock"}],"source_content_type":"text/x-python","patch_set":8,"id":"560c743a_8dbcd79e","line":395,"updated":"2024-02-28 13:48:20.000000000","message":"ditto","commit_id":"39b07aa38f1de7f65b7e89cd89308ac2c734e9f6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9d61755112ded058475595c12d2e8ecb209c18ac","unresolved":true,"context_lines":[{"line_number":308,"context_line":"            access_level\u003daccess_level,"},{"line_number":309,"context_line":"            lock_visibility\u003dTrue,"},{"line_number":310,"context_line":"            lock_deletion\u003dTrue,"},{"line_number":311,"context_line":"            lock_reason\u003d\"Lock by nova\","},{"line_number":312,"context_line":"        )"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        access \u003d Access.from_manila_access(access)"}],"source_content_type":"text/x-python","patch_set":12,"id":"d562fbb3_e9f6a535","line":311,"range":{"start_line":311,"start_character":24,"end_line":311,"end_character":38},"updated":"2024-08-26 19:05:40.000000000","message":"I was thinking that maybe we can have a lock reason that adds a bit more of details here? Not asking for a lot of details, of course we don\u0027t want to \"leak\" info, but would be nice to have at least the mapping id","commit_id":"055519d663dab9182457c0902a8f6ccc67737795"}]}