)]}'
{"id":"openstack%2Fnova~891","triplet_id":"openstack%2Fnova~master~Ifb6a5799666e83cf7efbfd0d40e1b2c899c40cb8","project":"openstack/nova","branch":"master","topic":"bug/83351","hashtags":[],"change_id":"Ifb6a5799666e83cf7efbfd0d40e1b2c899c40cb8","subject":"Check to see LXC container can actually run properly on a host before starting. Fixes LP: 83351","status":"ABANDONED","created":"2011-10-14 18:07:53.000000000","updated":"2011-11-24 18:11:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0f13d343a31d98d3b4827a26387ca2ff20fa1c9a","_number":891,"virtual_id_number":891,"owner":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"all":[{"value":-1,"date":"2011-10-31 17:51:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":-1,"date":"2011-10-14 19:06:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-10-14 19:06:13.000000000","updated_by":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"reviewer":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"state":"REVIEWER"},{"updated":"2011-10-31 17:51:13.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"}],"messages":[{"id":"87a09a5c0312b1dc31e71772293ebbcd5ac96264","author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"date":"2011-10-14 19:06:13.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nHi Chuck,\n  A few comments.\na.) I believe you typo\u0027d the bug number.  I believe this fixes bug 833519, not bug 83351.\nb.) i believe that your check to account for i386 on x86_64  will never run.\n   The path for \u0027if host_arch !\u003d guest_arch\u0027 will be taken, won\u0027t it?\nc.) LOG.info is a bit noisy for this obviouss debug code.\n   I\u0027d suggest a single log.debug message and a log.warn on failure.\nd.) maybe rename your method \u0027_get_lxc_host_info\u0027 as thats not really what it is doing.  Its really checking if this instance will runon this libvirt.","accounts_in_message":[],"_revision_number":1},{"id":"3ef6497994babc64959e9f9a0eb37adacf98ae25","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2011-10-31 17:51:13.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nThe second part of that branch definitely won\u0027t run, and I agree the name isn\u0027t aligned with the implementation.\n\nI don\u0027t know that I agree the logging is too noisy\n\nFinally, unit tests?","accounts_in_message":[],"_revision_number":1},{"id":"680077c180c58f8a2c26cc351120851914bee69d","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2011-11-24 18:11:40.000000000","message":"Patch Set 1: Abandoned\n\nthis no longer applies for libvirt 0.9.7 due to console changes","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6e11baa0711373e886943b72c69c52745387503b","revisions":{"6e11baa0711373e886943b72c69c52745387503b":{"kind":"REWORK","_number":1,"created":"2011-10-14 18:07:53.000000000","uploader":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"ref":"refs/changes/91/891/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/91/891/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/891/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/891/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/891/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/91/891/1"}}},"commit":{"parents":[{"commit":"52b5611a863bd59102a492237f9cd7049c2908c2","subject":"Merge \"Added vcpu_weight to models.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/52b5611a863bd59102a492237f9cd7049c2908c2"}]}],"author":{"name":"Chuck Short","email":"chuck.short@canonical.com","date":"2011-10-14 18:06:21.000000000","tz":-240},"committer":{"name":"Chuck Short","email":"chuck.short@canonical.com","date":"2011-10-14 18:06:21.000000000","tz":-240},"subject":"Check to see LXC container can actually run properly on a host before starting. Fixes LP: 83351","message":"Check to see LXC container can actually run properly on a host before starting.\nFixes LP: 83351\n\nChange-Id: Ifb6a5799666e83cf7efbfd0d40e1b2c899c40cb8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6e11baa0711373e886943b72c69c52745387503b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6e11baa0711373e886943b72c69c52745387503b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"52b5611a863bd59102a492237f9cd7049c2908c2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}