)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"56f5ceaa817623df249e1757aec3da0f25ceece9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This makes us use the new method if available, and if not, fall back"},{"line_number":10,"context_line":"to the old method."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If52ac05a02b69476bd2cfa74a7ee800c3f6eeb20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"6212ad3d_346ed089","line":12,"updated":"2025-04-22 18:16:05.000000000","message":"do we have a tracker for this?\nblueprint or bug?","commit_id":"c3a53d0900a2321f473789dc1c428da4ca903d09"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"c5e839bc8dbad5beb3f0c34d05d5d5ee4ecd1101","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"87d74057_9b47746f","updated":"2023-08-31 10:54:42.000000000","message":"recheck","commit_id":"3d93de5e3617856a290292bbb168c3226e901797"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"351287b88f6e72e4160d04c27cac6b7e900a900a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0faf4292_f38dd03a","updated":"2023-08-16 16:42:43.000000000","message":"recheck ceph job timed out with tons of failures but no OOM","commit_id":"3d93de5e3617856a290292bbb168c3226e901797"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4760b609e6c78077fb199a45b99a5069271dccb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6fb16e54_009f803e","updated":"2023-08-16 13:45:17.000000000","message":"recheck deps changed","commit_id":"3d93de5e3617856a290292bbb168c3226e901797"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"2847fc8b5da7b9c15bbd41efcbb3f2be8d4c94ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"049df00b_19d2c2e2","updated":"2023-10-27 10:44:56.000000000","message":"recheck deps changed","commit_id":"95cc13bdc1ac54ddec1fe65bb2b9075bcf2ca3ab"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b4ae8eb4c6da6174b1a61935665feca5f70ab742","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4fccef4a_e3610f04","updated":"2023-10-26 20:04:51.000000000","message":"recheck hang during devstack setup. not likely related, but will see after another run","commit_id":"95cc13bdc1ac54ddec1fe65bb2b9075bcf2ca3ab"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"7180c12ba79830860d622c24b81bcf7b0f571c9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8348cb62_031370eb","updated":"2024-02-20 10:28:38.000000000","message":"recheck deps updated","commit_id":"138fa682000c5f9b42710f6039a00964f531033b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"14e7bb5171a999c8b5887bb3220e7e1279c82966","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1a127bc2_9bfd8fcd","updated":"2024-01-16 14:53:48.000000000","message":"recheck unrelated timeout","commit_id":"138fa682000c5f9b42710f6039a00964f531033b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"93e41798cda8c8646aa8d00aa7719800c045a881","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b9898561_0a72c54f","updated":"2024-02-23 11:29:23.000000000","message":"looks like the glance code is not merged yet so this is proably punted to next cycle at this point.","commit_id":"670676cb8b1fc255a5e2cfe4410baf684ad08f21"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"15c990cd171eac3887228c348a78f21218b04586","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"25a131b4_a0c78fad","updated":"2024-07-25 13:49:52.000000000","message":"recheck","commit_id":"670676cb8b1fc255a5e2cfe4410baf684ad08f21"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"3a6f10162b226c15e17c1aaac2ea0b311f7b99f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"69d0dbcd_c63f262a","updated":"2024-07-10 07:52:49.000000000","message":"recheck","commit_id":"670676cb8b1fc255a5e2cfe4410baf684ad08f21"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"df0833b12367131cb5bb2273129b1850692f6bc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"674a9b2a_19e43db8","updated":"2024-04-18 10:46:35.000000000","message":"recheck deps updated","commit_id":"670676cb8b1fc255a5e2cfe4410baf684ad08f21"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"355354251913b5af033ac6c9faa5de395a30c6aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0b141a72_d879312c","updated":"2024-08-29 20:29:05.000000000","message":"Pranali, seems like this failure might be related to the location stuff?","commit_id":"055e8861849248b51270e343eaa7adb9b2def1e9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a5d12dbc2252dd9af06b68cf0bea58dcad4cb58c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fc459345_131eae6f","updated":"2024-12-18 14:49:37.000000000","message":"recheck the tempest patch is merged","commit_id":"055e8861849248b51270e343eaa7adb9b2def1e9"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"a2632b97726ece828eb3694fbd0f9ade4da0fb20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1903b947_1286bae9","in_reply_to":"0b141a72_d879312c","updated":"2024-08-30 08:46:53.000000000","message":"Yes, this tempest fix should resolve this failure now\nhttps://review.opendev.org/c/openstack/tempest/+/927575","commit_id":"055e8861849248b51270e343eaa7adb9b2def1e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e476e48bb2bc61b759f4456ccce56c0df9f3b3ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6505d5f5_9e960294","updated":"2025-04-21 14:10:17.000000000","message":"Sean and Melanie, I think this is ready to be reviewed now, based on the success of the DNM above.","commit_id":"c3a53d0900a2321f473789dc1c428da4ca903d09"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"607d74a76a67d873f821b638d7f1991b8babec87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ffbffce5_45853500","updated":"2025-04-21 14:27:52.000000000","message":"Do we need release note for this?","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"56633af11196edde83cfa79aa527aff839b3653f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"bea6691b_9ca9108f","updated":"2025-04-21 16:49:51.000000000","message":"Looks good, thank you!!","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"56f5ceaa817623df249e1757aec3da0f25ceece9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"b0c5e520_f2896c17","updated":"2025-04-22 18:16:05.000000000","message":"i dont have time to reivew the zuul logs todayb but based on your repsonce on the DNM it sould like this is mostly ready to go. do we want to add a release note to advertise that nova now supports this?\n\ni have not looked at our docs to see if we have a glance section but beyond installing a version that meets our requirement i dont think there is anything for an admin to configure specially for this on the nova side.\n\nso out side of a release to tell people they shoudl upgde glance ot fully take advantage of this there  is not doc change needed correct?\n\nobviously if your still deploying 2 copies fo glance and using the old way to look up the location you don\u0027t have to do that any more but that\u0027s out os scope of nova install guide so just wondering if there is anything left in this series?\n\nlooking at https://review.opendev.org/q/topic:%22New-Location-Apis%22+status:open\ni don\u0027t see anything proposed on the nova side.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6a7297922e66f29fd09586b0c6ddc5dcc1804f9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"56d9b310_7c2fa291","updated":"2025-04-24 17:13:25.000000000","message":"sorry didnt get back to this yesterday. i see sylvian has had time to review since then so i guess this is good to go","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5efa4303f42a0b8514a369cf296fd3fdefe4fd3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"74435cc9_9df8b801","updated":"2025-04-22 12:27:59.000000000","message":"this looks mostly ok. some testing question inline but nothing major","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"df05172a4336c1a18db7f6767ed6b0957640b661","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"faa3df11_d477c4c1","in_reply_to":"b0c5e520_f2896c17","updated":"2025-04-22 18:20:50.000000000","message":"Abhi asked that above and I said I didn\u0027t think we needed one because it\u0027s totally invisible to users and basically invisible to operators. If you think it\u0027s really important, then we can, but it\u0027s a very small change that most people will not notice. I also think we don\u0027t really need a blueprint or bug for this because it\u0027s just parity. I can tag the glance blueprint if you think it\u0027s really worth respinning and the CI time, but I think it\u0027s probably not very important :)","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5a4f54ad3d90c4751ebcdccde8b5d02ea8a716d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"69d4e0f3_0c4ac073","in_reply_to":"faa3df11_d477c4c1","updated":"2025-04-22 18:25:02.000000000","message":"no i was more trying to figure out if \"this is done\" i.e. we could merge this in nova and not need any follow ups\n\nor if there was more to come.\nwithout a bluepirnt or simialr it was had to tell the scope just looking at this in isolation.\n\nif  we are happy to proceed with this in general and dont expect to call this out in the release note prelude or release notes in genral as a minor feature we  dont need to respin.\n\ni woudl like to look at the ci logs just to see this working before i move to +2 i just wont have time to do that today.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"89e95e104d84eb36708f094b41d1020f166d9191","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c01f15c6_d0b350c9","in_reply_to":"ffbffce5_45853500","updated":"2025-04-21 15:40:14.000000000","message":"I don\u0027t think we need one because it should be invisible to everyone. It still works with old glance, and also with new.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"}],"nova/image/glance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"25b9498f0e546f336b6c3cfa46cd84bcefc9afea","unresolved":true,"context_lines":[{"line_number":564,"context_line":"            try:"},{"line_number":565,"context_line":"                return self._client.call("},{"line_number":566,"context_line":"                    context, 2, method, args\u003d(image_id, location, {}))"},{"line_number":567,"context_line":"            except glanceclient.exc.HTTPNotImplemented:"},{"line_number":568,"context_line":"                LOG.debug(\u0027Glance method %s not available\u0027, method)"},{"line_number":569,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":570,"context_line":"                exc \u003d e"}],"source_content_type":"text/x-python","patch_set":7,"id":"70503555_132cb605","line":567,"updated":"2023-11-03 14:35:45.000000000","message":"Will this happen with old glance? When I tested it (it\u0027s been a while now), the old glance returned 404 for the URL that doesn\u0027t exist before the feature is added. Did you add some translation in the glanceclient to make it NotImplemented?","commit_id":"cf7e3f6bd6d70e963057e9db0094e4e1f3a36fd0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ae5e34b32327416be12f78e99771b186018984a8","unresolved":false,"context_lines":[{"line_number":564,"context_line":"            try:"},{"line_number":565,"context_line":"                return self._client.call("},{"line_number":566,"context_line":"                    context, 2, method, args\u003d(image_id, location, {}))"},{"line_number":567,"context_line":"            except glanceclient.exc.HTTPNotImplemented:"},{"line_number":568,"context_line":"                LOG.debug(\u0027Glance method %s not available\u0027, method)"},{"line_number":569,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":570,"context_line":"                exc \u003d e"}],"source_content_type":"text/x-python","patch_set":7,"id":"e95822e1_085f8554","line":567,"in_reply_to":"3b6c5116_a230ad53","updated":"2024-08-29 14:49:42.000000000","message":"Ack, ya the glance lcinet patch did add that.\n\nill mark this as resolved to make the review simpler","commit_id":"cf7e3f6bd6d70e963057e9db0094e4e1f3a36fd0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"741d9c501ef8f9af3b955acf15f32c6efd21f74b","unresolved":true,"context_lines":[{"line_number":564,"context_line":"            try:"},{"line_number":565,"context_line":"                return self._client.call("},{"line_number":566,"context_line":"                    context, 2, method, args\u003d(image_id, location, {}))"},{"line_number":567,"context_line":"            except glanceclient.exc.HTTPNotImplemented:"},{"line_number":568,"context_line":"                LOG.debug(\u0027Glance method %s not available\u0027, method)"},{"line_number":569,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":570,"context_line":"                exc \u003d e"}],"source_content_type":"text/x-python","patch_set":7,"id":"3b6c5116_a230ad53","line":567,"in_reply_to":"70503555_132cb605","updated":"2023-11-03 14:39:27.000000000","message":"Ah yep, I see:\n\nhttps://review.opendev.org/c/openstack/python-glanceclient/+/890634/10/glanceclient/v2/images.py#571","commit_id":"cf7e3f6bd6d70e963057e9db0094e4e1f3a36fd0"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"2dcc1e8486ab94a6688b4ef225424be857e5949c","unresolved":true,"context_lines":[{"line_number":569,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":570,"context_line":"                exc \u003d e"},{"line_number":571,"context_line":"                _reraise_translated_exception()"},{"line_number":572,"context_line":"        raise exc"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":575,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":8,"id":"096a697d_19640ef9","line":572,"updated":"2023-12-07 13:07:54.000000000","message":"It looks to me like we would never get here, because _reraise_translated_exception() would already bring us out of this function.","commit_id":"cf3e519c9789085e85cc55fa1b2937e6f135cec6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ae5e34b32327416be12f78e99771b186018984a8","unresolved":true,"context_lines":[{"line_number":569,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":570,"context_line":"                exc \u003d e"},{"line_number":571,"context_line":"                _reraise_translated_exception()"},{"line_number":572,"context_line":"        raise exc"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":575,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":8,"id":"a1d28daf_f8d079b0","line":572,"in_reply_to":"096a697d_19640ef9","updated":"2024-08-29 14:49:42.000000000","message":"we get here if its a HTTPNotImplemented error and this returns None.\n\nim not entirly sure if that is intentional but there is a code path that returns this.","commit_id":"cf3e519c9789085e85cc55fa1b2937e6f135cec6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e476e48bb2bc61b759f4456ccce56c0df9f3b3ae","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":570,"context_line":"                exc \u003d e"},{"line_number":571,"context_line":"                _reraise_translated_exception()"},{"line_number":572,"context_line":"        raise exc"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":575,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":8,"id":"89297a27_3557f2f6","line":572,"in_reply_to":"66f77f82_3d86b272","updated":"2025-04-21 14:10:17.000000000","message":"Done","commit_id":"cf3e519c9789085e85cc55fa1b2937e6f135cec6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6151cc95862039f6d2b94a3f4bb3c2a83c84ca7b","unresolved":true,"context_lines":[{"line_number":569,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":570,"context_line":"                exc \u003d e"},{"line_number":571,"context_line":"                _reraise_translated_exception()"},{"line_number":572,"context_line":"        raise exc"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":575,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":8,"id":"66f77f82_3d86b272","line":572,"in_reply_to":"a1d28daf_f8d079b0","updated":"2024-08-29 15:02:44.000000000","message":"I think line 572 was supposed to have `as exc` on it so we would return that if it was the last exception. However, it really shouldn\u0027t be possible since the old `add_location` call should never return `HTTPNotImplemented`. I\u0027ll change this up after we get a test run in this new configuration.","commit_id":"cf3e519c9789085e85cc55fa1b2937e6f135cec6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5efa4303f42a0b8514a369cf296fd3fdefe4fd3f","unresolved":true,"context_lines":[{"line_number":575,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":576,"context_line":"                exc \u003d e"},{"line_number":577,"context_line":"                _reraise_translated_exception()"},{"line_number":578,"context_line":"        raise exc"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":581,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":19,"id":"48085f73_1cd4077e","line":578,"updated":"2025-04-22 12:27:59.000000000","message":"my only reservation, well ok i dont supper like the try approch but i get why your doing it, is this is one more method for use to port to the sdk.\n\nwe likely should start making progress on that this cycle ,but it would be unreasonable to ask you to do that here so im ok with this for now.\n\nwhen we do swap to the sdk do you think it would be reasonable to only use the new location api. my personal feeling is we should likely keep this fallback until the last verion of glance that does nto support moves to unmaintained/eol\n\nwoudl you mind adding a TODO to remove the fallback when that happens if you respin?","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4fbec1cf5a091c45574b623a0919c63f3998061","unresolved":true,"context_lines":[{"line_number":575,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":576,"context_line":"                exc \u003d e"},{"line_number":577,"context_line":"                _reraise_translated_exception()"},{"line_number":578,"context_line":"        raise exc"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":581,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":19,"id":"62d714e1_3d237f81","line":578,"in_reply_to":"48085f73_1cd4077e","updated":"2025-04-22 14:55:45.000000000","message":"Well, tbh, I\u0027m not really sure on what timeline we should remove it. Like, it\u0027s fine to keep using an old glance for a long time. RAX historically didn\u0027t upgrade glance nearly as often as nova. Given how small this change is, I don\u0027t really see any reason why we\u0027d need to remove it any time soon. We\u0027d just be breaking compatibility to remove like six extra lines of code. I would think the *earliest* I\u0027d want to do that is when the version of glance that _removed_ the old API goes unmaintained, but even then it seems not that important.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df4787cdeffaca243482d9e48912ec7c7876f66a","unresolved":false,"context_lines":[{"line_number":575,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":576,"context_line":"                exc \u003d e"},{"line_number":577,"context_line":"                _reraise_translated_exception()"},{"line_number":578,"context_line":"        raise exc"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":581,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":19,"id":"bdbb0328_4b25b584","line":578,"in_reply_to":"62d714e1_3d237f81","updated":"2025-04-22 17:54:15.000000000","message":"Ack thats fair. ill mark this resovled.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f858bf5cc2ecf76911017f1d010b299af96a3e82","unresolved":false,"context_lines":[{"line_number":575,"context_line":"            except glanceclient.exc.HTTPBadRequest as e:"},{"line_number":576,"context_line":"                exc \u003d e"},{"line_number":577,"context_line":"                _reraise_translated_exception()"},{"line_number":578,"context_line":"        raise exc"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _add_image_member(self, context, image_id, member_id):"},{"line_number":581,"context_line":"        \"\"\"Grant access to another project that does not own the image"}],"source_content_type":"text/x-python","patch_set":19,"id":"88d388e9_e20bde4e","line":578,"in_reply_to":"bdbb0328_4b25b584","updated":"2025-04-24 15:50:48.000000000","message":"This is a fine pattern for me given tuples are ordered in Python.\nWe could nitpick in the fact we could have a little bit commented more why we do this, but that\u0027s fine.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"}],"nova/tests/unit/image/test_glance.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5efa4303f42a0b8514a369cf296fd3fdefe4fd3f","unresolved":true,"context_lines":[{"line_number":1784,"context_line":"        self.assertEqual(mock.sentinel.trans_from, image_meta)"},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"    def test_create_success_v2_with_location_old_api(self):"},{"line_number":1787,"context_line":"        self.test_create_success_v2_with_location(old_api\u003dTrue)"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"    def test_create_success_v2_with_location_no_api(self):"},{"line_number":1790,"context_line":"        self.test_create_success_v2_with_location(old_api\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":19,"id":"f1fb944d_72a0d7af","line":1787,"updated":"2025-04-22 12:27:59.000000000","message":"nit: this is \n\n self.test_create_success_v2_with_location(old_api\u003dTrue,new_api\u003dTrue)\n \ndue to the implict default.\n \nwould that be clearer?\n\n\nfollowup question.\nalso i notice that you are testing \n\nold\u003dFalse,new\u003dtrue\nold\u003dfalse,new\u003dfalse\nold\u003dtrue, new\u003dture\n\nwe are missing old\u003dtrue, new\u003dfalse\n\nshould we also add that since that is any cloud that is configure with the less secure api that has not upgrade glance to support the new api which woudl be say master nova runing with caracal? glance.\n\ni don\u0027t know if we have any non-unmaintained branches that don\u0027t support the new api. i.e. epoxy i belive does supprot the new api but im not sure if 2025.1,  2024.2 and 2024.1 all supprot it?","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df4787cdeffaca243482d9e48912ec7c7876f66a","unresolved":false,"context_lines":[{"line_number":1784,"context_line":"        self.assertEqual(mock.sentinel.trans_from, image_meta)"},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"    def test_create_success_v2_with_location_old_api(self):"},{"line_number":1787,"context_line":"        self.test_create_success_v2_with_location(old_api\u003dTrue)"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"    def test_create_success_v2_with_location_no_api(self):"},{"line_number":1790,"context_line":"        self.test_create_success_v2_with_location(old_api\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":19,"id":"a2be257f_10b82d7b","line":1787,"in_reply_to":"2b9040a9_54da022d","updated":"2025-04-22 17:54:15.000000000","message":"no need to update. if you are respining for somethign else you can make it explict but your right, the precendnce does mean that `old\u003dtrue,new\u003dtrue is the same as old\u003dtrue,new\u003dfalse` so im happy with the test coverage in that case.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d4fbec1cf5a091c45574b623a0919c63f3998061","unresolved":true,"context_lines":[{"line_number":1784,"context_line":"        self.assertEqual(mock.sentinel.trans_from, image_meta)"},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"    def test_create_success_v2_with_location_old_api(self):"},{"line_number":1787,"context_line":"        self.test_create_success_v2_with_location(old_api\u003dTrue)"},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"    def test_create_success_v2_with_location_no_api(self):"},{"line_number":1790,"context_line":"        self.test_create_success_v2_with_location(old_api\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":19,"id":"2b9040a9_54da022d","line":1787,"in_reply_to":"f1fb944d_72a0d7af","updated":"2025-04-22 14:55:45.000000000","message":"old\u003dtrue,new\u003dtrue is the same as old\u003dtrue,new\u003dfalse since the old flag takes precedence in the test code. Thus I don\u0027t think adding another one will change it here since we\u0027re mocking everything out.\n\nI think epoxy is the first version to support the new API, if I\u0027m not mistaken, so grenade skip level should be testing old glance with new nova.\n\nI can change the above to be an explicit call for each of the flags if you prefer, sure.","commit_id":"eab0de290099fedf1119e9056c5f86b52c8e58fb"}]}