)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06f908cfa491230189da9697c64aa90efddd37d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bda5ea16_e1756900","updated":"2023-08-14 11:33:59.000000000","message":"mostly style nits.","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"0b26f51037dfea95964813839216b413b09b5a73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0bfcad4f_3be71370","updated":"2024-01-08 11:09:56.000000000","message":"recheck old logs are gone","commit_id":"b0d2d811e358f91721af675b49c655ac91d4e549"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ecf87ed13bc814824d9872553dc3bbdbdc61678a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8c5f6b62_6d5ce3cd","updated":"2024-02-29 12:18:38.000000000","message":"As Sean notes, this needs a new RPC API version","commit_id":"3858c2371b08c58c6194a24837f22d1d5dcf0204"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0224862352e039106f1537fcbde3fd0435d0097c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"61f1bee9_9599b1c9","updated":"2024-02-23 12:19:52.000000000","message":"the rpc breakage is still not fixed","commit_id":"3858c2371b08c58c6194a24837f22d1d5dcf0204"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"53055b764a5f2e3c617b3df24947b380cc7cd61b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dac09c2a_03c24f85","in_reply_to":"61f1bee9_9599b1c9","updated":"2024-02-29 19:57:01.000000000","message":"done","commit_id":"3858c2371b08c58c6194a24837f22d1d5dcf0204"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"53055b764a5f2e3c617b3df24947b380cc7cd61b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"45fbb856_8bb0a5f0","in_reply_to":"8c5f6b62_6d5ce3cd","updated":"2024-02-29 19:57:01.000000000","message":"done","commit_id":"3858c2371b08c58c6194a24837f22d1d5dcf0204"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ec6e1b88c8b984f94a28c68e47a7f06da7e39e83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"26d9d1bd_4f557a30","updated":"2024-03-14 09:03:58.000000000","message":"After some discussion upstream, the consensus is to merge this on that cycle as it\u0027s a SLURP release. Let\u0027s give it a shot now.","commit_id":"dc6dac360c8ab026897d1f4bc04f30e5bd8a9998"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f66f5c0f57c83bea4cf3e6e5e68386da459261e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e0bd4613_9bbeb345","updated":"2024-03-05 17:58:30.000000000","message":"This is late in teh cycle to do this but since it cant be backported im inclined to sway we shoudl incldue htis for rc1.\n\ni am intetionally not setting +w as i want sylvain to weigh in on that","commit_id":"dc6dac360c8ab026897d1f4bc04f30e5bd8a9998"}],"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06f908cfa491230189da9697c64aa90efddd37d8","unresolved":true,"context_lines":[{"line_number":5635,"context_line":"        # a STOPPED server and we don\u0027t want to set it back to ACTIVE"},{"line_number":5636,"context_line":"        # in case _prep_resize fails."},{"line_number":5637,"context_line":"        instance_state \u003d instance.vm_state"},{"line_number":5638,"context_line":"        with self._error_out_instance_on_exception("},{"line_number":5639,"context_line":"                context, instance, instance_state\u003dinstance_state), \\"},{"line_number":5640,"context_line":"                errors_out_migration_ctxt(migration):"},{"line_number":5641,"context_line":""},{"line_number":5642,"context_line":"            self._send_prep_resize_notifications("},{"line_number":5643,"context_line":"                context, instance, fields.NotificationPhase.START,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5ad6d0e_a4ee03d6","line":5640,"range":{"start_line":5638,"start_character":8,"end_line":5640,"end_character":53},"updated":"2023-08-14 11:33:59.000000000","message":"nit i would prefer if you update it to \n\n        with self._error_out_instance_on_exception(\n                context, instance, instance_state\u003dinstance_state\n             ), errors_out_migration_ctxt(migration):","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b279c30ee9ae770301e3e741ae60dedd000b0f87","unresolved":false,"context_lines":[{"line_number":5635,"context_line":"        # a STOPPED server and we don\u0027t want to set it back to ACTIVE"},{"line_number":5636,"context_line":"        # in case _prep_resize fails."},{"line_number":5637,"context_line":"        instance_state \u003d instance.vm_state"},{"line_number":5638,"context_line":"        with self._error_out_instance_on_exception("},{"line_number":5639,"context_line":"                context, instance, instance_state\u003dinstance_state), \\"},{"line_number":5640,"context_line":"                errors_out_migration_ctxt(migration):"},{"line_number":5641,"context_line":""},{"line_number":5642,"context_line":"            self._send_prep_resize_notifications("},{"line_number":5643,"context_line":"                context, instance, fields.NotificationPhase.START,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b080ebc_4c5fdd0f","line":5640,"range":{"start_line":5638,"start_character":8,"end_line":5640,"end_character":53},"in_reply_to":"e5ad6d0e_a4ee03d6","updated":"2023-08-16 08:28:05.000000000","message":"Done","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06f908cfa491230189da9697c64aa90efddd37d8","unresolved":true,"context_lines":[{"line_number":7914,"context_line":"            old_volume_id, new_volume_id)"},{"line_number":7915,"context_line":""},{"line_number":7916,"context_line":"    @wrap_exception()"},{"line_number":7917,"context_line":"    def remove_volume_connection(self, context, volume_id, instance,"},{"line_number":7918,"context_line":"                                 delete_attachment\u003dFalse):"},{"line_number":7919,"context_line":"        \"\"\"Remove the volume connection on this host"},{"line_number":7920,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c6150017_b6a5198f","line":7917,"updated":"2023-08-14 11:33:59.000000000","message":"while we allow that style in old code\n     def remove_volume_connection(self, context, volume_id, instance,\n                                  delete_attachment\u003dFalse):\nthe prefered styple is \n```                              \n    def remove_volume_connection(\n        self, context, volume_id, instance,\n        delete_attachment\u003dFalse\n    ):\n``` \nor\n```\n    def remove_volume_connection(\n        self, context, volume_id, instance,\n        delete_attachment\u003dFalse):\n```\nbasically if you need to split parmater over multiple lines then you shoudl move\nall of them to a new line so that you can properly dedent the parmater block.","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8b0bb2d8bfd5b3709a70c1278ec69429d18ca7fc","unresolved":false,"context_lines":[{"line_number":7914,"context_line":"            old_volume_id, new_volume_id)"},{"line_number":7915,"context_line":""},{"line_number":7916,"context_line":"    @wrap_exception()"},{"line_number":7917,"context_line":"    def remove_volume_connection(self, context, volume_id, instance,"},{"line_number":7918,"context_line":"                                 delete_attachment\u003dFalse):"},{"line_number":7919,"context_line":"        \"\"\"Remove the volume connection on this host"},{"line_number":7920,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e2c0f6a1_f3537544","line":7917,"in_reply_to":"c3cc9eea_c0d9e7dc","updated":"2023-09-07 15:50:33.000000000","message":"Done","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b279c30ee9ae770301e3e741ae60dedd000b0f87","unresolved":true,"context_lines":[{"line_number":7914,"context_line":"            old_volume_id, new_volume_id)"},{"line_number":7915,"context_line":""},{"line_number":7916,"context_line":"    @wrap_exception()"},{"line_number":7917,"context_line":"    def remove_volume_connection(self, context, volume_id, instance,"},{"line_number":7918,"context_line":"                                 delete_attachment\u003dFalse):"},{"line_number":7919,"context_line":"        \"\"\"Remove the volume connection on this host"},{"line_number":7920,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c3cc9eea_c0d9e7dc","line":7917,"in_reply_to":"c6150017_b6a5198f","updated":"2023-08-16 08:28:05.000000000","message":"updated, not as same as suggested (because seemed correct locally, but this need update). \nas I might need to make other changes (future reviews), so not updating right away, will update and resolve in next PS.","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dc6707b320d7996583312caa4fc6cde20ad05052","unresolved":true,"context_lines":[{"line_number":5718,"context_line":"        with self._error_out_instance_on_exception("},{"line_number":5719,"context_line":"            context, instance, instance_state\u003dinstance_state"},{"line_number":5720,"context_line":"         ), errors_out_migration_ctxt(migration):"},{"line_number":5721,"context_line":""},{"line_number":5722,"context_line":"            self._send_prep_resize_notifications("},{"line_number":5723,"context_line":"                context, instance, fields.NotificationPhase.START,"},{"line_number":5724,"context_line":"                flavor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0356f359_ae434196","line":5721,"updated":"2024-02-13 13:06:09.000000000","message":"this is an unreatled change.","commit_id":"4f43da3decdb02c02736d15428e1c171786778a6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c7598592dc9d6e356185307450bdb0f3deab9968","unresolved":false,"context_lines":[{"line_number":5718,"context_line":"        with self._error_out_instance_on_exception("},{"line_number":5719,"context_line":"            context, instance, instance_state\u003dinstance_state"},{"line_number":5720,"context_line":"         ), errors_out_migration_ctxt(migration):"},{"line_number":5721,"context_line":""},{"line_number":5722,"context_line":"            self._send_prep_resize_notifications("},{"line_number":5723,"context_line":"                context, instance, fields.NotificationPhase.START,"},{"line_number":5724,"context_line":"                flavor)"}],"source_content_type":"text/x-python","patch_set":5,"id":"71880d39_9f6885ae","line":5721,"in_reply_to":"0356f359_ae434196","updated":"2024-02-14 10:27:30.000000000","message":"yeah, just wanted remove \u0027/\u0027, and I missed to mention in commit msg as well, \nBut it is unrelated, so reverted, thanks","commit_id":"4f43da3decdb02c02736d15428e1c171786778a6"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06f908cfa491230189da9697c64aa90efddd37d8","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"        cctxt.cast(ctxt, \u0027remove_fixed_ip_from_instance\u0027,"},{"line_number":1140,"context_line":"                   instance\u003dinstance, address\u003daddress)"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    def remove_volume_connection(self, ctxt, instance, volume_id, host,"},{"line_number":1143,"context_line":"                                 delete_attachment\u003dFalse):"},{"line_number":1144,"context_line":"        version \u003d self._ver(ctxt, \u00275.0\u0027)"},{"line_number":1145,"context_line":"        cctxt \u003d self.router.client(ctxt).prepare("},{"line_number":1146,"context_line":"                server\u003dhost, version\u003dversion)"},{"line_number":1147,"context_line":"        return cctxt.call(ctxt, \u0027remove_volume_connection\u0027,"},{"line_number":1148,"context_line":"                          instance\u003dinstance, volume_id\u003dvolume_id,"},{"line_number":1149,"context_line":"                          delete_attachment\u003ddelete_attachment)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def rescue_instance(self, ctxt, instance, rescue_password,"},{"line_number":1152,"context_line":"                        rescue_image_ref\u003dNone, clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bc0b88e_f40a0538","line":1149,"range":{"start_line":1142,"start_character":2,"end_line":1149,"end_character":62},"updated":"2023-08-14 11:33:59.000000000","message":"same can yo dedent this\n\n    def remove_volume_connection(self, ctxt, instance, volume_id, host,\n                                 delete_attachment\u003dFalse):\n        version \u003d self._ver(ctxt, \u00275.0\u0027)\n        cctxt \u003d self.router.client(ctxt).prepare(\n                server\u003dhost, version\u003dversion)\n        return cctxt.call(ctxt, \u0027remove_volume_connection\u0027,\n                          instance\u003dinstance, volume_id\u003dvolume_id,\n                          delete_attachment\u003ddelete_attachment)\n                          \nto\n\n    def remove_volume_connection(\n        self, ctxt, instance, volume_id, host,\n        delete_attachment\u003dFalse\n    ):\n        version \u003d self._ver(ctxt, \u00275.0\u0027)\n        cctxt \u003d self.router.client(ctxt).prepare(\n                server\u003dhost, version\u003dversion)\n        return cctxt.call(\n            ctxt, \u0027remove_volume_connection\u0027,\n            instance\u003dinstance, volume_id\u003dvolume_id,\n            delete_attachment\u003ddelete_attachment)","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"b279c30ee9ae770301e3e741ae60dedd000b0f87","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        cctxt.cast(ctxt, \u0027remove_fixed_ip_from_instance\u0027,"},{"line_number":1140,"context_line":"                   instance\u003dinstance, address\u003daddress)"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    def remove_volume_connection(self, ctxt, instance, volume_id, host,"},{"line_number":1143,"context_line":"                                 delete_attachment\u003dFalse):"},{"line_number":1144,"context_line":"        version \u003d self._ver(ctxt, \u00275.0\u0027)"},{"line_number":1145,"context_line":"        cctxt \u003d self.router.client(ctxt).prepare("},{"line_number":1146,"context_line":"                server\u003dhost, version\u003dversion)"},{"line_number":1147,"context_line":"        return cctxt.call(ctxt, \u0027remove_volume_connection\u0027,"},{"line_number":1148,"context_line":"                          instance\u003dinstance, volume_id\u003dvolume_id,"},{"line_number":1149,"context_line":"                          delete_attachment\u003ddelete_attachment)"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def rescue_instance(self, ctxt, instance, rescue_password,"},{"line_number":1152,"context_line":"                        rescue_image_ref\u003dNone, clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f827716_abefce0f","line":1149,"range":{"start_line":1142,"start_character":2,"end_line":1149,"end_character":62},"in_reply_to":"4bc0b88e_f40a0538","updated":"2023-08-16 08:28:05.000000000","message":"Done","commit_id":"2b9d438367ed057ece48287c764c5a5ee1f53a66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dc6707b320d7996583312caa4fc6cde20ad05052","unresolved":true,"context_lines":[{"line_number":1143,"context_line":"    def remove_volume_connection("},{"line_number":1144,"context_line":"                self, ctxt, instance, volume_id, host,"},{"line_number":1145,"context_line":"                delete_attachment\u003dFalse"},{"line_number":1146,"context_line":"            ):"},{"line_number":1147,"context_line":"        version \u003d self._ver(ctxt, \u00275.0\u0027)"},{"line_number":1148,"context_line":"        cctxt \u003d self.router.client(ctxt).prepare("},{"line_number":1149,"context_line":"                server\u003dhost, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f737b168_7b280780","line":1146,"range":{"start_line":1146,"start_character":4,"end_line":1146,"end_character":14},"updated":"2024-02-13 13:06:09.000000000","message":"dan will want you to not put this on a new line\n\nalso you are changing the rpc api by passing anddtioal parmater so you need to add a new rpc version and you need to support calling it with the old version without this parameter.\n\nlike this\n\n        version \u003d self._ver(ctxt, \u00275.3\u0027)\n        kwargs \u003d {\n            \u0027instance\u0027: instance,\n            \u0027block_migration\u0027: block_migration,\n            \u0027disk_over_commit\u0027: disk_over_commit,\n            \u0027migration\u0027: migration,\n            \u0027limits\u0027: limits\n        }\n        if not client.can_send_version(version):\n            kwargs.pop(\u0027migration\u0027)\n            kwargs.pop(\u0027limits\u0027)\n            version \u003d \u00275.0\u0027\n        cctxt \u003d client.prepare(server\u003ddestination, version\u003dversion,\n                               call_monitor_timeout\u003dCONF.rpc_response_timeout,\n                               timeout\u003dCONF.long_rpc_timeout)\n        return cctxt.call(ctxt, \u0027check_can_live_migrate_destination\u0027, **kwargs)\n        \n        \nthis should be breaking the grenade job but we are not creating any vms with voluems in it\n\nhttps://7e4ed52e60c14914c16f-0507f0d56ad72621551127593d6d8a94.ssl.cf1.rackcdn.com/891289/5/check/grenade-skip-level-always/8d538f9/testr_results.html","commit_id":"4f43da3decdb02c02736d15428e1c171786778a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7fc91bb3a02e3d6b9caa1a13869c5a0fce68ae58","unresolved":true,"context_lines":[{"line_number":1143,"context_line":"    def remove_volume_connection("},{"line_number":1144,"context_line":"                self, ctxt, instance, volume_id, host,"},{"line_number":1145,"context_line":"                delete_attachment\u003dFalse"},{"line_number":1146,"context_line":"            ):"},{"line_number":1147,"context_line":"        version \u003d self._ver(ctxt, \u00275.0\u0027)"},{"line_number":1148,"context_line":"        cctxt \u003d self.router.client(ctxt).prepare("},{"line_number":1149,"context_line":"                server\u003dhost, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6f159b53_f4caa04f","line":1146,"range":{"start_line":1146,"start_character":4,"end_line":1146,"end_character":14},"in_reply_to":"6d2ef558_fb174e5f","updated":"2024-02-13 13:10:43.000000000","message":"actully we have test_attach_detach_volume_to_instance but the skip level job is singel node so it still would not catch this.","commit_id":"4f43da3decdb02c02736d15428e1c171786778a6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"53055b764a5f2e3c617b3df24947b380cc7cd61b","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"    def remove_volume_connection("},{"line_number":1144,"context_line":"                self, ctxt, instance, volume_id, host,"},{"line_number":1145,"context_line":"                delete_attachment\u003dFalse"},{"line_number":1146,"context_line":"            ):"},{"line_number":1147,"context_line":"        version \u003d self._ver(ctxt, \u00275.0\u0027)"},{"line_number":1148,"context_line":"        cctxt \u003d self.router.client(ctxt).prepare("},{"line_number":1149,"context_line":"                server\u003dhost, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a2a3344a_f6d8c70f","line":1146,"range":{"start_line":1146,"start_character":4,"end_line":1146,"end_character":14},"in_reply_to":"6f159b53_f4caa04f","updated":"2024-02-29 19:57:01.000000000","message":"was missing few things locally, so tests were failing hence took time, thanks","commit_id":"4f43da3decdb02c02736d15428e1c171786778a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3dd8bf3851a9ece27380d4d85a5b477b4e99824f","unresolved":true,"context_lines":[{"line_number":1143,"context_line":"    def remove_volume_connection("},{"line_number":1144,"context_line":"                self, ctxt, instance, volume_id, host,"},{"line_number":1145,"context_line":"                delete_attachment\u003dFalse"},{"line_number":1146,"context_line":"            ):"},{"line_number":1147,"context_line":"        version \u003d self._ver(ctxt, \u00275.0\u0027)"},{"line_number":1148,"context_line":"        cctxt \u003d self.router.client(ctxt).prepare("},{"line_number":1149,"context_line":"                server\u003dhost, version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6d2ef558_fb174e5f","line":1146,"range":{"start_line":1146,"start_character":4,"end_line":1146,"end_character":14},"in_reply_to":"f737b168_7b280780","updated":"2024-02-13 13:07:46.000000000","message":"actully we crete a BFV instance in \ntempest.api.compute.servers.test_create_server.ServersTestBootFromVolume\nbut we dont detach a volume so this never gets called.","commit_id":"4f43da3decdb02c02736d15428e1c171786778a6"}]}