)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5055001a42cf7481f838d59bb9b9382a356916f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9e080ed_86147296","updated":"2023-08-15 13:54:09.000000000","message":"recheck ssh timeout","commit_id":"bd1bccec4bd7084c75988cabd6e83537e4da0498"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"59e5753da4964b16ef5a83a7bcf6a85b36696970","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8157bcfa_5b2a76bd","updated":"2023-08-22 19:00:11.000000000","message":"recheck dep changed","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7f38a11e8c38dccd91c024a0aa964c31f4abded4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f7d6a6f2_fa3a1b1f","updated":"2023-08-22 22:00:25.000000000","message":"recheck grenade guest panic on boot","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c25c36974b9032a86d690c2c89d1c50a2a273690","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8a3abe02_e2fabcd8","updated":"2023-08-23 22:45:16.000000000","message":"recheck mysql oom\u0027d","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4eff1ce1083b8c9e1d75091cdde00a7cb2f4c58b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a2273803_58cc2eff","updated":"2023-08-23 11:29:06.000000000","message":"recheck tempest-integrated-compute-rbac-old-defaults fail on \ntest_rebuild_volume_backed_server because the iamge did not match. \n\nthis might be a tempest bug or a job issue.\nwe recently change this in https://github.com/openstack/tempest/commit/768d253670941ed5c88d923452192b385224622f to use the alt image \n\ni dont actully think that is the problem but that patch allso is waiting ofr the rebuidl by doing \n\n        # Verify the server properties after the rebuild completes\n        waiters.wait_for_server_status(self.servers_client,\n                                       rebuilt_server[\u0027id\u0027], \u0027ACTIVE\u0027)\n\nhttps://github.com/openstack/tempest/blame/49c64a985cae8eeb0dc4b8cf772d8bdcbd46ebdc/tempest/api/compute/servers/test_server_actions.py#L878-L880\n\nthat could race fi the server is still in active becuase the rebuild has not started yet.\n\nthe test shoudl wait for rebuilding before waiting for Active to make sure that does not happen. the issue with that in tempest is that might not happen for long enoug to see it with adn they cant use the notification like we would in fucntional test so there only way to propelry wait woudl be the server event api.\nlets reheck and see if it passes.\n\nif it does then this is an unstable test and a race we shoudl fix.","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9114581fa9a06bf0fbd54927d1a84748637a005","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8c58be83_0a815168","updated":"2023-08-23 18:14:59.000000000","message":"recheck volume backed rebuild failed (timeout waiting for cinder)","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"89280a23279b3c294a84394f54afdb5eed391080","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a1787396_5a1d9b07","updated":"2023-08-23 13:48:13.000000000","message":"recheck volume timeout in grenade resource phase","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a9099f7df4d5164d31e1aeb55b4df4e85a4c2e5","unresolved":true,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        instance \u003d self._get_server("},{"line_number":471,"context_line":"            context, req, id, is_detail\u003dTrue,"},{"line_number":472,"context_line":"            columns_to_join\u003d[\u0027services\u0027],"},{"line_number":473,"context_line":"            cell_down_support\u003dcell_down_support)"},{"line_number":474,"context_line":"        context.can(server_policies.SERVERS % \u0027show\u0027,"},{"line_number":475,"context_line":"                    target\u003d{\u0027project_id\u0027: instance.project_id})"}],"source_content_type":"text/x-python","patch_set":7,"id":"117c4dc6_3e13e306","line":472,"updated":"2023-08-22 16:27:32.000000000","message":"while i agree with your reasoning it woudl have been nice to leave a TODO comment to track removing this again in the future.\ncan you perhaps file a launchpad bug for this so we might rememeber to adress this","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"190ad4192e37aa35a1487069bfcaae3bb691f247","unresolved":false,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        instance \u003d self._get_server("},{"line_number":471,"context_line":"            context, req, id, is_detail\u003dTrue,"},{"line_number":472,"context_line":"            columns_to_join\u003d[\u0027services\u0027],"},{"line_number":473,"context_line":"            cell_down_support\u003dcell_down_support)"},{"line_number":474,"context_line":"        context.can(server_policies.SERVERS % \u0027show\u0027,"},{"line_number":475,"context_line":"                    target\u003d{\u0027project_id\u0027: instance.project_id})"}],"source_content_type":"text/x-python","patch_set":7,"id":"2ff41d8c_f2f70da0","line":472,"updated":"2023-08-23 11:57:37.000000000","message":"with this change, there is no lazy-loading for \u0027services\u0027  while server show (which was a single lazy-loaded attribute), hence obj_load_attr won\u0027t be called for show here: https://review.opendev.org/c/openstack/nova/+/891340/5/nova/objects/instance.py#1126\n\nlogs clear too.","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"73fd4326efb4eb5d68bb09f53d4227c42a7d6653","unresolved":true,"context_lines":[{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        instance \u003d self._get_server("},{"line_number":471,"context_line":"            context, req, id, is_detail\u003dTrue,"},{"line_number":472,"context_line":"            columns_to_join\u003d[\u0027services\u0027],"},{"line_number":473,"context_line":"            cell_down_support\u003dcell_down_support)"},{"line_number":474,"context_line":"        context.can(server_policies.SERVERS % \u0027show\u0027,"},{"line_number":475,"context_line":"                    target\u003d{\u0027project_id\u0027: instance.project_id})"}],"source_content_type":"text/x-python","patch_set":7,"id":"f45b660f_6e1aab45","line":472,"in_reply_to":"117c4dc6_3e13e306","updated":"2023-08-22 16:34:08.000000000","message":"Why would it be removed? Are you talking about the comment about making fault loadable if it\u0027s missing?","commit_id":"9ae9d77b030e1dbc74b0e771c15c180a4fdf379f"}]}