)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1c618c5a1a175548f27d21f0a5e508651e87bad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"09630dfd_fa4f7f96","updated":"2023-08-23 21:01:44.000000000","message":"recheck dep failed","commit_id":"8d0a0ec88e3951d8457b59d0fc790c836498ce60"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5ea6eac486fbd43975a1afbba42b265fc9bfcd03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f93a19b9_09d678ac","updated":"2023-08-24 19:51:47.000000000","message":"recheck dep merged","commit_id":"8d0a0ec88e3951d8457b59d0fc790c836498ce60"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3686c2dc24dab83ada726d225f2e9ec6d7d832d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0a4666ce_3d607697","updated":"2023-08-22 19:34:09.000000000","message":"this also looks fine to me","commit_id":"8d0a0ec88e3951d8457b59d0fc790c836498ce60"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3686c2dc24dab83ada726d225f2e9ec6d7d832d7","unresolved":true,"context_lines":[{"line_number":1050,"context_line":"                                    columns_to_join\u003d[\u0027services\u0027, \u0027resources\u0027,"},{"line_number":1051,"context_line":"                                                     \u0027pci_requests\u0027,"},{"line_number":1052,"context_line":"                                                     \u0027pci_devices\u0027,"},{"line_number":1053,"context_line":"                                                     \u0027trusted_certs\u0027,"},{"line_number":1054,"context_line":"                                                     \u0027vcpu_model\u0027])"},{"line_number":1055,"context_line":"        context.can(server_policies.SERVERS % \u0027resize\u0027,"},{"line_number":1056,"context_line":"                    target\u003d{\u0027user_id\u0027: instance.user_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9778879b_03c54ba7","line":1053,"range":{"start_line":1053,"start_character":54,"end_line":1053,"end_character":67},"updated":"2023-08-22 19:34:09.000000000","message":"is truested_certs related to the half implemented trusted boot stuff we had at one point?","commit_id":"8d0a0ec88e3951d8457b59d0fc790c836498ce60"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2229799215611b5e9a4b13fd0e0245c4d11dcafa","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                                    columns_to_join\u003d[\u0027services\u0027, \u0027resources\u0027,"},{"line_number":1051,"context_line":"                                                     \u0027pci_requests\u0027,"},{"line_number":1052,"context_line":"                                                     \u0027pci_devices\u0027,"},{"line_number":1053,"context_line":"                                                     \u0027trusted_certs\u0027,"},{"line_number":1054,"context_line":"                                                     \u0027vcpu_model\u0027])"},{"line_number":1055,"context_line":"        context.can(server_policies.SERVERS % \u0027resize\u0027,"},{"line_number":1056,"context_line":"                    target\u003d{\u0027user_id\u0027: instance.user_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"89367d07_cdc47217","line":1053,"range":{"start_line":1053,"start_character":54,"end_line":1053,"end_character":67},"in_reply_to":"2422e288_c1ea16d6","updated":"2023-08-23 11:17:46.000000000","message":"melaine found that its part of the cinder image signing verification code\nits a list of uuids for truested certs that we store in instnace_extra \ni dont actully know where the cert itsself is stored exactly but i think its in barbican and the uuid is the barbican secret uuid althogh it coudl be sotred in glance too. i didnt really looks more once she found the spec.\n\ntldr is if this is set on an instance then we wont boot it unless the iamge has been signed by one of the certs so you can make sure the image you think your are booting is actully the one that is booting and has not been modifed.\n\nthere are even tempest test for this which is nice although i didt check if we actully run them in nova. we proably doo but i have never really interacted with this feature intentionally.","commit_id":"8d0a0ec88e3951d8457b59d0fc790c836498ce60"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ea10a81971e8196b8dfe94c37b0f2cbce84ea9b1","unresolved":true,"context_lines":[{"line_number":1050,"context_line":"                                    columns_to_join\u003d[\u0027services\u0027, \u0027resources\u0027,"},{"line_number":1051,"context_line":"                                                     \u0027pci_requests\u0027,"},{"line_number":1052,"context_line":"                                                     \u0027pci_devices\u0027,"},{"line_number":1053,"context_line":"                                                     \u0027trusted_certs\u0027,"},{"line_number":1054,"context_line":"                                                     \u0027vcpu_model\u0027])"},{"line_number":1055,"context_line":"        context.can(server_policies.SERVERS % \u0027resize\u0027,"},{"line_number":1056,"context_line":"                    target\u003d{\u0027user_id\u0027: instance.user_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2422e288_c1ea16d6","line":1053,"range":{"start_line":1053,"start_character":54,"end_line":1053,"end_character":67},"in_reply_to":"9778879b_03c54ba7","updated":"2023-08-22 19:45:58.000000000","message":"IDK, I was actually kinda surprised to see it here 😊","commit_id":"8d0a0ec88e3951d8457b59d0fc790c836498ce60"}]}